135849 2014-08-12 12:46:03 -0700 Web Inspector: Timeline selection range creation does not work when clicking event bubble or near bottom of overview 2014-08-12 13:44:01 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1028566 0 joepeck 2014-08-12 12:46:03 -0700 * SUMMARY Timeline selection range creation does not work when clicking event bubble or near bottom of overview. Click and drag should always work. * STEPS TO REPRODUCe 1. Inspect apple.com 2. Reload to get timeline data 3. Switch to Timelines view 4. Zoom in on overview so there are some script/layout blocks that are not tiny 5. Attempt to start a new selection on an event bubble => does not work 6. Attempt to start a new selection anywhere near the bottom of the overview => does not work 1028567 1 webkit-bug-importer 2014-08-12 12:46:24 -0700 <rdar://problem/17994473> 1028569 2 joepeck 2014-08-12 12:50:14 -0700 Seems the issue is that the .timeline-ruler region is not involved with the event bubble chain when clicking something in the sibling graph-container region. At the bottom of the view, the scroller with its height of 16px is nabbing the mouse events. Giving the timeline ruler a z-index fixes all the issues. I wonder if there might be a better way. 1028575 3 236461 joepeck 2014-08-12 12:53:44 -0700 Created attachment 236461 [PATCH] Proposed Fix 1028588 4 236461 commit-queue 2014-08-12 13:43:58 -0700 Comment on attachment 236461 [PATCH] Proposed Fix Clearing flags on attachment: 236461 Committed r172488: <http://trac.webkit.org/changeset/172488> 1028589 5 commit-queue 2014-08-12 13:44:01 -0700 All reviewed patches have been landed. Closing bug. 236461 2014-08-12 12:53:44 -0700 2014-08-12 13:43:57 -0700 [PATCH] Proposed Fix selection-fix.patch text/plain 1582 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDU0YmZmMTEuLjUzODk1ZDIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIxIEBACiAyMDE0LTA4LTEyICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxp bmUgc2VsZWN0aW9uIHJhbmdlIGNyZWF0aW9uIGRvZXMgbm90IHdvcmsgd2hlbiBjbGlja2luZyBl dmVudCBidWJibGUgb3IgbmVhciBib3R0b20gb2Ygb3ZlcnZpZXcKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTg0OQorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENsaWNrIGV2ZW50cyBvbiBlbGVtZW50cyBp biB0aGUgZ3JhcGggY29udGFpbmVyIChldmVudCBidWJibGVzKSBvcgorICAgICAgICBpbiB0aGUg c2Nyb2xsIGNvbnRhaW5lciAoYm90dG9tIDE2cHgpIHdlcmUgYmVjb21pbmcgdGhlIGV2ZW50IHRh cmdldHMuCisgICAgICAgIEFzIHNpYmxpbmdzIG9mIHRoZSBydWxlciwgdGhlIGRpc3BhdGNoIHdv dWxkIG5vdCBnbyB0aHJvdWdoIHRoZSBydWxlci4KKyAgICAgICAgVGhlIHJ1bGVyIHdhcyBzdXBw b3NlZCB0byBiZSBvdmVybGF5aW5nIGV2ZXJ5dGhpbmcgaW4gdGhlIG92ZXJ2aWV3LAorICAgICAg ICBzbyBnaXZlIHRoZSBydWxlciBhIHotaW5kZXggc28gaXQgcmVhbGx5IGlzIG92ZXJsYXlpbmcg ZWxlbWVudHMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lUnVsZXIu Y3NzOgorICAgICAgICAoLnRpbWVsaW5lLXJ1bGVyKToKKworMjAxNC0wOC0xMiAgSm9zZXBoIFBl Y29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IEdv VG9MaW5lIGRpYWxvZyBjbGVhciB0ZXh0IGJ1dHRvbiBsb29rcyBwb29yCiAgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU4MjgKIApkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVSdWxlci5j c3MgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1 bGVyLmNzcwppbmRleCBhYmYyMmRlLi4yZDg2NzkzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1bGVyLmNzcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZVJ1bGVyLmNzcwpA QCAtMjYsNiArMjYsNyBAQAogLnRpbWVsaW5lLXJ1bGVyIHsKICAgICBwb3NpdGlvbjogcmVsYXRp dmU7CiAgICAgcG9pbnRlci1ldmVudHM6IG5vbmU7CisgICAgei1pbmRleDogMTsKIH0KIAogLnRp bWVsaW5lLXJ1bGVyLmFsbG93cy10aW1lLXJhbmdlLXNlbGVjdGlvbiB7Cg==