135846 2014-08-12 11:34:22 -0700 Don't show the combined menu if there are no services available 2014-08-12 13:05:29 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton beidson enrica oldest_to_newest 1028549 0 thorton 2014-08-12 11:34:22 -0700 <rdar://problem/17582099> Don't allow a selection Highlight to become active if there is no service available to handle it. Previously we showed the combined menu with just phone numbers in it if any were detected. 1028550 1 236457 thorton 2014-08-12 11:35:21 -0700 Created attachment 236457 patch 1028551 2 thorton 2014-08-12 11:36:35 -0700 This is written on top of https://bugs.webkit.org/show_bug.cgi?id=135829 so it may not apply. 1028579 3 thorton 2014-08-12 13:05:29 -0700 http://trac.webkit.org/changeset/172484 236457 2014-08-12 11:35:21 -0700 2014-08-12 12:27:45 -0700 patch no-combined-just-phone.diff text/plain 2566 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBjNWFhYmNjLi5jN2EzYWFkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIg QEAKIDIwMTQtMDgtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAK KyAgICAgICAgRG9uJ3Qgc2hvdyB0aGUgY29tYmluZWQgbWVudSBpZiB0aGVyZSBhcmUgbm8gc2Vy dmljZXMgYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzU4NDYKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3NTgyMDk5PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9X ZWJQYWdlL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIuaDoKKyAgICAgICAgQWRkIGEgRklYTUUu CisKKyAgICAgICAgKiBXZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRy b2xsZXIubW06CisgICAgICAgIChXZWJLaXQ6OlNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6OmRl dGVybWluZUFjdGl2ZUhpZ2hsaWdodCk6CisgICAgICAgIERvbid0IGFsbG93IGEgc2VsZWN0aW9u IEhpZ2hsaWdodCB0byBiZWNvbWUgYWN0aXZlIGlmIHRoZXJlIGlzIG5vCisgICAgICAgIHNlcnZp Y2UgYXZhaWxhYmxlIHRvIGhhbmRsZSBpdC4gUHJldmlvdXNseSB3ZSBzaG93ZWQgdGhlIGNvbWJp bmVkIG1lbnUKKyAgICAgICAgd2l0aCBqdXN0IHBob25lIG51bWJlcnMgaW4gaXQgaWYgYW55IHdl cmUgZGV0ZWN0ZWQuCisKKzIwMTQtMDgtMTIgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBh cHBsZS5jb20+CisKICAgICAgICAgQWRkIGEgZmFkZSB0cmFuc2l0aW9uIHRvIHNlcnZpY2VzIGhp Z2hsaWdodHMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNTgyOQogICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc5MzU3MzY+CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvU2VydmljZXNPdmVybGF5Q29udHJvbGxl ci5oIGIvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL1NlcnZpY2VzT3ZlcmxheUNv bnRyb2xsZXIuaAppbmRleCAwMGVjMzk5Li4zMjlkMDhmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi S2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5oCisrKyBi L1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9TZXJ2aWNlc092ZXJsYXlDb250cm9s bGVyLmgKQEAgLTE0Myw2ICsxNDMsNyBAQCBwcml2YXRlOgogCiAgICAgSGFzaFNldDxIaWdobGln aHQqPiBtX2hpZ2hsaWdodHM7CiAKKyAgICAvLyBGSVhNRTogVGhlc2Ugc2hvdWxkIG1vdmUgb250 byBIaWdobGlnaHQuCiAgICAgVmVjdG9yPFdlYkNvcmU6OkxheW91dFJlY3Q+IG1fY3VycmVudFNl bGVjdGlvblJlY3RzOwogICAgIGJvb2wgbV9pc1RleHRPbmx5OwogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xs ZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3Zl cmxheUNvbnRyb2xsZXIubW0KaW5kZXggNjAwNGI4YS4uMDk4YjU3OSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092ZXJsYXlDb250cm9s bGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2Vydmlj ZXNPdmVybGF5Q29udHJvbGxlci5tbQpAQCAtNTg5LDggKzU4OSw4IEBAIHZvaWQgU2VydmljZXNP dmVybGF5Q29udHJvbGxlcjo6ZGV0ZXJtaW5lQWN0aXZlSGlnaGxpZ2h0KGJvb2wmIG1vdXNlSXNP dmVyQWN0aXZlCiAgICAgICAgICAgICBpZiAobmV3QWN0aXZlSGlnaGxpZ2h0ICYmIG5ld0FjdGl2 ZUhpZ2hsaWdodC0+dHlwZSgpID09IEhpZ2hsaWdodDo6VHlwZTo6VGVsZXBob25lTnVtYmVyKQog ICAgICAgICAgICAgICAgIGNvbnRpbnVlOwogCi0gICAgICAgICAgICAvLyBJZiB0aGlzIGhpZ2hs aWdodCBoYXMgbm8gY29tcGF0aWJsZSBzZXJ2aWNlcywgaXQgY2FuJ3QgYmUgYWN0aXZlLCB1bmxl c3Mgd2UgaGF2ZSB0ZWxlcGhvbmUgbnVtYmVyIGhpZ2hsaWdodHMgdG8gc2hvdyBpbiB0aGUgY29t YmluZWQgbWVudS4KLSAgICAgICAgICAgIGlmICh0ZWxlcGhvbmVOdW1iZXJSYW5nZXNGb3JGb2N1 c2VkRnJhbWUoKS5pc0VtcHR5KCkgJiYgIWhhc1JlbGV2YW50U2VsZWN0aW9uU2VydmljZXMoKSkK KyAgICAgICAgICAgIC8vIElmIHRoaXMgaGlnaGxpZ2h0IGhhcyBubyBjb21wYXRpYmxlIHNlcnZp Y2VzLCBpdCBjYW4ndCBiZSBhY3RpdmUuCisgICAgICAgICAgICBpZiAoIWhhc1JlbGV2YW50U2Vs ZWN0aW9uU2VydmljZXMoKSkKICAgICAgICAgICAgICAgICBjb250aW51ZTsKICAgICAgICAgfQog Cg==