135845 2014-08-12 11:10:22 -0700 [iOS] build-webkit should not build WebKitSystemInterface and WebKitAdditions 2014-08-12 19:35:53 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 dbates dbates aestes ddkilzer mrowe oldest_to_newest 1028539 0 dbates 2014-08-12 11:10:22 -0700 We should remove the logic added to build-webkit to build projects WebKitSystemInterface and WebKitAdditions when building the iOS WebKit port because build-webkit shouldn't be responsible for building such projects. Such logic was added as a convenience to expedite the bring up of the iOS WebKit port when it was upstreamed. 1028541 1 dbates 2014-08-12 11:14:58 -0700 Removing the dependencies to build projects WebKitSystemInterface and WebKitAdditions when building the iOS WebKit port will help towards building the iOS WebKit port using the public SDK. 1028542 2 236456 dbates 2014-08-12 11:15:54 -0700 Created attachment 236456 Patch 1028701 3 dbates 2014-08-12 19:35:53 -0700 Committed r172511: <http://trac.webkit.org/changeset/172511> 236456 2014-08-12 11:15:54 -0700 2014-08-12 11:16:34 -0700 Patch bug-135845-20140812111544.patch text/plain 1848 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNDcyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2JjNjkzYzZjMzk2NTdjOWJmZWNkMjU0NTViZTM5MjYx ODhlMGYzNy4uODEyNWE3OTRhYzZlM2JkNDgwMjhiM2MwY2I4YmU4ZmQ2NWFiODNhNyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTA4LTEyICBEYW5pZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAg ICAgICBbaU9TXSBidWlsZC13ZWJraXQgc2hvdWxkIG5vdCBidWlsZCBXZWJLaXRTeXN0ZW1JbnRl cmZhY2UgYW5kIFdlYktpdEFkZGl0aW9ucworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM1ODQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVG93YXJkcyBidWlsZGluZyB0aGUgaU9TIFdlYktpdCBwb3J0IHVz aW5nIHRoZSBwdWJsaWMgU0RLLCByZW1vdmUgdGhlIGxvZ2ljCisgICAgICAgIGFkZGVkIHRvIGJ1 aWxkLXdlYmtpdCB0byBidWlsZCBwcm9qZWN0cyBXZWJLaXRTeXN0ZW1JbnRlcmZhY2UgYW5kCisg ICAgICAgIFdlYktpdEFkZGl0aW9ucyB3aGVuIGJ1aWxkaW5nIHRoZSBpT1MgV2ViS2l0IHBvcnQu CisKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDoKKwogMjAxNC0wOC0xMiAgRWR1YXJk byBMaW1hIE1pdGV2ICA8ZWxpbWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBTdWJ0bGUt Y3J5cHRvIGZlYXR1cmUgb2ZmIGJ5IGRlZmF1bHQgYW5kIGFkZCBhIG5ldyBjb25maWd1cmUgZmxh ZyB0byBlbmFibGUgaXQKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIv VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggOGUyMzkxNmQ5ZWUyZWY0ODRjYjJiMWM3 ZWNjYmFkYTNhYzIyMzYzYS4uODdlNGVhYzU0NWJjMzY2ODU2ZTY3NjI0YjNlMGVkMGJkNmM5NjM4 OSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2Ny aXB0cy9idWlsZC13ZWJraXQKQEAgLTE5NSwxOCArMTk1LDYgQEAgaWYgKGlzQXBwbGVNYWNXZWJL aXQoKSkgewogICAgICAgICBwdXNoIEBvcHRpb25zLCAkb3B0aW9uIHVubGVzcyAkb3B0aW9uIGVx ICIiOwogICAgIH0KIAotICAgIGlmIChpc0lPU1dlYktpdCgpKSB7Ci0gICAgICAgICMgRklYTUU6 IFJlbW92ZSB0aGUgaW5jbHVzaW9uIG9mIGJvdGggV2ViS2l0IFN5c3RlbSBJbnRlcmZhY2UgYW5k IFdlYktpdCBBZGRpdGlvbnMgcHJvamVjdHMKLSAgICAgICAgIyBvbmNlIHRoZSBpT1MgYnVpbGQg aXMgc3RhYmxlLgotCi0gICAgICAgICMgV2ViS2l0U3lzdGVtSW50ZXJmYWNlIHNob3VsZCBhbHdh eXMgYmUgYnVpbHQganVzdCBiZWZvcmUgV2ViS2l0LgotICAgICAgICBteSAkd2ViS2l0SW5kZXgg PSBmaXJzdCB7ICRwcm9qZWN0c1skX10gZXEgIlNvdXJjZS9XZWJLaXQiIH0gMC4uJCNwcm9qZWN0 czsKLSAgICAgICAgc3BsaWNlKEBwcm9qZWN0cywgJHdlYktpdEluZGV4LCAwLCAiLi4vSW50ZXJu YWwvV2ViS2l0U3lzdGVtSW50ZXJmYWNlIik7Ci0KLSAgICAgICAgIyBXZWJLaXRBZGRpdGlvbnMg bXVzdCBjb21lIGJlZm9yZSBXZWJDb3JlCi0gICAgICAgIHNwbGljZShAcHJvamVjdHMsIDAsIDAs ICIuLi9JbnRlcm5hbC9XZWJLaXRBZGRpdGlvbnMiKTsKLSAgICB9Ci0KICAgICAjIEFOR0xFIG11 c3QgY29tZSBiZWZvcmUgV2ViQ29yZQogICAgIHNwbGljZSBAcHJvamVjdHMsIDAsIDAsICJTb3Vy Y2UvVGhpcmRQYXJ0eS9BTkdMRSI7CiAK