135843 2014-08-12 10:10:16 -0700 BPLATFORM(IOS) always evaluates to false 2014-08-12 19:33:25 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 135848 1 dbates dbates barraclough ggaren kling rniwa sam oldest_to_newest 1028529 0 dbates 2014-08-12 10:10:16 -0700 BPLATFORM(IOS) always evaluates to false regardless of whether we are building bmalloc for iOS. Moreover, BPLATFORM(X) always evaluates to false for any X. 1028530 1 236452 dbates 2014-08-12 10:11:44 -0700 Created attachment 236452 Patch 1028533 2 dbates 2014-08-12 10:20:33 -0700 The patch for bug #131658 defined BPLATFORM(X) as (defined BPLATFORM_##PLATFORM && PLATFORM_##PLATFORM). Notice that the second conjunct is PLATFORM_##PLATFORM. But it should be BPLATFORM_##PLATFORM. Otherwise BPLATFORM(X) will always evaluate to false for any X since PLATFORM_X is undefined for any X and an undefined macro value evaluates to false in a boolean context. 1028565 3 236452 ggaren 2014-08-12 12:45:37 -0700 Comment on attachment 236452 Patch r=me 1028699 4 dbates 2014-08-12 19:27:48 -0700 For completeness, with the proposed change iOS will use 16kB pages instead of 4kb pages. 1028700 5 dbates 2014-08-12 19:33:25 -0700 Committed r172510: <http://trac.webkit.org/changeset/172510> 236452 2014-08-12 10:11:44 -0700 2014-08-12 12:45:37 -0700 Patch bug-135843-20140812101134.patch text/plain 1583 dbates U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggMDY1NzM3MTI3YzI0YzA4 MDA3NmMxYzI2M2Q5YzJiZDFiZjA4ZWI2NC4uY2I1MDQwYTc3NjE5MDcwMjkxYjFhN2UzZGM0ZGFl YTE3YTM3ZTkxNyAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA4LTEyICBEYW5p ZWwgQmF0ZXMgIDxkYWJhdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBCUExBVEZPUk0oSU9TKSBh bHdheXMgZXZhbHVhdGVzIHRvIGZhbHNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzU4NDMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggdHlwbyBpbiBkZWZpbml0aW9uIG9mIEJQTEFURk9STSgpIGFu ZCBpbmNsdWRlIHN5c3RlbSBoZWFkZXIgVGFyZ2V0Q29uZGl0aW9uYWxzLmgKKyAgICAgICAgKHdo ZW4gYnVpbGRpbmcgb24gYW4gQXBwbGUgcGxhdGZvcm0pIHNvIHRoYXQgQlBMQVRGT1JNKFgpIGV2 YWx1YXRlcyB0byB0cnVlIHdoZW4KKyAgICAgICAgYnVpbGRpbmcgZm9yIHBsYXRmb3JtIFguIElu IHBhcnRpY3VsYXIsIHNvIHRoYXQgQlBMQVRGT1JNKElPUykgZXZhbHVhdGVzIHRvIHRydWUgd2hl bgorICAgICAgICBidWlsZGluZyBmb3IgaU9TLgorCisgICAgICAgICogYm1hbGxvYy9CUGxhdGZv cm0uaDoKKwogMjAxNC0wNS0wMSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgogCiAg ICAgICAgIEZpeGVkIHByb2R1Y3Rpb24gYnVpbGRzIGZvciB0aGUgaU9TIFNpbXVsYXRvci4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRmb3JtLmggYi9Tb3VyY2UvYm1h bGxvYy9ibWFsbG9jL0JQbGF0Zm9ybS5oCmluZGV4IGE2ZmU4OTdjMzUxM2NmZTAxMDY2NjUzMDY4 NDllNTY0MjExZDIyY2UuLmYzYWFlOGJhMTA2YTMzODA3MDFlYzc3YTFiNDRlZDhhZGIyYWUxMmYg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFsbG9jL2JtYWxsb2MvQlBsYXRmb3JtLmgKKysrIGIvU291 cmNlL2JtYWxsb2MvYm1hbGxvYy9CUGxhdGZvcm0uaApAQCAtMjYsNyArMjYsMTEgQEAKICNpZm5k ZWYgQlBsYXRmb3JtX2gKICNkZWZpbmUgQlBsYXRmb3JtX2gKIAotI2RlZmluZSBCUExBVEZPUk0o UExBVEZPUk0pIChkZWZpbmVkIEJQTEFURk9STV8jI1BMQVRGT1JNICYmIFBMQVRGT1JNXyMjUExB VEZPUk0pCisjaWZkZWYgX19BUFBMRV9fCisjaW5jbHVkZSA8VGFyZ2V0Q29uZGl0aW9uYWxzLmg+ CisjZW5kaWYKKworI2RlZmluZSBCUExBVEZPUk0oUExBVEZPUk0pIChkZWZpbmVkIEJQTEFURk9S TV8jI1BMQVRGT1JNICYmIEJQTEFURk9STV8jI1BMQVRGT1JNKQogCiAjaWYgKChkZWZpbmVkKFRB UkdFVF9PU19FTUJFRERFRCkgJiYgVEFSR0VUX09TX0VNQkVEREVEKSBcCiAgICAgfHwgKGRlZmlu ZWQoVEFSR0VUX09TX0lQSE9ORSkgJiYgVEFSR0VUX09TX0lQSE9ORSkgXAo=