135840 2014-08-12 09:00:45 -0700 [gtk] Gaps between synchronised CSS-animated images at 50% Zoom 2023-05-10 10:42:45 -0700 1 1 1 Unclassified WebKit Animations 528+ (Nightly build) Unspecified Unspecified NEW P2 Normal --- 1 s.stjames webkit-unassigned dino graouts gyuyoung.kim mrobinson obzhirov spena zalan oldest_to_newest 1028513 0 236446 s.stjames 2014-08-12 09:00:45 -0700 Created attachment 236446 Test-case We at Samsung have run into some sub-pixel layout issues with the attached test-case; it shows a white border composed of 8 corner and edge pieces all animated in tandem with css transitions, and as it moves between the two red rectangles, there should be no visible "joins" or "seams" between the edge and corner pieces, but unfortunately there are - although this happens only at certain Zoom levels (notably: not at multiples of 100%). 50% Zoom usually shows the bug. On upstream-GTK, there seem to be a few contributing factors: 1) In RenderLayerBacking, the computation of the "anchor" in updateGeometry is slightly off for most of the frames: I think it's supposed to always be (0,0,0) in this example, but usually ends up fractionally different - and this "fraction" is blown up when the 9-patch pieces are laid out into about a pixel's worth of misalignment, leading to a visual gap between the pieces. This seems to be due to different rounding being used between enclosingRelativeCompositingBounds() and layerOffset(). 2) Again in updateGeometry, the m_graphicsLayer->setSize(contentsSize); eventually results in the 9-patch pieces being rendered with slightly incorrect sizes, again leading to a visible gap between the pieces: setting it to the size of compositingBounds() seems to be more correct for this test-case, but I'm sure it breaks others :) 3) The BitmapTextures that are are ultimately rendered by TextureMapperGL have their contents offset slightly, again leading to visible (but this time "gradiented") gaps between the pieces: see the attached picture, which shows a dump of one of the BitmapTextures with a gap at the left edge. We are especially interested in #1, as we are using Coordinated Graphics and do not suffer from #3 there, though we have an analogue of #2 that is causing us some grief :) I'm betting #1 affects all platforms. I've been using the attached patch to aid diagnosis: it dumps out the coordinates of the pieces that are rendered out; snaps the zoom to 50% whenever it is manually changed; and also freezes the animation progress at 100% which makes the bug(s) slightly easier to analyse. I think the general question that I'm getting stuck on is the following: it is obviously useful & correct in the majority of cases to snap to pixels during layout, but this should not be done (ever?) when dealing with CSS transitions: how is this conflict supposed to be handled by WebKit? Zalan: I hope you don't mind me CC'ing you, but I'm keen to hear anything thoughts you have, especially on 1) and 2) :) 1028514 1 236447 s.stjames 2014-08-12 09:01:34 -0700 Created attachment 236447 Small set of diagnostic helpers for this issue 1028515 2 236448 s.stjames 2014-08-12 09:02:10 -0700 Created attachment 236448 BitmapTexture with contents incorrectly offset 1028519 3 spena 2014-08-12 09:05:44 -0700 Martin: I suggested Simon St. James to CC you, in case you can make any comment from WebKitGTK point of view. 236446 2014-08-12 09:00:45 -0700 2014-08-12 09:00:45 -0700 Test-case 9-patch-border-glitch-testcase.html text/html 11169 s.stjames PGh0bWw+CjxoZWFkPgo8c3R5bGU+CmJvZHkgewogICAgYmFja2dyb3VuZC1jb2xvcjogIzAwODAw MDsKfSAKCi50aWxlLWhpZ2hsaWdodCB7CiAgICBwb3NpdGlvbjogYWJzb2x1dGU7CiAgICB6LWlu ZGV4OiAyMDsKICAgIC13ZWJraXQtdHJhbnNpdGlvbjogbm9uZTsKICAgIC13ZWJraXQtdHJhbnNm b3JtOiB0cmFuc2xhdGVaKDApOwogICAgLXdlYmtpdC10cmFuc2Zvcm0tb3JpZ2luOiBsZWZ0IHRv cDsKfQoKLnRpbGUtaGlnaGxpZ2h0LnRyYW5zaXRpb24tb24gewogICAgLXdlYmtpdC10cmFuc2l0 aW9uOiBhbGwgMTAuNXMgbGluZWFyOwp9CgouaGlnaGxpZ2h0X2x0IHsKICAgIHdpZHRoOjY4cHg7 CiAgICBoZWlnaHQ6NjhweDsKICAgIGJhY2tncm91bmQtaW1hZ2U6dXJsKGRhdGE6aW1hZ2UvcG5n O2Jhc2U2NCxpVkJPUncwS0dnb0FBQUFOU1VoRVVnQUFBRVFBQUFCRUNBWUFBQUE0RTVPeUFBQUFC SE5DU1ZRSUNBZ0lmQWhraUFBQUFBbHdTRmx6QUFBT3hBQUFEc1FCbFNzT0d3QUFBQmwwUlZoMFUy OW1kSGRoY21VQVFXUnZZbVVnU1cxaFoyVlNaV0ZrZVhISlpUd0FBQUNIU1VSQlZIaWM3ZFhCQ1lB d0ZBVkJJL2JmY3J6dlRUREd3MHdETHl3ZmNod0FBQUFBQUFCOFlhd2VtSFBPMVJ0dk9uYy80RzhF Q1VGQ2tCQWtCSWxyNS9nWVkvbTMvNVFMQ1VGQ2tCQWtCQWxCUXBBUUpBUUpRVUtRRUNRRUNVRkNr QkFrQkFsQlFwQVFKQVFKUVVLUUVDUUVDVUZDa0JBa0JBbEJRcEFRSkFRSlFVS1FFQ1J1dXhBRVdu MnU2cFVBQUFBQVNVVk9SSzVDWUlJPSk7CiAgICBiYWNrZ3JvdW5kLXJlcGVhdDpuby1yZXBlYXQ7 Cn0KLmhpZ2hsaWdodF90IHsKICAgIHdpZHRoOjM2cHg7CiAgICBoZWlnaHQ6NjhweDsKICAgIGJh Y2tncm91bmQtaW1hZ2U6dXJsKGRhdGE6aW1hZ2UvcG5nO2Jhc2U2NCxpVkJPUncwS0dnb0FBQUFO U1VoRVVnQUFBQVFBQUFCRUNBWUFBQUNtcVpRU0FBQUFCSE5DU1ZRSUNBZ0lmQWhraUFBQUFBbHdT Rmx6QUFBT3hBQUFEc1FCbFNzT0d3QUFBQmwwUlZoMFUyOW1kSGRoY21VQVFXUnZZbVVnU1cxaFoy VlNaV0ZrZVhISlpUd0FBQUFnU1VSQlZEaU5ZMkFZQllNUk1QNy8vLzgvc2dBVHVncWFDSXlDVVVC M0FBREN0UVFLK0FjV2VBQUFBQUJKUlU1RXJrSmdnZz09KTsKICAgIGJhY2tncm91bmQtcmVwZWF0 Om5vLXJlcGVhdDsKfQouaGlnaGxpZ2h0X3J0IHsKICAgIHdpZHRoOjY4cHg7CiAgICBoZWlnaHQ6 NjhweDsKICAgIGJhY2tncm91bmQtaW1hZ2U6dXJsKGRhdGE6aW1hZ2UvcG5nO2Jhc2U2NCxpVkJP UncwS0dnb0FBQUFOU1VoRVVnQUFBRVFBQUFCRUNBWUFBQUE0RTVPeUFBQUFCSE5DU1ZRSUNBZ0lm QWhraUFBQUFBbHdTRmx6QUFBT3hBQUFEc1FCbFNzT0d3QUFBQmwwUlZoMFUyOW1kSGRoY21VQVFX UnZZbVVnU1cxaFoyVlNaV0ZrZVhISlpUd0FBQUNKU1VSQlZIaWM3ZFpCQ29SQURBQkJzLy8vODNq dnc0TENLRUxWQTBMb1MzSWNBQUFBQUFBQVBHSFdXdXZ0SmE2WW1kazUvN2R6K0JjSkVvS0VJQ0ZJ Q0JKYlQ5aGQvMTRCWi9kaGdvUWdJVWdJRW9LRUlDRklDQktDaENBaFNBZ1Nnb1FnSVVnSUVvS0VJ Q0ZJQ0JLQ2hDQWhTQWdTZ29RZ0lVZ0lFb0tFSUNGSUNCS0NoQ0FoU0p4akFBaFhsbGUyNndBQUFB QkpSVTVFcmtKZ2dnPT0pOwogICAgYmFja2dyb3VuZC1yZXBlYXQ6bm8tcmVwZWF0OyAgICAKfQou aGlnaGxpZ2h0X2wgewogICAgd2lkdGg6NjhweDsKICAgIGhlaWdodDozNnB4OwogICAgYmFja2dy b3VuZC1pbWFnZTp1cmwoZGF0YTppbWFnZS9wbmc7YmFzZTY0LGlWQk9SdzBLR2dvQUFBQU5TVWhF VWdBQUFFUUFBQUFFQ0FZQUFBQTNTNW5lQUFBQUJITkNTVlFJQ0FnSWZBaGtpQUFBQUFsd1NGbHpB QUFPeEFBQURzUUJsU3NPR3dBQUFCbDBSVmgwVTI5bWRIZGhjbVVBUVdSdlltVWdTVzFoWjJWU1pX RmtlWEhKWlR3QUFBQXBTVVJCVkRpTlkyU2dNZmovLy85L1hIS01qSXlNdExhZlZNQTAwQTRZYkdB MFFOREFhSUNnQVFDYnhRUUlDUGJZb1FBQUFBQkpSVTVFcmtKZ2dnPT0pOwogICAgYmFja2dyb3Vu ZC1yZXBlYXQ6bm8tcmVwZWF0Owp9Ci5oaWdobGlnaHRfciB7CiAgICB3aWR0aDo2OHB4OwogICAg aGVpZ2h0OjM2cHg7CiAgICBiYWNrZ3JvdW5kLWltYWdlOnVybChkYXRhOmltYWdlL3BuZztiYXNl NjQsaVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUVRQUFBQUVDQVlBQUFBM1M1bmVBQUFBQkhOQ1NW UUlDQWdJZkFoa2lBQUFBQWx3U0ZsekFBQU94QUFBRHNRQmxTc09Hd0FBQUJsMFJWaDBVMjltZEhk aGNtVUFRV1J2WW1VZ1NXMWhaMlZTWldGa2VYSEpaVHdBQUFBblNVUkJWRGlOWTJRWWhPRC8vLy8v Y2NreE1qSXkwdEp1SmxvYVBoVEJhSUNnZ2RFQVFRTUF5N1lFQ0hMeklUQUFBQUFBU1VWT1JLNUNZ SUk9KTsKICAgIGJhY2tncm91bmQtcmVwZWF0Om5vLXJlcGVhdDsKfQouaGlnaGxpZ2h0X2xiIHsK ICAgIHdpZHRoOjY4cHg7CiAgICBoZWlnaHQ6NjhweDsKICAgIGJhY2tncm91bmQtaW1hZ2U6dXJs KGRhdGE6aW1hZ2UvcG5nO2Jhc2U2NCxpVkJPUncwS0dnb0FBQUFOU1VoRVVnQUFBRVFBQUFCRUNB WUFBQUE0RTVPeUFBQUFCSE5DU1ZRSUNBZ0lmQWhraUFBQUFBbHdTRmx6QUFBT3hBQUFEc1FCbFNz T0d3QUFBQmwwUlZoMFUyOW1kSGRoY21VQVFXUnZZbVVnU1cxaFoyVlNaV0ZrZVhISlpUd0FBQUNK U1VSQlZIaWM3ZG94Q29CQURBQkI0Ly8vZlBZTENoYUhGalB0RlRtV2xKbGpzN1hXdW51Ym1kazkv NjN6NncvOGpTQWhTQWdTZ29RZ0lVZ0lFb0tFSUNGSUNCS0NoQ0FoU0FnU2dvUWdJVWdJRW9LRUlD RklDQktDaENBaFNBZ1Nnb1FnSVVnSUVvS0VJQ0ZJQ0JMYmo5NmVqdTcreUlhRUlDRklDQktDaENB QUFBQUFBQUI4NGdLNUNBaFRUa2QxRFFBQUFBQkpSVTVFcmtKZ2dnPT0pOwogICAgYmFja2dyb3Vu ZC1yZXBlYXQ6bm8tcmVwZWF0Owp9Ci5oaWdobGlnaHRfYiB7CiAgICB3aWR0aDozNnB4OwogICAg aGVpZ2h0OjY4cHg7CiAgICBiYWNrZ3JvdW5kLWltYWdlOnVybChkYXRhOmltYWdlL3BuZztiYXNl NjQsaVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUFRQUFBQkVDQVlBQUFDbXFaUVNBQUFBQkhOQ1NW UUlDQWdJZkFoa2lBQUFBQWx3U0ZsekFBQU94QUFBRHNRQmxTc09Hd0FBQUJsMFJWaDBVMjltZEhk aGNtVUFRV1J2WW1VZ1NXMWhaMlZTWldGa2VYSEpaVHdBQUFBZ1NVUkJWRGlOWTJBWUJhT0F6b0R4 Ly8vLy81RUZtTkJWMEVSZ0ZBeE9BQUJHd3dRS2RUOWM1d0FBQUFCSlJVNUVya0pnZ2c9PSk7CiAg ICBiYWNrZ3JvdW5kLXJlcGVhdDpuby1yZXBlYXQ7Cn0KLmhpZ2hsaWdodF9yYiB7CiAgICB3aWR0 aDo2OHB4OwogICAgaGVpZ2h0OjY4cHg7CiAgICBiYWNrZ3JvdW5kLWltYWdlOnVybChkYXRhOmlt YWdlL3BuZztiYXNlNjQsaVZCT1J3MEtHZ29BQUFBTlNVaEVVZ0FBQUVRQUFBQkVDQVlBQUFBNEU1 T3lBQUFBQkhOQ1NWUUlDQWdJZkFoa2lBQUFBQWx3U0ZsekFBQU94QUFBRHNRQmxTc09Hd0FBQUJs MFJWaDBVMjltZEhkaGNtVUFRV1J2WW1VZ1NXMWhaMlZTWldGa2VYSEpaVHdBQUFDR1NVUkJWSGlj N2RwQkNnSkJEQURCemVML3Z4enZEWG9iVkt5NkJpYlE1RGh6ZmFIZDNWZXptWm1UdSsrVGovOGlR VUtRRUNRRUNVRkNrQkFrQkFsQlFwQVFKQVFKUVVLUUVDUUVDVUZDa0JBa0JBbEJRcEFRSkFRSlFV S1FFQ1FFQ1VGQ2tCQWtCQWxCUXBBUUpCN3ZQcmo5SXhjU2dvUWdJVWdJRW9JQUFBQUFBQUR3RVUv S3hBaFdEbGFGU1FBQUFBQkpSVTVFcmtKZ2dnPT0pOwogICAgYmFja2dyb3VuZC1yZXBlYXQ6bm8t cmVwZWF0Owp9Cjwvc3R5bGU+Cgo8c2NyaXB0Pgp2YXIgVGVzdCA9IHsKaW5pdDogZnVuY3Rpb24o KSB7CiAgICAgIHZhciBlVGVtcCA9IGRvY3VtZW50LmJvZHkuY2hpbGROb2RlcywKICAgICAgICAg IG5Db3VudCA9IDA7CgogICAgICB2YXIgZUluaXRpYWxFbGVtZW50VFdpZHRoID0gMzY7CiAgICAg IHZhciBlSW5pdGlhbEVsZW1lbnRMVFdpZHRoID0gNjg7CgogICAgICB0aGlzLmVOaW5lUGF0Y2hF bGVtZW50cyA9IFtdOwoKICAgICAgdGhpcy5vTmluZVBhdGNoUG9zaXRpb24gPSB7eDogMCwgeTog MCwgdzogZUluaXRpYWxFbGVtZW50VFdpZHRoLCBoOiBlSW5pdGlhbEVsZW1lbnRUV2lkdGh9Owog ICAgICB0aGlzLm5OaW5lUGF0Y2hCb3JkZXJXaWR0aCA9IGVJbml0aWFsRWxlbWVudExUV2lkdGg7 CiAgICAgIHRoaXMubk5pbmVQYXRjaFNjYWxlRGl2aWRlciA9IGVJbml0aWFsRWxlbWVudFRXaWR0 aDsKCiAgICAgIGZvciAodmFyIGkgPSAwOyBpIDwgZVRlbXAubGVuZ3RoOyBpKyspIHsKICAgICAg ICAgIGlmIChlVGVtcFtpXS5ub2RlTmFtZSA9PSAiRElWIikgewogICAgICAgICAgICAgIHRoaXMu ZU5pbmVQYXRjaEVsZW1lbnRzW25Db3VudCsrXSA9IGVUZW1wW2ldOwogICAgICAgICAgfQogICAg ICB9CgogICAgICB2YXIgb3JpZ2luYWxUaGlzID0gdGhpczsKICAgICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoJy5oaWdobGlnaHRfdCcpLmFkZEV2ZW50TGlzdGVuZXIoIndlYmtpdFRyYW5zaXRp b25FbmQiLCBmdW5jdGlvbihldikgeyBvcmlnaW5hbFRoaXMubW92ZUhpZ2hsaWdodEVuZChldiwg b3JpZ2luYWxUaGlzKTsgfSwgdHJ1ZSk7CiAgICAgIHRoaXMuc2V0UG9zaXRpb24odGhpcy5vTmlu ZVBhdGNoUG9zaXRpb24ueCwgdGhpcy5vTmluZVBhdGNoUG9zaXRpb24ueSwgdGhpcy5vTmluZVBh dGNoUG9zaXRpb24udywgdGhpcy5vTmluZVBhdGNoUG9zaXRpb24uaCk7Cn0sCgpuaW5lUGF0Y2hQ b3NpdGlvbkZvckVsZW1lbnQ6IGZ1bmN0aW9uKGVsZW1lbnQpIHsKICAgICB2YXIgeDEgPSBlbGVt ZW50Lm9mZnNldFBhcmVudC5vZmZzZXRMZWZ0ICsgZWxlbWVudC5vZmZzZXRMZWZ0ICsgdGhpcy5u TmluZVBhdGNoU2NhbGVEaXZpZGVyOwogICAgIHZhciB5MSA9IGVsZW1lbnQub2Zmc2V0UGFyZW50 Lm9mZnNldFRvcCArIGVsZW1lbnQub2Zmc2V0VG9wICsgdGhpcy5uTmluZVBhdGNoU2NhbGVEaXZp ZGVyOwogICAgIHZhciB3MSA9IGVsZW1lbnQub2Zmc2V0V2lkdGggLSAodGhpcy5uTmluZVBhdGNo U2NhbGVEaXZpZGVyICogMik7CiAgICAgdmFyIGgxID0gZWxlbWVudC5vZmZzZXRIZWlnaHQgLSAo dGhpcy5uTmluZVBhdGNoU2NhbGVEaXZpZGVyICogMik7CgogICAgIHgxID0gTWF0aC5mbG9vcih4 MSAtICgoKHcxICogMS4wMykgKiAwLjUpIC0gKHcxICogMC41KSkpOwogICAgIHkxID0gTWF0aC5m bG9vcih5MSAtICgoKGgxICogMS4wMykgKiAwLjUpIC0gKGgxICogMC41KSkpOwogICAgIHcxID0g TWF0aC5jZWlsKHcxICogMS4wMyk7CiAgICAgaDEgPSBNYXRoLmNlaWwoaDEgKiAxLjAzKTsKCiAg ICAgcmV0dXJuIHsgeDogeDEsIHk6IHkxLCB3OiB3MSwgaDogaDEgfTsKIH0sCgptb3ZlOiBmdW5j dGlvbihvcHRpb25zKSB7CgogIGlmIChvcHRpb25zLnRhcmdldEVsZW1lbnQpIHsKCiAgICAgIHRo aXMuc2V0QW5pbWF0aW9uKCk7CgogICAgICB2YXIgcG9zaXRpb25Gb3JFbGVtZW50ID0gdGhpcy5u aW5lUGF0Y2hQb3NpdGlvbkZvckVsZW1lbnQob3B0aW9ucy50YXJnZXRFbGVtZW50KTsKCiAgICAg IHRoaXMubW92ZUhpZ2hsaWdodCh0aGlzLm9OaW5lUGF0Y2hQb3NpdGlvbi54LCB0aGlzLm9OaW5l UGF0Y2hQb3NpdGlvbi55LCB0aGlzLm9OaW5lUGF0Y2hQb3NpdGlvbi53LCB0aGlzLm9OaW5lUGF0 Y2hQb3NpdGlvbi5oLCBwb3NpdGlvbkZvckVsZW1lbnQueCwgcG9zaXRpb25Gb3JFbGVtZW50Lnks IHBvc2l0aW9uRm9yRWxlbWVudC53LCBwb3NpdGlvbkZvckVsZW1lbnQuaCk7CiAgfQp9LAoKcmVz ZXRBbmltYXRpb246IGZ1bmN0aW9uKCkgewogICAgZm9yICh2YXIgaSA9IDA7IGkgPCB0aGlzLmVO aW5lUGF0Y2hFbGVtZW50cy5sZW5ndGg7IGkrKykgewogICAgICAgIHRoaXMuZU5pbmVQYXRjaEVs ZW1lbnRzW2ldLmNsYXNzTmFtZSA9CiAgICAgICAgICAgIHRoaXMuZU5pbmVQYXRjaEVsZW1lbnRz W2ldLmNsYXNzTmFtZS5yZXBsYWNlKC9cYnRyYW5zaXRpb24tb25cYi8sJycpOwogICAgfQp9LApz ZXRBbmltYXRpb246IGZ1bmN0aW9uKCkgewogIGZvciAodmFyIGkgPSAwOyBpIDwgdGhpcy5lTmlu ZVBhdGNoRWxlbWVudHMubGVuZ3RoOyBpKyspIHsKICAgICAgdGhpcy5lTmluZVBhdGNoRWxlbWVu dHNbaV0uY2xhc3NOYW1lID0KICAgICAgICAgIHRoaXMuZU5pbmVQYXRjaEVsZW1lbnRzW2ldLmNs YXNzTmFtZSArPSAiIHRyYW5zaXRpb24tb24iOwogIH0KfSwKCnNldEVsUG9zaXRpb246IGZ1bmN0 aW9uKGVsLCB4LCB5KSB7CiAgIGVsLnN0eWxlLmxlZnQgPSB4ICsgJ3B4JzsKICAgZWwuc3R5bGUu dG9wID0geSArICdweCc7Cn0sCgptb3ZlSGlnaGxpZ2h0RW5kOiBmdW5jdGlvbihldiwgb3JpZ2lu YWxUaGlzKSB7CiAgZXYuc3RvcFByb3BhZ2F0aW9uKCk7CiAgdmFyIHByb3AgPSBvcmlnaW5hbFRo aXMudGFyZ2V0QW5pUHJvcGVydHk7CiAgb3JpZ2luYWxUaGlzLnNldFBvc2l0aW9uKHByb3AueCwg cHJvcC55LCBwcm9wLncsIHByb3AuaCk7CiAgLy8gRG9uJ3Qgc3RhcnQgYSBuZXcgdHJhbnNpdGlv biBmcm9tIHdpdGhpbiB0aGUgImZpbmlzaGVkIiBjYWxsYmFjayBvZiB0aGUgbGFzdCBvbmUuCiAg c2V0VGltZW91dChkb2N1bWVudC5nbywgMCk7Cn0sCgpzZXRQb3NpdGlvbjogZnVuY3Rpb24oeCwg eSwgdywgaCkgewogICAgIHRoaXMucmVzZXRBbmltYXRpb24oKTsKCiAgICAgZm9yICh2YXIgaSA9 IDA7IGkgPCB0aGlzLmVOaW5lUGF0Y2hFbGVtZW50cy5sZW5ndGg7IGkrKykgewogICAgICAgICB0 aGlzLmVOaW5lUGF0Y2hFbGVtZW50c1tpXS5zdHlsZS53ZWJraXRUcmFuc2Zvcm0gPSAnJzsKICAg ICB9CgogICAgIHRoaXMuc2V0RWxQb3NpdGlvbih0aGlzLmVOaW5lUGF0Y2hFbGVtZW50c1swXSwg eCAtIHRoaXMubk5pbmVQYXRjaEJvcmRlcldpZHRoLCB5IC0gdGhpcy5uTmluZVBhdGNoQm9yZGVy V2lkdGgpOwogICAgIHRoaXMuc2V0RWxQb3NpdGlvbih0aGlzLmVOaW5lUGF0Y2hFbGVtZW50c1sx XSwgeCwgeSAtIHRoaXMubk5pbmVQYXRjaEJvcmRlcldpZHRoKTsKICAgICB0aGlzLmVOaW5lUGF0 Y2hFbGVtZW50c1sxXS5zdHlsZS53aWR0aCA9IHcgKyAncHgnOwogICAgIHRoaXMuZU5pbmVQYXRj aEVsZW1lbnRzWzFdLnN0eWxlLmJhY2tncm91bmRTaXplID0gdyArICdweCAnICsgdGhpcy5uTmlu ZVBhdGNoQm9yZGVyV2lkdGggKyAncHgnOwogICAgIHRoaXMuc2V0RWxQb3NpdGlvbih0aGlzLmVO aW5lUGF0Y2hFbGVtZW50c1syXSwgeCArIHcsIHkgLSB0aGlzLm5OaW5lUGF0Y2hCb3JkZXJXaWR0 aCk7CiAgICAgdGhpcy5zZXRFbFBvc2l0aW9uKHRoaXMuZU5pbmVQYXRjaEVsZW1lbnRzWzNdLCB4 IC0gdGhpcy5uTmluZVBhdGNoQm9yZGVyV2lkdGgsIHkpOwogICAgIHRoaXMuZU5pbmVQYXRjaEVs ZW1lbnRzWzNdLnN0eWxlLmhlaWdodCA9IGggKyAncHgnOwogICAgIHRoaXMuZU5pbmVQYXRjaEVs ZW1lbnRzWzNdLnN0eWxlLmJhY2tncm91bmRTaXplPXRoaXMubk5pbmVQYXRjaEJvcmRlcldpZHRo ICsgJ3B4ICcgKyBoICsgJ3B4JzsKICAgICB0aGlzLnNldEVsUG9zaXRpb24odGhpcy5lTmluZVBh dGNoRWxlbWVudHNbNF0sIHggKyB3LCB5KTsKICAgICB0aGlzLmVOaW5lUGF0Y2hFbGVtZW50c1s0 XS5zdHlsZS5oZWlnaHQgPSBoICsgJ3B4JzsKICAgICB0aGlzLmVOaW5lUGF0Y2hFbGVtZW50c1s0 XS5zdHlsZS5iYWNrZ3JvdW5kU2l6ZSA9IHRoaXMubk5pbmVQYXRjaEJvcmRlcldpZHRoICsgJ3B4 ICcgKyBoICsgJ3B4JzsKICAgICB0aGlzLnNldEVsUG9zaXRpb24odGhpcy5lTmluZVBhdGNoRWxl bWVudHNbNV0sIHggLSB0aGlzLm5OaW5lUGF0Y2hCb3JkZXJXaWR0aCwgeSArIGgpOwogICAgIHRo aXMuc2V0RWxQb3NpdGlvbih0aGlzLmVOaW5lUGF0Y2hFbGVtZW50c1s2XSwgeCwgeSArIGgpOwog ICAgIHRoaXMuZU5pbmVQYXRjaEVsZW1lbnRzWzZdLnN0eWxlLndpZHRoID0gdyArICdweCc7CiAg ICAgdGhpcy5lTmluZVBhdGNoRWxlbWVudHNbNl0uc3R5bGUuYmFja2dyb3VuZFNpemUgPSB3ICsg J3B4ICcgKyB0aGlzLm5OaW5lUGF0Y2hCb3JkZXJXaWR0aCArICdweCc7CiAgICAgdGhpcy5zZXRF bFBvc2l0aW9uKHRoaXMuZU5pbmVQYXRjaEVsZW1lbnRzWzddLCB4ICsgdywgeSArIGgpOwogICAg IHRoaXMub05pbmVQYXRjaFBvc2l0aW9uID0ge3g6IHgsIHk6IHksIHc6IHcsIGg6IGh9OwogfSwK Cm1vdmVIaWdobGlnaHQ6IGZ1bmN0aW9uKHgxLCB5MSwgdzEsIGgxLCB4MiwgeTIsIHcyLCBoMikg ewogICB2YXIgc2NhbGV4ID0gdzIgLyB0aGlzLm9OaW5lUGF0Y2hQb3NpdGlvbi53LAogICBzY2Fs ZXkgPSBoMiAvIHRoaXMub05pbmVQYXRjaFBvc2l0aW9uLmgsCiAgIHRyYW5zX3gyID0geDIgLSB4 MSwKICAgdHJhbnNfeTIgPSB5MiAtIHkxLAogICB4Ml9pbm5lciA9IHcyICsgdHJhbnNfeDIgLSB3 MSwKICAgeTJfaW5uZXIgPSBoMiArIHRyYW5zX3kyIC0gaDE7CgogICB0aGlzLnRhcmdldEFuaVBy b3BlcnR5ID0ge3g6IHgyLCB5OiB5MiwgdzogdzIsIGg6IGgyfTsKICAgdGhpcy5lTmluZVBhdGNo RWxlbWVudHNbMF0uc3R5bGUud2Via2l0VHJhbnNmb3JtID0gJ3RyYW5zbGF0ZTNkKCcgKyB0cmFu c194MiArICdweCwgJyArIHRyYW5zX3kyICsgJ3B4LCAwcHgpJzsKICAgdGhpcy5lTmluZVBhdGNo RWxlbWVudHNbMV0uc3R5bGUud2Via2l0VHJhbnNmb3JtID0gJ3RyYW5zbGF0ZTNkKCcgKyB0cmFu c194MiArICdweCwgJyArIHRyYW5zX3kyICsgJ3B4LCAwcHgpIHNjYWxlM2QoJyArIHNjYWxleCAr ICcsIDEuMCwgMS4wKSc7CiAgIHRoaXMuZU5pbmVQYXRjaEVsZW1lbnRzWzJdLnN0eWxlLndlYmtp dFRyYW5zZm9ybSA9ICd0cmFuc2xhdGUzZCgnICsgeDJfaW5uZXIgKyAncHgsICcgKyB0cmFuc195 MiArICdweCwgMHB4KSc7CiAgIHRoaXMuZU5pbmVQYXRjaEVsZW1lbnRzWzNdLnN0eWxlLndlYmtp dFRyYW5zZm9ybSA9ICd0cmFuc2xhdGUzZCgnICsgdHJhbnNfeDIgKyAncHgsICcgKyB0cmFuc195 MiArICdweCwgMHB4KSBzY2FsZTNkKDEuMCwgJyArIHNjYWxleSArICcsIDEuMCknOwogICB0aGlz LmVOaW5lUGF0Y2hFbGVtZW50c1s0XS5zdHlsZS53ZWJraXRUcmFuc2Zvcm0gPSAndHJhbnNsYXRl M2QoJyArIHgyX2lubmVyICsgJ3B4LCAnICsgdHJhbnNfeTIgKyAncHgsIDBweCkgc2NhbGUzZCgx LjAsICcgKyBzY2FsZXkgKyAnLCAxLjApJzsKICAgdGhpcy5lTmluZVBhdGNoRWxlbWVudHNbNV0u c3R5bGUud2Via2l0VHJhbnNmb3JtID0gJ3RyYW5zbGF0ZTNkKCcgKyB0cmFuc194MiArICdweCwg JyArIHkyX2lubmVyICsgJ3B4LCAwcHgpJzsKICAgdGhpcy5lTmluZVBhdGNoRWxlbWVudHNbNl0u c3R5bGUud2Via2l0VHJhbnNmb3JtID0gJ3RyYW5zbGF0ZTNkKCcgKyB0cmFuc194MiArICdweCwg JyArIHkyX2lubmVyICsgJ3B4LCAwcHgpIHNjYWxlM2QoJyArIHNjYWxleCArICcsIDEuMCwgMS4w KSc7CiAgIHRoaXMuZU5pbmVQYXRjaEVsZW1lbnRzWzddLnN0eWxlLndlYmtpdFRyYW5zZm9ybSA9 ICd0cmFuc2xhdGUzZCgnICsgeDJfaW5uZXIgKyAncHgsICcgKyB5Ml9pbm5lciArICdweCwgMHB4 KSc7Cn0sCgoKICAgIH0KPC9zY3JpcHQ+CjxzY3JpcHQ+CnZhciBpbml0ZWQgPSBmYWxzZTsKdmFy IGRpcmVjdGlvbiA9IC0xOwpmdW5jdGlvbiBnbygpIHsKICAgIGlmICghaW5pdGVkKQogICAgewog ICAgICAgIFRlc3QuaW5pdCgpOwogICAgICAgIGluaXRlZCA9IHRydWU7CiAgICAgICAgZG9jdW1l bnQuZ28gPSBnbzsKICAgICAgICB2YXIgcG9zaXRpb25PZkluaXRpYWxFbGVtZW50ID0gVGVzdC5u aW5lUGF0Y2hQb3NpdGlvbkZvckVsZW1lbnQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3JlY3Qx JykpOwogICAgICAgIFRlc3Quc2V0UG9zaXRpb24ocG9zaXRpb25PZkluaXRpYWxFbGVtZW50Lngs IHBvc2l0aW9uT2ZJbml0aWFsRWxlbWVudC55LCBwb3NpdGlvbk9mSW5pdGlhbEVsZW1lbnQudywg cG9zaXRpb25PZkluaXRpYWxFbGVtZW50LmgpOwogICAgICAgIHdpbmRvdy5zZXRUaW1lb3V0KGRv Y3VtZW50LmdvLCAwMDAwKTsKICAgIH0KICAgIGVsc2UKICAgIHsKICAgICAgICB2YXIgb3B0aW9u cyA9IG5ldyBPYmplY3Q7CiAgICAgICAgaWYgKGRpcmVjdGlvbiA9PSAxKQogICAgICAgIHsKICAg ICAgICAgICAgb3B0aW9ucy50YXJnZXRFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQo J3JlY3QxJyk7CiAgICAgICAgICAgIG9wdGlvbnMucHJldmlvdXNFbGVtZW50ID0gZG9jdW1lbnQu Z2V0RWxlbWVudEJ5SWQoJ3JlY3QyJyk7CiAgICAgICAgfQogICAgICAgIGVsc2UKICAgICAgICB7 CiAgICAgICAgICAgIG9wdGlvbnMudGFyZ2V0RWxlbWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRC eUlkKCdyZWN0MicpOwogICAgICAgICAgICBvcHRpb25zLnByZXZpb3VzRWxlbWVudCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCdyZWN0MScpOwogICAgICAgIH0KICAgICAgICBkaXJlY3Rpb24g PSAtZGlyZWN0aW9uOwogICAgICAgIFRlc3QubW92ZShvcHRpb25zKTsKICAgIH0KfTsKPC9zY3Jp cHQ+Cgo8L2hlYWQ+Cjxib2R5IG9ubG9hZD0nZ28oKSc+CjxkaXYgY2xhc3M9InRpbGUtaGlnaGxp Z2h0IGhpZ2hsaWdodF9sdCIgaWQ9Ii5oaWdobGlnaHRfbHQiPjwvZGl2Pgo8ZGl2IGNsYXNzPSJ0 aWxlLWhpZ2hsaWdodCBoaWdobGlnaHRfdCIgaWQ9Ii5oaWdobGlnaHRfdCI+PC9kaXY+CjxkaXYg Y2xhc3M9InRpbGUtaGlnaGxpZ2h0IGhpZ2hsaWdodF9ydCI+PC9kaXY+CjxkaXYgY2xhc3M9InRp bGUtaGlnaGxpZ2h0IGhpZ2hsaWdodF9sIj48L2Rpdj4KPGRpdiBjbGFzcz0idGlsZS1oaWdobGln aHQgaGlnaGxpZ2h0X3IiPjwvZGl2Pgo8ZGl2IGNsYXNzPSJ0aWxlLWhpZ2hsaWdodCBoaWdobGln aHRfbGIiPjwvZGl2Pgo8ZGl2IGNsYXNzPSJ0aWxlLWhpZ2hsaWdodCBoaWdobGlnaHRfYiI+PC9k aXY+CjxkaXYgY2xhc3M9InRpbGUtaGlnaGxpZ2h0IGhpZ2hsaWdodF9yYiI+PC9kaXY+Cgo8ZGl2 IHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMTAwcHg7IGxlZnQ6IDE1MHB4OyB3aWR0 aDogMTAwcHg7IGhlaWdodDogMTAwcHg7IGJhY2tncm91bmQtY29sb3I6IHJlZDsgY29sb3I6IHJl ZDsiIGlkPSJyZWN0MSIvPgo8ZGl2IHN0eWxlPSJwb3NpdGlvbjogYWJzb2x1dGU7IHRvcDogMTAw cHg7IGxlZnQ6IDQ1MHB4OyB3aWR0aDogMzAwcHg7IGhlaWdodDogNDAwcHg7IGJhY2tncm91bmQt Y29sb3I6IHJlZDsgY29sb3I6IHJlZDsiIGlkPSJyZWN0MiIvPgo8L2JvZHk+CjwvaHRtbD4K 236447 2014-08-12 09:01:34 -0700 2014-08-12 09:01:34 -0700 Small set of diagnostic helpers for this issue diagnostic-helper.patch text/plain 2294 s.stjames ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5 ZXJBbmltYXRpb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NMYXllckFuaW1hdGlvbi5jcHAKaW5kZXggZGM5YTY5Yi4uODE4ODcxYiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckFuaW1hdGlvbi5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3NMYXllckFu aW1hdGlvbi5jcHAKQEAgLTIyOCw2ICsyMjgsNyBAQCBHcmFwaGljc0xheWVyQW5pbWF0aW9uOjpH cmFwaGljc0xheWVyQW5pbWF0aW9uKGNvbnN0IFN0cmluZyYgbmFtZSwgY29uc3QgS2V5ZnJhbQog CiB2b2lkIEdyYXBoaWNzTGF5ZXJBbmltYXRpb246OmFwcGx5SW50ZXJuYWwoQ2xpZW50KiBjbGll bnQsIGNvbnN0IEFuaW1hdGlvblZhbHVlJiBmcm9tLCBjb25zdCBBbmltYXRpb25WYWx1ZSYgdG8s IGZsb2F0IHByb2dyZXNzKQogeworICAgIHByb2dyZXNzID0gMS4wOyAvLyBGcmVlemUgcHJvZ3Jl c3MgZm9yIGVhc2llciBsYXlvdXQgZGVidWdnaW5nLgogICAgIHN3aXRjaCAobV9rZXlmcmFtZXMu cHJvcGVydHkoKSkgewogICAgIGNhc2UgQW5pbWF0ZWRQcm9wZXJ0eU9wYWNpdHk6CiAgICAgICAg IGNsaWVudC0+c2V0QW5pbWF0ZWRPcGFjaXR5KGFwcGx5T3BhY2l0eUFuaW1hdGlvbigoc3RhdGlj X2Nhc3Q8Y29uc3QgRmxvYXRBbmltYXRpb25WYWx1ZSY+KGZyb20pLnZhbHVlKCkpLCAoc3RhdGlj X2Nhc3Q8Y29uc3QgRmxvYXRBbmltYXRpb25WYWx1ZSY+KHRvKS52YWx1ZSgpKSwgcHJvZ3Jlc3Mp KTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9U ZXh0dXJlTWFwcGVyR0wuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4 bWFwL1RleHR1cmVNYXBwZXJHTC5jcHAKaW5kZXggMjRkZWQxZS4uMjY4MmY0MCAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJH TC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1 cmVNYXBwZXJHTC5jcHAKQEAgLTU0Nyw2ICs1NDcsOSBAQCB2b2lkIFRleHR1cmVNYXBwZXJHTDo6 ZHJhd1RleHR1cmUoUGxhdGZvcm0zRE9iamVjdCB0ZXh0dXJlLCBGbGFncyBmbGFncywgY29uc3Qg SQogICAgICAgICBmbGFncyB8PSBTaG91bGRBbnRpYWxpYXM7CiAgICAgfQogCisgICAgRmxvYXRR dWFkIHRhcmdldFF1YWQgPSBtb2RlbFZpZXdNYXRyaXgubWFwUXVhZCh0YXJnZXRSZWN0KTsKKyAg ICBwcmludGYoInRyYW5zZm9ybWVkOiAoJWxmLCVsZikgLSAoJWxmLCVsZikgJWxmeCVsZlxuIiwg dGFyZ2V0UXVhZC5wMSgpLngoKSwgdGFyZ2V0UXVhZC5wMSgpLnkoKSwgdGFyZ2V0UXVhZC5wMygp LngoKSwgdGFyZ2V0UXVhZC5wMygpLnkoKSwgKHRhcmdldFF1YWQucDIoKSAtIHRhcmdldFF1YWQu cDEoKSkuZGlhZ29uYWxMZW5ndGgoKSwgKHRhcmdldFF1YWQucDMoKSAtIHRhcmdldFF1YWQucDIo KSkuZGlhZ29uYWxMZW5ndGgoKSk7CisKICNpZiBFTkFCTEUoQ1NTX0ZJTFRFUlMpCiAgICAgUmVm UHRyPEZpbHRlck9wZXJhdGlvbj4gZmlsdGVyID0gZGF0YSgpLmZpbHRlckluZm8gPyBkYXRhKCku ZmlsdGVySW5mby0+ZmlsdGVyOiAwOwogICAgIEdDM0R1aW50IGZpbHRlckNvbnRlbnRUZXh0dXJl SUQgPSAwOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94 eS5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAppbmRleCAw ZTU2MGFiLi44MjdiY2M5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2Vi UGFnZVByb3h5LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5 LmNwcApAQCAtMTk0Nyw2ICsxOTQ3LDggQEAgdm9pZCBXZWJQYWdlUHJveHk6OnNldFBhZ2Vab29t RmFjdG9yKGRvdWJsZSB6b29tRmFjdG9yKQogCiAgICAgaWYgKG1fcGFnZVpvb21GYWN0b3IgPT0g em9vbUZhY3RvcikKICAgICAgICAgcmV0dXJuOworICAgIAorICAgIHpvb21GYWN0b3IgPSAwLjU7 CiAKICAgICBtX3BhZ2Vab29tRmFjdG9yID0gem9vbUZhY3RvcjsKICAgICBtX3Byb2Nlc3MtPnNl bmQoTWVzc2FnZXM6OldlYlBhZ2U6OlNldFBhZ2Vab29tRmFjdG9yKG1fcGFnZVpvb21GYWN0b3Ip LCBtX3BhZ2VJRCk7IAo= 236448 2014-08-12 09:02:10 -0700 2014-08-12 09:02:10 -0700 BitmapTexture with contents incorrectly offset BitmapTexture-bottom-edge-piece.png image/png 287 s.stjames iVBORw0KGgoAAAANSUhEUgAAAA8AAAAjCAAAAABu0w/bAAAABGdBTUEAALGPC/xhBQAAAAFzUkdC AK7OHOkAAAAgY0hSTQAAeiYAAICEAAD6AAAAgOgAAHUwAADqYAAAOpgAABdwnLpRPAAAAAJiS0dE AP+Hj8y/AAAACXBIWXMAAABIAAAASABGyWs+AAAAGElEQVQoz2NgGG7gPwogzDdDAQPt+sEOAPNj LMv8/hP0AAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDE0LTA4LTEyVDE1OjI4OjE5KzAxOjAwBWq2EgAA ACV0RVh0ZGF0ZTptb2RpZnkAMjAxNC0wOC0xMlQxNToyODoxOSswMTowMHQ3Dq4AAAAASUVORK5C YII=