135832 2014-08-12 00:43:19 -0700 [CMAKE] WebProcess shouldn't need to explicitly link to JavaScriptCore and WebCore 2014-08-12 23:44:59 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned bunhere cdumez commit-queue gyuyoung.kim pnormand rakuco ryuan.choi sergio oldest_to_newest 1028444 0 cgarcia 2014-08-12 00:43:19 -0700 Linking to WebKit2 should be enough, like Network and Plugin processes. 1028446 1 236430 cgarcia 2014-08-12 00:45:49 -0700 Created attachment 236430 Patch Gyuyoung, could you please confirm this patch doesn't break the EFL build with shared WebCore? 1028669 2 ryuan.choi 2014-08-12 16:50:45 -0700 I don't remember why it was required long time ago. But I can confirm that EFL port looks fine now with this patch whatever SHARED_CORE is ON/OFF. 1028722 3 gyuyoung.kim 2014-08-12 22:38:11 -0700 (In reply to comment #1) > Created an attachment (id=236430) [details] > Patch > > Gyuyoung, could you please confirm this patch doesn't break the EFL build with shared WebCore? When I test this patch locally, there is no build break. Besides I let efl-ews to build with SHARED_CORE=ON yesterday. Additionally I'm taking a look how to run layout test on EFL port regardless of SHARED_CORE. 1028723 4 gyuyoung.kim 2014-08-12 22:42:44 -0700 (In reply to comment #2) > I don't remember why it was required long time ago. IIRC, initial EFL WK1 DumpRenderTree was implemented only with SHARED_CORE=ON because SAHRED_CORE reduces linking time on debug build. It looks nobody checked EFL layout test failed on release build at that time. IMO, that's why EFL port should enable SHARED_CORE to run layout test. However, it looks EFL WK2 doesn't need to enable it if we set something environment variables. Let me post when I solve this issue. 1028736 5 cgarcia 2014-08-12 23:44:59 -0700 Committed r172516: <http://trac.webkit.org/changeset/172516> 236430 2014-08-12 00:45:49 -0700 2014-08-12 22:38:31 -0700 Patch wk2-web-process-link.diff text/plain 950 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktp dDIvQ01ha2VMaXN0cy50eHQKaW5kZXggMGU2Y2FkOS4uZDA1OGViMSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0 cy50eHQKQEAgLTY1Myw4ICs2NTMsNiBAQCBzZXQoV2ViS2l0Ml9NRVNTQUdFU19JTl9GSUxFUwog KQogCiBzZXQoV2ViUHJvY2Vzc19MSUJSQVJJRVMKLSAgICBKYXZhU2NyaXB0Q29yZQotICAgIFdl YkNvcmUKICAgICBXZWJLaXQyCiApCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAyZGFlNGE1Li4wODRlM2ZmIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDgtMTIgIENhcmxvcyBHYXJjaWEgQ2Ft cG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDTUFLRV0gV2ViUHJvY2VzcyBz aG91bGRuJ3QgbmVlZCB0byBleHBsaWNpdGx5IGxpbmsgdG8gSmF2YVNjcmlwdENvcmUgYW5kIFdl YkNvcmUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz NTgzMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExp bmtpbmcgdG8gV2ViS2l0MiBzaG91bGQgYmUgZW5vdWdoLCBsaWtlIE5ldHdvcmsgYW5kIFBsdWdp biBwcm9jZXNzZXMuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDoKKwogMjAxNC0wOC0xMSAg RW5yaWNhIENhc3VjY2kgIDxlbnJpY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEltcHJvdmUgbG9v ayBhbmQgZmVlbCBvZiBjb21iaW5lZCBzZXJ2aWNlIG1lbnUuLgo=