135828 2014-08-11 19:28:26 -0700 Web Inspector: GoToLine dialog clear text button looks poor 2014-08-12 01:16:45 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1028399 0 joepeck 2014-08-11 19:28:26 -0700 * SUMMARY Go to Line clear text button looks poor. * STEPS TO REPRODUCE 1. Inspect apple.com 2. Select a javascript resource 3. Select the ContentView 4. Show Go To Line dialog with ⌃G 5. Type some text => (X) clear text button looks bad * NOTES The button is off center, and too thin. Compare to Xcode for example. 1028400 1 236425 joepeck 2014-08-11 19:30:53 -0700 Created attachment 236425 [PATCH] Proposed Fix 1028443 2 webkit-bug-importer 2014-08-12 00:41:32 -0700 <rdar://problem/17987726> 1028456 3 236425 commit-queue 2014-08-12 01:16:43 -0700 Comment on attachment 236425 [PATCH] Proposed Fix Clearing flags on attachment: 236425 Committed r172436: <http://trac.webkit.org/changeset/172436> 1028457 4 commit-queue 2014-08-12 01:16:45 -0700 All reviewed patches have been landed. Closing bug. 236425 2014-08-11 19:30:53 -0700 2014-08-12 01:16:43 -0700 [PATCH] Proposed Fix white.patch text/plain 2567 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDVhMzllN2YuLjNmYTRiZjUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE0LTA4LTExICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogR29Ub0xp bmUgZGlhbG9nIGNsZWFyIHRleHQgYnV0dG9uIGxvb2tzIHBvb3IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTgyOAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExlZ2FjeS9DbG9zZVdoaXRlLnN2ZyB3YXMg bm90IHVzZWQsIGJ1dCBpbiB0aGUgY2FzZSB3aGVyZSB0aGUgd2hpdGUKKyAgICAgICAgY2xvc2Ug YnV0dG9uIGlzIG5lZWRlZCB0aGUgdGhpY2tlciBiYXJzIGxvb2tzIGJldHRlci4gUmUtdXNlIHRo ZQorICAgICAgICBMZWdhY3kgaW1hZ2UgYXMgdGhlIGRlZmF1bHQgQ2xvc2VXaGl0ZS5zdmcuCisK KyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0ltYWdlcy9DbG9zZVdoaXRlLnN2ZzoKKyAgICAgICAg KiBVc2VySW50ZXJmYWNlL0ltYWdlcy9MZWdhY3kvQ2xvc2VXaGl0ZS5zdmc6IFJlbW92ZWQuCisK KzIwMTQtMDgtMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBFYXNpZXIgV2F5IHRvIGdvIGJhY2sgdG8gdGhlIFRpbWVsaW5l IE92ZXJ2aWV3cwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM1ODI3CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL0ltYWdlcy9DbG9zZVdoaXRlLnN2ZyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL0ltYWdlcy9DbG9zZVdoaXRlLnN2ZwppbmRleCA2ODkyNzViLi5kZDBiNWI5IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9JbWFnZXMvQ2xvc2VX aGl0ZS5zdmcKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvSW1hZ2Vz L0Nsb3NlV2hpdGUuc3ZnCkBAIC0xLDUgKzEsNSBAQAogPD94bWwgdmVyc2lvbj0iMS4wIiBlbmNv ZGluZz0idXRmLTgiPz4KLTwhLS0gQ29weXJpZ2h0IMKpIDIwMTQgQXBwbGUgSW5jLiBBbGwgcmln aHRzIHJlc2VydmVkLiAtLT4KKzwhLS0gQ29weXJpZ2h0IMKpIDIwMTMgQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLiAtLT4KIDxzdmcgdmVyc2lvbj0iMS4xIiB4bWxucz0iaHR0cDovL3d3 dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAxNiAxNCI+Ci0gICAgPHBhdGggZmlsbD0i bm9uZSIgc3Ryb2tlPSJ3aGl0ZSIgc3Ryb2tlLWxpbmVjYXA9InNxdWFyZSIgZD0iTSAzLjUgNC41 IEwgMTAuNSAxMS41IE0gMy41IDExLjUgTCAxMC41IDQuNSIvPgorICAgIDxwYXRoIGZpbGw9Indo aXRlIiBkPSJNIDEyLjk0OTIxOSAxMC41MzUxNTYgTCAxMS41MzUxNTYgMTEuOTQ5MjE5IEwgOCA4 LjQxNDA2MiBMIDQuNDY0ODQ0IDExLjk0OTIxOSBMIDMuMDUwNzgxIDEwLjUzNTE1NiBMIDYuNTg1 OTM4IDcgTCAzLjA1MDc4MSAzLjQ2NDg0NCBMIDQuNDY0ODQ0IDIuMDUwNzgxIEwgOCA1LjU4NTkz OCBMIDExLjUzNTE1NiAyLjA1MDc4MSBMIDEyLjk0OTIxOSAzLjQ2NDg0NCBMIDkuNDE0MDYyIDcg WiIvPgogPC9zdmc+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9JbWFnZXMvTGVnYWN5L0Nsb3NlV2hpdGUuc3ZnIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvSW1hZ2VzL0xlZ2FjeS9DbG9zZVdoaXRlLnN2ZwpkZWxldGVkIGZpbGUg bW9kZSAxMDA2NDQKaW5kZXggZGQwYjViOS4uMDAwMDAwMAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9JbWFnZXMvTGVnYWN5L0Nsb3NlV2hpdGUuc3ZnCisrKyAvZGV2 L251bGwKQEAgLTEsNSArMCwwIEBACi08P3htbCB2ZXJzaW9uPSIxLjAiIGVuY29kaW5nPSJ1dGYt OCI/PgotPCEtLSBDb3B5cmlnaHQgwqkgMjAxMyBBcHBsZSBJbmMuIEFsbCByaWdodHMgcmVzZXJ2 ZWQuIC0tPgotPHN2ZyB2ZXJzaW9uPSIxLjEiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAw L3N2ZyIgdmlld0JveD0iMCAwIDE2IDE0Ij4KLSAgICA8cGF0aCBmaWxsPSJ3aGl0ZSIgZD0iTSAx Mi45NDkyMTkgMTAuNTM1MTU2IEwgMTEuNTM1MTU2IDExLjk0OTIxOSBMIDggOC40MTQwNjIgTCA0 LjQ2NDg0NCAxMS45NDkyMTkgTCAzLjA1MDc4MSAxMC41MzUxNTYgTCA2LjU4NTkzOCA3IEwgMy4w NTA3ODEgMy40NjQ4NDQgTCA0LjQ2NDg0NCAyLjA1MDc4MSBMIDggNS41ODU5MzggTCAxMS41MzUx NTYgMi4wNTA3ODEgTCAxMi45NDkyMTkgMy40NjQ4NDQgTCA5LjQxNDA2MiA3IFoiLz4KLTwvc3Zn Pgo=