135807 2014-08-11 10:59:42 -0700 generate header detection files on Windows CMake 2014-08-12 15:44:00 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 achristensen achristensen benjamin bfulgham bunhere cmarcelo commit-queue gyuyoung.kim laszlo.gombos rakuco sergio oldest_to_newest 1028230 0 achristensen 2014-08-11 10:59:42 -0700 The Windows build requires WTF/WTFHeaderDetection.h and WebCore/WebCoreHeaderDetection.h, which are generated by testing for the existence of Apple internal stuff. I've implemented the stubs of these headers to get them to compile without detecting the internal stuff, which will need to be done later. 1028231 1 236383 achristensen 2014-08-11 11:03:08 -0700 Created attachment 236383 Patch 1028607 2 236383 bfulgham 2014-08-12 14:32:37 -0700 Comment on attachment 236383 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236383&action=review r=me. Please change those bugs to be "FIXME(Bug ###)" format, with bugs filed to extend the CMake stuff to do what we need for internal use. > Source/WTF/wtf/PlatformWin.cmake:22 > +#FIXME: This should run testOSXLevel.cmd if it is available. Please file a bug and make this a #FIXME(Bug##) bug. > Source/WebCore/PlatformWin.cmake:93 > +#FIXME: This should test if AVF headers are available. Ditto above comment. 1028637 3 achristensen 2014-08-12 15:44:00 -0700 Added comments and committed to http://trac.webkit.org/changeset/172499 236383 2014-08-11 11:03:08 -0700 2014-08-12 14:32:36 -0700 Patch bug-135807-20140811110257.patch text/plain 4851 achristensen SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyMzk0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBA CisyMDE0LTA4LTExICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+ CisKKyAgICAgICAgR2VuZXJhdGUgaGVhZGVyIGRldGVjdGlvbiBoZWFkZXJzIGZvciBDTWFrZSBv biBXaW5kb3dzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MTM1ODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgSW5jbHVkZSB0aGUgZGVyaXZlZCBzb3VyY2Vz IGRpcmVjdG9yeSB0byBmaW5kIFdURi9XVEZIZWFkZXJEZXRlY3Rpb24uaC4KKwogMjAxNC0wOC0x MCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIERlc3RydWN0dXJp bmcgYXNzaWdubWVudCBpbiBhIHZhciBkZWNsYXJhdGlvbiBsaXN0IGluY29ycmVjdGx5IGNvbnN1 bWVzIHN1YnNlcXVlbnQgdmFyaWFibGUgaW5pdGlhbGlzZXJzCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL0NNYWtlTGlzdHMudHh0CShyZXZpc2lvbiAxNzIzOTQpCisrKyBTb3VyY2UvSmF2YVNjcmlw dENvcmUvQ01ha2VMaXN0cy50eHQJKHdvcmtpbmcgY29weSkKQEAgLTI3LDYgKzI3LDcgQEAgc2V0 KEphdmFTY3JpcHRDb3JlX0lOQ0xVREVfRElSRUNUT1JJRVMKICAgICAiJHtKQVZBU0NSSVBUQ09S RV9ESVJ9L3Rvb2xzIgogICAgICIke0pBVkFTQ1JJUFRDT1JFX0RJUn0veWFyciIKICAgICAiJHtX VEZfRElSfSIKKyAgICAiJHtERVJJVkVEX1NPVVJDRVNfRElSfSIKICAgICAiJHtERVJJVkVEX1NP VVJDRVNfRElSfS9Gb3J3YXJkaW5nSGVhZGVycyIKICAgICAiJHtERVJJVkVEX1NPVVJDRVNfSkFW QVNDUklQVENPUkVfRElSfSIKICAgICAiJHtERVJJVkVEX1NPVVJDRVNfSkFWQVNDUklQVENPUkVf RElSfS9pbnNwZWN0b3IiCkluZGV4OiBTb3VyY2UvV1RGL0NoYW5nZUxvZwo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvV1RGL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyMzk0KQorKysgU291cmNlL1dURi9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxNC0wOC0xMSAgQWxl eCBDaHJpc3RlbnNlbiAgPGFjaHJpc3RlbnNlbkB3ZWJraXQub3JnPgorCisgICAgICAgIEdlbmVy YXRlIGhlYWRlciBkZXRlY3Rpb24gaGVhZGVycyBmb3IgQ01ha2Ugb24gV2luZG93cy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTgwNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL0NNYWtlTGlz dHMudHh0OgorICAgICAgICAqIHd0Zi9QbGF0Zm9ybVdpbi5jbWFrZToKKyAgICAgICAgR2VuZXJh dGUgYW5kIGluY2x1ZGUgYSBzdHViIFdURkhlYWRlckRldGVjdGlvbi5oLgorCiAyMDE0LTA4LTEw ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBVcGRh dGUgSGFzaFRhYmxlJ3Mgb3BlcmF0b3I9IGFmdGVyIHIxNzIxNjcgcGVyIHJldmlldyBjb21tZW50 cwpJbmRleDogU291cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dURi93dGYvQ01ha2VMaXN0cy50eHQJKHJldmlzaW9uIDE3MjM5NCkKKysrIFNvdXJjZS9X VEYvd3RmL0NNYWtlTGlzdHMudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0yMTgsNiArMjE4LDcgQEAg c2V0KFdURl9JTkNMVURFX0RJUkVDVE9SSUVTCiAgICAgIiR7V1RGX0RJUn0vd3RmL3VuaWNvZGUi CiAgICAgIiR7VEhJUkRQQVJUWV9ESVJ9IgogICAgICIke0NNQUtFX0JJTkFSWV9ESVJ9IgorICAg ICIke0RFUklWRURfU09VUkNFU19ESVJ9IgogKQogCiBzZXQoV1RGX0xJQlJBUklFUwpJbmRleDog U291cmNlL1dURi93dGYvUGxhdGZvcm1XaW4uY21ha2UKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dU Ri93dGYvUGxhdGZvcm1XaW4uY21ha2UJKHJldmlzaW9uIDE3MjM5NCkKKysrIFNvdXJjZS9XVEYv d3RmL1BsYXRmb3JtV2luLmNtYWtlCSh3b3JraW5nIGNvcHkpCkBAIC0xNCwzICsxNCwxNCBAQCBl bHNlICgpCiAgICAgICAgIHdpbm1tCiAgICAgKQogZW5kaWYgKCkKKworbGlzdChBUFBFTkQgV1RG X0hFQURFUlMKKyAgICAiJHtERVJJVkVEX1NPVVJDRVNfV1RGX0RJUn0vV1RGSGVhZGVyRGV0ZWN0 aW9uLmgiCispCisKKyNGSVhNRTogVGhpcyBzaG91bGQgcnVuIHRlc3RPU1hMZXZlbC5jbWQgaWYg aXQgaXMgYXZhaWxhYmxlLgorYWRkX2N1c3RvbV9jb21tYW5kKAorICAgIE9VVFBVVCAiJHtERVJJ VkVEX1NPVVJDRVNfV1RGX0RJUn0vV1RGSGVhZGVyRGV0ZWN0aW9uLmgiCisgICAgV09SS0lOR19E SVJFQ1RPUlkgIiR7REVSSVZFRF9TT1VSQ0VTX1dURl9ESVJ9IgorICAgIENPTU1BTkQgZWNobyAv KiBObyBMZWdpYmxlIE91dHB1dCBTdXBwb3J0IEZvdW5kICovID4gV1RGSGVhZGVyRGV0ZWN0aW9u LmgKKyAgICBWRVJCQVRJTSkKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjM5NCkKKysrIFNv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisy MDE0LTA4LTExICBBbGV4IENocmlzdGVuc2VuICA8YWNocmlzdGVuc2VuQHdlYmtpdC5vcmc+CisK KyAgICAgICAgR2VuZXJhdGUgaGVhZGVyIGRldGVjdGlvbiBoZWFkZXJzIGZvciBDTWFrZSBvbiBX aW5kb3dzLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM1ODA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBDTWFrZUxpc3RzLnR4dDoKKyAgICAgICAgKiBQbGF0Zm9ybVdpbi5jbWFrZToKKyAgICAgICAg R2VuZXJhdGUgYW5kIGluY2x1ZGUgYSBzdHViIFdlYkNvcmVIZWFkZXJEZXRlY3Rpb24uaC4KKwog MjAxNC0wOC0xMSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVlQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE3MjM5My4KSW5kZXg6IFNvdXJjZS9XZWJD b3JlL0NNYWtlTGlzdHMudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL0NNYWtlTGlz dHMudHh0CShyZXZpc2lvbiAxNzIzOTQpCisrKyBTb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4 dAkod29ya2luZyBjb3B5KQpAQCAtMTIxLDYgKzEyMSw3IEBAIHNldChXZWJDb3JlX0lOQ0xVREVf RElSRUNUT1JJRVMKICAgICAiJHtKQVZBU0NSSVBUQ09SRV9ESVJ9L3J1bnRpbWUiCiAgICAgIiR7 SkFWQVNDUklQVENPUkVfRElSfS95YXJyIgogICAgICIke1dURl9ESVJ9IgorICAgICIke0RFUklW RURfU09VUkNFU19ESVJ9IgogICAgICIke0RFUklWRURfU09VUkNFU19ESVJ9L0ZvcndhcmRpbmdI ZWFkZXJzIgogICAgICIke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9IgogICAg ICIke0RFUklWRURfU09VUkNFU19KQVZBU0NSSVBUQ09SRV9ESVJ9L2luc3BlY3RvciIKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL1BsYXRmb3JtV2luLmNtYWtlCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJDb3JlL1BsYXRmb3JtV2luLmNtYWtlCShyZXZpc2lvbiAxNzIzOTQpCisrKyBTb3VyY2UvV2Vi Q29yZS9QbGF0Zm9ybVdpbi5jbWFrZQkod29ya2luZyBjb3B5KQpAQCAtODUsMyArODUsMTQgQEAg ZWxzZSAoKQogICAgICAgICBwbHVnaW5zL1BsdWdpblZpZXdOb25lLmNwcAogICAgICkKIGVuZGlm ICgpCisKK2xpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUworICAgICIke0RFUklWRURfU09VUkNF U19XRUJDT1JFX0RJUn0vV2ViQ29yZUhlYWRlckRldGVjdGlvbi5oIgorKQorCisjRklYTUU6IFRo aXMgc2hvdWxkIHRlc3QgaWYgQVZGIGhlYWRlcnMgYXJlIGF2YWlsYWJsZS4KK2FkZF9jdXN0b21f Y29tbWFuZCgKKyAgICBPVVRQVVQgIiR7REVSSVZFRF9TT1VSQ0VTX1dFQkNPUkVfRElSfS9XZWJD b3JlSGVhZGVyRGV0ZWN0aW9uLmgiCisgICAgV09SS0lOR19ESVJFQ1RPUlkgIiR7REVSSVZFRF9T T1VSQ0VTX1dFQkNPUkVfRElSfSIKKyAgICBDT01NQU5EIGVjaG8gLyogSWRlbnRpZnlpbmcgQVZG b3VuZGF0aW9uIFN1cHBvcnQgKi8gPiBXZWJDb3JlSGVhZGVyRGV0ZWN0aW9uLmgKKyAgICBWRVJC QVRJTSkK