135798 2014-08-11 06:06:56 -0700 [GTK] Subtle-crypto feature off by default and add a new configure flag to enable it 2014-08-12 02:35:57 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 elima webkit-unassigned berto bunhere cgarcia commit-queue dbates gyuyoung.kim mrobinson pnormand rakuco sergio oldest_to_newest 1028173 0 elima 2014-08-11 06:06:56 -0700 Now that patches for subtle crypto from bug 133122 are starting to land, it has been recommended to turn OFF the feature by default while the implementations for the different crypto algorithms are not there. Currently, the feature is ON by default and there are stubs for all algorithm implementations. But we still want the build and tests bots to pick up this feature, so we need to add a new configure flag to enable it on specific builds. 1028174 1 236365 elima 2014-08-11 06:16:13 -0700 Created attachment 236365 Patch 1028175 2 236365 pnormand 2014-08-11 06:32:51 -0700 Comment on attachment 236365 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236365&action=review > Tools/Scripts/webkitperl/FeatureList.pm:380 > + define => "ENABLE_SUBTLE_CRYPTO", default => 0, value => \$subtleCrypto }, Having a default value of 0 here will disable the feature unless --enable-subtle-crypto is explicitely passed. So I think you need to have isGtk() at least. Is the feature enabled on Mac as well? If so the value would need to be (isGtk() || isMac()) 1028182 3 elima 2014-08-11 07:28:28 -0700 Philippe, good catch! Indeed, at least the Mac port has it on and also iOS (per Source/WebCore/Configurations/FeatureDefines.xcconfig). I think the default value is: default => isAppleMacWebkit() || isIOSWebKit() but it would be nice to have confirmation from someone more familiar with these ports. Neither EFL nor Window seem to implement the feature. 1028229 4 236382 elima 2014-08-11 10:56:25 -0700 Created attachment 236382 Patch 1028432 5 236382 pnormand 2014-08-11 23:10:33 -0700 Comment on attachment 236382 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236382&action=review > Tools/Scripts/webkitperl/FeatureList.pm:380 > + define => "ENABLE_SUBTLE_CRYPTO", default => isAppleMacWebKit() || isIOSWebKit(), value => \$subtleCrypto }, I still don't understand why isGtk() is not there. Or you plan to enable it later? 1028438 6 elima 2014-08-11 23:52:53 -0700 "default" is the default value for the flag. If the flag is not explicitly set in the command line of your build-webkit call (either --subtle-crypto or --no-subtle-crypto), that's the assumed value. Now, we want the GTK port to have it off by default, hence isGtk() is not there. And to activate it one must explicitly add --subtle-crypto, and then is enabled. 1028464 7 elima 2014-08-12 01:43:04 -0700 Ok, I understood things wrongly. You meant having the flag on by default for GTK builds using build-webkit. Release builds don't use that so it is safe. The result is the same as I originally intended: The feature is available only to developers and build/test bots, but not present in releases. Submitting new patch adding isGtk() :). Sorry for the noise. 1028465 8 236432 elima 2014-08-12 01:45:16 -0700 Created attachment 236432 Patch 1028466 9 236432 pnormand 2014-08-12 01:49:12 -0700 Comment on attachment 236432 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236432&action=review > Tools/Scripts/webkitperl/FeatureList.pm:380 > + define => "ENABLE_SUBTLE_CRYPTO", default => isGtk() || isAppleMacWebKit() || isIOSWebKit(), value => \$subtleCrypto }, Sorry I should have mentioned that earlier, other options enclose the default value between parenthesis, check the video option for instance. No idea if it's really needed but would be good to have it for consistency at least. 1028468 10 236433 elima 2014-08-12 01:52:55 -0700 Created attachment 236433 Patch 1028472 11 236433 commit-queue 2014-08-12 02:35:52 -0700 Comment on attachment 236433 Patch Clearing flags on attachment: 236433 Committed r172439: <http://trac.webkit.org/changeset/172439> 1028473 12 commit-queue 2014-08-12 02:35:57 -0700 All reviewed patches have been landed. Closing bug. 236365 2014-08-11 06:16:13 -0700 2014-08-11 10:56:15 -0700 Patch bug-135798-20140811151602.patch text/plain 3139 elima U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDIyNTZm YjEwYmQ2NTkzMmYxYzMwZmUyZTg2OTE4ODAyNjEwZTU0MmYuLmQ3ZGU2M2FjNzYyZjUzNjVmNDcx OWNkMzgxYTFkN2UxM2ZlNzUxNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzgsNyArMTM4 LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NFQ0NPTVBfRklM VEVSUyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0hBUkVE X1dPUktFUlMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU1BF TExDSEVDSyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJQ SVhFTF9MQVlPVVQgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf U1VCVExFX0NSWVBUTyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9TVUJUTEVfQ1JZUFRPIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9URU1QTEFURV9FTEVNRU5UIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFM VUUoRU5BQkxFX1RPVUNIX0VWRU5UUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9VU0VSU0VMRUNUX0FMTCBPTikKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlY2M4NGYyYzQ1OTA1NDY0YTVkNDRiMmI1MjJkODI3 NjZiMDY3MTg3Li44ZjM1ODg0YWE1ODg3MDcxZDcyZjkxNzE4MmE2YWZhNGU1YzgwMjc3IDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMTQtMDgtMTEgIEVkdWFyZG8gTGltYSBNaXRldiAgPGVsaW1hQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gU3VidGxlLWNyeXB0byBmZWF0dXJlIG9mZiBieSBkZWZhdWx0IGFu ZCBhZGQgYSBuZXcgY29uZmlndXJlIGZsYWcgdG8gZW5hYmxlIGl0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3OTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cGVybC9GZWF0 dXJlTGlzdC5wbTogQWRkcyBuZXcgZmxhZyAtLXN1YnRsZS1jcnlwdG8gdG8KKyAgICAgICAgICAg IHRvZ2dsZSBTVUJUTEVfQ1JZUFRPIGZlYXR1cmUuCisKIDIwMTQtMDgtMTEgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZp eCBHVEsrIG1ha2UgZGlzdGNoZWNrLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw ZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0 LnBtCmluZGV4IGI5YTcxNTg3ZmQ5YzRhYjc5MWYwMzM3YmI0YjYwZTczMTRkMjMyZDkuLjZlY2Y1 NDM1YTM2OWYxYjBhNWUzMjljOTYxMDMxMWEyNzMyMTllMzAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTEyMiw2ICsxMjIsNyBAQCBteSAoCiAgICAgJHNoYXJl ZFdvcmtlcnNTdXBwb3J0LAogICAgICRzcWxEYXRhYmFzZVN1cHBvcnQsCiAgICAgJHN0eWxlU2Nv cGVkU3VwcG9ydCwKKyAgICAkc3VidGxlQ3J5cHRvLAogICAgICRzdWlkTGludXhTYW5kYm94LAog ICAgICRzdmdET01PYmpDQmluZGluZ3NTdXBwb3J0LAogICAgICRzdmdGb250c1N1cHBvcnQsCkBA IC0zNzUsNiArMzc2LDkgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgIHsgb3B0aW9uID0+ICJzcWwt ZGF0YWJhc2UiLCBkZXNjID0+ICJUb2dnbGUgU1FMIERhdGFiYXNlIHN1cHBvcnQiLAogICAgICAg ZGVmaW5lID0+ICJFTkFCTEVfU1FMX0RBVEFCQVNFIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBc JHNxbERhdGFiYXNlU3VwcG9ydCB9LAogCisgICAgeyBvcHRpb24gPT4gInN1YnRsZS1jcnlwdG8i LCBkZXNjID0+ICJUb2dnbGUgV2ViQ3J5cHRvIFN1YnRsZS1DcnlwdG8gc3VwcG9ydCIsCisgICAg ICBkZWZpbmUgPT4gIkVOQUJMRV9TVUJUTEVfQ1JZUFRPIiwgZGVmYXVsdCA9PiAwLCB2YWx1ZSA9 PiBcJHN1YnRsZUNyeXB0byB9LAorCiAgICAgeyBvcHRpb24gPT4gInN1aWQtbGludXgtc2FuZGJv eCIsIGRlc2MgPT4gIlRvZ2dsZSBzdWlkIHNhbmRib3ggZm9yIGxpbnV4IiwKICAgICAgIGRlZmlu ZSA9PiAiRU5BQkxFX1NVSURfU0FOREJPWF9MSU5VWCIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4g XCRzdWlkTGludXhTYW5kYm94IH0sCiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxv ZwppbmRleCBmODFhYzc5ODA2ZWFiYzg4ZjdjOGU2YjE1YjdiZGU0MjA3MDc3NWQ0Li4zZjdjOWMy YTY5ZjdmZDQ1MTg5YTA3ODEzZDg5YTIzOWE4NGVjNjc1IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDgtMTEgIEVkdWFyZG8gTGlt YSBNaXRldiAgPGVsaW1hQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10gU3VidGxlLWNyeXB0 byBmZWF0dXJlIG9mZiBieSBkZWZhdWx0IGFuZCBhZGQgYSBuZXcgY29uZmlndXJlIGZsYWcgdG8g ZW5hYmxlIGl0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzU3OTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlOiBNYWtlcyBTVUJUTEVfQ1JZUFRPIGZs YWcgb2ZmIGJ5IGRlZmF1bHQuCisKIDIwMTQtMDgtMTEgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1x dWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIxNzIz OTMuCg== 236382 2014-08-11 10:56:25 -0700 2014-08-12 01:45:06 -0700 Patch bug-135798-20140811195613.patch text/plain 3173 elima U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMzk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDIyNTZm YjEwYmQ2NTkzMmYxYzMwZmUyZTg2OTE4ODAyNjEwZTU0MmYuLmQ3ZGU2M2FjNzYyZjUzNjVmNDcx OWNkMzgxYTFkN2UxM2ZlNzUxNjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzgsNyArMTM4 LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NFQ0NPTVBfRklM VEVSUyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0hBUkVE X1dPUktFUlMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU1BF TExDSEVDSyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJQ SVhFTF9MQVlPVVQgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf U1VCVExFX0NSWVBUTyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9TVUJUTEVfQ1JZUFRPIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9URU1QTEFURV9FTEVNRU5UIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFM VUUoRU5BQkxFX1RPVUNIX0VWRU5UUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9VU0VSU0VMRUNUX0FMTCBPTikKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBlY2M4NGYyYzQ1OTA1NDY0YTVkNDRiMmI1MjJkODI3 NjZiMDY3MTg3Li44ZjM1ODg0YWE1ODg3MDcxZDcyZjkxNzE4MmE2YWZhNGU1YzgwMjc3IDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMTQtMDgtMTEgIEVkdWFyZG8gTGltYSBNaXRldiAgPGVsaW1hQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gU3VidGxlLWNyeXB0byBmZWF0dXJlIG9mZiBieSBkZWZhdWx0IGFu ZCBhZGQgYSBuZXcgY29uZmlndXJlIGZsYWcgdG8gZW5hYmxlIGl0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3OTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cGVybC9GZWF0 dXJlTGlzdC5wbTogQWRkcyBuZXcgZmxhZyAtLXN1YnRsZS1jcnlwdG8gdG8KKyAgICAgICAgICAg IHRvZ2dsZSBTVUJUTEVfQ1JZUFRPIGZlYXR1cmUuCisKIDIwMTQtMDgtMTEgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQuIEZp eCBHVEsrIG1ha2UgZGlzdGNoZWNrLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRw ZXJsL0ZlYXR1cmVMaXN0LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0 LnBtCmluZGV4IGI5YTcxNTg3ZmQ5YzRhYjc5MWYwMzM3YmI0YjYwZTczMTRkMjMyZDkuLjg3NDQ2 OWFhZTY2ZWI3NDIzNGEwNTU0ZjNiYzY2MTNhMWVhNDlhMDAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Nj cmlwdHMvd2Via2l0cGVybC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtp dHBlcmwvRmVhdHVyZUxpc3QucG0KQEAgLTEyMiw2ICsxMjIsNyBAQCBteSAoCiAgICAgJHNoYXJl ZFdvcmtlcnNTdXBwb3J0LAogICAgICRzcWxEYXRhYmFzZVN1cHBvcnQsCiAgICAgJHN0eWxlU2Nv cGVkU3VwcG9ydCwKKyAgICAkc3VidGxlQ3J5cHRvLAogICAgICRzdWlkTGludXhTYW5kYm94LAog ICAgICRzdmdET01PYmpDQmluZGluZ3NTdXBwb3J0LAogICAgICRzdmdGb250c1N1cHBvcnQsCkBA IC0zNzUsNiArMzc2LDkgQEAgbXkgQGZlYXR1cmVzID0gKAogICAgIHsgb3B0aW9uID0+ICJzcWwt ZGF0YWJhc2UiLCBkZXNjID0+ICJUb2dnbGUgU1FMIERhdGFiYXNlIHN1cHBvcnQiLAogICAgICAg ZGVmaW5lID0+ICJFTkFCTEVfU1FMX0RBVEFCQVNFIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBc JHNxbERhdGFiYXNlU3VwcG9ydCB9LAogCisgICAgeyBvcHRpb24gPT4gInN1YnRsZS1jcnlwdG8i LCBkZXNjID0+ICJUb2dnbGUgV2ViQ3J5cHRvIFN1YnRsZS1DcnlwdG8gc3VwcG9ydCIsCisgICAg ICBkZWZpbmUgPT4gIkVOQUJMRV9TVUJUTEVfQ1JZUFRPIiwgZGVmYXVsdCA9PiBpc0FwcGxlTWFj V2ViS2l0KCkgfHwgaXNJT1NXZWJLaXQoKSwgdmFsdWUgPT4gXCRzdWJ0bGVDcnlwdG8gfSwKKwog ICAgIHsgb3B0aW9uID0+ICJzdWlkLWxpbnV4LXNhbmRib3giLCBkZXNjID0+ICJUb2dnbGUgc3Vp ZCBzYW5kYm94IGZvciBsaW51eCIsCiAgICAgICBkZWZpbmUgPT4gIkVOQUJMRV9TVUlEX1NBTkRC T1hfTElOVVgiLCBkZWZhdWx0ID0+IDAsIHZhbHVlID0+IFwkc3VpZExpbnV4U2FuZGJveCB9LAog CmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VMb2cKaW5kZXggZjgxYWM3OTgwNmVhYmM4 OGY3YzhlNmIxNWI3YmRlNDIwNzA3NzVkNC4uM2Y3YzljMmE2OWY3ZmQ0NTE4OWEwNzgxM2Q4OWEy MzlhODRlYzY3NSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEyIEBACisyMDE0LTA4LTExICBFZHVhcmRvIExpbWEgTWl0ZXYgIDxlbGltYUBpZ2FsaWEu Y29tPgorCisgICAgICAgIFtHVEtdIFN1YnRsZS1jcnlwdG8gZmVhdHVyZSBvZmYgYnkgZGVmYXVs dCBhbmQgYWRkIGEgbmV3IGNvbmZpZ3VyZSBmbGFnIHRvIGVuYWJsZSBpdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1Nzk4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9u c0dUSy5jbWFrZTogTWFrZXMgU1VCVExFX0NSWVBUTyBmbGFnIG9mZiBieSBkZWZhdWx0LgorCiAy MDE0LTA4LTExICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Via2l0Lm9yZz4KIAogICAg ICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTcyMzkzLgo= 236432 2014-08-12 01:45:16 -0700 2014-08-12 01:52:45 -0700 Patch bug-135798-20140812104504.patch text/plain 3336 elima U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDM2ZTZm YjE5YTkwYmE0YTdhN2NhMzk2Y2U3NzFjMDQyYmI2MDlkMzguLjM1MmQ3MWMyYTQ4YzI2YjkwYmMy ZmJiOWU3OTg1ZWJiOGQ2YzY0YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzgsNyArMTM4 LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NFQ0NPTVBfRklM VEVSUyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0hBUkVE X1dPUktFUlMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU1BF TExDSEVDSyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJQ SVhFTF9MQVlPVVQgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf U1VCVExFX0NSWVBUTyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9TVUJUTEVfQ1JZUFRPIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9URU1QTEFURV9FTEVNRU5UIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFM VUUoRU5BQkxFX1RPVUNIX0VWRU5UUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9VU0VSU0VMRUNUX0FMTCBPTikKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkZTE3MzU2NzZmMGVkNDdjMDdiMDljOWZmNTI1NjY2 N2ExN2UxZDYyLi5lNjViMzFiNDdkNmZlMDgyMjAwY2IxNDRhY2M3NGMwMTRjY2I3ZjIxIDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMTQtMDgtMTIgIEVkdWFyZG8gTGltYSBNaXRldiAgPGVsaW1hQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gU3VidGxlLWNyeXB0byBmZWF0dXJlIG9mZiBieSBkZWZhdWx0IGFu ZCBhZGQgYSBuZXcgY29uZmlndXJlIGZsYWcgdG8gZW5hYmxlIGl0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3OTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cGVybC9GZWF0 dXJlTGlzdC5wbTogQWRkcyBuZXcgZmxhZyAtLXN1YnRsZS1jcnlwdG8gdG8KKyAgICAgICAgICAg IHRvZ2dsZSBTVUJUTEVfQ1JZUFRPIGZlYXR1cmUuCisKIDIwMTQtMDgtMTIgIFNoaXZha3VtYXIg Sk0gIDxzaGl2YS5qbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIE1pbmlicm93 c2VyOiBFbmhhbmNlIHRoZSBhcHBsaWNhdGlvbiB0byB1c2UgZG93bmxvYWQgZGlyZWN0b3J5IHNl bGVjdG9yLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0 LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4IGI5YTcx NTg3ZmQ5YzRhYjc5MWYwMzM3YmI0YjYwZTczMTRkMjMyZDkuLjk5NzIwMmYxMmYwMDNiYmRlMmQ1 OWRkYzgyNDYzYzVjN2U4Y2FhMzUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVy bC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxp c3QucG0KQEAgLTEyMiw2ICsxMjIsNyBAQCBteSAoCiAgICAgJHNoYXJlZFdvcmtlcnNTdXBwb3J0 LAogICAgICRzcWxEYXRhYmFzZVN1cHBvcnQsCiAgICAgJHN0eWxlU2NvcGVkU3VwcG9ydCwKKyAg ICAkc3VidGxlQ3J5cHRvLAogICAgICRzdWlkTGludXhTYW5kYm94LAogICAgICRzdmdET01PYmpD QmluZGluZ3NTdXBwb3J0LAogICAgICRzdmdGb250c1N1cHBvcnQsCkBAIC0zNzUsNiArMzc2LDkg QEAgbXkgQGZlYXR1cmVzID0gKAogICAgIHsgb3B0aW9uID0+ICJzcWwtZGF0YWJhc2UiLCBkZXNj ID0+ICJUb2dnbGUgU1FMIERhdGFiYXNlIHN1cHBvcnQiLAogICAgICAgZGVmaW5lID0+ICJFTkFC TEVfU1FMX0RBVEFCQVNFIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJHNxbERhdGFiYXNlU3Vw cG9ydCB9LAogCisgICAgeyBvcHRpb24gPT4gInN1YnRsZS1jcnlwdG8iLCBkZXNjID0+ICJUb2dn bGUgV2ViQ3J5cHRvIFN1YnRsZS1DcnlwdG8gc3VwcG9ydCIsCisgICAgICBkZWZpbmUgPT4gIkVO QUJMRV9TVUJUTEVfQ1JZUFRPIiwgZGVmYXVsdCA9PiBpc0d0aygpIHx8IGlzQXBwbGVNYWNXZWJL aXQoKSB8fCBpc0lPU1dlYktpdCgpLCB2YWx1ZSA9PiBcJHN1YnRsZUNyeXB0byB9LAorCiAgICAg eyBvcHRpb24gPT4gInN1aWQtbGludXgtc2FuZGJveCIsIGRlc2MgPT4gIlRvZ2dsZSBzdWlkIHNh bmRib3ggZm9yIGxpbnV4IiwKICAgICAgIGRlZmluZSA9PiAiRU5BQkxFX1NVSURfU0FOREJPWF9M SU5VWCIsIGRlZmF1bHQgPT4gMCwgdmFsdWUgPT4gXCRzdWlkTGludXhTYW5kYm94IH0sCiAKZGlm ZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBiMGZjNzhjZGQ0ZjJiNjkzMmE3 NmU5ZjZkNTQzYTIxNDQ2Yjg5MzFlLi44ZDJjODhlYjc2ZThkZjk2MjVjOGY5ZWQ1ZDE3OWJiYjRm MzgyYjEwIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDQgKzEs MTMgQEAKIDIwMTQtMDgtMTIgIEVkdWFyZG8gTGltYSBNaXRldiAgPGVsaW1hQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gU3VidGxlLWNyeXB0byBmZWF0dXJlIG9mZiBieSBkZWZhdWx0IGFu ZCBhZGQgYSBuZXcgY29uZmlndXJlIGZsYWcgdG8gZW5hYmxlIGl0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3OTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlOiBNYWtlcyBTVUJUTEVfQ1JZUFRPIGZsYWcgb2ZmIGJ5IGRlZmF1bHQuCisKKzIwMTQt MDgtMTIgIEVkdWFyZG8gTGltYSBNaXRldiAgPGVsaW1hQGlnYWxpYS5jb20+CiAgICAgICAgIFtH VEtdIEFkZHMgZGVwZW5kZW5jeSBvbiBHbnVUTFMgMy4wKyBmb3IgdGhlIGltcGxlbWVudGF0aW9u IG9mIHN1YnRsZSBjcnlwdG8gYWxnb3JpdGhtcwogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMzMzE3CiAK 236433 2014-08-12 01:52:55 -0700 2014-08-12 02:35:51 -0700 Patch bug-135798-20140812105243.patch text/plain 3338 elima U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyNDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDM2ZTZm YjE5YTkwYmE0YTdhN2NhMzk2Y2U3NzFjMDQyYmI2MDlkMzguLjM1MmQ3MWMyYTQ4YzI2YjkwYmMy ZmJiOWU3OTg1ZWJiOGQ2YzY0YTggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCkBAIC0xMzgsNyArMTM4 LDcgQEAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxFX1NFQ0NPTVBfRklM VEVSUyBPRkYpCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU0hBUkVE X1dPUktFUlMgT04pCiBXRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfU1BF TExDSEVDSyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJMRV9TVUJQ SVhFTF9MQVlPVVQgT04pCi1XRUJLSVRfT1BUSU9OX0RFRkFVTFRfUE9SVF9WQUxVRShFTkFCTEVf U1VCVExFX0NSWVBUTyBPTikKK1dFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVOQUJM RV9TVUJUTEVfQ1JZUFRPIE9GRikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZBTFVFKEVO QUJMRV9URU1QTEFURV9FTEVNRU5UIE9OKQogV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFM VUUoRU5BQkxFX1RPVUNIX0VWRU5UUyBPTikKIFdFQktJVF9PUFRJT05fREVGQVVMVF9QT1JUX1ZB TFVFKEVOQUJMRV9VU0VSU0VMRUNUX0FMTCBPTikKZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxv ZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkZTE3MzU2NzZmMGVkNDdjMDdiMDljOWZmNTI1NjY2 N2ExN2UxZDYyLi5lNjViMzFiNDdkNmZlMDgyMjAwY2IxNDRhY2M3NGMwMTRjY2I3ZjIxIDEwMDY0 NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTMgQEAKKzIwMTQtMDgtMTIgIEVkdWFyZG8gTGltYSBNaXRldiAgPGVsaW1hQGlnYWxpYS5jb20+ CisKKyAgICAgICAgW0dUS10gU3VidGxlLWNyeXB0byBmZWF0dXJlIG9mZiBieSBkZWZhdWx0IGFu ZCBhZGQgYSBuZXcgY29uZmlndXJlIGZsYWcgdG8gZW5hYmxlIGl0CisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3OTgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cGVybC9GZWF0 dXJlTGlzdC5wbTogQWRkcyBuZXcgZmxhZyAtLXN1YnRsZS1jcnlwdG8gdG8KKyAgICAgICAgICAg IHRvZ2dsZSBTVUJUTEVfQ1JZUFRPIGZlYXR1cmUuCisKIDIwMTQtMDgtMTIgIFNoaXZha3VtYXIg Sk0gIDxzaGl2YS5qbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXVtXSzJdIE1pbmlicm93 c2VyOiBFbmhhbmNlIHRoZSBhcHBsaWNhdGlvbiB0byB1c2UgZG93bmxvYWQgZGlyZWN0b3J5IHNl bGVjdG9yLgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0 LnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRwZXJsL0ZlYXR1cmVMaXN0LnBtCmluZGV4IGI5YTcx NTg3ZmQ5YzRhYjc5MWYwMzM3YmI0YjYwZTczMTRkMjMyZDkuLmVjYWZhZTE3ZjZhYjU5YTAzNGRk ZDdiZDAwZjMyYTEwMjQ3YzY0ODkgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cGVy bC9GZWF0dXJlTGlzdC5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdHBlcmwvRmVhdHVyZUxp c3QucG0KQEAgLTEyMiw2ICsxMjIsNyBAQCBteSAoCiAgICAgJHNoYXJlZFdvcmtlcnNTdXBwb3J0 LAogICAgICRzcWxEYXRhYmFzZVN1cHBvcnQsCiAgICAgJHN0eWxlU2NvcGVkU3VwcG9ydCwKKyAg ICAkc3VidGxlQ3J5cHRvLAogICAgICRzdWlkTGludXhTYW5kYm94LAogICAgICRzdmdET01PYmpD QmluZGluZ3NTdXBwb3J0LAogICAgICRzdmdGb250c1N1cHBvcnQsCkBAIC0zNzUsNiArMzc2LDkg QEAgbXkgQGZlYXR1cmVzID0gKAogICAgIHsgb3B0aW9uID0+ICJzcWwtZGF0YWJhc2UiLCBkZXNj ID0+ICJUb2dnbGUgU1FMIERhdGFiYXNlIHN1cHBvcnQiLAogICAgICAgZGVmaW5lID0+ICJFTkFC TEVfU1FMX0RBVEFCQVNFIiwgZGVmYXVsdCA9PiAxLCB2YWx1ZSA9PiBcJHNxbERhdGFiYXNlU3Vw cG9ydCB9LAogCisgICAgeyBvcHRpb24gPT4gInN1YnRsZS1jcnlwdG8iLCBkZXNjID0+ICJUb2dn bGUgV2ViQ3J5cHRvIFN1YnRsZS1DcnlwdG8gc3VwcG9ydCIsCisgICAgICBkZWZpbmUgPT4gIkVO QUJMRV9TVUJUTEVfQ1JZUFRPIiwgZGVmYXVsdCA9PiAoaXNHdGsoKSB8fCBpc0FwcGxlTWFjV2Vi S2l0KCkgfHwgaXNJT1NXZWJLaXQoKSksIHZhbHVlID0+IFwkc3VidGxlQ3J5cHRvIH0sCisKICAg ICB7IG9wdGlvbiA9PiAic3VpZC1saW51eC1zYW5kYm94IiwgZGVzYyA9PiAiVG9nZ2xlIHN1aWQg c2FuZGJveCBmb3IgbGludXgiLAogICAgICAgZGVmaW5lID0+ICJFTkFCTEVfU1VJRF9TQU5EQk9Y X0xJTlVYIiwgZGVmYXVsdCA9PiAwLCB2YWx1ZSA9PiBcJHN1aWRMaW51eFNhbmRib3ggfSwKIApk aWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IGIwZmM3OGNkZDRmMmI2OTMy YTc2ZTlmNmQ1NDNhMjE0NDZiODkzMWUuLjhkMmM4OGViNzZlOGRmOTYyNWM4ZjllZDVkMTc5YmJi NGYzODJiMTAgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsNCAr MSwxMyBAQAogMjAxNC0wOC0xMiAgRWR1YXJkbyBMaW1hIE1pdGV2ICA8ZWxpbWFAaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBTdWJ0bGUtY3J5cHRvIGZlYXR1cmUgb2ZmIGJ5IGRlZmF1bHQg YW5kIGFkZCBhIG5ldyBjb25maWd1cmUgZmxhZyB0byBlbmFibGUgaXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTc5OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNH VEsuY21ha2U6IE1ha2VzIFNVQlRMRV9DUllQVE8gZmxhZyBvZmYgYnkgZGVmYXVsdC4KKworMjAx NC0wOC0xMiAgRWR1YXJkbyBMaW1hIE1pdGV2ICA8ZWxpbWFAaWdhbGlhLmNvbT4KICAgICAgICAg W0dUS10gQWRkcyBkZXBlbmRlbmN5IG9uIEdudVRMUyAzLjArIGZvciB0aGUgaW1wbGVtZW50YXRp b24gb2Ygc3VidGxlIGNyeXB0byBhbGdvcml0aG1zCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzMzMTcKIAo=