135791 2014-08-10 22:19:03 -0700 [EFL][WK2] Minibrowser: Enhance the application to use download directory selector 2014-08-12 01:22:25 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 shiva.jm webkit-unassigned commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi oldest_to_newest 1028126 0 shiva.jm 2014-08-10 22:19:03 -0700 Currently Minibrowser stores the downloaded files to /tmp directory, so add support so that destination folder can be selected by the user. 1028127 1 236351 shiva.jm 2014-08-10 22:36:09 -0700 Created attachment 236351 Patch Currently Minibrowser stores the downloaded files to /tmp directory, add support so that destination folder can be selected by the user. 1028409 2 236351 gyuyoung.kim 2014-08-11 21:07:41 -0700 Comment on attachment 236351 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236351&action=review Looks fine. > Tools/MiniBrowser/efl/main.c:662 > + Eina_Stringshare *save_file_path = show_file_entry_dialog(window, "DOWNLOAD", home_path ? home_path : "/home"); Isn't it better to use /tmp when *home_path* isn't set ? > Tools/MiniBrowser/efl/main.c:674 > + eina_strbuf_append(destination_path, "/downloaded-file.XXXXXX"); Can't we change download file name as well ? 1028413 3 236428 shiva.jm 2014-08-11 21:46:00 -0700 Created attachment 236428 Patch for landing 1028458 4 236428 commit-queue 2014-08-12 01:22:20 -0700 Comment on attachment 236428 Patch for landing Clearing flags on attachment: 236428 Committed r172437: <http://trac.webkit.org/changeset/172437> 1028459 5 commit-queue 2014-08-12 01:22:25 -0700 All reviewed patches have been landed. Closing bug. 236351 2014-08-10 22:36:09 -0700 2014-08-11 21:45:49 -0700 Patch bug-135791.patch text/plain 2987 shiva.jm SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MjM4NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE0LTA4LTEwICBTaGl2YWt1bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5j b20+CisKKyAgICAgICAgW0VGTF1bV0syXSBNaW5pYnJvd3NlcjogRW5oYW5jZSB0aGUgYXBwbGlj YXRpb24gdG8gdXNlIGRvd25sb2FkIGRpcmVjdG9yeSBzZWxlY3Rvci4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTc5MQorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEN1cnJlbnRseSBNaW5pYnJvd3NlciBz dG9yZXMgdGhlIGRvd25sb2FkZWQgZmlsZXMgdG8gL3RtcCBkaXJlY3RvcnksIGFkZCBzdXBwb3J0 IHNvIHRoYXQgZGVzdGluYXRpb24gZm9sZGVyIGNhbiBiZSBzZWxlY3RlZCBieSB0aGUKKyAgICAg ICAgdXNlci4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWluLmM6CisgICAgICAgIChv bl9kb3dubG9hZF9yZXF1ZXN0KToKKwogMjAxNC0wOC0wOCAgU2ltb24gRnJhc2VyICA8c2ltb24u ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBVbmJyZWFrIHdlYmtpdHB5IHVuaXQgdGVzdHMg YnkgY2hlY2tpbmcgZm9yIHRoZSBleGlzdGVuY2Ugb2YgdGhlIGltYWdlIGRpZmYgdGVtcGxhdGUK SW5kZXg6IFRvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMv TWluaUJyb3dzZXIvZWZsL21haW4uYwkocmV2aXNpb24gMTcyMzg0KQorKysgVG9vbHMvTWluaUJy b3dzZXIvZWZsL21haW4uYwkod29ya2luZyBjb3B5KQpAQCAtNjU0LDI2ICs2NTQsMzcgQEAgc3Rh dGljIHZvaWQKIG9uX2Rvd25sb2FkX3JlcXVlc3Qodm9pZCAqdXNlcl9kYXRhLCBFdmFzX09iamVj dCAqZXdrX3ZpZXcsIHZvaWQgKmV2ZW50X2luZm8pCiB7CiAgICAgRXdrX0Rvd25sb2FkX0pvYiAq ZG93bmxvYWQgPSAoRXdrX0Rvd25sb2FkX0pvYiAqKWV2ZW50X2luZm87CisgICAgQnJvd3Nlcl9X aW5kb3cgKndpbmRvdyA9IChCcm93c2VyX1dpbmRvdyAqKXVzZXJfZGF0YTsKIAotICAgIC8vIEZJ WE1FOiBUaGUgZGVzdGluYXRpb24gZm9sZGVyIHNob3VsZCBiZSBzZWxlY3RlZCBieSB0aGUgdXNl ciBidXQgd2Ugc2V0IGl0IHRvICcvdG1wJyBmb3Igbm93LgogICAgIEVpbmFfU3RyYnVmICpkZXN0 aW5hdGlvbl9wYXRoID0gZWluYV9zdHJidWZfbmV3KCk7CiAKKyAgICBjb25zdCBjaGFyICpob21l X3BhdGggPSBnZXRlbnYoIkhPTUUiKTsKKyAgICBFaW5hX1N0cmluZ3NoYXJlICpzYXZlX2ZpbGVf cGF0aCA9IHNob3dfZmlsZV9lbnRyeV9kaWFsb2cod2luZG93LCAiRE9XTkxPQUQiLCBob21lX3Bh dGggPyBob21lX3BhdGggOiAiL2hvbWUiKTsKKworICAgIGlmIChzYXZlX2ZpbGVfcGF0aCkKKyAg ICAgICAgZWluYV9zdHJidWZfYXBwZW5kX3ByaW50ZihkZXN0aW5hdGlvbl9wYXRoLCAiJXMiLCBz YXZlX2ZpbGVfcGF0aCk7CisgICAgZWxzZQorICAgICAgICBlaW5hX3N0cmJ1Zl9hcHBlbmQoZGVz dGluYXRpb25fcGF0aCwgIi90bXAiKTsKKwogICAgIGNvbnN0IGNoYXIgKnN1Z2dlc3RlZF9uYW1l ID0gZXdrX2Rvd25sb2FkX2pvYl9zdWdnZXN0ZWRfZmlsZW5hbWVfZ2V0KGRvd25sb2FkKTsKICAg ICBpZiAoc3VnZ2VzdGVkX25hbWUgJiYgKnN1Z2dlc3RlZF9uYW1lKQotICAgICAgICBlaW5hX3N0 cmJ1Zl9hcHBlbmRfcHJpbnRmKGRlc3RpbmF0aW9uX3BhdGgsICIvdG1wLyVzIiwgc3VnZ2VzdGVk X25hbWUpOworICAgICAgICBlaW5hX3N0cmJ1Zl9hcHBlbmRfcHJpbnRmKGRlc3RpbmF0aW9uX3Bh dGgsICIvJXMiLCBzdWdnZXN0ZWRfbmFtZSk7CiAgICAgZWxzZSB7CiAgICAgICAgIC8vIEdlbmVy YXRlIGEgdW5pcXVlIGZpbGUgbmFtZSBzaW5jZSBubyBuYW1lIHdhcyBzdWdnZXN0ZWQuCi0gICAg ICAgIGNoYXIgdW5pcXVlX3BhdGhbXSA9ICIvdG1wL2Rvd25sb2FkZWQtZmlsZS5YWFhYWFgiOwot ICAgICAgICBpZiAobWtzdGVtcCh1bmlxdWVfcGF0aCkgPT0gLTEpIHsKKyAgICAgICAgZWluYV9z dHJidWZfYXBwZW5kKGRlc3RpbmF0aW9uX3BhdGgsICIvZG93bmxvYWRlZC1maWxlLlhYWFhYWCIp OworICAgICAgICBjaGFyICp1cmwgPSBOVUxMOworICAgICAgICB1cmwgPSBlaW5hX3N0cmJ1Zl9z dHJpbmdfc3RlYWwoZGVzdGluYXRpb25fcGF0aCk7CisgICAgICAgIGlmIChta3N0ZW1wKHVybCkg PT0gLTEpIHsKICAgICAgICAgICAgIGluZm8oIkVSUk9SOiBDb3VsZCBub3QgZ2VuZXJhdGUgYSB1 bmlxdWUgZmlsZSBuYW1lLiIpOwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0gICAg ICAgIGVpbmFfc3RyYnVmX2FwcGVuZChkZXN0aW5hdGlvbl9wYXRoLCB1bmlxdWVfcGF0aCk7Cisg ICAgICAgIGVpbmFfc3RyYnVmX2FwcGVuZChkZXN0aW5hdGlvbl9wYXRoLCB1cmwpOwogICAgIH0K IAogICAgIGV3a19kb3dubG9hZF9qb2JfZGVzdGluYXRpb25fc2V0KGRvd25sb2FkLCBlaW5hX3N0 cmJ1Zl9zdHJpbmdfZ2V0KGRlc3RpbmF0aW9uX3BhdGgpKTsKICAgICBpbmZvKCJEb3dubG9hZGlu ZzogJXMiLCBlaW5hX3N0cmJ1Zl9zdHJpbmdfZ2V0KGRlc3RpbmF0aW9uX3BhdGgpKTsKICAgICBl aW5hX3N0cmJ1Zl9mcmVlKGRlc3RpbmF0aW9uX3BhdGgpOworICAgIGVpbmFfc3RyaW5nc2hhcmVf ZGVsKHNhdmVfZmlsZV9wYXRoKTsKIH0KIAogc3RhdGljIHZvaWQgb25fZmlsZXBpY2tlcl9wYXJl bnRfZGVsZXRpb24odm9pZCAqdXNlcl9kYXRhLCBFdmFzICpldmFzLCBFdmFzX09iamVjdCAqZWxt X3dpbmRvdywgdm9pZCAqZXZlbnQpOwo= 236428 2014-08-11 21:46:00 -0700 2014-08-12 01:22:20 -0700 Patch for landing bug-135791-20140812103510.patch text/plain 2964 shiva.jm SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MjQyOSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDE0LTA4LTExICBTaGl2YWt1bWFyIEpNICA8c2hpdmEuam1Ac2Ftc3VuZy5j b20+CisKKyAgICAgICAgW0VGTF1bV0syXSBNaW5pYnJvd3NlcjogRW5oYW5jZSB0aGUgYXBwbGlj YXRpb24gdG8gdXNlIGRvd25sb2FkIGRpcmVjdG9yeSBzZWxlY3Rvci4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTc5MQorCisgICAgICAgIFJldmll d2VkIGJ5IEd5dXlvdW5nIEtpbS4KKworICAgICAgICBDdXJyZW50bHkgTWluaWJyb3dzZXIgc3Rv cmVzIHRoZSBkb3dubG9hZGVkIGZpbGVzIHRvIC90bXAgZGlyZWN0b3J5LCBhZGQgc3VwcG9ydCBz byB0aGF0IGRlc3RpbmF0aW9uIGZvbGRlciBjYW4gYmUgc2VsZWN0ZWQgYnkgdGhlCisgICAgICAg IHVzZXIuCisKKyAgICAgICAgKiBNaW5pQnJvd3Nlci9lZmwvbWFpbi5jOgorICAgICAgICAob25f ZG93bmxvYWRfcmVxdWVzdCk6CisKIDIwMTQtMDgtMTEgIERhbiBCZXJuc3RlaW4gIDxtaXR6QGFw cGxlLmNvbT4KIAogICAgICAgICBBZGRlZCBhbiB1cGRhdGUtd2Via2l0IG9wdGlvbiB0byB1cGRh dGUgdGhlIGF1eGlsaWFyeSBsaWJyYXJpZXMgb3Igbm90LgpJbmRleDogVG9vbHMvTWluaUJyb3dz ZXIvZWZsL21haW4uYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5j CShyZXZpc2lvbiAxNzI0MjkpCisrKyBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCSh3b3Jr aW5nIGNvcHkpCkBAIC02NTQsMjYgKzY1NCwzNyBAQCBzdGF0aWMgdm9pZAogb25fZG93bmxvYWRf cmVxdWVzdCh2b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICpld2tfdmlldywgdm9pZCAqZXZl bnRfaW5mbykKIHsKICAgICBFd2tfRG93bmxvYWRfSm9iICpkb3dubG9hZCA9IChFd2tfRG93bmxv YWRfSm9iICopZXZlbnRfaW5mbzsKKyAgICBCcm93c2VyX1dpbmRvdyAqd2luZG93ID0gKEJyb3dz ZXJfV2luZG93ICopdXNlcl9kYXRhOwogCi0gICAgLy8gRklYTUU6IFRoZSBkZXN0aW5hdGlvbiBm b2xkZXIgc2hvdWxkIGJlIHNlbGVjdGVkIGJ5IHRoZSB1c2VyIGJ1dCB3ZSBzZXQgaXQgdG8gJy90 bXAnIGZvciBub3cuCiAgICAgRWluYV9TdHJidWYgKmRlc3RpbmF0aW9uX3BhdGggPSBlaW5hX3N0 cmJ1Zl9uZXcoKTsKIAorICAgIGNvbnN0IGNoYXIgKmhvbWVfcGF0aCA9IGdldGVudigiSE9NRSIp OworICAgIEVpbmFfU3RyaW5nc2hhcmUgKnNhdmVfZmlsZV9wYXRoID0gc2hvd19maWxlX2VudHJ5 X2RpYWxvZyh3aW5kb3csICJET1dOTE9BRCIsIGhvbWVfcGF0aCA/IGhvbWVfcGF0aCA6ICIvdG1w Iik7CisKKyAgICBpZiAoc2F2ZV9maWxlX3BhdGgpCisgICAgICAgIGVpbmFfc3RyYnVmX2FwcGVu ZF9wcmludGYoZGVzdGluYXRpb25fcGF0aCwgIiVzIiwgc2F2ZV9maWxlX3BhdGgpOworICAgIGVs c2UKKyAgICAgICAgZWluYV9zdHJidWZfYXBwZW5kKGRlc3RpbmF0aW9uX3BhdGgsICIvdG1wIik7 CisKICAgICBjb25zdCBjaGFyICpzdWdnZXN0ZWRfbmFtZSA9IGV3a19kb3dubG9hZF9qb2Jfc3Vn Z2VzdGVkX2ZpbGVuYW1lX2dldChkb3dubG9hZCk7CiAgICAgaWYgKHN1Z2dlc3RlZF9uYW1lICYm ICpzdWdnZXN0ZWRfbmFtZSkKLSAgICAgICAgZWluYV9zdHJidWZfYXBwZW5kX3ByaW50ZihkZXN0 aW5hdGlvbl9wYXRoLCAiL3RtcC8lcyIsIHN1Z2dlc3RlZF9uYW1lKTsKKyAgICAgICAgZWluYV9z dHJidWZfYXBwZW5kX3ByaW50ZihkZXN0aW5hdGlvbl9wYXRoLCAiLyVzIiwgc3VnZ2VzdGVkX25h bWUpOwogICAgIGVsc2UgewogICAgICAgICAvLyBHZW5lcmF0ZSBhIHVuaXF1ZSBmaWxlIG5hbWUg c2luY2Ugbm8gbmFtZSB3YXMgc3VnZ2VzdGVkLgotICAgICAgICBjaGFyIHVuaXF1ZV9wYXRoW10g PSAiL3RtcC9kb3dubG9hZGVkLWZpbGUuWFhYWFhYIjsKLSAgICAgICAgaWYgKG1rc3RlbXAodW5p cXVlX3BhdGgpID09IC0xKSB7CisgICAgICAgIGVpbmFfc3RyYnVmX2FwcGVuZChkZXN0aW5hdGlv bl9wYXRoLCAiL2Rvd25sb2FkZWQtZmlsZS5YWFhYWFgiKTsKKyAgICAgICAgY2hhciAqdXJsID0g TlVMTDsKKyAgICAgICAgdXJsID0gZWluYV9zdHJidWZfc3RyaW5nX3N0ZWFsKGRlc3RpbmF0aW9u X3BhdGgpOworICAgICAgICBpZiAobWtzdGVtcCh1cmwpID09IC0xKSB7CiAgICAgICAgICAgICBp bmZvKCJFUlJPUjogQ291bGQgbm90IGdlbmVyYXRlIGEgdW5pcXVlIGZpbGUgbmFtZS4iKTsKICAg ICAgICAgICAgIHJldHVybjsKICAgICAgICAgfQotICAgICAgICBlaW5hX3N0cmJ1Zl9hcHBlbmQo ZGVzdGluYXRpb25fcGF0aCwgdW5pcXVlX3BhdGgpOworICAgICAgICBlaW5hX3N0cmJ1Zl9hcHBl bmQoZGVzdGluYXRpb25fcGF0aCwgdXJsKTsKICAgICB9CiAKICAgICBld2tfZG93bmxvYWRfam9i X2Rlc3RpbmF0aW9uX3NldChkb3dubG9hZCwgZWluYV9zdHJidWZfc3RyaW5nX2dldChkZXN0aW5h dGlvbl9wYXRoKSk7CiAgICAgaW5mbygiRG93bmxvYWRpbmc6ICVzIiwgZWluYV9zdHJidWZfc3Ry aW5nX2dldChkZXN0aW5hdGlvbl9wYXRoKSk7CiAgICAgZWluYV9zdHJidWZfZnJlZShkZXN0aW5h dGlvbl9wYXRoKTsKKyAgICBlaW5hX3N0cmluZ3NoYXJlX2RlbChzYXZlX2ZpbGVfcGF0aCk7CiB9 CiAKIHN0YXRpYyB2b2lkIG9uX2ZpbGVwaWNrZXJfcGFyZW50X2RlbGV0aW9uKHZvaWQgKnVzZXJf ZGF0YSwgRXZhcyAqZXZhcywgRXZhc19PYmplY3QgKmVsbV93aW5kb3csIHZvaWQgKmV2ZW50KTsK