135785 2014-08-09 12:18:04 -0700 REGRESSION (r172301): Combined phone number highlight doesn't appear if rich content is selected and we have no rich content services 2014-08-09 18:05:32 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton beidson enrica oldest_to_newest 1028063 0 thorton 2014-08-09 12:18:04 -0700 <rdar://problem/17969843> Steps to Reproduce: 1. Install only a plain text service. 2. Go to http://apple.com/contact 3. Select from "Contact Apple Support" to "Lost or Stolen Apple Products" in the second column 4. Hover the selection. Expected: Should get a selection button and a menu when clicking it. Actual: No button, no menu, no phone numbers. 1028064 1 236337 thorton 2014-08-09 12:20:35 -0700 Created attachment 236337 patch 1028065 2 236338 thorton 2014-08-09 12:32:07 -0700 Created attachment 236338 patch I was going to do this in two patches, but there's no point. 1028070 3 thorton 2014-08-09 18:05:32 -0700 http://trac.webkit.org/changeset/172374 236337 2014-08-09 12:20:35 -0700 2014-08-09 12:32:07 -0700 patch telephonemissing.diff text/plain 2350 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyYWQyMzUwLi5iMGRlNmYxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTQtMDgtMDkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjE3MjMwMSk6IENvbWJpbmVkIHBob25lIG51bWJlciBoaWdo bGlnaHQgZG9lc24ndCBhcHBlYXIgaWYgcmljaCBjb250ZW50IGlzIHNlbGVjdGVkIGFuZCB3ZSBo YXZlIG5vIHJpY2ggY29udGVudCBzZXJ2aWNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1Nzg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzk2 OTg0Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbToKKyAg ICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6ZHJhd1NlbGVjdGlvbkhp Z2hsaWdodCk6CisgICAgICAgIFdlIGNhbid0IGVhcmx5IHJldHVybiBpbiB0aGUgcmljaC1jb250 ZW50LWJ1dC1uby1yaWNoLXNlcnZpY2VzIGNhc2UKKyAgICAgICAgaWYgd2UgaGF2ZSB0ZWxlcGhv bmUgbnVtYmVycyBpbiB0aGUgc2VsZWN0aW9uLCBiZWNhdXNlIHdlIHdhbnQgdG8gb2ZmZXIKKyAg ICAgICAgdGhlbSB1cCBpbiB0aGUgY29tYmluZWQgbWVudS4KKwogMjAxNC0wOC0wOCAgR3J6ZWdv cnogQ3phamtvd3NraSAgPGcuY3phamtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZM XSBEbyBub3QgaW5pdGlhbGl6ZSBnX3R5cGUgaW4gV2ViUHJvY2Vzc01haW46OnBsYXRmb3JtSW5p dGlhbGl6ZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2Uv bWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9j ZXNzL1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0KaW5kZXggMWFiY2Mz OC4uY2Y4YzhkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdl L21hYy9TZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQpAQCAtMjcz LDExICsyNzMsMTEgQEAgdm9pZCBTZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyOjpkcmF3U2VsZWN0 aW9uSGlnaGxpZ2h0KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCYKIHsKICAgICAvLyBJdCdzIHBv c3NpYmxlIHRvIGVuZCB1cCBkcmF3aW5nIHRoZSBzZWxlY3Rpb24gaGlnaGxpZ2h0IGJlZm9yZSB3 ZSd2ZSBhY3R1YWxseSByZWNlaXZlZCB0aGUgc2VsZWN0aW9uIHJlY3RzLgogICAgIC8vIElmIHRo YXQgaGFwcGVucyB3ZSdsbCBlbmQgdXAgaGVyZSBhZ2FpbiBvbmNlIHdlIGhhdmUgdGhlIHJlY3Rz LgotICAgIGlmIChtX2N1cnJlbnRTZWxlY3Rpb25SZWN0cy5pc0VtcHR5KCkgfHwgKCFXZWJQcm9j ZXNzOjpzaGFyZWQoKS5oYXNSaWNoQ29udGVudFNlcnZpY2VzKCkgJiYgIW1faXNUZXh0T25seSkp CisgICAgaWYgKG1fY3VycmVudFNlbGVjdGlvblJlY3RzLmlzRW1wdHkoKSkKICAgICAgICAgcmV0 dXJuOwogCi0gICAgLy8gSWYgdGhlcmUgYXJlIG5vIGluc3RhbGxlZCBzZWxlY3Rpb24gc2Vydmlj ZXMgYW5kIHdlIGhhdmUgbm8gcGhvbmUgbnVtYmVycyBkZXRlY3RlZCwgdGhlbiB3ZSBoYXZlIG5v dGhpbmcgdG8gZHJhdy4KLSAgICBpZiAoIVdlYlByb2Nlc3M6OnNoYXJlZCgpLmhhc1NlbGVjdGlv blNlcnZpY2VzKCkgJiYgbV9jdXJyZW50VGVsZXBob25lTnVtYmVyUmFuZ2VzLmlzRW1wdHkoKSkK KyAgICAvLyBJZiB0aGVyZSBhcmUgbm8gYXBwcm9wcmlhdGUgaW5zdGFsbGVkIHNlbGVjdGlvbiBz ZXJ2aWNlcyBhbmQgd2UgaGF2ZSBubyBwaG9uZSBudW1iZXJzIGRldGVjdGVkLCB0aGVuIHdlIGhh dmUgbm90aGluZyB0byBkcmF3LgorICAgIGlmICgoIVdlYlByb2Nlc3M6OnNoYXJlZCgpLmhhc1Nl bGVjdGlvblNlcnZpY2VzKCkgfHwgKCFXZWJQcm9jZXNzOjpzaGFyZWQoKS5oYXNSaWNoQ29udGVu dFNlcnZpY2VzKCkgJiYgIW1faXNUZXh0T25seSkpICYmIG1fY3VycmVudFRlbGVwaG9uZU51bWJl clJhbmdlcy5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmICghbV9zZWxlY3Rp b25IaWdobGlnaHQpCg== 236338 2014-08-09 12:32:07 -0700 2014-08-09 18:01:57 -0700 patch telephonemissing.diff text/plain 3601 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAyYWQyMzUwLi41MDFlOWU4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTQtMDgtMDkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgUkVHUkVTU0lPTiAocjE3MjMwMSk6IENvbWJpbmVkIHBob25lIG51bWJlciBoaWdo bGlnaHQgZG9lc24ndCBhcHBlYXIgaWYgcmljaCBjb250ZW50IGlzIHNlbGVjdGVkIGFuZCB3ZSBo YXZlIG5vIHJpY2ggY29udGVudCBzZXJ2aWNlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1Nzg1CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzk2 OTg0Mz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbToKKyAg ICAgICAgKFdlYktpdDo6U2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6ZHJhd1NlbGVjdGlvbkhp Z2hsaWdodCk6CisgICAgICAgIFdlIGNhbid0IGVhcmx5IHJldHVybiBpbiB0aGUgcmljaC1jb250 ZW50LWJ1dC1uby1yaWNoLXNlcnZpY2VzIGNhc2UKKyAgICAgICAgaWYgd2UgaGF2ZSB0ZWxlcGhv bmUgbnVtYmVycyBpbiB0aGUgc2VsZWN0aW9uLCBiZWNhdXNlIHdlIHdhbnQgdG8gb2ZmZXIKKyAg ICAgICAgdGhlbSB1cCBpbiB0aGUgY29tYmluZWQgbWVudS4KKworICAgICAgICAqIFVJUHJvY2Vz cy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5tbToKKyAgICAgICAgSWYgd2UgZW5kIHVwIHdp dGggbm8gbWVudSwgYmVjYXVzZSB0aGVyZSB3ZXJlIG5vIHNlcnZpY2VzIGF2YWlsYWJsZSwKKyAg ICAgICAgbWFrZSBhIGZyZXNoIG9uZSB0aGF0IHdlIGNhbiBmaWxsIHdpdGggY29tYmluZWQgdGVs ZXBob25lIG51bWJlciBpdGVtcy4KKwogMjAxNC0wOC0wOCAgR3J6ZWdvcnogQ3phamtvd3NraSAg PGcuY3phamtvd3NraUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbRUZMXSBEbyBub3QgaW5pdGlh bGl6ZSBnX3R5cGUgaW4gV2ViUHJvY2Vzc01haW46OnBsYXRmb3JtSW5pdGlhbGl6ZSgpCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlN YWMubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlN YWMubW0KaW5kZXggNzhjZmUzZC4uZWNjOTk0NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCisrKyBiL1NvdXJjZS9XZWJL aXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5tbQpAQCAtNDA2LDcgKzQw NiwxMCBAQCB2b2lkIFdlYkNvbnRleHRNZW51UHJveHlNYWM6OnNldHVwU2VydmljZXNNZW51KGNv bnN0IENvbnRleHRNZW51Q29udGV4dERhdGEmIGNvbgogICAgIC8vIEV4cGxpY2l0bHkgYWRkIGEg bWVudSBpdGVtIGZvciBlYWNoIHRlbGVwaG9uZSBudW1iZXIgdGhhdCBpcyBpbiB0aGUgc2VsZWN0 aW9uLgogICAgIGNvbnN0IFZlY3RvcjxTdHJpbmc+JiBzZWxlY3RlZFRlbGVwaG9uZU51bWJlcnMg PSBjb250ZXh0LnNlbGVjdGVkVGVsZXBob25lTnVtYmVycygpOwogICAgIGlmICghc2VsZWN0ZWRU ZWxlcGhvbmVOdW1iZXJzLmlzRW1wdHkoKSkgewotICAgICAgICBbbV9zZXJ2aWNlc01lbnUuZ2V0 KCkgYWRkSXRlbTpbTlNNZW51SXRlbSBzZXBhcmF0b3JJdGVtXV07CisgICAgICAgIGlmIChtX3Nl cnZpY2VzTWVudSkKKyAgICAgICAgICAgIFttX3NlcnZpY2VzTWVudSBhZGRJdGVtOltOU01lbnVJ dGVtIHNlcGFyYXRvckl0ZW1dXTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgbV9zZXJ2aWNl c01lbnUgPSBhZG9wdE5TKFtbTlNNZW51IGFsbG9jXSBpbml0XSk7CiAgICAgICAgIGZvciAoYXV0 byYgdGVsZXBob25lTnVtYmVyIDogc2VsZWN0ZWRUZWxlcGhvbmVOdW1iZXJzKSB7CiAgICAgICAg ICAgICBpZiAoTlNNZW51SXRlbSAqaXRlbSA9IG1lbnVJdGVtRm9yVGVsZXBob25lTnVtYmVyKHRl bGVwaG9uZU51bWJlcikpCiAgICAgICAgICAgICAgICAgW21fc2VydmljZXNNZW51IGFkZEl0ZW06 aXRlbV07CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFj L1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0gYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNz L1dlYlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0KaW5kZXggMWFiY2MzOC4u Y2Y4YzhkNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21h Yy9TZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1dlYlBy b2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQpAQCAtMjczLDEx ICsyNzMsMTEgQEAgdm9pZCBTZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyOjpkcmF3U2VsZWN0aW9u SGlnaGxpZ2h0KFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dCYKIHsKICAgICAvLyBJdCdzIHBvc3Np YmxlIHRvIGVuZCB1cCBkcmF3aW5nIHRoZSBzZWxlY3Rpb24gaGlnaGxpZ2h0IGJlZm9yZSB3ZSd2 ZSBhY3R1YWxseSByZWNlaXZlZCB0aGUgc2VsZWN0aW9uIHJlY3RzLgogICAgIC8vIElmIHRoYXQg aGFwcGVucyB3ZSdsbCBlbmQgdXAgaGVyZSBhZ2FpbiBvbmNlIHdlIGhhdmUgdGhlIHJlY3RzLgot ICAgIGlmIChtX2N1cnJlbnRTZWxlY3Rpb25SZWN0cy5pc0VtcHR5KCkgfHwgKCFXZWJQcm9jZXNz OjpzaGFyZWQoKS5oYXNSaWNoQ29udGVudFNlcnZpY2VzKCkgJiYgIW1faXNUZXh0T25seSkpCisg ICAgaWYgKG1fY3VycmVudFNlbGVjdGlvblJlY3RzLmlzRW1wdHkoKSkKICAgICAgICAgcmV0dXJu OwogCi0gICAgLy8gSWYgdGhlcmUgYXJlIG5vIGluc3RhbGxlZCBzZWxlY3Rpb24gc2VydmljZXMg YW5kIHdlIGhhdmUgbm8gcGhvbmUgbnVtYmVycyBkZXRlY3RlZCwgdGhlbiB3ZSBoYXZlIG5vdGhp bmcgdG8gZHJhdy4KLSAgICBpZiAoIVdlYlByb2Nlc3M6OnNoYXJlZCgpLmhhc1NlbGVjdGlvblNl cnZpY2VzKCkgJiYgbV9jdXJyZW50VGVsZXBob25lTnVtYmVyUmFuZ2VzLmlzRW1wdHkoKSkKKyAg ICAvLyBJZiB0aGVyZSBhcmUgbm8gYXBwcm9wcmlhdGUgaW5zdGFsbGVkIHNlbGVjdGlvbiBzZXJ2 aWNlcyBhbmQgd2UgaGF2ZSBubyBwaG9uZSBudW1iZXJzIGRldGVjdGVkLCB0aGVuIHdlIGhhdmUg bm90aGluZyB0byBkcmF3LgorICAgIGlmICgoIVdlYlByb2Nlc3M6OnNoYXJlZCgpLmhhc1NlbGVj dGlvblNlcnZpY2VzKCkgfHwgKCFXZWJQcm9jZXNzOjpzaGFyZWQoKS5oYXNSaWNoQ29udGVudFNl cnZpY2VzKCkgJiYgIW1faXNUZXh0T25seSkpICYmIG1fY3VycmVudFRlbGVwaG9uZU51bWJlclJh bmdlcy5pc0VtcHR5KCkpCiAgICAgICAgIHJldHVybjsKIAogICAgIGlmICghbV9zZWxlY3Rpb25I aWdobGlnaHQpCg==