135776 2014-08-08 16:16:28 -0700 [Services with UI] Action menu arrow hit testing is sometimes wrong 2014-08-11 10:52:46 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Mac Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 enrica enrica beidson thorton oldest_to_newest 1027990 0 enrica 2014-08-08 16:16:28 -0700 * STEPS TO REPRODUCE 0. Install and enable a text viewer extension. 1. Load the Yelp page for Nihon Whiskey Loung in San Francisco - http://www.yelp.com/biz/nihon-whisky-lounge-san-francisco#query:nihon%20whiskey%20lounge 2. Select text from the second review, then hover over the first line of the selection. 3. Nothing happens - no arrow. 4. Hover a bit lower, over the whitespace under the first line. 5. Arrow appears. <rdar://problem/17837670> 1027996 1 236322 enrica 2014-08-08 16:26:08 -0700 Created attachment 236322 Patch 1027998 2 236322 beidson 2014-08-08 16:34:34 -0700 Comment on attachment 236322 Patch I stared at the rect math for like 5 minutes. Seems fine! 1028002 3 236322 thorton 2014-08-08 16:38:22 -0700 Comment on attachment 236322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236322&action=review > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:152 > + if (rects.isEmpty() || rects.size() == 1) should this just be rects.size() <= 1? > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:171 > + // Next stich together all the rects on the last line of the selection. s/stich/stitch/ > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:186 > + // indexFromEnd is the index of the last rectangle on the sendon the last line. "on the sendon"? 1028217 4 enrica 2014-08-11 10:29:01 -0700 (In reply to comment #3) > (From update of attachment 236322 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236322&action=review > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:152 > > + if (rects.isEmpty() || rects.size() == 1) > > should this just be rects.size() <= 1? Yes, it is better. > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:171 > > + // Next stich together all the rects on the last line of the selection. > > s/stich/stitch/ > > > Source/WebKit2/WebProcess/WebPage/mac/ServicesOverlayController.mm:186 > > + // indexFromEnd is the index of the last rectangle on the sendon the last line. > > "on the sendon"? Thanks for catching the typos. 1028227 5 enrica 2014-08-11 10:52:46 -0700 Committed revision 172395. 236322 2014-08-08 16:26:08 -0700 2014-08-08 16:38:22 -0700 Patch stitchrects.txt text/plain 4152 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjM2NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA4LTA4ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW1NlcnZpY2VzIHdpdGggVUld IEFjdGlvbiBtZW51IGFycm93IGhpdCB0ZXN0aW5nIGlzIHNvbWV0aW1lcyB3cm9uZy4KKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTc3NgorICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMTc4Mzc2NzA+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlcmUgd2FzIGEgcHJvYmxlbSBpbiB0aGUgYWxnb3JpdGht IHRoYXQgc3RpdGNoZXMgdG9nZXRoZXIgdGhlIHNlbGVjdGlvbiByZWN0YW5nbGVzCisgICAgICAg IHRvIGJlIGdpdmVuIHRvIERhdGEgRGV0ZWN0b3JzIEFQSS4KKyAgICAgICAgVGhpcyBjaGFuZ2Ug YWRkcyBhIG5ldyBmdW5jdGlvbiB0aGF0IHN0aWNoZXMgdG9nZXRoZXIgYWxsIHRoZSByZWN0cyBj b250cmlidXRpbmcgdG8gdGhlCisgICAgICAgIGZpcnN0IGxpbmUsIGFsbCB0aGUgcmVjdHMgY29u dHJpYnV0aW5nIHRvIHRoZSBsYXN0IGxpbmUgYW5kIGFsbCB0aGUgb25lcyBpbiB0aGUgbWlkZGxl LgorICAgICAgICBUaGlzIHdheSB3ZSBjYW4gaGF2ZSBhIG1heGltdW0gb2YgMyBub24gb3Zlcmxh cHBpbmcgcmVjdGFuZ2xlcy4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvU2Vy dmljZXNPdmVybGF5Q29udHJvbGxlci5tbToKKyAgICAgICAgKFdlYktpdDo6c3RpdGNoUmVjdHMp OgorICAgICAgICAoV2ViS2l0Ojpjb21wYWN0UmVjdHNXaXRoR2FwUmVjdHMpOgorCiAyMDE0LTA4 LTA4ICBUaW1vdGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAg ICBDbGllbnRzIHRoYXQgcmVxdWVzdCB0aGUgc2VsZWN0aW9uIHNlcnZpY2VzIG1lbnUgYWZ0ZXIg V2ViS2l0MiB3aWxsIGdldCBvbmUgd2l0aCBkaWZmZXJlbnQgbWV0cmljcyB0aGFuIG90aGVyd2lz ZQpJbmRleDogU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092 ZXJsYXlDb250cm9sbGVyLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1dlYlByb2Nl c3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQkocmV2aXNpb24gMTcy MzAxKQorKysgU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092 ZXJsYXlDb250cm9sbGVyLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xNDcsMjIgKzE0Nyw1OCBAQCBz dGF0aWMgdm9pZCBleHBhbmRGb3JHYXAoVmVjdG9yPExheW91dFJlCiAgICAgfQogfQogCi1zdGF0 aWMgdm9pZCBjb21wYWN0UmVjdHNXaXRoR2FwUmVjdHMoVmVjdG9yPExheW91dFJlY3Q+JiByZWN0 cywgY29uc3QgVmVjdG9yPEdhcFJlY3RzPiYgZ2FwUmVjdHMpCitzdGF0aWMgaW5saW5lIHZvaWQg c3RpdGNoUmVjdHMoVmVjdG9yPExheW91dFJlY3Q+JiByZWN0cykKIHsKLSAgICBpZiAocmVjdHMu aXNFbXB0eSgpKQorICAgIGlmIChyZWN0cy5pc0VtcHR5KCkgfHwgcmVjdHMuc2l6ZSgpID09IDEp CisgICAgICAgIHJldHVybjsKKyAgICAKKyAgICBWZWN0b3I8TGF5b3V0UmVjdD4gbmV3UmVjdHM7 CisgICAgCisgICAgLy8gRmlyc3Qgc3RpdGNoIHRvZ2V0aGVyIGFsbCB0aGUgcmVjdHMgb24gdGhl IGZpcnN0IGxpbmUgb2YgdGhlIHNlbGVjdGlvbi4KKyAgICBzaXplX3QgaW5kZXhGcm9tU3RhcnQg PSAwOworICAgIExheW91dFVuaXQgZmlyc3RUb3AgPSByZWN0c1tpbmRleEZyb21TdGFydF0ueSgp OworICAgIExheW91dFJlY3QmIGN1cnJlbnRSZWN0ID0gcmVjdHNbaW5kZXhGcm9tU3RhcnQrK107 CisgICAgd2hpbGUgKGluZGV4RnJvbVN0YXJ0IDwgcmVjdHMuc2l6ZSgpICYmIHJlY3RzW2luZGV4 RnJvbVN0YXJ0XS55KCkgPT0gZmlyc3RUb3ApCisgICAgICAgIGN1cnJlbnRSZWN0LnVuaXRlKHJl Y3RzW2luZGV4RnJvbVN0YXJ0KytdKTsKKyAgICAKKyAgICBuZXdSZWN0cy5hcHBlbmQoY3VycmVu dFJlY3QpOworICAgIGlmIChpbmRleEZyb21TdGFydCA9PSByZWN0cy5zaXplKCkpIHsKKyAgICAg ICAgLy8gQWxsIHRoZSByZWN0cyBhcmUgb24gb25lIGxpbmUuIFRoZXJlIGlzIG5vdGhpbmcgZWxz ZSB0byBkby4KKyAgICAgICAgcmVjdHMuc3dhcChuZXdSZWN0cyk7CiAgICAgICAgIHJldHVybjsK LQotICAgIC8vIEFsbCBvZiB0aGUgbWlkZGxlIHJlY3RzIC0gZXZlcnl0aGluZyBidXQgdGhlIGZp cnN0IGFuZCBsYXN0IC0gY2FuIGJlIHVuaW9uZWQgdG9nZXRoZXIuCi0gICAgaWYgKHJlY3RzLnNp emUoKSA+IDMpIHsKLSAgICAgICAgTGF5b3V0UmVjdCB1bml0ZWQ7Ci0gICAgICAgIGZvciAodW5z aWduZWQgaSA9IDE7IGkgPCByZWN0cy5zaXplKCkgLSAxOyArK2kpCi0gICAgICAgICAgICB1bml0 ZWQudW5pdGUocmVjdHNbaV0pOwotCi0gICAgICAgIHJlY3RzWzFdID0gdW5pdGVkOwotICAgICAg ICByZWN0c1syXSA9IHJlY3RzLmxhc3QoKTsKLSAgICAgICAgcmVjdHMuc2hyaW5rKDMpOwogICAg IH0KKyAgICAKKyAgICAvLyBOZXh0IHN0aWNoIHRvZ2V0aGVyIGFsbCB0aGUgcmVjdHMgb24gdGhl IGxhc3QgbGluZSBvZiB0aGUgc2VsZWN0aW9uLgorICAgIHNpemVfdCBpbmRleEZyb21FbmQgPSBy ZWN0cy5zaXplKCkgLSAxOworICAgIExheW91dFVuaXQgbGFzdFRvcCA9IHJlY3RzW2luZGV4RnJv bUVuZF0ueSgpOworICAgIExheW91dFJlY3QgbGFzdFJlY3QgPSByZWN0c1tpbmRleEZyb21FbmRd OworICAgIHdoaWxlIChpbmRleEZyb21FbmQgIT0gaW5kZXhGcm9tU3RhcnQgJiYgcmVjdHNbLS1p bmRleEZyb21FbmRdLnkoKSA9PSBsYXN0VG9wKQorICAgICAgICBsYXN0UmVjdC51bml0ZShyZWN0 c1tpbmRleEZyb21FbmRdKTsKKyAgICAKKyAgICBpZiAoaW5kZXhGcm9tRW5kID09IGluZGV4RnJv bVN0YXJ0KSB7CisgICAgICAgIC8vIEFsbCB0aGUgcmVjdHMgYXJlIG9uIHR3byBsaW5lcyBvbmx5 LiBUaGVyZSBpcyBub3RoaW5nIGVsc2UgdG8gZG8uCisgICAgICAgIG5ld1JlY3RzLmFwcGVuZChs YXN0UmVjdCk7CisgICAgICAgIHJlY3RzLnN3YXAobmV3UmVjdHMpOworICAgICAgICByZXR1cm47 CisgICAgfQorICAgIAorICAgIC8vIGluZGV4RnJvbVN0YXJ0IGlzIHRoZSBpbmRleCBvZiB0aGUg Zmlyc3QgcmVjdGFuZ2xlIG9uIHRoZSBzZWNvbmQgbGluZS4KKyAgICAvLyBpbmRleEZyb21FbmQg aXMgdGhlIGluZGV4IG9mIHRoZSBsYXN0IHJlY3RhbmdsZSBvbiB0aGUgc2VuZG9uIHRoZSBsYXN0 IGxpbmUuCisgICAgLy8gU3RpdGNoIHRvZ2V0aGVyIGFsbCB0aGUgcmVjdHMgYWZ0ZXIgdGhlIGZp cnN0IGxpbmUgdW50aWwgdGhlIHNlY29uZCB0byB0aGUgbGFzdCBpbmNsdWRlZC4KKyAgICBjdXJy ZW50UmVjdCA9IHJlY3RzW2luZGV4RnJvbVN0YXJ0XTsKKyAgICB3aGlsZSAoaW5kZXhGcm9tU3Rh cnQgIT0gaW5kZXhGcm9tRW5kKQorICAgICAgICBjdXJyZW50UmVjdC51bml0ZShyZWN0c1srK2lu ZGV4RnJvbVN0YXJ0XSk7CisgICAgCisgICAgbmV3UmVjdHMuYXBwZW5kKGN1cnJlbnRSZWN0KTsK KyAgICBuZXdSZWN0cy5hcHBlbmQobGFzdFJlY3QpOworCisgICAgcmVjdHMuc3dhcChuZXdSZWN0 cyk7Cit9CiAKK3N0YXRpYyB2b2lkIGNvbXBhY3RSZWN0c1dpdGhHYXBSZWN0cyhWZWN0b3I8TGF5 b3V0UmVjdD4mIHJlY3RzLCBjb25zdCBWZWN0b3I8R2FwUmVjdHM+JiBnYXBSZWN0cykKK3sKKyAg ICBzdGl0Y2hSZWN0cyhyZWN0cyk7CisgICAgCiAgICAgLy8gRklYTUU6IFRoZSBmb2xsb3dpbmcg YWxpZ25tZW50cyBhcmUgY29ycmVjdCBmb3IgTFRSIHRleHQuCiAgICAgLy8gV2Ugc2hvdWxkIGFs c28gYWNjb3VudCBmb3IgUlRMLgogICAgIHVpbnQ4X3QgYWxpZ25tZW50c1szXTsK