135770 2014-08-08 14:44:21 -0700 [CSS Grid Layout] Test coverage for first-line pseudo-element 2014-09-02 01:36:27 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 60731 1 rego rego commit-queue jfernandez svillar oldest_to_newest 1027955 0 rego 2014-08-08 14:44:21 -0700 According to the spec the ::first-line pseudo-element do not apply to grid containers: "the ::first-line and ::first-letter pseudo-elements do not apply to grid containers." I'll provide a patch to add coverage for ::first-line which is already working as expected. ::first-letter needs some changes in the code, so it'd be done in a separated patch. This has already landed in Blink: https://src.chromium.org/viewvc/blink?view=rev&revision=179640 1027958 1 236309 rego 2014-08-08 14:48:37 -0700 Created attachment 236309 Patch 1028836 2 236309 zoltan 2014-08-13 11:20:14 -0700 Comment on attachment 236309 Patch r=me 1032581 3 236309 commit-queue 2014-09-02 01:36:25 -0700 Comment on attachment 236309 Patch Clearing flags on attachment: 236309 Committed r173169: <http://trac.webkit.org/changeset/173169> 1032582 4 commit-queue 2014-09-02 01:36:27 -0700 All reviewed patches have been landed. Closing bug. 236309 2014-08-08 14:48:37 -0700 2014-09-02 01:36:24 -0700 Patch bug-135770-20140808234825.patch text/plain 5655 rego U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMTY3CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggMjU1OWFiMjdlYmYxMDU0NjViMTAz ZWEwZjFmZWU1Yzk3YTlhMDNiMi4uMzNhZTVjN2ZjNzEwZGRmMjUxZjU3YzIxM2I3YzVmMmI1OGI1 NTk3NiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE0LTA4LTA4ICBNYW51ZWwgUmVnbyBDYXNh c25vdmFzICA8cmVnb0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtDU1MgR3JpZCBMYXlvdXRdIFRl c3QgY292ZXJhZ2UgZm9yIGZpcnN0LWxpbmUgcHNldWRvLWVsZW1lbnQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTc3MAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFjY29yZGluZyB0byB0aGUgc3BlYyB0 aGUgOjpmaXJzdC1saW5lIHBzZXVkby1lbGVtZW50IGRvIG5vdCBhcHBseSB0bworICAgICAgICBn cmlkIGNvbnRhaW5lcnMuCisKKyAgICAgICAgVGhpcyB3YXMgYWxyZWFkeSB3b3JraW5nIGFzIGV4 cGVjdGVkIGJ1dCB3ZSB3ZXJlIG1pc3Npbmcgc29tZSB0ZXN0cworICAgICAgICBjaGVja2luZyBp dCwgc28gd2UgYXJlIGFkZGluZyBuZXcgdGVzdHMgdG8gaGF2ZSBjb3ZlcmFnZS4KKworICAgICAg ICAqIGZhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtY29udGFpbmVyLWlnbm9yZS1maXJzdC1saW5l LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3Jp ZC1jb250YWluZXItaWdub3JlLWZpcnN0LWxpbmUuaHRtbDogQWRkZWQuCisgICAgICAgICogZmFz dC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1pdGVtLWZpcnN0LWxpbmUtdmFsaWQtZXhwZWN0ZWQudHh0 OiBBZGRlZC4KKyAgICAgICAgKiBmYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWl0ZW0tZmlyc3Qt bGluZS12YWxpZC5odG1sOiBBZGRlZC4KKwogMjAxNC0wOC0wNiAgQnJlbnQgRnVsZ2hhbSAgPGJm dWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbTWFjXSBVbmFibGUgdG8gc2Nyb2xsIHRvIGJv dHRvbSBvZiBuZXN0ZWQgc2Nyb2xsYWJsZSBhcmVhcwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1jb250YWluZXItaWdub3JlLWZpcnN0LWxpbmUtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1jb250YWlu ZXItaWdub3JlLWZpcnN0LWxpbmUtZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0Cmlu ZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjZjNDZjMTNmMmI3 MTAwZDVmYzQyNmYxNDQ5MDg4NTQ5M2ZhMzQyYTQKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRU ZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNvbnRhaW5lci1pZ25vcmUtZmlyc3QtbGlu ZS1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwyMiBAQAorVGhpcyB0ZXN0IGdyaWQgaXRlbSBzaG91 bGQgaWdub3JlIGdyaWQgY29udGFpbmVyJ3MgZmlyc3QtbGluZSBwc2V1ZG8tZWxlbWVudC4KKwor VGhlIGZpcnN0IGl0ZW0uCitUaGUgc2Vjb25kIGl0ZW0uCitQQVNTCitUaGUgZmlyc3QgaXRlbS4K K1RoZSBzZWNvbmQgaXRlbS4KK1BBU1MKK0Fub255bW91cyBpdGVtLgorUEFTUworQW5vbnltb3Vz IGl0ZW0uCitQQVNTCitUaGUgZmlyc3QgaXRlbS4KK1RoZSBzZWNvbmQgaXRlbS4KK1BBU1MKK1Ro ZSBmaXJzdCBpdGVtLgorVGhlIHNlY29uZCBpdGVtLgorIFBBU1MKK0Fub255bW91cyBpdGVtLgor UEFTUworQW5vbnltb3VzIGl0ZW0uCitQQVNTCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy1ncmlkLWxheW91dC9ncmlkLWNvbnRhaW5lci1pZ25vcmUtZmlyc3QtbGluZS5odG1sIGIv TGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1sYXlvdXQvZ3JpZC1jb250YWluZXItaWdub3JlLWZp cnN0LWxpbmUuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi4wZDg0YTc4NGRjNmEwOTM0NGQ5NWMzOWUxZTU0ZTVm YjVmY2IzYmY3Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ3JpZC1s YXlvdXQvZ3JpZC1jb250YWluZXItaWdub3JlLWZpcnN0LWxpbmUuaHRtbApAQCAtMCwwICsxLDU5 IEBACis8IURPQ1RZUEUgaHRtbD4KKzxodG1sPgorPGxpbmsgaHJlZj0icmVzb3VyY2VzL2dyaWQu Y3NzIiByZWw9InN0eWxlc2hlZXQiPgorPHN0eWxlPgorICAgIGJvZHkgeyBsaW5lLWhlaWdodDog MjBweDsgfQorICAgIC5ncmlkLWZpcnN0LWxpbmU6OmZpcnN0LWxpbmUgeyBsaW5lLWhlaWdodDog MTAwcHg7IH0KKyAgICAuY29udGFpbmVyOjpmaXJzdC1saW5lIHsgbGluZS1oZWlnaHQ6IDIwMHB4 OyB9Cis8L3N0eWxlPgorCis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2NoZWNrLWxheW91 dC5qcyI+PC9zY3JpcHQ+Cis8Ym9keSBvbmxvYWQ9ImNoZWNrTGF5b3V0KCcuZ3JpZC1maXJzdC1s aW5lJyk7Ij4KKzxwPlRoaXMgdGVzdCBncmlkIGl0ZW0gc2hvdWxkIGlnbm9yZSBncmlkIGNvbnRh aW5lcidzIGZpcnN0LWxpbmUgcHNldWRvLWVsZW1lbnQuPC9wPgorCis8ZGl2IGNsYXNzPSJncmlk IGdyaWQtZmlyc3QtbGluZSI+CisgICAgPGRpdiBjbGFzcz0iaXRlbSIgZGF0YS1leHBlY3RlZC1o ZWlnaHQ9MjA+VGhlIGZpcnN0IGl0ZW0uPC9kaXY+CisgICAgPGRpdiBjbGFzcz0iaXRlbSIgZGF0 YS1leHBlY3RlZC1oZWlnaHQ9MjA+VGhlIHNlY29uZCBpdGVtLjwvZGl2PgorPC9kaXY+CisKKzxk aXYgY2xhc3M9ImlubGluZS1ncmlkIGdyaWQtZmlyc3QtbGluZSI+CisgICAgPGRpdiBjbGFzcz0i aXRlbSIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9MjA+VGhlIGZpcnN0IGl0ZW0uPC9kaXY+CisgICAg PGRpdiBjbGFzcz0iaXRlbSIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9MjA+VGhlIHNlY29uZCBpdGVt LjwvZGl2PgorPC9kaXY+CisKKzxkaXYgY2xhc3M9ImdyaWQgZ3JpZC1maXJzdC1saW5lIiBkYXRh LWV4cGVjdGVkLWhlaWdodD0yMD4KKyAgICBBbm9ueW1vdXMgaXRlbS4KKzwvZGl2PgorCis8ZGl2 IGNsYXNzPSJpbmxpbmUtZ3JpZCBncmlkLWZpcnN0LWxpbmUiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0 PTIwPgorICAgIEFub255bW91cyBpdGVtLgorPC9kaXY+CisKKzxkaXYgY2xhc3M9ImNvbnRhaW5l ciI+CisgICAgPGRpdiBjbGFzcz0iZ3JpZCBncmlkLWZpcnN0LWxpbmUiPgorICAgICAgICA8ZGl2 IGNsYXNzPSJpdGVtIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0yMD5UaGUgZmlyc3QgaXRlbS48L2Rp dj4KKyAgICAgICAgPGRpdiBjbGFzcz0iaXRlbSIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9MjA+VGhl IHNlY29uZCBpdGVtLjwvZGl2PgorICAgIDwvZGl2PgorPC9kaXY+CisKKzxkaXYgY2xhc3M9ImNv bnRhaW5lciI+CisgICAgPGRpdiBjbGFzcz0iaW5saW5lLWdyaWQgZ3JpZC1maXJzdC1saW5lIj4K KyAgICAgICAgPGRpdiBjbGFzcz0iaXRlbSIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9MjA+VGhlIGZp cnN0IGl0ZW0uPC9kaXY+CisgICAgICAgIDxkaXYgY2xhc3M9Iml0ZW0iIGRhdGEtZXhwZWN0ZWQt aGVpZ2h0PTIwPlRoZSBzZWNvbmQgaXRlbS48L2Rpdj4KKyAgICA8L2Rpdj4KKzwvZGl2PgorCis8 ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxkaXYgY2xhc3M9ImdyaWQgZ3JpZC1maXJzdC1s aW5lIiBkYXRhLWV4cGVjdGVkLWhlaWdodD0yMD4KKyAgICAgICAgQW5vbnltb3VzIGl0ZW0uCisg ICAgPC9kaXY+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKyAgICA8ZGl2IGNs YXNzPSJpbmxpbmUtZ3JpZCBncmlkLWZpcnN0LWxpbmUiIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0PTIw PgorICAgICAgICBBbm9ueW1vdXMgaXRlbS4KKyAgICA8L2Rpdj4KKzwvZGl2PgorCis8L2JvZHk+ Cis8L2h0bWw+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9n cmlkLWl0ZW0tZmlyc3QtbGluZS12YWxpZC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L2Nzcy1ncmlkLWxheW91dC9ncmlkLWl0ZW0tZmlyc3QtbGluZS12YWxpZC1leHBlY3RlZC50eHQK bmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMC4uMzkwZDNkNmVmNDg2YTExNjkzNzViOTY2YTU0N2E0NTc5MTFkZWRhZAotLS0g L2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdyaWQtbGF5b3V0L2dyaWQtaXRl bS1maXJzdC1saW5lLXZhbGlkLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDggQEAKK1RoaXMgdGVz dCBncmlkIGl0ZW0ncyBmaXJzdC1saW5lIHBzZXVkby1lbGVtZW50IHNob3VsZCBiZSB2YWxpZC4K KworVGhlIGZpcnN0IGl0ZW0uCitUaGUgc2Vjb25kIGl0ZW0uCitQQVNTCitUaGUgZmlyc3QgaXRl bS4KK1RoZSBzZWNvbmQgaXRlbS4KK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3Qv Y3NzLWdyaWQtbGF5b3V0L2dyaWQtaXRlbS1maXJzdC1saW5lLXZhbGlkLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWl0ZW0tZmlyc3QtbGluZS12YWxpZC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLmUxYzM2YzdjNWFhYTg4ZWI5NTc5MWUyZGY0ZjU1OWE3MjFhMDc1ZGMKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1ncmlkLWxheW91dC9ncmlkLWl0 ZW0tZmlyc3QtbGluZS12YWxpZC5odG1sCkBAIC0wLDAgKzEsMjMgQEAKKzwhRE9DVFlQRSBodG1s PgorPGh0bWw+Cis8bGluayBocmVmPSJyZXNvdXJjZXMvZ3JpZC5jc3MiIHJlbD0ic3R5bGVzaGVl dCI+Cis8c3R5bGU+CisgICAgLml0ZW06OmZpcnN0LWxpbmUgeyBsaW5lLWhlaWdodDogMTAwcHg7 IH0KKzwvc3R5bGU+CisKKzxzY3JpcHQgc3JjPSIuLi8uLi9yZXNvdXJjZXMvY2hlY2stbGF5b3V0 LmpzIj48L3NjcmlwdD4KKzxib2R5IG9ubG9hZD0iY2hlY2tMYXlvdXQoJy5ncmlkJyk7IGNoZWNr TGF5b3V0KCcuaW5saW5lLWdyaWQnKTsiPgorPHA+VGhpcyB0ZXN0IGdyaWQgaXRlbSdzIGZpcnN0 LWxpbmUgcHNldWRvLWVsZW1lbnQgc2hvdWxkIGJlIHZhbGlkLjwvcD4KKworPGRpdiBjbGFzcz0i Z3JpZCI+CisgICAgPGRpdiBjbGFzcz0iaXRlbSIgZGF0YS1leHBlY3RlZC1oZWlnaHQ9MTAwPlRo ZSBmaXJzdCBpdGVtLjwvZGl2PgorICAgIDxkaXYgY2xhc3M9Iml0ZW0iIGRhdGEtZXhwZWN0ZWQt aGVpZ2h0PTEwMD5UaGUgc2Vjb25kIGl0ZW0uPC9kaXY+Cis8L2Rpdj4KKworPGRpdiBjbGFzcz0i aW5saW5lLWdyaWQiPgorICAgIDxkaXYgY2xhc3M9Iml0ZW0iIGRhdGEtZXhwZWN0ZWQtaGVpZ2h0 PTEwMD5UaGUgZmlyc3QgaXRlbS48L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJpdGVtIiBkYXRhLWV4 cGVjdGVkLWhlaWdodD0xMDA+VGhlIHNlY29uZCBpdGVtLjwvZGl2PgorPC9kaXY+CisKKzwvYm9k eT4KKzwvaHRtbD4K