135765 2014-08-08 12:16:36 -0700 Clients that request the selection services menu after WebKit2 will get one with different metrics than otherwise 2014-08-08 16:16:22 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton beidson enrica oldest_to_newest 1027908 0 thorton 2014-08-08 12:16:36 -0700 The menu is cached between clients, but we make adjustments to it. We should copy it before adjusting. <rdar://problem/17962180> 1027916 1 236297 thorton 2014-08-08 12:38:16 -0700 Created attachment 236297 patch 1027989 2 thorton 2014-08-08 16:16:22 -0700 http://trac.webkit.org/changeset/172364 236297 2014-08-08 12:38:16 -0700 2014-08-08 15:16:55 -0700 patch copymenu.diff text/plain 2599 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA0NjViYmQ1Li4xZmUzOGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTgg QEAKIDIwMTQtMDgtMDggIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgogCisgICAgICAgIENsaWVudHMgdGhhdCByZXF1ZXN0IHRoZSBzZWxlY3Rpb24gc2VydmljZXMg bWVudSBhZnRlciBXZWJLaXQyIHdpbGwgZ2V0IG9uZSB3aXRoIGRpZmZlcmVudCBtZXRyaWNzIHRo YW4gb3RoZXJ3aXNlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzU3NjUKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3OTYyMTgwPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL21hYy9X ZWJDb250ZXh0TWVudVByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJDb250ZXh0TWVu dVByb3h5TWFjOjpzZXR1cFNlcnZpY2VzTWVudSk6CisgICAgICAgIFRoZSBtZW51IGlzIGNhY2hl ZCBiZXR3ZWVuIGNsaWVudHMsIGJ1dCB3ZSBtYWtlIGFkanVzdG1lbnRzIHRvIGl0LgorICAgICAg ICBXZSBzaG91bGQgY29weSBpdCBiZWZvcmUgYWRqdXN0aW5nLgorCisyMDE0LTA4LTA4ICBUaW1v dGh5IEhvcnRvbiAgPHRpbW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KKwogICAgICAgICBTZXJ2aWNl cyBvdmVybGF5IGRyb3Bkb3duIGlzIG9mdGVuIGluIHRoZSB3cm9uZyBwbGFjZSB3aXRoIHpvb21l ZCBwYWdlcyBvciBob3Jpem9udGFsIHNjcm9sbGluZwogICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NzU1CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8x NzkwNzc1Mj4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29u dGV4dE1lbnVQcm94eU1hYy5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvV2ViQ29u dGV4dE1lbnVQcm94eU1hYy5tbQppbmRleCBhMDc0NTIyLi5jYzVlODE0IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlNYWMubW0KKysr IGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1t CkBAIC0zNzAsNyArMzcwLDYgQEAgc3RhdGljIFZlY3RvcjxSZXRhaW5QdHI8TlNNZW51SXRlbT4+ IG5zTWVudUl0ZW1WZWN0b3IoY29uc3QgVmVjdG9yPFdlYkNvbnRleHRNZW4KIAogdm9pZCBXZWJD b250ZXh0TWVudVByb3h5TWFjOjpzZXR1cFNlcnZpY2VzTWVudShjb25zdCBDb250ZXh0TWVudUNv bnRleHREYXRhJiBjb250ZXh0KQogewotICAgIFJldGFpblB0cjxOU1NoYXJpbmdTZXJ2aWNlUGlj a2VyPiBwaWNrZXI7CiAgICAgYm9vbCBpbmNsdWRlRWRpdG9yU2VydmljZXMgPSBjb250ZXh0LmNv bnRyb2xsZWREYXRhSXNFZGl0YWJsZSgpOwogICAgIGJvb2wgaGFzQ29udHJvbGxlZEltYWdlID0g IWNvbnRleHQuY29udHJvbGxlZEltYWdlSGFuZGxlKCkuaXNOdWxsKCk7CiAgICAgTlNBcnJheSAq aXRlbXMgPSBuaWw7CkBAIC0zOTIsMTMgKzM5MSwxMyBAQCB2b2lkIFdlYkNvbnRleHRNZW51UHJv eHlNYWM6OnNldHVwU2VydmljZXNNZW51KGNvbnN0IENvbnRleHRNZW51Q29udGV4dERhdGEmIGNv bgogICAgICAgICByZXR1cm47CiAgICAgfQogCi0gICAgcGlja2VyID0gYWRvcHROUyhbW05TU2hh cmluZ1NlcnZpY2VQaWNrZXIgYWxsb2NdIGluaXRXaXRoSXRlbXM6aXRlbXNdKTsKKyAgICBSZXRh aW5QdHI8TlNTaGFyaW5nU2VydmljZVBpY2tlcj4gcGlja2VyID0gYWRvcHROUyhbW05TU2hhcmlu Z1NlcnZpY2VQaWNrZXIgYWxsb2NdIGluaXRXaXRoSXRlbXM6aXRlbXNdKTsKICAgICBbcGlja2Vy IHNldFN0eWxlOmhhc0NvbnRyb2xsZWRJbWFnZSA/IE5TU2hhcmluZ1NlcnZpY2VQaWNrZXJTdHls ZVJvbGxvdmVyIDogTlNTaGFyaW5nU2VydmljZVBpY2tlclN0eWxlVGV4dFNlbGVjdGlvbl07CiAg ICAgW3BpY2tlciBzZXREZWxlZ2F0ZTpbV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlIHNo YXJlZFNoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGVdXTsKICAgICBbW1dLU2hhcmluZ1NlcnZp Y2VQaWNrZXJEZWxlZ2F0ZSBzaGFyZWRTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlXSBzZXRQ aWNrZXI6cGlja2VyLmdldCgpXTsKICAgICBbW1dLU2hhcmluZ1NlcnZpY2VQaWNrZXJEZWxlZ2F0 ZSBzaGFyZWRTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlXSBzZXRJbmNsdWRlRWRpdG9yU2Vy dmljZXM6aW5jbHVkZUVkaXRvclNlcnZpY2VzXTsKIAotICAgIG1fc2VydmljZXNNZW51ID0gW3Bp Y2tlciBtZW51XTsKKyAgICBtX3NlcnZpY2VzTWVudSA9IGFkb3B0TlMoW1twaWNrZXIgbWVudV0g Y29weV0pOwogCiAgICAgaWYgKCFoYXNDb250cm9sbGVkSW1hZ2UpCiAgICAgICAgIFttX3NlcnZp Y2VzTWVudSBzZXRTaG93c1N0YXRlQ29sdW1uOllFU107Cg==