135755 2014-08-08 02:53:42 -0700 Services overlay dropdown is often in the wrong place with zoomed pages or horizontal scrolling 2014-08-08 09:23:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton beidson enrica oldest_to_newest 1027829 0 thorton 2014-08-08 02:53:42 -0700 DDHighlightCreateWithRectsInVisibleRectWithStyleAndDirection adjust the location of the button based on the visible rect, trying to keep the button visible. We're handing it the wrong visible rect, though, not taking scrolling into account. This leads to pages that scroll horizontally showing the button on the left even if there's space for it on the right, or sometimes not showing it at all. <rdar://problem/17907752> 1027831 1 236275 thorton 2014-08-08 02:56:03 -0700 Created attachment 236275 patch 1027857 2 thorton 2014-08-08 09:23:05 -0700 http://trac.webkit.org/changeset/172344 236275 2014-08-08 02:56:03 -0700 2014-08-08 07:30:10 -0700 patch button-side.diff text/plain 3466 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NDhiM2QwLi42ODExZGQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTQtMDgtMDggIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIFNlcnZpY2VzIG92ZXJsYXkgZHJvcGRvd24gaXMgb2Z0ZW4gaW4gdGhlIHdy b25nIHBsYWNlIHdpdGggem9vbWVkIHBhZ2VzIG9yIGhvcml6b250YWwgc2Nyb2xsaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3NTUKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzE3OTA3NzUyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092 ZXJsYXlDb250cm9sbGVyLm1tOgorICAgICAgICAoV2ViS2l0OjpTZXJ2aWNlc092ZXJsYXlDb250 cm9sbGVyOjplc3RhYmxpc2hIb3ZlcmVkVGVsZXBob25lSGlnaGxpZ2h0KToKKyAgICAgICAgKFdl YktpdDo6U2VydmljZXNPdmVybGF5Q29udHJvbGxlcjo6bWF5YmVDcmVhdGVTZWxlY3Rpb25IaWdo bGlnaHQpOgorICAgICAgICBEREhpZ2hsaWdodENyZWF0ZVdpdGhSZWN0c0luVmlzaWJsZVJlY3RX aXRoU3R5bGVBbmREaXJlY3Rpb24gYWRqdXN0cyB0aGUKKyAgICAgICAgbG9jYXRpb24gb2YgdGhl IGJ1dHRvbiBiYXNlZCBvbiB0aGUgdmlzaWJsZSByZWN0LCB0cnlpbmcgdG8ga2VlcCB0aGUgYnV0 dG9uIHZpc2libGUuCisKKyAgICAgICAgV2UncmUgaGFuZGluZyBpdCB0aGUgd3JvbmcgdmlzaWJs ZSByZWN0LCB0aG91Z2gsIG5vdCB0YWtpbmcgc2Nyb2xsaW5nIGludG8gYWNjb3VudC4KKworICAg ICAgICBUaGlzIGxlYWRzIHRvIHBhZ2VzIHRoYXQgc2Nyb2xsIGhvcml6b250YWxseSBzaG93aW5n IHRoZSBidXR0b24gb24gdGhlIGxlZnQKKyAgICAgICAgZXZlbiBpZiB0aGVyZSdzIHNwYWNlIGZv ciBpdCBvbiB0aGUgcmlnaHQsIG9yIHNvbWV0aW1lcyBub3Qgc2hvd2luZyBpdCBhdCBhbGwuCisK KyAgICAgICAgSW5zdGVhZCwgcHJvdmlkZSB0aGUgYWN0dWFsIG1haW4gRnJhbWVWaWV3IHZpc2li bGUgcmVjdDsgdGhlIHNhbWUgY29vcmRpbmF0ZQorICAgICAgICBzcGFjZSB0aGF0IHRoZSBoaWdo bGlnaHQgcmVjdHMgYXJlIHByb3ZpZGVkIGluLgorCiAyMDE0LTA4LTA3ICBUaW0gSG9ydG9uICA8 dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAgICAgICAgIFtTZXJ2aWNlcyB3aXRoIFVJXSBB Y3Rpb24gbWVudSBkb2VzIG5vdCBhcHBlYXIgaWYgc2VsZWN0aW9uIGluY2x1ZGVzIGJvdGggdGV4 dCBhbmQgYW4gaW1hZ2UKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvV2Vi UGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXQyL1dl YlByb2Nlc3MvV2ViUGFnZS9tYWMvU2VydmljZXNPdmVybGF5Q29udHJvbGxlci5tbQppbmRleCA3 OWIyMzcyLi4xYWJjYzM4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL1dl YlBhZ2UvbWFjL1NlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9TZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyLm1tCkBA IC00MzEsNyArNDMxLDcgQEAgdm9pZCBTZXJ2aWNlc092ZXJsYXlDb250cm9sbGVyOjplc3RhYmxp c2hIb3ZlcmVkVGVsZXBob25lSGlnaGxpZ2h0KGJvb2wmIG1vdXNlSXMKICAgICAgICAgICAgIHJl Y3Quc2V0TG9jYXRpb24obWFpbkZyYW1lVmlldy53aW5kb3dUb0NvbnRlbnRzKHZpZXdGb3JSYW5n ZS0+Y29udGVudHNUb1dpbmRvdyhyZWN0LmxvY2F0aW9uKCkpKSk7CiAKICAgICAgICAgICAgIENH UmVjdCBjZ1JlY3QgPSByZWN0OwotICAgICAgICAgICAgbV90ZWxlcGhvbmVOdW1iZXJIaWdobGln aHRzW2ldID0gYWRvcHRDRihEREhpZ2hsaWdodENyZWF0ZVdpdGhSZWN0c0luVmlzaWJsZVJlY3RX aXRoU3R5bGVBbmREaXJlY3Rpb24obnVsbHB0ciwgJmNnUmVjdCwgMSwgdmlld0ZvclJhbmdlLT5i b3VuZHNSZWN0KCksIERESGlnaGxpZ2h0T3V0bGluZVdpdGhBcnJvdywgWUVTLCBOU1dyaXRpbmdE aXJlY3Rpb25OYXR1cmFsLCBOTywgWUVTKSk7CisgICAgICAgICAgICBtX3RlbGVwaG9uZU51bWJl ckhpZ2hsaWdodHNbaV0gPSBhZG9wdENGKERESGlnaGxpZ2h0Q3JlYXRlV2l0aFJlY3RzSW5WaXNp YmxlUmVjdFdpdGhTdHlsZUFuZERpcmVjdGlvbihudWxscHRyLCAmY2dSZWN0LCAxLCBtYWluRnJh bWVWaWV3LnZpc2libGVDb250ZW50UmVjdCgpLCBEREhpZ2hsaWdodE91dGxpbmVXaXRoQXJyb3cs IFlFUywgTlNXcml0aW5nRGlyZWN0aW9uTmF0dXJhbCwgTk8sIFlFUykpOwogICAgICAgICB9CiAK ICAgICAgICAgaWYgKCFtb3VzZUlzT3ZlckhpZ2hsaWdodChtX3RlbGVwaG9uZU51bWJlckhpZ2hs aWdodHNbaV0uZ2V0KCksIG1vdXNlSXNPdmVyQnV0dG9uKSkKQEAgLTQ2MCw4ICs0NjAsOCBAQCB2 b2lkIFNlcnZpY2VzT3ZlcmxheUNvbnRyb2xsZXI6Om1heWJlQ3JlYXRlU2VsZWN0aW9uSGlnaGxp Z2h0KCkKICAgICAgICAgY2dSZWN0cy5hcHBlbmQoKENHUmVjdClwaXhlbFNuYXBwZWRJbnRSZWN0 KHJlY3QpKTsKIAogICAgIGlmICghY2dSZWN0cy5pc0VtcHR5KCkpIHsKLSAgICAgICAgQ0dSZWN0 IGJvdW5kcyA9IG1fd2ViUGFnZS0+Y29yZVBhZ2UoKS0+bWFpbkZyYW1lKCkudmlldygpLT5ib3Vu ZHNSZWN0KCk7Ci0gICAgICAgIG1fc2VsZWN0aW9uSGlnaGxpZ2h0ID0gYWRvcHRDRihEREhpZ2hs aWdodENyZWF0ZVdpdGhSZWN0c0luVmlzaWJsZVJlY3RXaXRoU3R5bGVBbmREaXJlY3Rpb24obnVs bHB0ciwgY2dSZWN0cy5iZWdpbigpLCBjZ1JlY3RzLnNpemUoKSwgYm91bmRzLCBEREhpZ2hsaWdo dE5vT3V0bGluZVdpdGhBcnJvdywgWUVTLCBOU1dyaXRpbmdEaXJlY3Rpb25OYXR1cmFsLCBOTywg WUVTKSk7CisgICAgICAgIENHUmVjdCB2aXNpYmxlUmVjdCA9IG1fd2ViUGFnZS0+Y29yZVBhZ2Uo KS0+bWFpbkZyYW1lKCkudmlldygpLT52aXNpYmxlQ29udGVudFJlY3QoKTsKKyAgICAgICAgbV9z ZWxlY3Rpb25IaWdobGlnaHQgPSBhZG9wdENGKERESGlnaGxpZ2h0Q3JlYXRlV2l0aFJlY3RzSW5W aXNpYmxlUmVjdFdpdGhTdHlsZUFuZERpcmVjdGlvbihudWxscHRyLCBjZ1JlY3RzLmJlZ2luKCks IGNnUmVjdHMuc2l6ZSgpLCB2aXNpYmxlUmVjdCwgRERIaWdobGlnaHROb091dGxpbmVXaXRoQXJy b3csIFlFUywgTlNXcml0aW5nRGlyZWN0aW9uTmF0dXJhbCwgTk8sIFlFUykpOwogCiAgICAgICAg IG1fc2VydmljZXNPdmVybGF5LT5zZXROZWVkc0Rpc3BsYXkoKTsKICAgICB9Cg==