<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>135754</bug_id>
          
          <creation_ts>2014-08-08 02:25:05 -0700</creation_ts>
          <short_desc>[GTK] Child processes should be installed in a versioned directory</short_desc>
          <delta_ts>2014-08-24 23:48:06 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKitGTK</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>Gtk</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Carlos Garcia Campos">cgarcia</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>berto</cc>
    
    <cc>bunhere</cc>
    
    <cc>commit-queue</cc>
    
    <cc>gyuyoung.kim</cc>
    
    <cc>rakuco</cc>
    
    <cc>sergio</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1027825</commentid>
    <comment_count>0</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-08-08 02:25:05 -0700</bug_when>
    <thetext>To make it possible to install 2.4 and 2.6 in parallel.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1027826</commentid>
    <comment_count>1</comment_count>
      <attachid>236273</attachid>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-08-08 02:28:21 -0700</bug_when>
    <thetext>Created attachment 236273
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1028082</commentid>
    <comment_count>2</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-08-10 00:10:16 -0700</bug_when>
    <thetext>Committed r172376: &lt;http://trac.webkit.org/changeset/172376&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1030004</commentid>
    <comment_count>3</comment_count>
    <who name="Alberto Garcia">berto</who>
    <bug_when>2014-08-19 04:45:23 -0700</bug_when>
    <thetext>I noticed we have a bit of a problem here, we are installing the
binaries in ${libexec}/webkitgtk-4.0/ (see LIBEXEC_INSTALL_DIR in
OptionsGTK.cmake) but we are also installing the injected bundle in
${libdir}/webkit2gtk-4.0/ (see PlatformGTK.cmake).

I suggest that we use webkit2gtk-4.0 in both cases.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1031041</commentid>
    <comment_count>4</comment_count>
    <who name="Carlos Garcia Campos">cgarcia</who>
    <bug_when>2014-08-24 23:48:06 -0700</bug_when>
    <thetext>(In reply to comment #3)
&gt; I noticed we have a bit of a problem here, we are installing the
&gt; binaries in ${libexec}/webkitgtk-4.0/ (see LIBEXEC_INSTALL_DIR in
&gt; OptionsGTK.cmake) but we are also installing the injected bundle in
&gt; ${libdir}/webkit2gtk-4.0/ (see PlatformGTK.cmake).
&gt; 
&gt; I suggest that we use webkit2gtk-4.0 in both cases.

You are right, if we use ${libexec}/webkitgtk-4.0/ we should probably add another directory ${libexec}/webkitgtk-4.0/webkit2 or something like that, similar to what we do for header files. But it&apos;s very unlikely that we add another wk API layer that has extensions and processes, so it&apos;s simpler to use webkit2gtk-4.0 directly. Please, file a new bug report for this.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>236273</attachid>
            <date>2014-08-08 02:28:21 -0700</date>
            <delta_ts>2014-08-08 11:23:34 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>wk2-libexec.diff</filename>
            <type>text/plain</type>
            <size>1798</size>
            <attacher name="Carlos Garcia Campos">cgarcia</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5M2M2YTcwLi43YzkzNzZh
IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK
KzIwMTQtMDgtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor
CisgICAgICAgIFtHVEtdIENoaWxkIHByb2Nlc3NlcyBzaG91bGQgYmUgaW5zdGFsbGVkIGluIGEg
dmVyc2lvbmVkIGRpcmVjdG9yeQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93
X2J1Zy5jZ2k/aWQ9MTM1NzU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku
CisKKyAgICAgICAgRGVmaW5lIExJQkVYRUNfSU5TVEFMTF9ESVIgYXMKKyAgICAgICAgJHtDTUFL
RV9JTlNUQUxMX0ZVTExfTElCRVhFQ0RJUn0vd2Via2l0Z3RrLSR7V0VCS0lUR1RLX0FQSV9WRVJT
SU9OfQorICAgICAgICBzbyB0aGF0IHRoZSBjaGlsZCBwcm9jZXNzZXMgYXJlIGluc3RhbGxlZCBp
biAkbGliZXhlYy93ZWJraXRndGstNC4wLgorICAgICAgICBUaGlzIG1ha2VzIGl0IHBvc3NpYmxl
IHRvIGluc3RhbGwgMi42IGluIHBhcmFsbGVsIHRvIG9sZGVyIHZlcnNpb25zLgorCisgICAgICAg
ICogU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisKIDIwMTQtMDgtMDcgIEJlbmphbWlu
IFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5jb20+CiAKICAgICAgICAgR2V0IHJpZCBvZiBJTlBV
VF9TUEVFQ0gKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlIGIvU291
cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKaW5kZXggNTA5MDFmZi4uZTU3YzYxNSAxMDA2NDQK
LS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09w
dGlvbnNHVEsuY21ha2UKQEAgLTIwLDcgKzIwLDcgQEAgc2V0KEVOQUJMRV9XQVlMQU5EX1RBUkdF
VCBPRkYgQ0FDSEUgQk9PTCAiV2hldGhlciB0byBlbmFibGUgc3VwcG9ydCBmb3IgdGhlIFdheWwK
ICMgQ01BS0VfSU5TVEFMTF8qIHZhcmlhYmxlcyB0aGF0IGFyZSBwb3B1bGF0ZWQgYnkgdGhlIEdO
VUluc3RhbGxEaXJzIG1hY3JvLgogc2V0KExJQl9JTlNUQUxMX0RJUiAiJHtDTUFLRV9JTlNUQUxM
X0ZVTExfTElCRElSfSIgQ0FDSEUgUEFUSCAiQWJzb2x1dGUgcGF0aCB0byBsaWJyYXJ5IGluc3Rh
bGxhdGlvbiBkaXJlY3RvcnkiKQogc2V0KEVYRUNfSU5TVEFMTF9ESVIgIiR7Q01BS0VfSU5TVEFM
TF9GVUxMX0JJTkRJUn0iIENBQ0hFIFBBVEggIkFic29sdXRlIHBhdGggdG8gZXhlY3V0YWJsZSBp
bnN0YWxsYXRpb24gZGlyZWN0b3J5IikKLXNldChMSUJFWEVDX0lOU1RBTExfRElSICIke0NNQUtF
X0lOU1RBTExfRlVMTF9MSUJFWEVDRElSfSIgQ0FDSEUgUEFUSCAiQWJzb2x1dGUgcGF0aCB0byBp
bnN0YWxsIGV4ZWN1dGFibGVzIGV4ZWN1dGVkIGJ5IHRoZSBsaWJyYXJ5IikKK3NldChMSUJFWEVD
X0lOU1RBTExfRElSICIke0NNQUtFX0lOU1RBTExfRlVMTF9MSUJFWEVDRElSfS93ZWJraXRndGst
JHtXRUJLSVRHVEtfQVBJX1ZFUlNJT059IiBDQUNIRSBQQVRIICJBYnNvbHV0ZSBwYXRoIHRvIGlu
c3RhbGwgZXhlY3V0YWJsZXMgZXhlY3V0ZWQgYnkgdGhlIGxpYnJhcnkiKQogCiBzZXQoREFUQV9C
VUlMRF9ESVIgIiR7Q01BS0VfQklOQVJZX0RJUn0vc2hhcmUvJHtXZWJLaXRfT1VUUFVUX05BTUV9
IikKIHNldChEQVRBX0lOU1RBTExfRElSICIke0NNQUtFX0lOU1RBTExfREFUQURJUn0vd2Via2l0
Z3RrLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfSIpCg==
</data>
<flag name="review"
          id="260872"
          type_id="1"
          status="+"
          setter="gustavo"
    />
          </attachment>
      

    </bug>

</bugzilla>