13575 2007-05-03 08:59:22 -0700 Change of default colors for CSS2.1 system colors 2007-07-17 01:29:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 523.x (Safari 3) Mac (Intel) OS X 10.4 RESOLVED FIXED http://fumle.dk/colortest.php P2 Normal --- 0 pm webkit-unassigned pgbakker oldest_to_newest 11404 0 pm 2007-05-03 08:59:22 -0700 This patch changes the hardcoded colors from the current values which cause color conflicts on Menu, Info and Highlight items, effectively making these items unreadable because background and text color are identical. While this patch does not implement the fetching of colors from the OS via AppKit or similar, it does provide some sane color values based partially on Aqua and adaption to how the system colors degrade relative to the main colors on MS Windows. A testcase is available at http://fumle.dk/colortest.php where the topmost link switches the styling between using system colors and a hardcoded scheme equal to the one submitted in this patch. The test tries to use all colors which have semantic bindings, like all shadows and highlights for ThreeDFace, Menu, Hightlight etc. This change will enable webdevelopers to use system colors and get an acceptable result for Safari without adding a browser specific stylesheet to their site or application. This fix relates partially to bug #6129, but deviates from the recommended colors in that testcase because the submitter apparently hadn't done any comparison on how the result in safari would compare to other browsers. 11405 1 14319 pm 2007-05-03 09:02:39 -0700 Created attachment 14319 CSS 2.1 System color correction patch 10741 2 14319 hyatt 2007-05-07 22:05:52 -0700 Comment on attachment 14319 CSS 2.1 System color correction patch Ultimately these should be implemented by the RenderTheme instead (system fonts are done through it, and system colors should be too). 10634 3 mrowe 2007-05-09 01:10:31 -0700 Landed in r21328. 14319 2007-05-03 09:02:39 -0700 2007-05-07 22:05:52 -0700 CSS 2.1 System color correction patch CSS21SystemColors.patch text/plain 3170 pm SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTIyNikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMDctMDUtMDMgIFBldGVyIE3DvGxsZXIgPHBtQG9uZS5jb20+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2hhbmdlZCB0 aGUgaGFyZGNvZGVkIGNvbG9ycyB0aGF0IGFyZSB1c2VkIGZvciBDU1MyLjEgc3lzdGVtIGNvbG9y cy4KKyAgICAgICAgUHJldmlvdXMgY29sb3JzIGhhZCBudW1lcm91cyBjb25mbGljdHMgaW4gc2Vt YW50aWMgcGFpcnMsIHdoaWNoCisgICAgICAgIG1hZGUgdGV4dCBpbnZpc2libGUgaW4gSGlnaGxp Z2h0LCBJbmZvIGFuZCBNZW51IGNvbG9yZWQgYXJlYXMuCisgICAgICAgIFRoZSBuZXcgaGFyZGNv ZGVkIGNvbG9ycyBhcmUgaW5zcGlyZWQgYnkgQXF1YS4KKworICAgICAgICBJZGVhbGx5IHRoZXNl IGNvbG9ycyBzaG91bGQgYmUgZmV0Y2hlZCB0aHJvdWdoIEFwcEtpdCBpbnN0ZWFkLAorICAgICAg ICB0aG91Z2ggSSBhbSBub3Qgc3VyZSBpZiBpdCBpcyBwb3NzaWJsZSB0byBtYWtlIGEgMToxIG1h cHBpbmcKKyAgICAgICAgYmV0d2VlbiBDU1MyLjEgc3lzdGVtIGNvbG9ycyBhbmQgT1NYLgorCisg ICAgICAgICogY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwOgorICAgICAgICAoV2ViQ29yZTo6KToK KwogMjAwNy0wNS0wMyAgTWFyayBSb3dlICA8bXJvd2VAYXBwbGUuY29tPgogCiAgICAgICAgIFF0 IGJ1aWxkIGZpeC4gIEluIHIyMTE4NSB0aGUgUXQgdmVyc2lvbiBvZiBXZWJDb3JlOjpzY2FsZURy YWdJbWFnZSB3YXMKSW5kZXg6IFdlYkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCShyZXZpc2lvbiAyMTIy NikKKysrIFdlYkNvcmUvY3NzL2Nzc3N0eWxlc2VsZWN0b3IuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC00ODA4LDMzICs0ODA4LDMzIEBAIHN0YXRpYyBjb25zdCBDb2xvclZhbHVlIGNvbG9yVmFsdWVz W10gPSAKICAgICB7IENTU19WQUxfWUVMTE9XLCAweEZGRkZGRjAwIH0sCiAgICAgeyBDU1NfVkFM X1RSQU5TUEFSRU5ULCAweDAwMDAwMDAwIH0sCiAgICAgeyBDU1NfVkFMX0dSRVksIDB4RkY4MDgw ODAgfSwKLSAgICB7IENTU19WQUxfQUNUSVZFQk9SREVSLCAweEZGRTBFMEUwIH0sCi0gICAgeyBD U1NfVkFMX0FDVElWRUNBUFRJT04sIDB4RkYwMDAwMDAgfSwKLSAgICB7IENTU19WQUxfQVBQV09S S1NQQUNFLCAweEZGMDAwMDAwIH0sCisgICAgeyBDU1NfVkFMX0FDVElWRUJPUkRFUiwgMHhGRkZG RkZGRiB9LAorICAgIHsgQ1NTX1ZBTF9BQ1RJVkVDQVBUSU9OLCAweEZGQ0NDQ0NDIH0sCisgICAg eyBDU1NfVkFMX0FQUFdPUktTUEFDRSwgMHhGRkZGRkZGRiB9LAogICAgIHsgQ1NTX1ZBTF9CVVRU T05GQUNFLCAweEZGQzBDMEMwIH0sCi0gICAgeyBDU1NfVkFMX0JVVFRPTkhJR0hMSUdIVCwgMHhG RkUwRTBFMCB9LAotICAgIHsgQ1NTX1ZBTF9CVVRUT05TSEFET1csIDB4RkZGRkZGRkYgfSwKKyAg ICB7IENTU19WQUxfQlVUVE9OSElHSExJR0hULCAweEZGREREREREIH0sCisgICAgeyBDU1NfVkFM X0JVVFRPTlNIQURPVywgMHhGRjg4ODg4OCB9LAogICAgIHsgQ1NTX1ZBTF9CVVRUT05URVhULCAw eEZGMDAwMDAwIH0sCiAgICAgeyBDU1NfVkFMX0NBUFRJT05URVhULCAweEZGMDAwMDAwIH0sCiAg ICAgeyBDU1NfVkFMX0dSQVlURVhULCAweEZGODA4MDgwIH0sCi0gICAgeyBDU1NfVkFMX0hJR0hM SUdIVCwgMHhGRkZGRkZGRiB9LAotICAgIHsgQ1NTX1ZBTF9ISUdITElHSFRURVhULCAweEZGRkZG RkZGIH0sCisgICAgeyBDU1NfVkFMX0hJR0hMSUdIVCwgMHhGRkI1RDVGRiB9LAorICAgIHsgQ1NT X1ZBTF9ISUdITElHSFRURVhULCAweEZGMDAwMDAwIH0sCiAgICAgeyBDU1NfVkFMX0lOQUNUSVZF Qk9SREVSLCAweEZGRkZGRkZGIH0sCiAgICAgeyBDU1NfVkFMX0lOQUNUSVZFQ0FQVElPTiwgMHhG RkZGRkZGRiB9LAotICAgIHsgQ1NTX1ZBTF9JTkFDVElWRUNBUFRJT05URVhULCAweEZGMDAwMDAw IH0sCi0gICAgeyBDU1NfVkFMX0lORk9CQUNLR1JPVU5ELCAweEZGMDAwMDAwIH0sCisgICAgeyBD U1NfVkFMX0lOQUNUSVZFQ0FQVElPTlRFWFQsIDB4RkY3RjdGN0YgfSwKKyAgICB7IENTU19WQUxf SU5GT0JBQ0tHUk9VTkQsIDB4RkZGQkZDQzUgfSwKICAgICB7IENTU19WQUxfSU5GT1RFWFQsIDB4 RkYwMDAwMDAgfSwKLSAgICB7IENTU19WQUxfTUVOVSwgMHhGRkZGRkZGRiB9LAotICAgIHsgQ1NT X1ZBTF9NRU5VVEVYVCwgMHhGRkZGRkZGRiB9LAorICAgIHsgQ1NTX1ZBTF9NRU5VLCAweEZGQzBD MEMwIH0sCisgICAgeyBDU1NfVkFMX01FTlVURVhULCAweEZGMDAwMDAwIH0sCiAgICAgeyBDU1Nf VkFMX1NDUk9MTEJBUiwgMHhGRkZGRkZGRiB9LAogICAgIHsgQ1NTX1ZBTF9URVhULCAweEZGMDAw MDAwIH0sCi0gICAgeyBDU1NfVkFMX1RIUkVFRERBUktTSEFET1csIDB4RkY0MDQwNDAgfSwKKyAg ICB7IENTU19WQUxfVEhSRUVEREFSS1NIQURPVywgMHhGRjY2NjY2NiB9LAogICAgIHsgQ1NTX1ZB TF9USFJFRURGQUNFLCAweEZGQzBDMEMwIH0sCi0gICAgeyBDU1NfVkFMX1RIUkVFREhJR0hMSUdI VCwgMHhGRkUwRTBFMCB9LAorICAgIHsgQ1NTX1ZBTF9USFJFRURISUdITElHSFQsIDB4RkZERERE REQgfSwKICAgICB7IENTU19WQUxfVEhSRUVETElHSFRTSEFET1csIDB4RkZDMEMwQzAgfSwKLSAg ICB7IENTU19WQUxfVEhSRUVEU0hBRE9XLCAweEZGRkZGRkZGIH0sCisgICAgeyBDU1NfVkFMX1RI UkVFRFNIQURPVywgMHhGRjg4ODg4OCB9LAogICAgIHsgQ1NTX1ZBTF9XSU5ET1csIDB4RkZGRkZG RkYgfSwKLSAgICB7IENTU19WQUxfV0lORE9XRlJBTUUsIDB4RkZGRkZGRkYgfSwKKyAgICB7IENT U19WQUxfV0lORE9XRlJBTUUsIDB4RkZDQ0NDQ0MgfSwKICAgICB7IENTU19WQUxfV0lORE9XVEVY VCwgMHhGRjAwMDAwMCB9LAogICAgIHsgMCwgMCB9CiB9Owo=