135749 2014-08-07 23:47:14 -0700 Web Inspector: TimelineManager should reuse empty recordings 2014-08-09 21:34:51 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg burg commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1027797 0 burg 2014-08-07 23:47:14 -0700 Right now if you do a reload with a fresh recording, it immediately starts recording into "Timeline Recording 2". This is dumb. Also sync the "empty" state to the clear records button. It currently becomes disabled only when viewing a read-only recording. 1027798 1 webkit-bug-importer 2014-08-07 23:47:47 -0700 <rdar://problem/17956575> 1028008 2 236324 burg 2014-08-08 16:50:02 -0700 Created attachment 236324 Patch 1028073 3 236324 commit-queue 2014-08-09 21:34:48 -0700 Comment on attachment 236324 Patch Clearing flags on attachment: 236324 Committed r172375: <http://trac.webkit.org/changeset/172375> 1028074 4 commit-queue 2014-08-09 21:34:51 -0700 All reviewed patches have been landed. Closing bug. 236324 2014-08-08 16:50:02 -0700 2014-08-09 21:34:48 -0700 Patch bug-135749-20140808165003.patch text/plain 2830 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMzU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBl ZWE0MmNiMjM3MGM2Y2E4MWMyNzMyMGI2ZTQ5NWEzNjNkODE2ZDZkLi5jNDAxODNmOGI4NjBjYTkx OTAwM2ZiZjVkZmZhY2U1ODk0YTJkNmU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyMCBAQAogMjAxNC0wOC0wOCAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rv bi5lZHU+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVGltZWxpbmVNYW5hZ2VyIHNob3VsZCBy ZXVzZSBlbXB0eSByZWNvcmRpbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzU3NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBDaGVjayB3aGV0aGVyIHRoZSByZWNvcmRpbmcgaXMgZW1wdHkgYmVmb3Jl IGNyZWF0aW5nIGEgbmV3IG9uZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQ29udHJvbGxl cnMvVGltZWxpbmVNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFu YWdlci5wcm90b3R5cGUuX2xvYWROZXdSZWNvcmRpbmcpOgorICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvTW9kZWxzL1RpbWVsaW5lUmVjb3JkaW5nLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlRp bWVsaW5lUmVjb3JkaW5nLnByb3RvdHlwZS5pc0VtcHR5KToKKyAgICAgICAgKFdlYkluc3BlY3Rv ci5UaW1lbGluZVJlY29yZGluZy5wcm90b3R5cGUudW5sb2FkZWQpOgorCisyMDE0LTA4LTA4ICBC cmlhbiBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KKwogICAgICAgICBXZWIgSW5z cGVjdG9yOiBhZGQgZGVidWdnaW5nIGZsYWcgdG8gSW5zcGVjdG9yVGVzdCBmb3IgdW5idWZmZXJl ZCBsb2dnaW5nIHRvIHN0ZGVycgogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM1NzI2CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcyBiL1NvdXJjZS9XZWJJ bnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1RpbWVsaW5lTWFuYWdlci5qcwpp bmRleCBhNzY1M2ZkZjI5MTZjOGE2NjIzMDkyODQ0ODQ2Mjg2OGEzM2VmMDQ1Li5lMmNkZDYzODU4 ZjVlMDYxOGI2NzIwNTJmMmQyYWUzOTdlNGQyMjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9UaW1lbGluZU1hbmFnZXIuanMKKysr IGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvVGltZWxp bmVNYW5hZ2VyLmpzCkBAIC0zOTgsNiArMzk4LDkgQEAgV2ViSW5zcGVjdG9yLlRpbWVsaW5lTWFu YWdlci5wcm90b3R5cGUgPSB7CiAKICAgICBfbG9hZE5ld1JlY29yZGluZzogZnVuY3Rpb24oKQog ICAgIHsKKyAgICAgICAgaWYgKHRoaXMuX2FjdGl2ZVJlY29yZGluZyAmJiB0aGlzLl9hY3RpdmVS ZWNvcmRpbmcuaXNFbXB0eSgpKQorICAgICAgICAgICAgcmV0dXJuOworCiAgICAgICAgIHZhciBp ZGVudGlmaWVyID0gdGhpcy5fbmV4dFJlY29yZGluZ0lkZW50aWZpZXIrKzsKICAgICAgICAgdmFy IG5ld1JlY29yZGluZyA9IG5ldyBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcoaWRlbnRp ZmllciwgV2ViSW5zcGVjdG9yLlVJU3RyaW5nKCJUaW1lbGluZSBSZWNvcmRpbmcgJWQiKS5mb3Jt YXQoaWRlbnRpZmllcikpOwogICAgICAgICB0aGlzLl9yZWNvcmRpbmdzLnB1c2gobmV3UmVjb3Jk aW5nKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL01v ZGVscy9UaW1lbGluZVJlY29yZGluZy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL01vZGVscy9UaW1lbGluZVJlY29yZGluZy5qcwppbmRleCAxNmQwYzBkNmIwNjQwYTI1 NWFhMDg5NWM4OGFkODZhYjY2MjZjMjJjLi5jZWU4MWU4MjlmZjgwMDIwY2MzMmY0ZWNhMGJiNDY0 M2JhYjlkZWY4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9Nb2RlbHMvVGltZWxpbmVSZWNvcmRpbmcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvTW9kZWxzL1RpbWVsaW5lUmVjb3JkaW5nLmpzCkBAIC05MCw4ICs5MCwy MCBAQCBXZWJJbnNwZWN0b3IuVGltZWxpbmVSZWNvcmRpbmcucHJvdG90eXBlID0gewogICAgICAg ICByZXR1cm4gdGhpcy5faXNXcml0YWJsZTsKICAgICB9LAogCisgICAgaXNFbXB0eTogZnVuY3Rp b24oKQorICAgIHsKKyAgICAgICAgZm9yICh2YXIgdGltZWxpbmUgb2YgdGhpcy5fdGltZWxpbmVz LnZhbHVlcygpKSB7CisgICAgICAgICAgICBpZiAodGltZWxpbmUucmVjb3Jkcy5sZW5ndGgpCisg ICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9CisKKyAgICAgICAgcmV0dXJu IHRydWU7CisgICAgfSwKKwogICAgIHVubG9hZGVkOiBmdW5jdGlvbigpCiAgICAgeworICAgICAg ICBjb25zb2xlLmFzc2VydCghdGhpcy5pc0VtcHR5KCksICJTaG91bGRuJ3QgdW5sb2FkIGFuIGVt cHR5IHJlY29yZGluZzsgaXQgc2hvdWxkIGJlIHJldXNlZCBpbnN0ZWFkLiIpOworCiAgICAgICAg IHRoaXMuX2lzV3JpdGFibGUgPSBmYWxzZTsKICAgICB9LAogCg==