135747 2014-08-07 23:20:04 -0700 Additional items added to selection services menus are misaligned 2014-08-08 09:20:08 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton beidson enrica oldest_to_newest 1027786 0 thorton 2014-08-07 23:20:04 -0700 They're a bit out of whack because we use the wrong style and because of some properties set on the menu at creation time. <rdar://problem/17933167> 1027787 1 236268 thorton 2014-08-07 23:21:01 -0700 Created attachment 236268 patch 1027856 2 thorton 2014-08-08 09:20:08 -0700 http://trac.webkit.org/changeset/172343 236268 2014-08-07 23:21:01 -0700 2014-08-08 07:29:40 -0700 patch services-alignment.diff text/plain 3268 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA1NDhiM2QwLi5jYTliOTg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEg QEAKKzIwMTQtMDgtMDcgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIEFkZGl0aW9uYWwgaXRlbXMgYWRkZWQgdG8gc2VsZWN0aW9uIHNlcnZpY2Vz IG1lbnVzIGFyZSBtaXNhbGlnbmVkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzU3NDcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE3OTMzMTY3Pgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9j ZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tOgorICAgICAgICAoV2ViS2l0OjpXZWJD b250ZXh0TWVudVByb3h5TWFjOjpzZXR1cFNlcnZpY2VzTWVudSk6CisgICAgICAgIFVzZSBOU1No YXJpbmdTZXJ2aWNlUGlja2VyU3R5bGVSb2xsb3ZlciBmb3IgdGhlIHJvbGxvdmVyIGltYWdlIHNl cnZpY2VzIG1lbnU7CisgICAgICAgIHVzZSBOU1NoYXJpbmdTZXJ2aWNlUGlja2VyU3R5bGVUZXh0 U2VsZWN0aW9uIGZvciB0aGUgc2VsZWN0aW9uIHNlcnZpY2VzIG1lbnUuCisKKyAgICAgICAgU2V0 IE5TTWVudSdzIHNob3dzU3RhdGVDb2x1bW4gdG8gWUVTIGZvciBzZWxlY3Rpb24gc2VydmljZXMg bWVudXMsIHNvIHRoYXQKKyAgICAgICAgb3RoZXIgaXRlbXMgYWRkZWQgdG8gdGhlIG1lbnUgbGlu ZSB1cCBjb3JyZWN0bHkuCisKKyAgICAgICAgUmVtb3ZlIGFuIHVubmNlc3NhcnkgLmdldCgpCisK IDIwMTQtMDgtMDcgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW1NlcnZpY2VzIHdpdGggVUldIEFjdGlvbiBtZW51IGRvZXMgbm90IGFwcGVhciBpZiBz ZWxlY3Rpb24gaW5jbHVkZXMgYm90aCB0ZXh0IGFuZCBhbiBpbWFnZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tIGIvU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9XZWJDb250ZXh0TWVudVByb3h5TWFjLm1tCmluZGV4 IDA5ZjVkMWYuLmEwNzQ1MjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9t YWMvV2ViQ29udGV4dE1lbnVQcm94eU1hYy5tbQorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1dlYkNvbnRleHRNZW51UHJveHlNYWMubW0KQEAgLTM3Miw4ICszNzIsOSBAQCB2b2lk IFdlYkNvbnRleHRNZW51UHJveHlNYWM6OnNldHVwU2VydmljZXNNZW51KGNvbnN0IENvbnRleHRN ZW51Q29udGV4dERhdGEmIGNvbgogewogICAgIFJldGFpblB0cjxOU1NoYXJpbmdTZXJ2aWNlUGlj a2VyPiBwaWNrZXI7CiAgICAgYm9vbCBpbmNsdWRlRWRpdG9yU2VydmljZXMgPSBjb250ZXh0LmNv bnRyb2xsZWREYXRhSXNFZGl0YWJsZSgpOworICAgIGJvb2wgaGFzQ29udHJvbGxlZEltYWdlID0g IWNvbnRleHQuY29udHJvbGxlZEltYWdlSGFuZGxlKCkuaXNOdWxsKCk7CiAgICAgTlNBcnJheSAq aXRlbXMgPSBuaWw7Ci0gICAgaWYgKCFjb250ZXh0LmNvbnRyb2xsZWRJbWFnZUhhbmRsZSgpLmlz TnVsbCgpKSB7CisgICAgaWYgKGhhc0NvbnRyb2xsZWRJbWFnZSkgewogICAgICAgICBSZWZQdHI8 U2hhcmVhYmxlQml0bWFwPiBpbWFnZSA9IFNoYXJlYWJsZUJpdG1hcDo6Y3JlYXRlKGNvbnRleHQu Y29udHJvbGxlZEltYWdlSGFuZGxlKCkpOwogICAgICAgICBpZiAoIWltYWdlKQogICAgICAgICAg ICAgcmV0dXJuOwpAQCAtMzkyLDIwICszOTMsMjMgQEAgdm9pZCBXZWJDb250ZXh0TWVudVByb3h5 TWFjOjpzZXR1cFNlcnZpY2VzTWVudShjb25zdCBDb250ZXh0TWVudUNvbnRleHREYXRhJiBjb24K ICAgICB9CiAKICAgICBwaWNrZXIgPSBhZG9wdE5TKFtbTlNTaGFyaW5nU2VydmljZVBpY2tlciBh bGxvY10gaW5pdFdpdGhJdGVtczppdGVtc10pOwotICAgIFtwaWNrZXIgc2V0U3R5bGU6TlNTaGFy aW5nU2VydmljZVBpY2tlclN0eWxlUm9sbG92ZXJdOworICAgIFtwaWNrZXIgc2V0U3R5bGU6aGFz Q29udHJvbGxlZEltYWdlID8gTlNTaGFyaW5nU2VydmljZVBpY2tlclN0eWxlUm9sbG92ZXIgOiBO U1NoYXJpbmdTZXJ2aWNlUGlja2VyU3R5bGVUZXh0U2VsZWN0aW9uXTsKICAgICBbcGlja2VyIHNl dERlbGVnYXRlOltXS1NoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGUgc2hhcmVkU2hhcmluZ1Nl cnZpY2VQaWNrZXJEZWxlZ2F0ZV1dOwogICAgIFtbV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVn YXRlIHNoYXJlZFNoYXJpbmdTZXJ2aWNlUGlja2VyRGVsZWdhdGVdIHNldFBpY2tlcjpwaWNrZXIu Z2V0KCldOwogICAgIFtbV0tTaGFyaW5nU2VydmljZVBpY2tlckRlbGVnYXRlIHNoYXJlZFNoYXJp bmdTZXJ2aWNlUGlja2VyRGVsZWdhdGVdIHNldEluY2x1ZGVFZGl0b3JTZXJ2aWNlczppbmNsdWRl RWRpdG9yU2VydmljZXNdOwogCiAgICAgbV9zZXJ2aWNlc01lbnUgPSBbcGlja2VyIG1lbnVdOwog CisgICAgaWYgKCFoYXNDb250cm9sbGVkSW1hZ2UpCisgICAgICAgIFttX3NlcnZpY2VzTWVudSBz ZXRTaG93c1N0YXRlQ29sdW1uOllFU107CisKICAgICAvLyBFeHBsaWNpdGx5IGFkZCBhIG1lbnUg aXRlbSBmb3IgZWFjaCB0ZWxlcGhvbmUgbnVtYmVyIHRoYXQgaXMgaW4gdGhlIHNlbGVjdGlvbi4K ICAgICBjb25zdCBWZWN0b3I8U3RyaW5nPiYgc2VsZWN0ZWRUZWxlcGhvbmVOdW1iZXJzID0gY29u dGV4dC5zZWxlY3RlZFRlbGVwaG9uZU51bWJlcnMoKTsKICAgICBpZiAoIXNlbGVjdGVkVGVsZXBo b25lTnVtYmVycy5pc0VtcHR5KCkpIHsKICAgICAgICAgW21fc2VydmljZXNNZW51LmdldCgpIGFk ZEl0ZW06W05TTWVudUl0ZW0gc2VwYXJhdG9ySXRlbV1dOwogICAgICAgICBmb3IgKGF1dG8mIHRl bGVwaG9uZU51bWJlciA6IHNlbGVjdGVkVGVsZXBob25lTnVtYmVycykgewogICAgICAgICAgICAg aWYgKE5TTWVudUl0ZW0gKml0ZW0gPSBtZW51SXRlbUZvclRlbGVwaG9uZU51bWJlcih0ZWxlcGhv bmVOdW1iZXIpKQotICAgICAgICAgICAgICAgIFttX3NlcnZpY2VzTWVudS5nZXQoKSBhZGRJdGVt Oml0ZW1dOworICAgICAgICAgICAgICAgIFttX3NlcnZpY2VzTWVudSBhZGRJdGVtOml0ZW1dOwog ICAgICAgICB9CiAgICAgfQogCg==