135745 2014-08-07 21:50:30 -0700 Web Inspector: breakpoints enabled state is not persisted across re-opening the inspector 2014-08-07 23:53:46 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1027771 0 burg 2014-08-07 21:50:30 -0700 My hunch is that we force this setting to be on when we restore breakpoints. In DebuggerManager.setBreakpoint, it unconditionally enables breakpoints when they are set, to avoid the situation where the user sets a breakpoint and nothing happens. However, in this case the user isn't doing anything, so no need to dummy-proof it. 1027772 1 webkit-bug-importer 2014-08-07 21:51:11 -0700 <rdar://problem/17955768> 1027774 2 joepeck 2014-08-07 21:55:49 -0700 * STEPS TO REPRODUCE 1. Open inspector 2. Disable breakpoints 3. Close Inspector 4. Open Inspector => breakpoints should be disabled, but they are enabled 1027778 3 236265 joepeck 2014-08-07 22:04:48 -0700 Created attachment 236265 [PATCH] Proposed Fix 1027803 4 236265 commit-queue 2014-08-07 23:53:44 -0700 Comment on attachment 236265 [PATCH] Proposed Fix Clearing flags on attachment: 236265 Committed r172333: <http://trac.webkit.org/changeset/172333> 1027804 5 commit-queue 2014-08-07 23:53:46 -0700 All reviewed patches have been landed. Closing bug. 236265 2014-08-07 22:04:48 -0700 2014-08-07 23:53:43 -0700 [PATCH] Proposed Fix initialization.patch text/plain 2442 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGQwYWQ4NWUuLjU4NWEyNGIgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE0LTA4LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogYnJlYWtw b2ludHMgZW5hYmxlZCBzdGF0ZSBpcyBub3QgcGVyc2lzdGVkIGFjcm9zcyByZS1vcGVuaW5nIHRo ZSBpbnNwZWN0b3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNTc0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdoZW4gcmVzdG9yaW5nIGJyZWFrcG9pbnRzIHdoZW4gdGhlIGluc3BlY3RvciBpcyBpbml0 aWFsaXppbmcsIGRvIG5vdAorICAgICAgICBsZXQgc2V0dGluZyB0aGVzZSBicmVha3BvaW50cyBh dXRvbWF0aWNhbGx5IGVuYWJsZSBicmVha3BvaW50cy4gV2Ugc2hvdWxkCisgICAgICAgIHJlc3Bl Y3QgdGhlIHNldHRpbmcgaW4gdGhpcyBjYXNlLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9D b250cm9sbGVycy9EZWJ1Z2dlck1hbmFnZXIuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRGVi dWdnZXJNYW5hZ2VyLnJlc3RvcmVCcmVha3BvaW50c1Nvb24pOgorICAgICAgICAoV2ViSW5zcGVj dG9yLkRlYnVnZ2VyTWFuYWdlcik6CisKKzIwMTQtMDgtMDcgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBGaXggYWNjaWRlbnRh bCBhbHdheXMgdHJ1ZSBjb21wYXJpc29uCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzU3NDEKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2VyLmpzIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQ29udHJvbGxlcnMvRGVidWdnZXJNYW5hZ2Vy LmpzCmluZGV4IDBhOTVjZTkuLmQyOWMzNzUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL0RlYnVnZ2VyTWFuYWdlci5qcworKysgYi9T b3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9sbGVycy9EZWJ1Z2dlck1h bmFnZXIuanMKQEAgLTY3LDggKzY3LDEwIEBAIFdlYkluc3BlY3Rvci5EZWJ1Z2dlck1hbmFnZXIg PSBmdW5jdGlvbigpCiAgICAgdGhpcy5fdXBkYXRlQnJlYWtPbkV4Y2VwdGlvbnNTdGF0ZSgpOwog CiAgICAgZnVuY3Rpb24gcmVzdG9yZUJyZWFrcG9pbnRzU29vbigpIHsKKyAgICAgICAgdGhpcy5f cmVzdG9yaW5nQnJlYWtwb2ludHMgPSB0cnVlOwogICAgICAgICBmb3IgKHZhciBjb29raWUgb2Yg dGhpcy5fYnJlYWtwb2ludHNTZXR0aW5nLnZhbHVlKQogICAgICAgICAgICAgdGhpcy5hZGRCcmVh a3BvaW50KG5ldyBXZWJJbnNwZWN0b3IuQnJlYWtwb2ludChjb29raWUpKTsKKyAgICAgICAgZGVs ZXRlIHRoaXMuX3Jlc3RvcmluZ0JyZWFrcG9pbnRzOwogICAgIH0KIAogICAgIC8vIEVuc3VyZSB0 aGF0IGFsbCBtYW5hZ2VycyBsZWFybiBhYm91dCByZXN0b3JlZCBicmVha3BvaW50cywKQEAgLTUy Myw5ICs1MjUsMTEgQEAgV2ViSW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5wcm90b3R5cGUgPSB7 CiAgICAgICAgIGlmIChicmVha3BvaW50LmlkZW50aWZpZXIgfHwgYnJlYWtwb2ludC5kaXNhYmxl ZCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICAvLyBFbmFibGUgYnJlYWtwb2ludHMg c2luY2UgYSBicmVha3BvaW50IGlzIGJlaW5nIHNldC4gVGhpcyBlbGltaW5hdGVzCi0gICAgICAg IC8vIGEgbXVsdGktc3RlcCBwcm9jZXNzIGZvciB0aGUgdXNlciB0aGF0IGNhbiBiZSBjb25mdXNp bmcuCi0gICAgICAgIHRoaXMuYnJlYWtwb2ludHNFbmFibGVkID0gdHJ1ZTsKKyAgICAgICAgaWYg KCF0aGlzLl9yZXN0b3JpbmdCcmVha3BvaW50cykgeworICAgICAgICAgICAgLy8gRW5hYmxlIGJy ZWFrcG9pbnRzIHNpbmNlIGEgYnJlYWtwb2ludCBpcyBiZWluZyBzZXQuIFRoaXMgZWxpbWluYXRl cworICAgICAgICAgICAgLy8gYSBtdWx0aS1zdGVwIHByb2Nlc3MgZm9yIHRoZSB1c2VyIHRoYXQg Y2FuIGJlIGNvbmZ1c2luZy4KKyAgICAgICAgICAgIHRoaXMuYnJlYWtwb2ludHNFbmFibGVkID0g dHJ1ZTsKKyAgICAgICAgfQogCiAgICAgICAgIGZ1bmN0aW9uIGRpZFNldEJyZWFrcG9pbnQoZXJy b3IsIGJyZWFrcG9pbnRJZGVudGlmaWVyLCBsb2NhdGlvbnMpCiAgICAgICAgIHsK