135742 2014-08-07 21:05:44 -0700 REGRESSION(r172094): timeline views are blank after reloading in some situations 2014-08-08 11:22:09 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg burg commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1027759 0 burg 2014-08-07 21:05:44 -0700 Per Joe: "1. Uncaught exception showTimelineViewForType called with an undefined type from restoreFromCookie. You mentioned this should fix that problem: - if (selectedTimelineViewIdentifier === WebInspector.TimelineSidebarPanel.OverviewTimelineIdentifierCookieValue) + if (!selectedTimelineViewIdentifier || selectedTimelineViewIdentifier === WebInspector.TimelineSidebarPanel.OverviewTimelineIdentifierCookieValue) 2. Timeline views showing up completely blank - reload a page with the inspector open => overview/specific views are blank - make new selections in the timeline => views are still blank - switch recordings => causes things to work, but you have to make a new time selection" 1027760 1 webkit-bug-importer 2014-08-07 21:05:55 -0700 <rdar://problem/17955556> 1027775 2 burg 2014-08-07 21:56:49 -0700 (1) is easy enough to fix. For me, (2) manifests as the overview being shown for timeline 1 when timeline 2 is recording, and clicking on the timeline tree elements shows timelines for timeline 1 instead of 2. So it seems that we are showing timeline 1 by mistake, possibly right after showing the intended timeline. Without a debugger I can't be sure, so I'll try adding some logging. 1027793 3 236270 burg 2014-08-07 23:41:37 -0700 Created attachment 236270 Patch 1027794 4 burg 2014-08-07 23:42:58 -0700 The patch fixes this issue, at least on my machine. Joe, let me know if you still run into the same problem. 1027809 5 236270 commit-queue 2014-08-08 00:06:10 -0700 Comment on attachment 236270 Patch Clearing flags on attachment: 236270 Committed r172337: <http://trac.webkit.org/changeset/172337> 1027810 6 commit-queue 2014-08-08 00:06:13 -0700 All reviewed patches have been landed. Closing bug. 1027890 7 joepeck 2014-08-08 11:20:11 -0700 This works better, but I'm seeing an uncaught exception and some other issues. I'll file bugs. file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Protocol/InspectorBackend.js:173:30: CONSOLE ERROR Uncaught exception in inspector page while dispatching callback for command Page.getResourceTree: TypeError: undefined is not a function (evaluating 'candidateObjectCookie.every(function valuesMatchForKey(key) { return candidateObjectCookie[key] === cookie[key]; })') file:///Users/pecoraro/Build/Release/WebInspectorUI.framework/Resources/Views/NavigationSidebarPanel.js:702:77: CONSOLE ERROR TypeError: undefined is not a function (evaluating 'candidateObjectCookie.every(function valuesMatchForKey(key) { return candidateObjectCookie[key] === cookie[key]; })') 1027891 8 joepeck 2014-08-08 11:22:09 -0700 I'm guessing this issue was just a typo: - return candidateCookieKeys.length && candidateObjectCookie.every(function valuesMatchForKey(key) { + return candidateCookieKeys.length && candidateCookieKeys.every(function valuesMatchForKey(key) { 236270 2014-08-07 23:41:37 -0700 2014-08-08 00:06:09 -0700 Patch bug-135742-20140807234051.patch text/plain 6228 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMzIyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBi ZDA4MzU5YjUzNGRkZjgwY2FlM2JlMmJiMmQxNzQyNWU1OWM2YjYwLi40NTk3ZDEzODMwMDk1ZjUy YmMzMDhmYzg0ZDhlMWYwZDhmMDViNGUxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwzMyBAQAorMjAxNC0wOC0wNyAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rv bi5lZHU+CisKKyAgICAgICAgUkVHUkVTU0lPTihyMTcyMDk0KTogdGltZWxpbmUgdmlld3MgYXJl IGJsYW5rIGFmdGVyIHJlbG9hZGluZyBpbiBzb21lIHNpdHVhdGlvbnMKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTc0MgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHJlc3MgdmFyaW91cyBidWdzIHRo YXQgY2F1c2UgdGhlIHdyb25nIHRpbWVsaW5lIGNvbnRlbnQgdmlld3MgdG8gYXBwZWFyIHdoZW4K KyAgICAgICAgc3RhcnRpbmcgYSByZWNvcmRpbmcgYnkgcmVsb2FkaW5nIHRoZSBpbnNwZWN0ZWQg cGFnZS4gRml4IG90aGVyIHNtYWxsIG92ZXJzaWdodHMKKyAgICAgICAgdGhhdCB3ZXJlIGVuY291 bnRlcmVkIGluIHRoZSBzaWRlYmFyLWJhc2VkIHZpZXcgc3RhdGUgcmVzdG9yYXRpb24gY29kZS4K KworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvTW9kZWxzL1RpbWVsaW5lUmVjb3JkaW5nLmpzOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lUmVjb3JkaW5nLnByb3RvdHlwZS5zYXZlSWRl bnRpdHlUb0Nvb2tpZSk6IEFkZCBhIGR1bW15IGltcGxlbWVudGF0aW9uLgorCisgICAgICAgICog VXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzOgorICAgICAgICAo V2ViSW5zcGVjdG9yLk5hdmlnYXRpb25TaWRlYmFyUGFuZWwucHJvdG90eXBlLnRyZWVFbGVtZW50 TWF0Y2hlc0Nvb2tpZSk6CisgICAgICAgIFRoaXMgY29kZSBlcnJvbmVvdXNseSBtYXRjaGVzIGFu eSB0cmVlIGVsZW1lbnQgd2hvc2UgcmVwcmVzZW50ZWQgb2JqZWN0J3MKKyAgICAgICAgc2F2ZUlk ZW50aXR5VG9Db29raWUgZnVuY3Rpb24gcHJvZHVjZXMgYW4gZW1wdHkgY29va2llLgorCisgICAg ICAgICogVXNlckludGVyZmFjZS9WaWV3cy9UaW1lbGluZUNvbnRlbnRWaWV3LmpzOgorICAgICAg ICAoV2ViSW5zcGVjdG9yLlRpbWVsaW5lQ29udGVudFZpZXcucHJvdG90eXBlLl9zaG93VGltZWxp bmVWaWV3KTogQWRkIGFuIGFzc2VydGlvbgorICAgICAgICB0aGF0IHdpbGwgZmluZCBtaXNtYXRj aGVzIGJldHdlZW4gcmVwcmVzZW50ZWQgb2JqZWN0cyBvZiB0aGUgVGltZWxpbmVDb250ZW50Vmll dworICAgICAgICBhbmQgVGltZWxpbmVWaWV3cy4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVGlt ZWxpbmVTaWRlYmFyUGFuZWwucHJvdG90eXBlLnJlc3RvcmVTdGF0ZUZyb21Db29raWUpOiBEb24n dCBjYWxsCisgICAgICAgIHRoZSBzdXBlcmNsYXNzJ3MgaW1wbGVtZW50YXRpb24sIHNpbmNlIHdl IGRvIG5vdCB3YW50IHRvIHBlcmZvcm0gYSByZWxheGVkIG1hdGNoCisgICAgICAgIGFnYWluc3Qg YW55IG9mIG91ciB0cmVlIGVsZW1lbnRzLiBUaGUgb25seSB0aGluZyB0aGF0IGNhbiBiZSByZXN0 b3JlZCBhY3Jvc3MgcmVvcGVuCisgICAgICAgIGlzIGEgc2VsZWN0ZWQgdGltZWxpbmUgdHJlZSBl bGVtZW50LCB3aGljaCBpcyBhbHJlYWR5IGhhbmRsZWQgYnkgdGhpcyBvdmVycmlkZS4KKwogMjAx NC0wOC0wNyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5jb20+CiAKICAgICAgICAg Rml4IHJlZ3Jlc3Npb24gd2hlcmUgdHJlZSBvdXRsaW5lIGtleWJvYXJkIG5hdmlnYXRpb24gaXMg YnJva2VuLgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv TW9kZWxzL1RpbWVsaW5lUmVjb3JkaW5nLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvTW9kZWxzL1RpbWVsaW5lUmVjb3JkaW5nLmpzCmluZGV4IDE5ZWU0MTk0NmI4ZTQ5 ZTlmMmIyYWIzYWUyNDQzMjE3OWQyMjJiNTMuLjE2ZDBjMGQ2YjA2NDBhMjU1YWEwODk1Yzg4YWQ4 NmFiNjYyNmMyMmMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL01vZGVscy9UaW1lbGluZVJlY29yZGluZy5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvVXNlckludGVyZmFjZS9Nb2RlbHMvVGltZWxpbmVSZWNvcmRpbmcuanMKQEAgLTc5LDYgKzc5 LDEyIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVJlY29yZGluZy5wcm90b3R5cGUgPSB7CiAgICAg ICAgIHJldHVybiB0aGlzLl9lbmRUaW1lOwogICAgIH0sCiAKKyAgICBzYXZlSWRlbnRpdHlUb0Nv b2tpZTogZnVuY3Rpb24oKQorICAgIHsKKyAgICAgICAgLy8gRG8gbm90aGluZy4gVGltZWxpbmUg cmVjb3JkaW5ncyBhcmUgbm90IHBlcnNpc3RlZCB3aGVuIHRoZSBpbnNwZWN0b3IgaXMKKyAgICAg ICAgLy8gcmUtb3BlbmVkLCBzbyBkbyBub3QgYXR0ZW1wdCB0byByZXN0b3JlIGJ5IGlkZW50aWZp ZXIgb3IgZGlzcGxheSBuYW1lLgorICAgIH0sCisKICAgICBpc1dyaXRhYmxlOiBmdW5jdGlvbigp CiAgICAgewogICAgICAgICByZXR1cm4gdGhpcy5faXNXcml0YWJsZTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFy UGFuZWwuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9OYXZp Z2F0aW9uU2lkZWJhclBhbmVsLmpzCmluZGV4IGQ5ZTgxNWZhMjgzMjk4NDg5ODEwOTJiZGZmN2U2 Zjc1YWY3YWExYjEuLjQzZDUwOTI3NTQ4ZDdlNTk5ODI2ZjQ0NjJkN2IxNTY3OGEyNDIzYmMgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmln YXRpb25TaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcwpAQCAtNjk4LDcgKzY5OCw4IEBA IFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIGlmIChyZXByZXNlbnRlZE9iamVjdC5zYXZlSWRlbnRpdHlUb0Nvb2tpZSkKICAgICAg ICAgICAgICAgICByZXByZXNlbnRlZE9iamVjdC5zYXZlSWRlbnRpdHlUb0Nvb2tpZShjYW5kaWRh dGVPYmplY3RDb29raWUpOwogCi0gICAgICAgICAgICByZXR1cm4gT2JqZWN0LmtleXMoY2FuZGlk YXRlT2JqZWN0Q29va2llKS5ldmVyeShmdW5jdGlvbiB2YWx1ZXNNYXRjaEZvcktleShrZXkpIHsK KyAgICAgICAgICAgIHZhciBjYW5kaWRhdGVDb29raWVLZXlzID0gT2JqZWN0LmtleXMoY2FuZGlk YXRlT2JqZWN0Q29va2llKTsKKyAgICAgICAgICAgIHJldHVybiBjYW5kaWRhdGVDb29raWVLZXlz Lmxlbmd0aCAmJiBjYW5kaWRhdGVPYmplY3RDb29raWUuZXZlcnkoZnVuY3Rpb24gdmFsdWVzTWF0 Y2hGb3JLZXkoa2V5KSB7CiAgICAgICAgICAgICAgICAgcmV0dXJuIGNhbmRpZGF0ZU9iamVjdENv b2tpZVtrZXldID09PSBjb29raWVba2V5XTsKICAgICAgICAgICAgIH0pOwogICAgICAgICB9CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9UaW1l bGluZUNvbnRlbnRWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvVGltZWxpbmVDb250ZW50Vmlldy5qcwppbmRleCBiM2I2N2VmMWNiOWNmNTYxNzJjODhm YjBlMjBkZTQ1Zjk5MmRhNjg2Li40YjE3YmZjNDdkNTVhOTU0ZjEyNzBhN2MwYWRmN2I3ZjRiODc4 ZjczIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3 cy9UaW1lbGluZUNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lQ29udGVudFZpZXcuanMKQEAgLTI3NSw2ICsyNzUsNyBA QCBXZWJJbnNwZWN0b3IuVGltZWxpbmVDb250ZW50Vmlldy5wcm90b3R5cGUgPSB7CiAgICAgX3No b3dUaW1lbGluZVZpZXc6IGZ1bmN0aW9uKHRpbWVsaW5lVmlldykKICAgICB7CiAgICAgICAgIGNv bnNvbGUuYXNzZXJ0KHRpbWVsaW5lVmlldyBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5UaW1lbGlu ZVZpZXcpOworICAgICAgICBjb25zb2xlLmFzc2VydCh0aW1lbGluZVZpZXcucmVwcmVzZW50ZWRP YmplY3QgPT09IHRoaXMuX3JlY29yZGluZyB8fCB0aGlzLl9yZWNvcmRpbmcudGltZWxpbmVzLmhh cyh0aW1lbGluZVZpZXcucmVwcmVzZW50ZWRPYmplY3QudHlwZSkpOwogCiAgICAgICAgIC8vIElm IHRoZSBjb250ZW50IHZpZXcgaXMgc2hvd24gYW5kIHRoZW4gaGlkZGVuLCB3ZSBtdXN0IHJlYXR0 YWNoIHRoZSBjb250ZW50IHRyZWUgb3V0bGluZSBhbmQgdGltZWxpbmUgdmlldy4KICAgICAgICAg aWYgKHRpbWVsaW5lVmlldy52aXNpYmxlICYmIHRpbWVsaW5lVmlldyA9PT0gdGhpcy5fY3VycmVu dFRpbWVsaW5lVmlldykKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL1RpbWVsaW5lU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKaW5kZXggZGJh ZGRmM2IwNmZjZDMxNzFlMGUzZmFmODVlN2FkMTI5Y2ViMDEwYS4uNGExZjRmNjM1NDAyOTFhZGZm MDI0ZGQ1YTU4NDc3NGI5YmNmMTFlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvVGltZWxpbmVTaWRlYmFyUGFuZWwu anMKQEAgLTMzNywxMiArMzM3LDEzIEBAIFdlYkluc3BlY3Rvci5UaW1lbGluZVNpZGViYXJQYW5l bC5wcm90b3R5cGUgPSB7CiAgICAgICAgIHRoaXMuX3Jlc3RvcmVkU2hvd2luZ1RpbWVsaW5lQ29u dGVudFZpZXcgPSBjb29raWVbV2ViSW5zcGVjdG9yLlRpbWVsaW5lU2lkZWJhclBhbmVsLlNob3dp bmdUaW1lbGluZUNvbnRlbnRWaWV3Q29va2llS2V5XTsKIAogICAgICAgICB2YXIgc2VsZWN0ZWRU aW1lbGluZVZpZXdJZGVudGlmaWVyID0gY29va2llW1dlYkluc3BlY3Rvci5UaW1lbGluZVNpZGVi YXJQYW5lbC5TZWxlY3RlZFRpbWVsaW5lVmlld0lkZW50aWZpZXJDb29raWVLZXldOwotICAgICAg ICBpZiAoc2VsZWN0ZWRUaW1lbGluZVZpZXdJZGVudGlmaWVyID09PSBXZWJJbnNwZWN0b3IuVGlt ZWxpbmVTaWRlYmFyUGFuZWwuT3ZlcnZpZXdUaW1lbGluZUlkZW50aWZpZXJDb29raWVWYWx1ZSkK KyAgICAgICAgaWYgKCFzZWxlY3RlZFRpbWVsaW5lVmlld0lkZW50aWZpZXIgfHwgc2VsZWN0ZWRU aW1lbGluZVZpZXdJZGVudGlmaWVyID09PSBXZWJJbnNwZWN0b3IuVGltZWxpbmVTaWRlYmFyUGFu ZWwuT3ZlcnZpZXdUaW1lbGluZUlkZW50aWZpZXJDb29raWVWYWx1ZSkKICAgICAgICAgICAgIHRo aXMuc2hvd1RpbWVsaW5lT3ZlcnZpZXcoKTsKICAgICAgICAgZWxzZQogICAgICAgICAgICAgdGhp cy5zaG93VGltZWxpbmVWaWV3Rm9yVHlwZShzZWxlY3RlZFRpbWVsaW5lVmlld0lkZW50aWZpZXIp OwogCi0gICAgICAgIFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3RvdHlw ZS5yZXN0b3JlU3RhdGVGcm9tQ29va2llLmNhbGwodGhpcywgY29va2llLCByZWxheGVkTWF0Y2hE ZWxheSk7CisgICAgICAgIC8vIERvbid0IGNhbGwgTmF2aWdhdGlvblNpZGViYXJQYW5lbC5yZXN0 b3JlU3RhdGVGcm9tQ29va2llLCBiZWNhdXNlIGl0IHRyaWVzIHRvIG1hdGNoIGJhc2VkCisgICAg ICAgIC8vIG9uIHR5cGUgb25seSBhcyBhIGxhc3QgcmVzb3J0LiBUaGlzIHdvdWxkIGNhdXNlIHRo ZSBmaXJzdCByZWNvcmRpbmcgdG8gYmUgcmVzZWxlY3RlZCBvbiByZWxvYWQuCiAgICAgfSwKIAog ICAgIC8vIFByaXZhdGUK