135741 2014-08-07 20:57:40 -0700 Web Inspector: Fix accidental always true comparison 2014-08-07 23:57:51 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1027754 0 joepeck 2014-08-07 20:57:40 -0700 * SUMMARY There is what looks like a typo in a comparison in OverviewTimelineView.js. > if (!this.currentTime !== oldCurrentTime) { > ^ -- why? This looks like an accident causing the comparison to always be false. Removing it, things still behave as expected. I know of no user impact from this change. Possible performance improvement? 1027755 1 webkit-bug-importer 2014-08-07 20:57:49 -0700 <rdar://problem/17955491> 1027757 2 joepeck 2014-08-07 20:58:55 -0700 Err, this would cause the comparison to always be true* 1027758 3 236261 joepeck 2014-08-07 21:00:17 -0700 Created attachment 236261 [PATCH] Proposed Fix 1027788 4 236261 timothy 2014-08-07 23:23:37 -0700 Comment on attachment 236261 [PATCH] Proposed Fix Did my TreeOutline fix inspire you to search for this needle in a haystack? 1027789 5 timothy 2014-08-07 23:24:45 -0700 Yes, this would be a performance improvement. 1027807 6 236261 commit-queue 2014-08-07 23:57:49 -0700 Comment on attachment 236261 [PATCH] Proposed Fix Clearing flags on attachment: 236261 Committed r172336: <http://trac.webkit.org/changeset/172336> 1027808 7 commit-queue 2014-08-07 23:57:51 -0700 All reviewed patches have been landed. Closing bug. 236261 2014-08-07 21:00:17 -0700 2014-08-07 23:57:48 -0700 [PATCH] Proposed Fix accident.patch text/plain 1514 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGYyMWE5ZjguLmQwYWQ4NWUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE0LTA4LTA3ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRml4IGFj Y2lkZW50YWwgYWx3YXlzIHRydWUgY29tcGFyaXNvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NzQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgUmVtb3ZlIGFjY2lkZW50YWwgIiEiIHRoYXQgd291bGQg YWx3YXlzIGNhdXNlIHRoaXMgY29tcGFyaXNvbiB0byBzdWNjZWVkLgorCisgICAgICAgICogVXNl ckludGVyZmFjZS9WaWV3cy9PdmVydmlld1RpbWVsaW5lVmlldy5qczoKKyAgICAgICAgKFdlYklu c3BlY3Rvci5PdmVydmlld1RpbWVsaW5lVmlldy5wcm90b3R5cGUudXBkYXRlTGF5b3V0KToKKwor MjAxNC0wOC0wNyAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCiAgICAg ICAgIFdlYiBJbnNwZWN0b3I6IFRpbWVsaW5lIEZpbHRlciBCYXJzIGFyZSBub3QgYXBwZWFyaW5n IGF0IGFsbAogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM1NzQwCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL092ZXJ2aWV3VGltZWxpbmVWaWV3LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1Vz ZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanMKaW5kZXggMGI3M2ZlYi4u YmI4ZDRkNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvT3ZlcnZpZXdUaW1lbGluZVZpZXcuanMKQEAgLTEwNSw3ICsx MDUsNyBAQCBXZWJJbnNwZWN0b3IuT3ZlcnZpZXdUaW1lbGluZVZpZXcucHJvdG90eXBlID0gewog ICAgICAgICAgICAgfQogICAgICAgICB9CiAKLSAgICAgICAgaWYgKCF0aGlzLmN1cnJlbnRUaW1l ICE9PSBvbGRDdXJyZW50VGltZSkgeworICAgICAgICBpZiAodGhpcy5jdXJyZW50VGltZSAhPT0g b2xkQ3VycmVudFRpbWUpIHsKICAgICAgICAgICAgIHZhciBzZWxlY3RlZFRyZWVFbGVtZW50ID0g dGhpcy5uYXZpZ2F0aW9uU2lkZWJhclRyZWVPdXRsaW5lLnNlbGVjdGVkVHJlZUVsZW1lbnQ7CiAg ICAgICAgICAgICB2YXIgc2VsZWN0aW9uV2FzSGlkZGVuID0gc2VsZWN0ZWRUcmVlRWxlbWVudCAm JiBzZWxlY3RlZFRyZWVFbGVtZW50LmhpZGRlbjsKIAo=