135736 2014-08-07 17:03:55 -0700 HTML <sub> and <sup> elements do not work in some 64-bit builds 2014-08-18 11:20:09 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 simon.fraser simon.fraser commit-queue esprehn+autocc glenn jonlee kondapallykalyan mmaxfield simon.fraser thorton webkit-bug-importer zalan oldest_to_newest 1027700 0 simon.fraser 2014-08-07 17:03:55 -0700 HTML <sub> and <sup> elements do not work in some 64-bit builds 1027706 1 236244 simon.fraser 2014-08-07 17:11:48 -0700 Created attachment 236244 Patch 1027707 2 236244 thorton 2014-08-07 17:15:04 -0700 Comment on attachment 236244 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236244&action=review > Source/WebCore/rendering/VerticalPositionCache.h:36 > // Values for vertical alignment. does this comment still belong? 1027711 3 236244 zalan 2014-08-07 17:28:21 -0700 Comment on attachment 236244 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236244&action=review > Source/WebCore/rendering/RootInlineBox.cpp:942 > // Check the cache. > bool isRenderInline = renderer->isRenderInline(); > if (isRenderInline && !firstLine) { > - LayoutUnit verticalPosition = verticalPositionCache.get(renderer, baselineType()); > - if (verticalPosition != PositionUndefined) > - return verticalPosition; > + LayoutUnit cachedPosition; > + if (verticalPositionCache.get(renderer, baselineType(), cachedPosition)) > + return cachedPosition; > } > > LayoutUnit verticalPosition = 0; RootInlineBox::verticalPositionForBox is broken in so many different ways. :( 1027714 4 simon.fraser 2014-08-07 17:36:23 -0700 https://trac.webkit.org/r172317 1029807 5 jonlee 2014-08-18 11:20:09 -0700 <rdar://problem/17220564> 236244 2014-08-07 17:11:48 -0700 2014-08-07 17:28:21 -0700 Patch bug-135736-20140807171135.patch text/plain 4782 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMTk5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOTZkMzU5OWM5M2RmNzhl NjIzZmQwMDc1NWVhMDIzMTQ3MzkyMWY1NS4uYmYxZmYxN2JkOGVlY2M5MjYyMzc5Mzk0NmEwMzNk ODViYzk4ODJkZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMzIEBACisyMDE0LTA4LTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEhUTUwgPHN1Yj4g YW5kIDxzdXA+IGVsZW1lbnRzIGRvIG5vdCB3b3JrIGluIHNvbWUgNjQtYml0IGJ1aWxkcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NzM2CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBSb290 SW5saW5lQm94Ojp2ZXJ0aWNhbFBvc2l0aW9uRm9yQm94KCkgaGFkIHNvbWUgaW1wbGljaXQgY29u dmVyc2lvbnMgYmV0d2VlbgorICAgICAgICBMYXlvdXRVbml0IGFuZCBpbnQgdGhhdCBjYXVzZWQg b3ZlcmZsb3csIGFuZCByZXN1bHRlZCBpbiBkaWZmZXJlbnQgY29tcGFyaXNvbgorICAgICAgICBi ZWhhdmlvciB3aXRoIGFuIGludCBjb25zdGFudCBpbiBkaWZmZXJlbnQgYXJjaGl0ZWN0dXJlcywg c2luY2Ugb3ZlcmZsb3cgYmVoYXZpb3IKKyAgICAgICAgaXMgdW5kZWZpbmVkLgorICAgICAgICAK KyAgICAgICAgU3BlY2lmaWNhbGx5LCBWZXJ0aWNhbFBvc2l0aW9uQ2FjaGUgd2FzIHdyaXR0ZW4g aW4gdGVybXMgb2YgaW50cyB3aXRoIGEgc3BlY2lhbAorICAgICAgICAweDgwMDAwMDAwICJub3Qg Zm91bmQiIHZhbHVlLiBIb3dldmVyLCAweDgwMDAwMDAwIHdhcyBiZWluZyBhc3NpZ25lZCB0bwor ICAgICAgICBhIExheW91dFVuaXQsIHdoaWNoIG11bHRpcGxpZXMgYnkgNjQgY2F1c2luZyBvdmVy Zmxvdy4gVGhlIHJlc3VsdCB3YXMgdGhlbgorICAgICAgICBjb21wYXJlZCBhZ2FpbiB3aXRoIDB4 ODAwMDAwMDAgd2hpY2ggY291bGQgcGFzcyBvciBmYWlsIGRlcGVuZGluZyBvbiBvdmVyZmxvdwor ICAgICAgICBiZWhhdmlvci4KKyAgICAgICAgCisgICAgICAgIEZpeCBieSBjb252ZXJ0aW5nIFZl cnRpY2FsUG9zaXRpb25DYWNoZSB0byB1c2UgTGF5b3V0VW5pdHMsIGFuZCB0byBoYXZlIGEgYm9v bAorICAgICAgICByZXR1cm4gdmFsdWUgd2l0aCBhIHJlc3VsdCBvdXQgcGFyYW0sIGluc3RlYWQg b2YgYSBzcGVjaWFsIHJldHVybiB2YWx1ZS4KKworICAgICAgICBOb3QgZWFzaWx5IHRlc3RhYmxl LCBzaW5jZSB0aGUgZGlmZmVyZW5jZSBkb2VzIG5vdCBzaG93IGluIERSVCBvdXRwdXQsCisgICAg ICAgIGFuZCBhIHJlZiB0ZXN0IHdvdWxkIGJlIGZsYWtleS4KKworICAgICAgICAqIHJlbmRlcmlu Zy9Sb290SW5saW5lQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJvb3RJbmxpbmVCb3g6OmFz Y2VudEFuZERlc2NlbnRGb3JCb3gpOgorICAgICAgICAqIHJlbmRlcmluZy9WZXJ0aWNhbFBvc2l0 aW9uQ2FjaGUuaDoKKyAgICAgICAgKFdlYkNvcmU6OlZlcnRpY2FsUG9zaXRpb25DYWNoZTo6Z2V0 KToKKyAgICAgICAgKFdlYkNvcmU6OlZlcnRpY2FsUG9zaXRpb25DYWNoZTo6c2V0KToKKwogMjAx NC0wOC0wNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAg ICAgIFtpT1NdIE1ha2UgZG9jdW1lbnQgbWFya2VyIGFzc2V0cyBub3Qgc3BlY2lmaWMgdG8gcGFy dGljdWxhciBzY2FsZSBmYWN0b3JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUm9vdElubGluZUJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUm9vdElubGlu ZUJveC5jcHAKaW5kZXggZjNmODdjN2JhNmIzZTgzMTRjOTUwYWM5NmE5MmI4MWI2MDY3NDFkMi4u OWVjNDJkMzVhZWIxNGEwM2NlMzQ4NTA4OTFhZDA1ODUwNWMwNmRkOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jvb3RJbmxpbmVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9Sb290SW5saW5lQm94LmNwcApAQCAtOTM0LDkgKzkzNCw5IEBAIExheW91 dFVuaXQgUm9vdElubGluZUJveDo6dmVydGljYWxQb3NpdGlvbkZvckJveChJbmxpbmVCb3gqIGJv eCwgVmVydGljYWxQb3NpdGlvCiAgICAgLy8gQ2hlY2sgdGhlIGNhY2hlLgogICAgIGJvb2wgaXNS ZW5kZXJJbmxpbmUgPSByZW5kZXJlci0+aXNSZW5kZXJJbmxpbmUoKTsKICAgICBpZiAoaXNSZW5k ZXJJbmxpbmUgJiYgIWZpcnN0TGluZSkgewotICAgICAgICBMYXlvdXRVbml0IHZlcnRpY2FsUG9z aXRpb24gPSB2ZXJ0aWNhbFBvc2l0aW9uQ2FjaGUuZ2V0KHJlbmRlcmVyLCBiYXNlbGluZVR5cGUo KSk7Ci0gICAgICAgIGlmICh2ZXJ0aWNhbFBvc2l0aW9uICE9IFBvc2l0aW9uVW5kZWZpbmVkKQot ICAgICAgICAgICAgcmV0dXJuIHZlcnRpY2FsUG9zaXRpb247CisgICAgICAgIExheW91dFVuaXQg Y2FjaGVkUG9zaXRpb247CisgICAgICAgIGlmICh2ZXJ0aWNhbFBvc2l0aW9uQ2FjaGUuZ2V0KHJl bmRlcmVyLCBiYXNlbGluZVR5cGUoKSwgY2FjaGVkUG9zaXRpb24pKQorICAgICAgICAgICAgcmV0 dXJuIGNhY2hlZFBvc2l0aW9uOwogICAgIH0KIAogICAgIExheW91dFVuaXQgdmVydGljYWxQb3Np dGlvbiA9IDA7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVmVydGljYWxQ b3NpdGlvbkNhY2hlLmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvVmVydGljYWxQb3NpdGlv bkNhY2hlLmgKaW5kZXggYjdjZDdlMDg1ZTdmOWJlZGI1MjhmNjJkZWVmNTdhN2JiOGFhNWJlMS4u NzhmZGM1YjJkODMzYWQ3MDAyMDYxNWVlZWFjNzhjODgzNmI4ODU1NCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1ZlcnRpY2FsUG9zaXRpb25DYWNoZS5oCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9WZXJ0aWNhbFBvc2l0aW9uQ2FjaGUuaApAQCAtMzQsMjQgKzM0 LDI0IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIGNsYXNzIFJlbmRlck9iamVjdDsKIAogLy8gVmFs dWVzIGZvciB2ZXJ0aWNhbCBhbGlnbm1lbnQuCi1jb25zdCBpbnQgUG9zaXRpb25VbmRlZmluZWQg PSAweDgwMDAwMDAwOwotCiBjbGFzcyBWZXJ0aWNhbFBvc2l0aW9uQ2FjaGUgewogICAgIFdURl9N QUtFX05PTkNPUFlBQkxFKFZlcnRpY2FsUG9zaXRpb25DYWNoZSk7CiBwdWJsaWM6CiAgICAgVmVy dGljYWxQb3NpdGlvbkNhY2hlKCkKICAgICB7IH0KICAgICAKLSAgICBpbnQgZ2V0KFJlbmRlck9i amVjdCogcmVuZGVyZXIsIEZvbnRCYXNlbGluZSBiYXNlbGluZVR5cGUpIGNvbnN0CisgICAgYm9v bCBnZXQoUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgRm9udEJhc2VsaW5lIGJhc2VsaW5lVHlwZSwg TGF5b3V0VW5pdCYgcmVzdWx0KSBjb25zdAogICAgIHsKLSAgICAgICAgY29uc3QgSGFzaE1hcDxS ZW5kZXJPYmplY3QqLCBpbnQ+JiBtYXBUb0NoZWNrID0gYmFzZWxpbmVUeXBlID09IEFscGhhYmV0 aWNCYXNlbGluZSA/IG1fYWxwaGFiZXRpY1Bvc2l0aW9ucyA6IG1faWRlb2dyYXBoaWNQb3NpdGlv bnM7Ci0gICAgICAgIGNvbnN0IEhhc2hNYXA8UmVuZGVyT2JqZWN0KiwgaW50Pjo6Y29uc3RfaXRl cmF0b3IgaXQgPSBtYXBUb0NoZWNrLmZpbmQocmVuZGVyZXIpOworICAgICAgICBjb25zdCBIYXNo TWFwPFJlbmRlck9iamVjdCosIExheW91dFVuaXQ+JiBtYXBUb0NoZWNrID0gYmFzZWxpbmVUeXBl ID09IEFscGhhYmV0aWNCYXNlbGluZSA/IG1fYWxwaGFiZXRpY1Bvc2l0aW9ucyA6IG1faWRlb2dy YXBoaWNQb3NpdGlvbnM7CisgICAgICAgIGNvbnN0IEhhc2hNYXA8UmVuZGVyT2JqZWN0KiwgTGF5 b3V0VW5pdD46OmNvbnN0X2l0ZXJhdG9yIGl0ID0gbWFwVG9DaGVjay5maW5kKHJlbmRlcmVyKTsK ICAgICAgICAgaWYgKGl0ID09IG1hcFRvQ2hlY2suZW5kKCkpCi0gICAgICAgICAgICByZXR1cm4g UG9zaXRpb25VbmRlZmluZWQ7Ci0gICAgICAgIHJldHVybiBpdC0+dmFsdWU7CisgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgcmVzdWx0ID0gaXQtPnZhbHVlOworICAgICAgICBy ZXR1cm4gdHJ1ZTsKICAgICB9CiAgICAgCi0gICAgdm9pZCBzZXQoUmVuZGVyT2JqZWN0KiByZW5k ZXJlciwgRm9udEJhc2VsaW5lIGJhc2VsaW5lVHlwZSwgaW50IHBvc2l0aW9uKQorICAgIHZvaWQg c2V0KFJlbmRlck9iamVjdCogcmVuZGVyZXIsIEZvbnRCYXNlbGluZSBiYXNlbGluZVR5cGUsIExh eW91dFVuaXQgcG9zaXRpb24pCiAgICAgewogICAgICAgICBpZiAoYmFzZWxpbmVUeXBlID09IEFs cGhhYmV0aWNCYXNlbGluZSkKICAgICAgICAgICAgIG1fYWxwaGFiZXRpY1Bvc2l0aW9ucy5zZXQo cmVuZGVyZXIsIHBvc2l0aW9uKTsKQEAgLTYwLDggKzYwLDggQEAgcHVibGljOgogICAgIH0KIAog cHJpdmF0ZToKLSAgICBIYXNoTWFwPFJlbmRlck9iamVjdCosIGludD4gbV9hbHBoYWJldGljUG9z aXRpb25zOwotICAgIEhhc2hNYXA8UmVuZGVyT2JqZWN0KiwgaW50PiBtX2lkZW9ncmFwaGljUG9z aXRpb25zOworICAgIEhhc2hNYXA8UmVuZGVyT2JqZWN0KiwgTGF5b3V0VW5pdD4gbV9hbHBoYWJl dGljUG9zaXRpb25zOworICAgIEhhc2hNYXA8UmVuZGVyT2JqZWN0KiwgTGF5b3V0VW5pdD4gbV9p ZGVvZ3JhcGhpY1Bvc2l0aW9uczsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK