135734 2014-08-07 16:48:57 -0700 make clean does not work in OpenSource, fails in WebKitLibraries 2014-08-08 12:21:12 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck webkit-unassigned bfulgham commit-queue ddkilzer fpizlo mrowe oldest_to_newest 1027690 0 joepeck 2014-08-07 16:48:57 -0700 * SUMMARY `make clean` does not work because WebKitLibraries' Makefile is missing a "clean" target. * STEPS TO REPRODUCE shell> cd WebKitLibraries && make clean 1027691 1 236241 joepeck 2014-08-07 16:51:20 -0700 Created attachment 236241 [PATCH] Proposed Fix 1027892 2 236241 ddkilzer 2014-08-08 11:24:32 -0700 Comment on attachment 236241 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review r=me > Tools/Scripts/copy-webkitlibraries-to-product-directory:311 > + (system("rm", "-rf", "$productDir/usr/local/include/WebKitSystemInterface.h") == 0) or die; > + (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die; I think you need to use the exitStatus() function (in VCSUtils.pm) to check the result of system() on Windows. To put another way, I'm not sure if "system() == 0" will work on Windows. 1027900 3 236241 joepeck 2014-08-08 11:46:50 -0700 Comment on attachment 236241 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=236241&action=review >> Tools/Scripts/copy-webkitlibraries-to-product-directory:311 >> + (system("rm", "-rf", "$productDir$llvmPrefix") == 0) or die; > > I think you need to use the exitStatus() function (in VCSUtils.pm) to check the result of system() on Windows. > > To put another way, I'm not sure if "system() == 0" will work on Windows. The rest of this file uses this idiom. Spoke on IRC lets land as is. 1027910 4 236241 commit-queue 2014-08-08 12:20:43 -0700 Comment on attachment 236241 [PATCH] Proposed Fix Clearing flags on attachment: 236241 Committed r172349: <http://trac.webkit.org/changeset/172349> 1027911 5 commit-queue 2014-08-08 12:21:12 -0700 All reviewed patches have been landed. Closing bug. 236241 2014-08-07 16:51:20 -0700 2014-08-08 12:20:41 -0700 [PATCH] Proposed Fix clean-fix.patch text/plain 4009 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAxMWRh YmRiLi5lYTg2ZTMwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDgtMDcgIEpvc2VwaCBQZWNvcmFybyAgPHBl Y29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBtYWtlIGNsZWFuIGRvZXMgbm90IHdvcmsgaW4g T3BlblNvdXJjZSwgZmFpbHMgaW4gV2ViS2l0TGlicmFyaWVzCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3MzQKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvY29weS13ZWJraXRsaWJyYXJp ZXMtdG8tcHJvZHVjdC1kaXJlY3Rvcnk6CisgICAgICAgIEFkZCBhIC0tY2xlYW4gc3dpdGNoIHRo YXQgcmVtb3ZlcyBwb3NzaWJsZSBXZWJLaXRTeXN0ZW1JbnRlcmZhY2UKKyAgICAgICAgYW5kIExM Vk0gbGlicmFyaWVzIGFuZCBoZWFkZXJzIHRoYXQgbWF5IGhhdmUgYmVlbiBjb3BpZWQgdG8gdGhl CisgICAgICAgIHByb2R1Y3QgZGlyZWN0b3J5LgorCiAyMDE0LTA4LTA3ICBCZW5qYW1pbiBQb3Vs YWluICA8YnBvdWxhaW5AYXBwbGUuY29tPgogCiAgICAgICAgIEdldCByaWQgb2YgSU5QVVRfU1BF RUNICmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL2NvcHktd2Via2l0bGlicmFyaWVzLXRvLXBy b2R1Y3QtZGlyZWN0b3J5IGIvVG9vbHMvU2NyaXB0cy9jb3B5LXdlYmtpdGxpYnJhcmllcy10by1w cm9kdWN0LWRpcmVjdG9yeQppbmRleCA3ZmJkODFlLi5jODYwMTkyIDEwMDc1NQotLS0gYS9Ub29s cy9TY3JpcHRzL2NvcHktd2Via2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyZWN0b3J5CisrKyBi L1Rvb2xzL1NjcmlwdHMvY29weS13ZWJraXRsaWJyYXJpZXMtdG8tcHJvZHVjdC1kaXJlY3RvcnkK QEAgLTMzLDYgKzMzLDcgQEAgdXNlIHdlYmtpdGRpcnM7CiBteSAkc2hvd0hlbHAgPSAwOwogbXkg JGxsdm0gPSAwOwogbXkgJHdrc2kgPSAwOworbXkgJGNsZWFuID0gMDsKIG15ICRsbHZtSW5jbHVk ZVBhY2thZ2UgPSAiIjsKIG15ICRsbHZtTGlicmFyeVBhY2thZ2UgPSAiIjsKIG15ICR1c2VGdWxs TGliUGF0aHMgPSAwOwpAQCAtNDksNiArNTAsNyBAQCBVc2FnZTogJHByb2dyYW1OYW1lIFtvcHRp b25zXQogICAtLWhlbHAgICAgICAgICAgICAgICAgICAgICAgICBTaG93IHRoaXMgaGVscCBtZXNz YWdlCiAgIC0tW25vLV1sbHZtICAgICAgICAgICAgICAgICAgIFRvZ2dsZSBjb3B5aW5nIExMVk0g ZHJvcHMgKGRlZmF1bHQ6ICRsbHZtKQogICAtLVtuby1dd2tzaSAgICAgICAgICAgICAgICAgICBU b2dnbGUgY29weWluZyBXZWJLaXRTeXN0ZW1JbnRlcmZhY2UgZHJvcHMgKGRlZmF1bHQ6ICR3a3Np KQorICAtLWNsZWFuICAgICAgICAgICAgICAgICAgICAgICBDbGVhbiB0aGUgbGlicmFyaWVzIChk ZWZhdWx0OiAkY2xlYW4pCiAgIC0tdXNlLWxsdm0taW5jbHVkZXM9PHBhdGg+ICAgIEdldCB0aGUg TExWTSBpbmx1ZGVzIHBhY2thZ2UgZnJvbSA8cGF0aD4KICAgLS11c2UtbGx2bS1saWJyYXJpZXM9 PHBhdGg+ICAgR2V0IHRoZSBMTFZNIGxpYnJhcmllcyBwYWNrYWdlIGZyb20gPHBhdGg+CiAgIC0t W25vLV11c2UtZnVsbC1saWItcGF0aHMgICAgIFRvZ2dsZSB1c2luZyBmdWxsIGxpYnJhcnkgcGF0 aHMKQEAgLTY0LDYgKzY2LDcgQEAgR2V0T3B0aW9ucygKICAgICAnaGVscCcgPT4gXCRzaG93SGVs cCwKICAgICAnbGx2bSEnID0+IFwkbGx2bSwKICAgICAnd2tzaSEnID0+IFwkd2tzaSwKKyAgICAn Y2xlYW4nID0+IFwkY2xlYW4sCiAgICAgJ3VzZS1sbHZtLWluY2x1ZGVzPXMnID0+IFwkbGx2bUlu Y2x1ZGVQYWNrYWdlLAogICAgICd1c2UtbGx2bS1saWJyYXJpZXM9cycgPT4gXCRsbHZtTGlicmFy eVBhY2thZ2UsCiAgICAgJ3VzZS1mdWxsLWxpYi1wYXRocyEnID0+IFwkdXNlRnVsbExpYlBhdGhz LApAQCAtMzAyLDMgKzMwNSwxMiBAQCBpZiAoJGxsdm0pIHsKICAgICB9CiB9CiAKK2lmICgkY2xl YW4pIHsKKyAgICBwcmludCAiQ2xlYW5pbmcuXG4iOyAgICAKKyAgICAoc3lzdGVtKCJybSIsICIt cmYiLCAiJHByb2R1Y3REaXIvdXNyL2xvY2FsL2luY2x1ZGUvV2ViS2l0U3lzdGVtSW50ZXJmYWNl LmgiKSA9PSAwKSBvciBkaWU7CisgICAgKHN5c3RlbSgicm0iLCAiLXJmIiwgIiRwcm9kdWN0RGly JGxsdm1QcmVmaXgiKSA9PSAwKSBvciBkaWU7CisgICAgdW5saW5rIGdsb2IgIiRwcm9kdWN0RGly L2xpYldlYktpdFN5c3RlbUludGVyZmFjZSoiIG9yIGRpZSBpZiBnbG9iICIkcHJvZHVjdERpci9s aWJXZWJLaXRTeXN0ZW1JbnRlcmZhY2UqIjsKKyAgICB1bmxpbmsgZ2xvYiAiJHByb2R1Y3REaXIv dXNyL2xvY2FsL2xpYi9saWJXZWJLaXRTeXN0ZW1JbnRlcmZhY2UqIiBvciBkaWUgaWYgZ2xvYiAi JHByb2R1Y3REaXIvdXNyL2xvY2FsL2xpYi9saWJXZWJLaXRTeXN0ZW1JbnRlcmZhY2UqIjsKKyAg ICB1bmxpbmsgZ2xvYiAiJHByb2R1Y3REaXIvbGliTExWTSoiIG9yIGRpZSBpZiBnbG9iICIkcHJv ZHVjdERpci9saWJMTFZNKiI7CisgICAgdW5saW5rIGdsb2IgIiRwcm9kdWN0RGlyL2xpYkxUTyoi IG9yIGRpZSBpZiBnbG9iICIkcHJvZHVjdERpci9saWJMVE8qIjsKK30KZGlmZiAtLWdpdCBhL1dl YktpdExpYnJhcmllcy9DaGFuZ2VMb2cgYi9XZWJLaXRMaWJyYXJpZXMvQ2hhbmdlTG9nCmluZGV4 IDEzOWYwYjMuLjFkY2ZlOGMgMTAwNjQ0Ci0tLSBhL1dlYktpdExpYnJhcmllcy9DaGFuZ2VMb2cK KysrIGIvV2ViS2l0TGlicmFyaWVzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4 LTA3ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgbWFr ZSBjbGVhbiBkb2VzIG5vdCB3b3JrIGluIE9wZW5Tb3VyY2UsIGZhaWxzIGluIFdlYktpdExpYnJh cmllcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1 NzM0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBN YWtlZmlsZToKKyAgICAgICAgQWRkIGEgImNsZWFuIiB0YXJnZXQgdGhhdCBydW5zIGNvcHktd2Vi a2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyCisgICAgICAgIHdpdGggdGhlIG5ldyAtLWNsZWFu IHN3aXRjaC4KKwogMjAxNC0wOC0wNCAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluQHdlYmtp dC5vcmc+CiAKICAgICAgICAgQWRkIGEgZmxhZyBmb3IgdGhlIENTUyBTZWxlY3RvcnMgbGV2ZWwg NCBpbXBsZW1lbnRhdGlvbgpkaWZmIC0tZ2l0IGEvV2ViS2l0TGlicmFyaWVzL01ha2VmaWxlIGIv V2ViS2l0TGlicmFyaWVzL01ha2VmaWxlCmluZGV4IGVkMGZmYmEuLmM5ZjM1MzUgMTAwNjQ0Ci0t LSBhL1dlYktpdExpYnJhcmllcy9NYWtlZmlsZQorKysgYi9XZWJLaXRMaWJyYXJpZXMvTWFrZWZp bGUKQEAgLTMsOSArMywxMyBAQCBTQ1JJUFRTX1BBVEggPSAuLi9Ub29scy9TY3JpcHRzCiBpZmVx ICgkKHNoZWxsIHN3X3ZlcnMgLXByb2R1Y3RWZXJzaW9uIHwgY3V0IC1kLiAtZi0yKSwgMTAuMTAp CiBsaWJzOgogCUB0cnVlCitjbGVhbmxpYnM6CisJQHRydWUKIGVsc2UKIGxpYnM6CiAJcGVybCAk KFNDUklQVFNfUEFUSCkvY29weS13ZWJraXRsaWJyYXJpZXMtdG8tcHJvZHVjdC1kaXJlY3Rvcnkg LS13a3NpIC0tbGx2bQorY2xlYW5saWJzOgorCXBlcmwgJChTQ1JJUFRTX1BBVEgpL2NvcHktd2Vi a2l0bGlicmFyaWVzLXRvLXByb2R1Y3QtZGlyZWN0b3J5IC0tY2xlYW4KIGVuZGlmCiAKIGFsbDog bGlicwpAQCAtMjAsNCArMjQsNyBAQCByZWxlYXNlIHI6CiAKIGFuYWx5emU6CiAJJChTQ1JJUFRT X1BBVEgpL3NldC13ZWJraXQtY29uZmlndXJhdGlvbiAtLXJlbGVhc2UKLQlAJChNQUtFKSBsaWJz ClwgTm8gbmV3bGluZSBhdCBlbmQgb2YgZmlsZQorCUAkKE1BS0UpIGxpYnMKKworY2xlYW46CisJ QCQoTUFLRSkgY2xlYW5saWJzCg==