135726 2014-08-07 14:59:28 -0700 Web Inspector: add debugging flag to InspectorTest for unbuffered logging to stderr 2014-08-08 13:22:14 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg burg graouts joepeck mattbaker timothy webkit-bug-importer oldest_to_newest 1027642 0 burg 2014-08-07 14:59:28 -0700 . 1027643 1 webkit-bug-importer 2014-08-07 14:59:42 -0700 <rdar://problem/17951314> 1027681 2 236238 burg 2014-08-07 16:15:11 -0700 Created attachment 236238 Patch 1027682 3 burg 2014-08-07 16:16:16 -0700 I decided to not guard this with !LOG_DISABLED, since debug builds often crash for dumb reasons and will additionally spew whatever WebCoreLogging you may have enabled. I also couldn't figure out how to conditionalize the method in InspectorFrontendHost.idl. 1027686 4 236238 timothy 2014-08-07 16:34:01 -0700 Comment on attachment 236238 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236238&action=review > Source/WebInspectorUI/UserInterface/Base/Test.js:138 > + if (InspectorTest.dumpMessagesToConsole && InspectorFrontendHost.unbufferedLog) Do we need to test InspectorFrontendHost.unbufferedLog? 1027741 5 burg 2014-08-07 20:01:21 -0700 (In reply to comment #4) > (From update of attachment 236238 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236238&action=review > > > Source/WebInspectorUI/UserInterface/Base/Test.js:138 > > + if (InspectorTest.dumpMessagesToConsole && InspectorFrontendHost.unbufferedLog) > > Do we need to test InspectorFrontendHost.unbufferedLog? I guess we do control who the InspectorFrontendHost really is during testing, so this could be removed. 1027925 6 burg 2014-08-08 13:22:14 -0700 Committed r172355: <http://trac.webkit.org/changeset/172355> 236238 2014-08-07 16:15:11 -0700 2014-08-07 16:34:00 -0700 Patch bug-135726-20140807161510.patch text/plain 5811 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMjExCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFmZjA2MmEyY2JjZWMw ZTZlNWQ0ZmZmZTJlMjAzNDdjMWFkZjA3Ny4uY2IxNjc0YzViNjljNjBmNzI5M2Q3ODE2ODEzZDRm NjIzNDQ0ZGNlZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA4LTA3ICBCcmlh biBKLiBCdXJnICA8YnVyZ0Bjcy53YXNoaW5ndG9uLmVkdT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBhZGQgZGVidWdnaW5nIGZsYWcgdG8gSW5zcGVjdG9yVGVzdCBmb3IgdW5idWZmZXJlZCBs b2dnaW5nIHRvIHN0ZGVycgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1NzI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgQWRkIGEgYnJpZGdlIHNvIHRoYXQgSW5zcGVjdG9yVGVzdCBjYW4gc3luY2hyb25v dXNseSBsb2cgdG8gdGhlIGNvbnNvbGUuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9y RnJvbnRlbmRIb3N0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckZyb250ZW5kSG9z dDo6dW5idWZmZXJlZExvZyk6IEFkZGVkLgorICAgICAgICAqIGluc3BlY3Rvci9JbnNwZWN0b3JG cm9udGVuZEhvc3QuaDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0 LmlkbDoKKwogMjAxNC0wOC0wNyAgWmFuIERvYmVyc2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+ CiAKICAgICAgICAgQVNTRVJUIGluIERvY3VtZW50Ojp1bnJlZ2lzdGVyQ29sbGVjdGlvbiByZWxv YWRpbmcgYXBwbGUuY29tCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdl TG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCAxY2M3NDZkM2UyZjQ2 YTVmOGY0OTFhYjA3YTZhYWJmYzE2NzA0NWE5Li5lNTEyMzVlYjY0NjI3ODhmZjY0MTIwZDRiZWVh ZGQ3NDkyNjA2NmVkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAxNC0wOC0wNyAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CisKKyAg ICAgICAgV2ViIEluc3BlY3RvcjogYWRkIGRlYnVnZ2luZyBmbGFnIHRvIEluc3BlY3RvclRlc3Qg Zm9yIHVuYnVmZmVyZWQgbG9nZ2luZyB0byBzdGRlcnIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTcyNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZGVkIGEgZmxhZyBmb3IgZGVidWdnaW5nIGluc3Bl Y3RvciB0ZXN0cyB3aGljaCB3aWxsIHN5bmNocm9ub3VzbHkgbG9nIG1lc3NhZ2VzLgorICAgICAg ICBUaGlzIGF2b2lkcyBmYWlsdXJlIG1vZGVzIHRoYXQgcHJldmVudCBsb2dnaW5nIGZyb20gYmVp bmcgYWRkZWQgdG8gdGhlIHRlc3QgcGFnZS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFz ZS9UZXN0LmpzOgorICAgICAgICAoSW5zcGVjdG9yVGVzdC5kZWJ1Z0xvZyk6CisgICAgICAgIChJ bnNwZWN0b3JUZXN0LmFkZFJlc3VsdCk6CisKIDIwMTQtMDgtMDYgIEJyaWFuIEouIEJ1cmcgIDxi dXJnQGNzLndhc2hpbmd0b24uZWR1PgogCiAgICAgICAgIFdlYiBJbnNwZWN0b3I6IGJyZWFrcG9p bnQgcmVzb2x2ZWQgc3RhdGUgc2hvdWxkIG5vdCBkZXBlbmQgb24gYWxsIGJyZWFrcG9pbnRzIGJl aW5nIGVuYWJsZWQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JGcm9udGVuZEhvc3QuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZy b250ZW5kSG9zdC5jcHAKaW5kZXggNjlhZDMxMDFkOTUyZDQwNzU5Njk4N2QyODVmYTkzNDQ3Mjg3 ZjY1ZC4uZDFhNDYyNTg2ZDk5OGEyMDY2OTMzOGFhZjk4NzJmNTQ0MGIwMDY4MyAxMDA2NDQKLS0t IGEvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5jcHAKQEAg LTMwMiw2ICszMDIsMTIgQEAgYm9vbCBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OmlzVW5kZXJUZXN0 KCkKICAgICByZXR1cm4gbV9jbGllbnQgJiYgbV9jbGllbnQtPmlzVW5kZXJUZXN0KCk7CiB9CiAK K3ZvaWQgSW5zcGVjdG9yRnJvbnRlbmRIb3N0Ojp1bmJ1ZmZlcmVkTG9nKGNvbnN0IFN0cmluZyYg bWVzc2FnZSkKK3sKKyAgICAvLyBUaGlzIGlzIHVzZWQgb25seSBmb3IgZGVidWdnaW5nIGluc3Bl Y3RvciB0ZXN0cy4KKyAgICBXVEZMb2dBbHdheXMoIkluc3BlY3RvclRlc3Q6ICVzIiwgbWVzc2Fn ZS51dGY4KCkuZGF0YSgpKTsKK30KKwogdm9pZCBJbnNwZWN0b3JGcm9udGVuZEhvc3Q6OmJlZXAo KQogewogICAgIHN5c3RlbUJlZXAoKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3Bl Y3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9J bnNwZWN0b3JGcm9udGVuZEhvc3QuaAppbmRleCA5Zjg2MjI4MDUwOTZhZDNmZmI2Yjk2ZDI5Nzg5 YjA1M2ZhN2VhMDI5Li44ZThjZDg1MjQ0NTgzMDFiOTQzODVjNGFmOGIxOGVjYTFiNDc1Mzc0IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRlbmRIb3N0 LmgKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kSG9zdC5o CkBAIC04NCw2ICs4NCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGRpc3BhdGNoRXZlbnRBc0NvbnRl eHRNZW51RXZlbnQoRXZlbnQqKTsKIAogICAgIGJvb2wgaXNVbmRlclRlc3QoKTsKKyAgICB2b2lk IHVuYnVmZmVyZWRMb2coY29uc3QgU3RyaW5nJiBtZXNzYWdlKTsKIAogICAgIHZvaWQgYmVlcCgp OwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRnJvbnRl bmRIb3N0LmlkbCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhv c3QuaWRsCmluZGV4IDQwMTJmMzcxNGFjZjkwMDQ0OGQwMWM5YWNiMmMyMjk1YTM1NzM2NGYuLmVi OGQ3MjgzNmM0MDkyZWY3YjM1MmJiZGQ3ZWQ1MmI0ZmUwOTQ4Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaWRsCisrKyBiL1NvdXJj ZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZEhvc3QuaWRsCkBAIC02NCw2ICs2 NCw3IEBACiAgICAgW0N1c3RvbV0gdm9pZCBzaG93Q29udGV4dE1lbnUoTW91c2VFdmVudCBldmVu dCwgYW55IGl0ZW1zKTsKICAgICB2b2lkIGRpc3BhdGNoRXZlbnRBc0NvbnRleHRNZW51RXZlbnQo RXZlbnQgZXZlbnQpOwogICAgIHZvaWQgc2VuZE1lc3NhZ2VUb0JhY2tlbmQoRE9NU3RyaW5nIG1l c3NhZ2UpOworICAgIHZvaWQgdW5idWZmZXJlZExvZyhET01TdHJpbmcgbWVzc2FnZSk7CiAKICAg ICBbQ3VzdG9tXSB2b2lkIHJlY29yZEFjdGlvblRha2VuKHVuc2lnbmVkIGxvbmcgYWN0aW9uQ29k ZSk7CiAgICAgW0N1c3RvbV0gdm9pZCByZWNvcmRQYW5lbFNob3duKHVuc2lnbmVkIGxvbmcgcGFu ZWxDb2RlKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L0Jhc2UvVGVzdC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2Uv VGVzdC5qcwppbmRleCBkOTdkY2I5MTFmMTFiZThhMGQ3ZjYxZjZkZTkwMjIxYTJiY2Y2NDE2Li41 ZTEzNzFjMTU1MjFjMjY1ZTdlNWVjNDkyMzI2ZjI2MTAyN2YxYjYyIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL1Rlc3QuanMKKysrIGIvU291cmNl L1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9UZXN0LmpzCkBAIC03OCw2ICs3OCw5 IEBAIFdlYkluc3BlY3Rvci51cGRhdGVEb2NrZWRTdGF0ZSA9IGZ1bmN0aW9uKCkKIC8vIHdoaWNo IGFyZSBwcm92aWRlZCBieSBgaW5zcGVjdG9yLXRlc3QuanNgLgogSW5zcGVjdG9yVGVzdCA9IHt9 OwogCisvLyBUaGlzIGlzIHVzZWZ1bCBmb3IgZGVidWdnaW5nIEluc3BlY3RvciB0ZXN0cyBieSBz eW5jaHJvbm91c2x5IGxvZ2dpbmcgbWVzc2FnZXMuCitJbnNwZWN0b3JUZXN0LmR1bXBNZXNzYWdl c1RvQ29uc29sZSA9IGZhbHNlOworCiAvLyBUaGlzIGlzIGEgd29ya2Fyb3VuZCBmb3IgdGhlIGZh Y3QgdGhhdCBpdCB3b3VsZCBiZSBoYXJkIHRvIHNldCB1cCBhIGNvbnN0cnVjdG9yLAogLy8gcHJv dG90eXBlLCBhbmQgcHJvdG90eXBlIGNoYWluIGZvciB0aGUgc2luZ2xldG9uIEluc3BlY3RvclRl c3QuCiBJbnNwZWN0b3JUZXN0LkV2ZW50RGlzcGF0Y2hlciA9IGZ1bmN0aW9uKCkKQEAgLTEzMiwx MSArMTM1LDE3IEBAIEluc3BlY3RvclRlc3QuZXhwZWN0VGhhdCA9IGZ1bmN0aW9uKGNvbmRpdGlv biwgbWVzc2FnZSkKIC8vIFRoaXMgZnVuY3Rpb24gc2hvdWxkIG9ubHkgYmUgdXNlZCB0byBkZWJ1 ZyB0ZXN0cyBhbmQgbm90IHRvIHByb2R1Y2Ugbm9ybWFsIHRlc3Qgb3V0cHV0LgogSW5zcGVjdG9y VGVzdC5kZWJ1Z0xvZyA9IGZ1bmN0aW9uKG1lc3NhZ2UpCiB7CisgICAgaWYgKEluc3BlY3RvclRl c3QuZHVtcE1lc3NhZ2VzVG9Db25zb2xlICYmIEluc3BlY3RvckZyb250ZW5kSG9zdC51bmJ1ZmZl cmVkTG9nKQorICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEhvc3QudW5idWZmZXJlZExvZygiZGVi dWdMb2c6ICIgKyBtZXNzYWdlKTsKKwogICAgIHRoaXMuZXZhbHVhdGVJblBhZ2UoIkluc3BlY3Rv clRlc3RQcm94eS5kZWJ1Z0xvZyh1bmVzY2FwZSgnIiArIGVzY2FwZShKU09OLnN0cmluZ2lmeSht ZXNzYWdlKSkgKyAiJykpIik7CiB9CiAKIEluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0ID0gZnVu Y3Rpb24oKQogeworICAgIGlmIChJbnNwZWN0b3JUZXN0LmR1bXBNZXNzYWdlc1RvQ29uc29sZSAm JiBJbnNwZWN0b3JGcm9udGVuZEhvc3QudW5idWZmZXJlZExvZykKKyAgICAgICAgSW5zcGVjdG9y RnJvbnRlbmRIb3N0LnVuYnVmZmVyZWRMb2coIkluc3BlY3RvclRlc3QuY29tcGxldGVUZXN0KCki KTsKKwogICAgIGZ1bmN0aW9uIHNpZ25hbENvbXBsZXRpb25Ub1Rlc3RQYWdlKCkgewogICAgICAg ICBJbnNwZWN0b3JCYWNrZW5kLnJ1bkFmdGVyUGVuZGluZ0Rpc3BhdGNoZXModGhpcy5ldmFsdWF0 ZUluUGFnZS5iaW5kKHRoaXMsICJJbnNwZWN0b3JUZXN0UHJveHkuY29tcGxldGVUZXN0KCkiKSk7 CiAgICAgfQpAQCAtMTY1LDYgKzE3NCw5IEBAIEluc3BlY3RvclRlc3QuYWRkUmVzdWx0ID0gZnVu Y3Rpb24odGV4dCkKIHsKICAgICB0aGlzLl9yZXN1bHRzLnB1c2godGV4dCk7CiAKKyAgICBpZiAo SW5zcGVjdG9yVGVzdC5kdW1wTWVzc2FnZXNUb0NvbnNvbGUgJiYgSW5zcGVjdG9yRnJvbnRlbmRI b3N0LnVuYnVmZmVyZWRMb2cpCisgICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9zdC51bmJ1ZmZl cmVkTG9nKCJhZGRSZXN1bHQ6ICIgKyB0ZXh0KTsKKwogICAgIGlmICghdGhpcy5fdGVzdFBhZ2VJ c1JlbG9hZGluZykKICAgICAgICAgdGhpcy5ldmFsdWF0ZUluUGFnZSgiSW5zcGVjdG9yVGVzdFBy b3h5LmFkZFJlc3VsdCh1bmVzY2FwZSgnIiArIGVzY2FwZSh0ZXh0KSArICInKSkiKTsKIH0K