135723 2014-08-07 14:27:13 -0700 Web Inspector: Filter bar text and icon are positioned too low and tight 2014-08-07 17:08:37 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 timothy timothy commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1027620 0 timothy 2014-08-07 14:27:13 -0700 The position could improve. 1027621 1 webkit-bug-importer 2014-08-07 14:27:51 -0700 <rdar://problem/17950778> 1027622 2 236222 timothy 2014-08-07 14:28:16 -0700 Created attachment 236222 Patch 1027624 3 236222 joepeck 2014-08-07 14:31:29 -0700 Comment on attachment 236222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236222&action=review r=me > Source/WebInspectorUI/UserInterface/Views/FilterBar.css:44 > + padding-top: 0; Do we need to worry about mac-platform.legacy? 1027687 4 236222 timothy 2014-08-07 16:35:33 -0700 Comment on attachment 236222 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236222&action=review >> Source/WebInspectorUI/UserInterface/Views/FilterBar.css:44 >> + padding-top: 0; > > Do we need to worry about mac-platform.legacy? Nope, it is fine. 1027704 5 236222 commit-queue 2014-08-07 17:08:34 -0700 Comment on attachment 236222 Patch Clearing flags on attachment: 236222 Committed r172312: <http://trac.webkit.org/changeset/172312> 1027705 6 commit-queue 2014-08-07 17:08:37 -0700 All reviewed patches have been landed. Closing bug. 236222 2014-08-07 14:28:16 -0700 2014-08-07 17:08:33 -0700 Patch bug-135723-20140807142805.patch text/plain 2162 timothy U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMjYzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk ZWNkMmE1MTQ3NTFhYTRhMDVmMDFkZGIxYmE1ZmJjNzk4ZjJhNzUxLi4xNGQ5NGY0OTllNWE4YjBk YmMyYTQ3MDJhZDNiZjZmZjI2NjY0ZTMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxOCBAQAogMjAxNC0wOC0wNyAgVGltb3RoeSBIYXRjaGVyICA8dGltb3RoeUBhcHBsZS5j b20+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRmlsdGVyIGJhciB0ZXh0IGFuZCBpY29uIGFy ZSBwb3NpdGlvbmVkIHRvbyBsb3cgYW5kIHRpZ2h0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRmlsdGVyQmFyLmNz czoKKyAgICAgICAgKC5maWx0ZXItYmFyID4gaW5wdXRbdHlwZT0ic2VhcmNoIl0pOgorICAgICAg ICAoLmZpbHRlci1iYXIgPiBpbnB1dFt0eXBlPSJzZWFyY2giXTo6LXdlYmtpdC1zZWFyY2gtZGVj b3JhdGlvbik6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hCYXIuY3NzOgor ICAgICAgICAoLnNlYXJjaC1iYXIgPiBpbnB1dFt0eXBlPSJzZWFyY2giXSk6CisKKzIwMTQtMDgt MDcgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCiAgICAgICAgIEZpeCBy ZWZlcmVuY2UgdG8gbWlzc2luZyBDbG9zZVRpbWVsaW5lLnN2ZyBpbWFnZS4KIAogICAgICAgICBS dWJiZXItc3RhbXBlZCBieSBKb3NlcGggUGVjb3Jhcm8uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9GaWx0ZXJCYXIuY3NzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRmlsdGVyQmFyLmNzcwppbmRleCBlMDg5 MTQ1ZDUzZWMyNDFlNmY1NTI0MWI4NzU2NWE5MjEzNDYwZjBhLi4yZWYxMzE2ZmIyZDhlMTI3NTEy NmZjMjY0ZmRlYjExOTc0ZDYzOTUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9GaWx0ZXJCYXIuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0ZpbHRlckJhci5jc3MKQEAgLTQxLDYgKzQxLDcgQEAg Ym9keS5tYWMtcGxhdGZvcm0ubGVnYWN5IC5maWx0ZXItYmFyIHsKICAgICAtd2Via2l0LWZsZXg6 IDE7CiAKICAgICBtYXJnaW46IDFweCA2cHg7CisgICAgcGFkZGluZy10b3A6IDA7CiAKICAgICBv dXRsaW5lOiBub25lOwogCkBAIC03Myw4ICs3NCw4IEBAIGJvZHkubWFjLXBsYXRmb3JtLmxlZ2Fj eSAuZmlsdGVyLWJhciA+IGlucHV0W3R5cGU9InNlYXJjaCJdIHsKICAgICB3aWR0aDogMTNweDsK ICAgICBoZWlnaHQ6IDEzcHg7CiAKLSAgICBtYXJnaW4tbGVmdDogMXB4OwotICAgIG1hcmdpbi1y aWdodDogM3B4OworICAgIG1hcmdpbi1sZWZ0OiA2cHg7CisgICAgbWFyZ2luLXJpZ2h0OiA2cHg7 CiAKICAgICB2ZXJ0aWNhbC1hbGlnbjogYm90dG9tOwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hCYXIuY3NzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvU2VhcmNoQmFyLmNzcwppbmRleCBmOWZm MDA4NmRmY2VmMWE2M2JlM2U5NDkwYmE2MzA4ODVkMmI2Mjc2Li5iZWRkZDc2ZjdhOTMzODFmMWI0 NjJlNDFmODM3ZmJlYTljZTI5MDMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9TZWFyY2hCYXIuY3NzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NlYXJjaEJhci5jc3MKQEAgLTI0LDYgKzI0LDcgQEAK ICAqLwogCiAuc2VhcmNoLWJhciA+IGlucHV0W3R5cGU9InNlYXJjaCJdIHsKKyAgICBwYWRkaW5n LXRvcDogMDsKICAgICBtYXJnaW46IDFweCA2cHg7CiAKICAgICBvdXRsaW5lOiBub25lOwo=