135722 2014-08-07 14:22:46 -0700 SpeculateInt32Operand is sometimes used in a 64-bit context, which has undefined behavior 2014-08-07 15:08:43 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mhahnenberg mhahnenberg commit-queue oldest_to_newest 1027618 0 mhahnenberg 2014-08-07 14:22:46 -0700 We should be using SpeculateStrictInt32Operand instead. 1027619 1 236221 mhahnenberg 2014-08-07 14:25:33 -0700 Created attachment 236221 Patch 1027645 2 236221 commit-queue 2014-08-07 15:08:41 -0700 Comment on attachment 236221 Patch Clearing flags on attachment: 236221 Committed r172282: <http://trac.webkit.org/changeset/172282> 1027646 3 commit-queue 2014-08-07 15:08:43 -0700 All reviewed patches have been landed. Closing bug. 236221 2014-08-07 14:25:33 -0700 2014-08-07 15:08:41 -0700 Patch bug-135722-20140807142521.patch text/plain 3124 mhahnenberg SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTcyMjY5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTA4LTA3ICBNYXJrIEhhaG5lbmJlcmcgIDxtaGFobmVuYmVyZ0BhcHBsZS5jb20+CisK KyAgICAgICAgU3BlY3VsYXRlSW50MzJPcGVyYW5kIGlzIHNvbWV0aW1lcyB1c2VkIGluIGEgNjQt Yml0IGNvbnRleHQsIHdoaWNoIGhhcyB1bmRlZmluZWQgYmVoYXZpb3IKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTcyMgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdlIHNob3VsZCBiZSB1c2luZyBTcGVj dWxhdGVTdHJpY3RJbnQzMk9wZXJhbmQgaW5zdGVhZC4KKworICAgICAgICAqIGRmZy9ERkdTcGVj dWxhdGl2ZUpJVDY0LmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpTcGVjdWxhdGl2ZUpJVDo6Y29t cGlsZSk6CisKIDIwMTQtMDgtMDcgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFpbkBhcHBsZS5j b20+CiAKICAgICAgICAgR2V0IHJpZCBvZiBJTlBVVF9TUEVFQ0gKSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQ2NC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0LmNwcAkocmV2aXNpb24g MTcyMjIxKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdTcGVjdWxhdGl2ZUpJVDY0 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDcyMSw3ICs0NzIxLDcgQEAgdm9pZCBTcGVjdWxhdGl2 ZUpJVDo6Y29tcGlsZShOb2RlKiBub2RlKQogICAgIH0KICAgICBjYXNlIEhhc0luZGV4ZWRQcm9w ZXJ0eTogewogICAgICAgICBTcGVjdWxhdGVDZWxsT3BlcmFuZCBiYXNlKHRoaXMsIG5vZGUtPmNo aWxkMSgpKTsKLSAgICAgICAgU3BlY3VsYXRlSW50MzJPcGVyYW5kIGluZGV4KHRoaXMsIG5vZGUt PmNoaWxkMigpKTsKKyAgICAgICAgU3BlY3VsYXRlU3RyaWN0SW50MzJPcGVyYW5kIGluZGV4KHRo aXMsIG5vZGUtPmNoaWxkMigpKTsKICAgICAgICAgR1BSUmVzdWx0IHJlc3VsdCh0aGlzKTsKIAog ICAgICAgICBHUFJSZWcgYmFzZUdQUiA9IGJhc2UuZ3ByKCk7CkBAIC00ODA2LDcgKzQ4MDYsNyBA QCB2b2lkIFNwZWN1bGF0aXZlSklUOjpjb21waWxlKE5vZGUqIG5vZGUpCiAKICAgICAgICAgU3Bl Y3VsYXRlQ2VsbE9wZXJhbmQgYmFzZSh0aGlzLCBiYXNlRWRnZSk7CiAgICAgICAgIFNwZWN1bGF0 ZUNlbGxPcGVyYW5kIHByb3BlcnR5KHRoaXMsIHByb3BlcnR5RWRnZSk7Ci0gICAgICAgIFNwZWN1 bGF0ZUludDMyT3BlcmFuZCBpbmRleCh0aGlzLCBpbmRleEVkZ2UpOworICAgICAgICBTcGVjdWxh dGVTdHJpY3RJbnQzMk9wZXJhbmQgaW5kZXgodGhpcywgaW5kZXhFZGdlKTsKICAgICAgICAgU3Bl Y3VsYXRlQ2VsbE9wZXJhbmQgZW51bWVyYXRvcih0aGlzLCBlbnVtZXJhdG9yRWRnZSk7CiAgICAg ICAgIEdQUlJlc3VsdCByZXN1bHQodGhpcyk7CiAgICAgICAgIEdQUlRlbXBvcmFyeSBzY3JhdGNo MSh0aGlzKTsKQEAgLTQ4NzYsMTUgKzQ4NzYsMTMgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29t cGlsZShOb2RlKiBub2RlKQogICAgIH0KICAgICBjYXNlIEdldEVudW1lcmF0b3JQbmFtZTogewog ICAgICAgICBTcGVjdWxhdGVDZWxsT3BlcmFuZCBlbnVtZXJhdG9yKHRoaXMsIG5vZGUtPmNoaWxk MSgpKTsKLSAgICAgICAgU3BlY3VsYXRlSW50MzJPcGVyYW5kIGluZGV4KHRoaXMsIG5vZGUtPmNo aWxkMigpKTsKKyAgICAgICAgU3BlY3VsYXRlU3RyaWN0SW50MzJPcGVyYW5kIGluZGV4KHRoaXMs IG5vZGUtPmNoaWxkMigpKTsKICAgICAgICAgR1BSVGVtcG9yYXJ5IHNjcmF0Y2gxKHRoaXMpOwot ICAgICAgICBHUFJUZW1wb3Jhcnkgc2NyYXRjaDIodGhpcyk7CiAgICAgICAgIEdQUlJlc3VsdCBy ZXN1bHQodGhpcyk7CiAKICAgICAgICAgR1BSUmVnIGVudW1lcmF0b3JHUFIgPSBlbnVtZXJhdG9y LmdwcigpOwogICAgICAgICBHUFJSZWcgaW5kZXhHUFIgPSBpbmRleC5ncHIoKTsKICAgICAgICAg R1BSUmVnIHNjcmF0Y2gxR1BSID0gc2NyYXRjaDEuZ3ByKCk7Ci0gICAgICAgIEdQUlJlZyBzY3Jh dGNoMkdQUiA9IHNjcmF0Y2gyLmdwcigpOwogICAgICAgICBHUFJSZWcgcmVzdWx0R1BSID0gcmVz dWx0LmdwcigpOwogCiAgICAgICAgIE1hY3JvQXNzZW1ibGVyOjpKdW1wIGluQm91bmRzID0gbV9q aXQuYnJhbmNoMzIoTWFjcm9Bc3NlbWJsZXI6OkJlbG93LCAKQEAgLTQ4OTYsOSArNDg5NCw3IEBA IHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGUoTm9kZSogbm9kZSkKICAgICAgICAgaW5Cb3Vu ZHMubGluaygmbV9qaXQpOwogCiAgICAgICAgIG1faml0LmxvYWRQdHIoTWFjcm9Bc3NlbWJsZXI6 OkFkZHJlc3MoZW51bWVyYXRvckdQUiwgSlNQcm9wZXJ0eU5hbWVFbnVtZXJhdG9yOjpjYWNoZWRQ cm9wZXJ0eU5hbWVzVmVjdG9yT2Zmc2V0KCkpLCBzY3JhdGNoMUdQUik7Ci0gICAgICAgIG1faml0 Lm1vdmUoaW5kZXhHUFIsIHNjcmF0Y2gyR1BSKTsKLSAgICAgICAgbV9qaXQuc2lnbkV4dGVuZDMy VG9QdHIoc2NyYXRjaDJHUFIsIHNjcmF0Y2gyR1BSKTsKLSAgICAgICAgbV9qaXQubG9hZDY0KE1h Y3JvQXNzZW1ibGVyOjpCYXNlSW5kZXgoc2NyYXRjaDFHUFIsIHNjcmF0Y2gyR1BSLCBNYWNyb0Fz c2VtYmxlcjo6VGltZXNFaWdodCksIHJlc3VsdEdQUik7CisgICAgICAgIG1faml0LmxvYWQ2NChN YWNyb0Fzc2VtYmxlcjo6QmFzZUluZGV4KHNjcmF0Y2gxR1BSLCBpbmRleEdQUiwgTWFjcm9Bc3Nl bWJsZXI6OlRpbWVzRWlnaHQpLCByZXN1bHRHUFIpOwogCiAgICAgICAgIGRvbmUubGluaygmbV9q aXQpOwogICAgICAgICBqc1ZhbHVlUmVzdWx0KHJlc3VsdEdQUiwgbm9kZSk7Cg==