135719 2014-08-07 13:38:21 -0700 REGRESSION(169139): LLINT intermittently fails JSC testapi tests 2015-03-25 16:16:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam webkit-bug-importer oldest_to_newest 1027590 0 mark.lam 2014-08-07 13:38:21 -0700 See http://build.webkit.org/builders/Apple%20Mavericks%20LLINT%20CLoop%20%28BuildAndTest%29/builds/7450/steps/webkit-jsc-cloop-test/logs/stdio. Maybe this is just a time out thing, but we should look into fixing the issue so that the LLINT CLoop bot is more reliable. 1027591 1 webkit-bug-importer 2014-08-07 13:39:01 -0700 <rdar://problem/17949979> 1080064 2 mark.lam 2015-03-25 15:35:09 -0700 This is a regression introduced in http://trac.webkit.org/changeset/169139 which changed VM::watchdog from an embedded field into a std::unique_ptr, but did not update the LLINT to access it as such. The issue has only manifested so far on the CLoop tests because those are LLINT only. In the non-CLoop cases, the JIT kicks in and does the right thing, thereby hiding the bug in the LLINT. 1080085 3 249438 mark.lam 2015-03-25 16:10:12 -0700 Created attachment 249438 the patch. 1080087 4 249438 ggaren 2015-03-25 16:13:16 -0700 Comment on attachment 249438 the patch. r=me 1080088 5 mark.lam 2015-03-25 16:16:54 -0700 Thanks. Landed in r181981: <http://trac.webkit.org/r181981>. 249438 2015-03-25 16:10:12 -0700 2015-03-25 16:13:16 -0700 the patch. bug-135719.patch text/plain 3730 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTgxOTc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBA CisyMDE1LTAzLTI1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBS RUdSRVNTSU9OKDE2OTEzOSk6IExMSU5UIGludGVybWl0dGVudGx5IGZhaWxzIEpTQyB0ZXN0YXBp IHRlc3RzLgorICAgICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM1NzE5PgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYSByZWdyZXNz aW9uIGludHJvZHVjZWQgaW4gaHR0cDovL3RyYWMud2Via2l0Lm9yZy9jaGFuZ2VzZXQvMTY5MTM5 IHdoaWNoCisgICAgICAgIGNoYW5nZWQgVk06OndhdGNoZG9nIGZyb20gYW4gZW1iZWRkZWQgZmll bGQgaW50byBhIHN0ZDo6dW5pcXVlX3B0ciwgYnV0IGRpZCBub3QKKyAgICAgICAgdXBkYXRlIHRo ZSBMTElOVCB0byBhY2Nlc3MgaXQgYXMgc3VjaC4KKworICAgICAgICBUaGUgaXNzdWUgaGFzIG9u bHkgbWFuaWZlc3RlZCBzbyBmYXIgb24gdGhlIENMb29wIHRlc3RzIGJlY2F1c2UgdGhvc2UgYXJl IExMSU5UCisgICAgICAgIG9ubHkuICBJbiB0aGUgbm9uLUNMb29wIGNhc2VzLCB0aGUgSklUIGtp Y2tzIGluIGFuZCBkb2VzIHRoZSByaWdodCB0aGluZywgdGhlcmVieQorICAgICAgICBoaWRpbmcg dGhlIGJ1ZyBpbiB0aGUgTExJTlQuCisKKyAgICAgICAgKiBBUEkvSlNDb250ZXh0UmVmLmNwcDoK KyAgICAgICAgKGNyZWF0ZVdhdGNoZG9nSWZOZWVkZWQpOgorICAgICAgICAoSlNDb250ZXh0R3Jv dXBTZXRFeGVjdXRpb25UaW1lTGltaXQpOgorICAgICAgICAoSlNDb250ZXh0R3JvdXBDbGVhckV4 ZWN1dGlvblRpbWVMaW1pdCk6CisgICAgICAgICogbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5h c206CisKIDIwMTUtMDMtMjUgIEZpbGlwIFBpemxvICA8ZnBpemxvQGFwcGxlLmNvbT4KIAogICAg ICAgICBDaGFuZ2UgQXRvbWljIG1ldGhvZHMgZnJvbSB1c2luZyB0aGVfd3JvbmdfbmFtaW5nX2Nv bnZlbnRpb25zIHRvIHVzaW5nIHRoZVJpZ2h0TmFtaW5nQ29udmVudGlvbnMuIEFsc28gbWFrZSBz ZXFfY3N0IHRoZSBkZWZhdWx0LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRDb3JlL0FQSS9KU0Nv bnRleHRSZWYuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlND b250ZXh0UmVmLmNwcAkocmV2aXNpb24gMTgxOTY4KQorKysgU291cmNlL0phdmFTY3JpcHRDb3Jl L0FQSS9KU0NvbnRleHRSZWYuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xMDAsMTIgKzEwMCwyMyBA QCBzdGF0aWMgYm9vbCBpbnRlcm5hbFNjcmlwdFRpbWVvdXRDYWxsYmFjCiAgICAgcmV0dXJuIGNh bGxiYWNrKGNvbnRleHRSZWYsIGNhbGxiYWNrRGF0YSk7CiB9CiAKK3N0YXRpYyB2b2lkIGNyZWF0 ZVdhdGNoZG9nSWZOZWVkZWQoVk0mIHZtKQoreworICAgIGlmICghdm0ud2F0Y2hkb2cpIHsKKyAg ICAgICAgdm0ud2F0Y2hkb2cgPSBzdGQ6Om1ha2VfdW5pcXVlPFdhdGNoZG9nPigpOworCisgICAg ICAgIC8vIFRoZSBMTElOVCBwZWVrcyBpbnRvIHRoZSBXYXRjaGRvZyBvYmplY3QgZGlyZWN0bHku IEluIG9yZGVyIHRvIGRvIHRoYXQsCisgICAgICAgIC8vIHRoZSBMTElOVCBhc3N1bWVzIHRoYXQg dGhlIGludGVybmFsIHNoYXBlIG9mIGEgc3RkOjp1bmlxdWVfcHRyIGlzIHRoZQorICAgICAgICAv LyBzYW1lIGFzIGEgcGxhaW4gQysrIHBvaW50ZXIsIGFuZCBsb2FkcyB0aGUgYWRkcmVzcyBvZiBX YXRjaGRvZyBmcm9tIGl0LgorICAgICAgICBSRUxFQVNFX0FTU0VSVCgqcmVpbnRlcnByZXRfY2Fz dDxXYXRjaGRvZyoqPigmdm0ud2F0Y2hkb2cpID09IHZtLndhdGNoZG9nLmdldCgpKTsKKyAgICB9 Cit9CisKIHZvaWQgSlNDb250ZXh0R3JvdXBTZXRFeGVjdXRpb25UaW1lTGltaXQoSlNDb250ZXh0 R3JvdXBSZWYgZ3JvdXAsIGRvdWJsZSBsaW1pdCwgSlNTaG91bGRUZXJtaW5hdGVDYWxsYmFjayBj YWxsYmFjaywgdm9pZCogY2FsbGJhY2tEYXRhKQogewogICAgIFZNJiB2bSA9ICp0b0pTKGdyb3Vw KTsKICAgICBKU0xvY2tIb2xkZXIgbG9ja2VyKCZ2bSk7Ci0gICAgaWYgKCF2bS53YXRjaGRvZykK LSAgICAgICAgdm0ud2F0Y2hkb2cgPSBzdGQ6Om1ha2VfdW5pcXVlPFdhdGNoZG9nPigpOworICAg IGNyZWF0ZVdhdGNoZG9nSWZOZWVkZWQodm0pOwogICAgIFdhdGNoZG9nJiB3YXRjaGRvZyA9ICp2 bS53YXRjaGRvZzsKICAgICBpZiAoY2FsbGJhY2spIHsKICAgICAgICAgdm9pZCogY2FsbGJhY2tQ dHIgPSByZWludGVycHJldF9jYXN0PHZvaWQqPihjYWxsYmFjayk7CkBAIC0xMTgsOCArMTI5LDcg QEAgdm9pZCBKU0NvbnRleHRHcm91cENsZWFyRXhlY3V0aW9uVGltZUxpbQogewogICAgIFZNJiB2 bSA9ICp0b0pTKGdyb3VwKTsKICAgICBKU0xvY2tIb2xkZXIgbG9ja2VyKCZ2bSk7Ci0gICAgaWYg KCF2bS53YXRjaGRvZykKLSAgICAgICAgdm0ud2F0Y2hkb2cgPSBzdGQ6Om1ha2VfdW5pcXVlPFdh dGNoZG9nPigpOworICAgIGNyZWF0ZVdhdGNoZG9nSWZOZWVkZWQodm0pOwogICAgIFdhdGNoZG9n JiB3YXRjaGRvZyA9ICp2bS53YXRjaGRvZzsKICAgICB3YXRjaGRvZy5zZXRUaW1lTGltaXQodm0s IHN0ZDo6Y2hyb25vOjptaWNyb3NlY29uZHM6Om1heCgpKTsKIH0KSW5kZXg6IFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVycHJldGVyLmFzbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvbGxpbnQvTG93TGV2ZWxJbnRlcnByZXRlci5hc20JKHJldmlz aW9uIDE4MTk2OCkKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9sbGludC9Mb3dMZXZlbEludGVy cHJldGVyLmFzbQkod29ya2luZyBjb3B5KQpAQCAtMTEyMCwxMiArMTEyMCwxNCBAQCBfbGxpbnRf b3BfbG9vcF9oaW50OgogICAgIHRyYWNlRXhlY3V0aW9uKCkKICAgICBsb2FkcCBDb2RlQmxvY2tb Y2ZyXSwgdDEKICAgICBsb2FkcCBDb2RlQmxvY2s6Om1fdm1bdDFdLCB0MQotICAgIGxvYWRiIFZN Ojp3YXRjaGRvZytXYXRjaGRvZzo6bV90aW1lckRpZEZpcmVbdDFdLCB0MAotICAgIGJ0Ym56IHQw LCAuaGFuZGxlV2F0Y2hkb2dUaW1lcgorICAgIGxvYWRwIFZNOjp3YXRjaGRvZ1t0MV0sIHQwCisg ICAgYnRwbnogdDAsIC5oYW5kbGVXYXRjaGRvZ1RpbWVyCiAuYWZ0ZXJXYXRjaGRvZ1RpbWVyQ2hl Y2s6CiAgICAgY2hlY2tTd2l0Y2hUb0pJVEZvckxvb3AoKQogICAgIGRpc3BhdGNoKDEpCiAuaGFu ZGxlV2F0Y2hkb2dUaW1lcjoKKyAgICBsb2FkYiBXYXRjaGRvZzo6bV90aW1lckRpZEZpcmVbdDBd LCB0MAorICAgIGJ0YnogdDAsIC5hZnRlcldhdGNoZG9nVGltZXJDaGVjawogICAgIGNhbGxXYXRj aGRvZ1RpbWVySGFuZGxlcigudGhyb3dIYW5kbGVyKQogICAgIGptcCAuYWZ0ZXJXYXRjaGRvZ1Rp bWVyQ2hlY2sKIC50aHJvd0hhbmRsZXI6Cg==