135716 2014-08-07 13:29:25 -0700 Create UTF-8 string from in-band VTT cues 2014-08-07 20:53:25 -0700 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson ap fpizlo jer.noble oldest_to_newest 1027583 0 eric.carlson 2014-08-07 13:29:25 -0700 VTT cues are always UTF-8, so use String::fromUTF8(). 1027607 1 236219 eric.carlson 2014-08-07 14:04:03 -0700 Created attachment 236219 Proposed patch. 1027610 2 eric.carlson 2014-08-07 14:05:08 -0700 Committed r172257: https://trac.webkit.org/r172257 1027611 3 eric.carlson 2014-08-07 14:06:21 -0700 <rdar://problem/17925660> 1027751 4 236219 ap 2014-08-07 20:53:25 -0700 Comment on attachment 236219 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=236219&action=review > Source/WebCore/platform/graphics/ISOVTTCue.cpp:78 > + return String::fromUTF8(JSC::Uint8Array::create(data, offset, length)->data(), length); What is the reason to create a UInt8Array here? This seems much more natural to me: return String::fromUTF8(static_cast<const char*>(data->data()) + offset, length); 236219 2014-08-07 14:04:03 -0700 2014-08-07 20:53:25 -0700 Proposed patch. string_encoding_patch_2.txt text/plain 1457 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MjIzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTA4LTA3ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIENyZWF0ZSBVVEYtOCBz dHJpbmcgZnJvbSBpbi1iYW5kIFZUVCBjdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3MTYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBUZXN0cyB3aWxsIGJlIGFkZGVkIGluIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU3MTcuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9n cmFwaGljcy9JU09WVFRDdWUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SVNPQm94OjpwZWVrU3Ry aW5nKTogQ2FsbCBTdHJpbmc6OmZyb21VVEY4IGJlY2F1c2Ugd2Uga25vdyB0aGF0IFZUVCBpcyBh bHdheXMKKyAgICAgICAgICAgIFVURi04LgorCiAyMDE0LTA4LTA3ICBHb3Jkb24gU2hlcmlkYW4g IDxnb3Jkb25fc2hlcmlkYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFByb3ZpZGUgbWV0aG9kcyB0 byBjbGVhciB1bmRlc2lyZWQgcmVmZXJlbmNlcyB0byBIaXN0b3J5SXRlbXMgdGhhdCBoYXZlIGJl ZW4gcmVtb3ZlZCBmcm9tIHRoZSBiYWNrL2ZvcmFyZCBsaXN0LgpJbmRleDogU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvSVNPVlRUQ3VlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JU09WVFRDdWUuY3BwCShyZXZpc2lvbiAxNzIxNjEp CisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JU09WVFRDdWUuY3BwCSh3b3Jr aW5nIGNvcHkpCkBAIC03NSw3ICs3NSw3IEBAIFN0cmluZyBJU09Cb3g6OnBlZWtTdHJpbmcoQXJy YXlCdWZmZXIqIGQKICAgICBpZiAoZGF0YS0+Ynl0ZUxlbmd0aCgpIDwgb2Zmc2V0ICsgbGVuZ3Ro KQogICAgICAgICByZXR1cm4gZW1wdHlTdHJpbmcoKTsKIAotICAgIHJldHVybiBTdHJpbmcoSlND OjpVaW50OEFycmF5OjpjcmVhdGUoZGF0YSwgb2Zmc2V0LCBsZW5ndGgpLT5kYXRhKCksIGxlbmd0 aCk7CisgICAgcmV0dXJuIFN0cmluZzo6ZnJvbVVURjgoSlNDOjpVaW50OEFycmF5OjpjcmVhdGUo ZGF0YSwgb2Zmc2V0LCBsZW5ndGgpLT5kYXRhKCksIGxlbmd0aCk7CiB9CiAKIHN0YXRpYyBjb25z dCBBdG9taWNTdHJpbmcmIHZ0dEN1ZUJveFR5cGUoKQo=