135700 2014-08-07 05:34:23 -0700 [EFL] Do not initialize g_type in WebProcessMain::platformInitialize() 2014-08-08 19:37:57 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski bunhere cdumez commit-queue gyuyoung.kim lucas.de.marchi sergio oldest_to_newest 1027470 0 g.czajkowski 2014-08-07 05:34:23 -0700 Inspired by Jinwoo commit (r171788). Glib since 2.36 itself initializes g_type_init. 1027473 1 236186 g.czajkowski 2014-08-07 05:44:17 -0700 Created attachment 236186 Patch 1027837 2 236186 ryuan.choi 2014-08-08 05:12:50 -0700 Comment on attachment 236186 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236186&action=review Looks good to me. > Source/WebKit2/WebProcess/efl/WebProcessMainEfl.cpp:-101 > -#if !GLIB_CHECK_VERSION(2, 35, 0) > - g_type_init(); > -#endif > - Yes, we are using at least GLIB 2.38 1028033 3 236186 gyuyoung.kim 2014-08-08 19:04:09 -0700 Comment on attachment 236186 Patch r=me. 1028039 4 236186 commit-queue 2014-08-08 19:37:52 -0700 Comment on attachment 236186 Patch Clearing flags on attachment: 236186 Committed r172371: <http://trac.webkit.org/changeset/172371> 1028040 5 commit-queue 2014-08-08 19:37:57 -0700 All reviewed patches have been landed. Closing bug. 236186 2014-08-07 05:44:17 -0700 2014-08-08 19:37:52 -0700 Patch 0001-g_tye_init-skip.patch text/plain 1578 g.czajkowski RnJvbSBmYTJiYWQ1Zjc0MDA1MmNlMWNlOGE5NjRmZTRmYTk4YjVjZGRkNmQyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBHcnplZ29yeiBDemFqa293c2tpIDxnLmN6YWprb3dza2lAc2Ft c3VuZy5jb20+CkRhdGU6IFRodSwgNyBBdWcgMjAxNCAxNDozNDo0NSArMDIwMApTdWJqZWN0OiBb UEFUQ0hdIGdfdHllX2luaXQgc2tpcAoKLS0tCiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgICAg ICAgICAgICAgICAgICAgICAgICAgICB8ICAgMTIgKysrKysrKysrKysrCiAuLi4vV2ViS2l0Mi9X ZWJQcm9jZXNzL2VmbC9XZWJQcm9jZXNzTWFpbkVmbC5jcHAgICB8ICAgIDQgLS0tLQogMiBmaWxl cyBjaGFuZ2VkLCAxMiBpbnNlcnRpb25zKCspLCA0IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRl eCA5YjRhYTAyLi43OGU4Njk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDgt MDcgIEdyemVnb3J6IEN6YWprb3dza2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CisKKyAg ICAgICAgW0VGTF0gRG8gbm90IGluaXRpYWxpemUgZ190eXBlIGluIFdlYlByb2Nlc3NNYWluOjpw bGF0Zm9ybUluaXRpYWxpemUoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM1NzAwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgSW5zcGlyZWQgYnkgcjE3MTc4OC4KKyAgICAgICAgR2xpYiBzaW5jZSAyLjM2 IGl0c2VsZiBpbml0aWFsaXplcyBnX3R5cGVfaW5pdC4KKworICAgICAgICAqIFdlYlByb2Nlc3Mv ZWZsL1dlYlByb2Nlc3NNYWluRWZsLmNwcDoKKwogMjAxNC0wOC0wNiAgVGltIEhvcnRvbiAgPHRp bW90aHlfaG9ydG9uQGFwcGxlLmNvbT4KIAogICAgICAgICBTZXJ2aWNlcyBvdmVybGF5IGZsYXNo ZXMgYSBsb3Q7IHNob3VsZCBoYXZlIHNvbWUgaHlzdGVyZXNpcyBiZWZvcmUgc2hvd2luZyBvdmVy bGF5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2VmbC9XZWJQcm9jZXNz TWFpbkVmbC5jcHAgYi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL2VmbC9XZWJQcm9jZXNzTWFp bkVmbC5jcHAKaW5kZXggY2JlYjMyMi4uNTJkMGFjYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvV2ViUHJvY2Vzcy9lZmwvV2ViUHJvY2Vzc01haW5FZmwuY3BwCisrKyBiL1NvdXJjZS9XZWJL aXQyL1dlYlByb2Nlc3MvZWZsL1dlYlByb2Nlc3NNYWluRWZsLmNwcApAQCAtOTUsMTAgKzk1LDYg QEAgcHVibGljOgogICAgICAgICAgICAgcmV0dXJuIGZhbHNlOwogICAgICAgICB9CiAKLSNpZiAh R0xJQl9DSEVDS19WRVJTSU9OKDIsIDM1LCAwKQotICAgICAgICBnX3R5cGVfaW5pdCgpOwotI2Vu ZGlmCi0KICAgICAgICAgaWYgKCFlY29yZV9tYWluX2xvb3BfZ2xpYl9pbnRlZ3JhdGUoKSkKICAg ICAgICAgICAgIHJldHVybiBmYWxzZTsKIAotLSAKMS43LjkuNQoK