135696 2014-08-07 03:01:48 -0700 [GTK] Test /webkit2/WebKitUserContentManager/injected-script fails 2014-08-07 03:20:28 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 1 cgarcia webkit-unassigned oldest_to_newest 1027456 0 cgarcia 2014-08-07 03:01:48 -0700 /webkit2/WebKitUserContentManager/injected-script: ** ERROR:../../Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:89:bool isScriptInjectedForURLAtPath(WebViewTest*, const char*): assertion failed: (javascriptResult) FAIL 1027458 1 236183 cgarcia 2014-08-07 03:08:02 -0700 Created attachment 236183 Patch 1027459 2 236183 svillar 2014-08-07 03:14:37 -0700 Comment on attachment 236183 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236183&action=review OK! > Tools/TestWebKitAPI/Tests/WebKit2Gtk/TestWebKitUserContentManager.cpp:54 > +static const char* kScriptTestScript = "document.getElementById('item').innerText"; Although harmless, you shouldn't need this. 1027460 3 cgarcia 2014-08-07 03:20:28 -0700 Committed r172206: <http://trac.webkit.org/changeset/172206> 236183 2014-08-07 03:08:02 -0700 2014-08-07 03:14:37 -0700 Patch wk2-user-scripts-test.diff text/plain 2939 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5YWFi ZDUwLi40MGE3ZDhlIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjAgQEAKIDIwMTQtMDgtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIFRlc3QgL3dlYmtpdDIvV2Vi S2l0VXNlckNvbnRlbnRNYW5hZ2VyL2luamVjdGVkLXNjcmlwdCBmYWlscworICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1Njk2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHRoZSBKYXZhU2NyaXB0IHVz ZWQgZm9yIHRoZSB0ZXN0cyBhbmQgZG9uJ3QgYXNzdW1lIHRoZQorICAgICAgICBKYXZhU2NyaXB0 IHJlc3VsdCBpcyBhbHdheXMgYSB2YWxpZCBwb2ludGVyLiBJbiBjYXNlIG9mIEphdmFTY3JpcHQK KyAgICAgICAgZXhjZXB0aW9uICh0aGF0IGhhcHBlbnMgd2hlbiB0ZXN0aW5nIHRoZSBzY3JpcHQg aGFzbid0IGJlZW4KKyAgICAgICAgaW5qZWN0ZWQpIHRoZSBKYXZhU2NyaXB0IHJlc3VsdCBpcyBO VUxMLgorCisgICAgICAgICogVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3RrL1Rlc3RXZWJL aXRVc2VyQ29udGVudE1hbmFnZXIuY3BwOgorICAgICAgICAoaXNTY3JpcHRJbmplY3RlZEZvclVS TEF0UGF0aCk6CisKKzIwMTQtMDgtMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBp Z2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIFVzZSBXZWJLaXROYXZpZ2F0aW9uQWN0aW9uIGFs c28gZm9yIFdlYktpdE5hdmlnYXRpb25Qb2xpY3lEZWNpc2lvbgogICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1Njk1CiAKZGlmZiAtLWdpdCBhL1Rvb2xz L1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViS2l0VXNlckNvbnRlbnRNYW5h Z2VyLmNwcCBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0Mkd0ay9UZXN0V2ViS2l0 VXNlckNvbnRlbnRNYW5hZ2VyLmNwcAppbmRleCBlZTYwNDlmLi42YmM3ZTY3IDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJHdGsvVGVzdFdlYktpdFVzZXJDb250 ZW50TWFuYWdlci5jcHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXQyR3Rr L1Rlc3RXZWJLaXRVc2VyQ29udGVudE1hbmFnZXIuY3BwCkBAIC01MSw3ICs1MSw3IEBAIHN0YXRp YyBjb25zdCBjaGFyKiBrSW5qZWN0ZWRTdHlsZVNoZWV0ID0gIiNzdHlsZWRFbGVtZW50IHsgZm9u dC13ZWlnaHQ6IGJvbGQ7IH0iCiBzdGF0aWMgY29uc3QgY2hhcioga1N0eWxlU2hlZXRUZXN0U2Ny aXB0ID0gImdldENvbXB1dGVkU3R5bGUoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ3N0eWxlZEVs ZW1lbnQnKSlbJ2ZvbnQtd2VpZ2h0J10iOwogc3RhdGljIGNvbnN0IGNoYXIqIGtTdHlsZVNoZWV0 VGVzdFNjcmlwdFJlc3VsdCA9ICJib2xkIjsKIHN0YXRpYyBjb25zdCBjaGFyKiBrSW5qZWN0ZWRT Y3JpcHQgPSAiZG9jdW1lbnQud3JpdGUoJzxkaXYgaWQ9XCJpdGVtXCI+R2VuZXJhdGVkIGJ5IGEg c2NyaXB0PC9kaXY+JykiOwotc3RhdGljIGNvbnN0IGNoYXIqIGtTY3JpcHRUZXN0U2NyaXB0ID0g ImdldEVsZW1lbnRCeUlkKCdpdGVtJykuaW5uZXJUZXh0IjsKK3N0YXRpYyBjb25zdCBjaGFyKiBr U2NyaXB0VGVzdFNjcmlwdCA9ICJkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnaXRlbScpLmlubmVy VGV4dCI7CiBzdGF0aWMgY29uc3QgY2hhcioga1NjcmlwdFRlc3RTY3JpcHRSZXN1bHQgPSAiR2Vu ZXJhdGVkIGJ5IGEgc2NyaXB0IjsKIAogc3RhdGljIHZvaWQgdGVzdFdlYlZpZXdOZXdXaXRoVXNl ckNvbnRlbnRNYW5hZ2VyKFRlc3QqIHRlc3QsIGdjb25zdHBvaW50ZXIpCkBAIC04NSwxMiArODUs MTMgQEAgc3RhdGljIGJvb2wgaXNTY3JpcHRJbmplY3RlZEZvclVSTEF0UGF0aChXZWJWaWV3VGVz dCogdGVzdCwgY29uc3QgY2hhciogcGF0aCkKICAgICB0ZXN0LT53YWl0VW50aWxMb2FkRmluaXNo ZWQoKTsKIAogICAgIEdVbmlxdWVPdXRQdHI8R0Vycm9yPiBlcnJvcjsKLSAgICBXZWJLaXRKYXZh c2NyaXB0UmVzdWx0KiBqYXZhc2NyaXB0UmVzdWx0ID0gdGVzdC0+cnVuSmF2YVNjcmlwdEFuZFdh aXRVbnRpbEZpbmlzaGVkKGtTY3JpcHRUZXN0U2NyaXB0LCAmZXJyb3Iub3V0UHRyKCkpOwotICAg IGdfYXNzZXJ0KGphdmFzY3JpcHRSZXN1bHQpOwotICAgIGdfYXNzZXJ0KCFlcnJvci5nZXQoKSk7 CisgICAgaWYgKFdlYktpdEphdmFzY3JpcHRSZXN1bHQqIGphdmFzY3JpcHRSZXN1bHQgPSB0ZXN0 LT5ydW5KYXZhU2NyaXB0QW5kV2FpdFVudGlsRmluaXNoZWQoa1NjcmlwdFRlc3RTY3JpcHQsICZl cnJvci5vdXRQdHIoKSkpIHsKKyAgICAgICAgZ19hc3NlcnQoIWVycm9yLmdldCgpKTsKIAotICAg IEdVbmlxdWVQdHI8Y2hhcj4gcmVzdWx0U3RyaW5nKFdlYlZpZXdUZXN0OjpqYXZhc2NyaXB0UmVz dWx0VG9DU3RyaW5nKGphdmFzY3JpcHRSZXN1bHQpKTsKLSAgICByZXR1cm4gIWdfc3RyY21wMChy ZXN1bHRTdHJpbmcuZ2V0KCksIGtTY3JpcHRUZXN0U2NyaXB0UmVzdWx0KTsKKyAgICAgICAgR1Vu aXF1ZVB0cjxjaGFyPiByZXN1bHRTdHJpbmcoV2ViVmlld1Rlc3Q6OmphdmFzY3JpcHRSZXN1bHRU b0NTdHJpbmcoamF2YXNjcmlwdFJlc3VsdCkpOworICAgICAgICByZXR1cm4gIWdfc3RyY21wMChy ZXN1bHRTdHJpbmcuZ2V0KCksIGtTY3JpcHRUZXN0U2NyaXB0UmVzdWx0KTsKKyAgICB9CisgICAg cmV0dXJuIGZhbHNlOwogfQogCiBzdGF0aWMgdm9pZCBmaWxsVVJMTGlzdEZyb21QYXRocyhjaGFy KiogbGlzdCwgY29uc3QgY2hhciogcGF0aCwgLi4uKQo=