135694 2014-08-07 01:19:19 -0700 [GTK] REGRESSION(r166239): The ld version script is not being used 2014-08-10 00:30:52 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 135760 1 berto webkit-unassigned bunhere cdumez cgarcia commit-queue gustavo gyuyoung.kim rakuco sergio oldest_to_newest 1027448 0 berto 2014-08-07 01:19:19 -0700 The symbols.filter script contains the list of symbols that are local and visible outside of the webkit library. Source/cmake/OptionsGTK.cmake contains the following line: set(VERSION_SCRIPT "-Wl,--version-script,${CMAKE_SOURCE_DIR}/Source/autotools/symbols.filter") However we don't seem to be using it and that variable is not referenced anywhere else (and that's anyway the old path, it was moved to Tools/gtk when we switched to cmake). 1027834 1 236276 cgarcia 2014-08-08 04:26:29 -0700 Created attachment 236276 Patch 1027885 2 cgarcia 2014-08-08 11:14:43 -0700 I guess the eflsymbols.filter file is not up to date, or it's only for WebKit1, or whatever, anyway I'll add the VERSION_SCRIPT to LDFLAGS only for GTK then. 1028083 3 236341 cgarcia 2014-08-10 00:15:55 -0700 Created attachment 236341 Patch for landing 1028085 4 cgarcia 2014-08-10 00:30:52 -0700 Committed r172377: <http://trac.webkit.org/changeset/172377> 236276 2014-08-08 04:26:29 -0700 2014-08-10 00:15:55 -0700 Patch wk2-symbols.diff text/plain 3539 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBhMTQ0NDZkLi44YjdmZDQw IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTQtMDgtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgor CisgICAgICAgIFtHVEtdIFJFR1JFU1NJT04ocjE2NjIzOSk6IFRoZSBsZCB2ZXJzaW9uIHNjcmlw dCBpcyBub3QgYmVpbmcgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM1Njk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTW92ZSB0aGUgc3ltYm9scyBmaWx0ZXIgZmlsZSBmcm9tIFRvb2xzL2d0ayB0 byBTb3VyY2UvY21ha2UgYW5kIHJlbmFtZQorICAgICAgICBpdCBhcyBndGtzeW1ib2xzLmZpbHRl ci4gQWxzbyB1cGRhdGVkIGl0LCBzaW5jZSBzb21lIG9mIHRoZSBzeW1ib2xzCisgICAgICAgIGV4 cG9ydGVkIHdlcmUgcmVuYW1lZC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RL LmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9ndGtzeW1ib2xzLmZpbHRlcjogUmVuYW1l ZCBmcm9tIFRvb2xzL2d0ay9zeW1ib2xzLmZpbHRlci4KKwogMjAxNC0wOC0wOCAgWmFuIERvYmVy c2VrICA8emRvYmVyc2VrQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0NNYWtlXSBEcm9wIHRoZSBy ZXF1aXJlZCB2ZXJzaW9uIG9mIENNYWtlIGRvd24gdG8gMi44LjgKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQK aW5kZXggYTI2ZWY3MC4uM2Y1MTg4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ01ha2VM aXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKQEAgLTcwNCw2ICs3 MDQsMTAgQEAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKFdlYktpdDIgJHtXZWJLaXQyX0xJQlJBUklF U30pCiBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoV2ViS2l0MiBQUk9QRVJUSUVTIEZPTERFUiAiV2Vi S2l0IikKIHNldF90YXJnZXRfcHJvcGVydGllcyhXZWJLaXQyIFBST1BFUlRJRVMgTElOS19JTlRF UkZBQ0VfTElCUkFSSUVTICIiKQogCitpZiAoVkVSU0lPTl9TQ1JJUFQpCisgICAgQUREX1RBUkdF VF9QUk9QRVJUSUVTKFdlYktpdDIgTElOS19GTEFHUyAiJHtWRVJTSU9OX1NDUklQVH0iKQorZW5k aWYgKCkKKwogaWYgKFdlYktpdDJfT1VUUFVUX05BTUUpCiAgICAgc2V0X3RhcmdldF9wcm9wZXJ0 aWVzKFdlYktpdDIgUFJPUEVSVElFUyBPVVRQVVRfTkFNRSAke1dlYktpdDJfT1VUUFVUX05BTUV9 KQogZW5kaWYgKCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZwppbmRleCAyNjU0OWJiLi43ZTI5MDQxIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBA IC0xLDUgKzEsMTQgQEAKIDIwMTQtMDgtMDggIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNp YUBpZ2FsaWEuY29tPgogCisgICAgICAgIFtHVEtdIFJFR1JFU1NJT04ocjE2NjIzOSk6IFRoZSBs ZCB2ZXJzaW9uIHNjcmlwdCBpcyBub3QgYmVpbmcgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1Njk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3RzLnR4dDogQWRkIFZFUlNJT05f U0NSSVBUIHRvIFdlYktpdDIgbGluayBmbGFncyBpZiBwcmVzZW50LgorCisyMDE0LTA4LTA4ICBD YXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBbR1RL XSBEbyBub3QgdXNlIEd0a1dpbmRvdzpyZXNpemUtZ3JpcC12aXNpYmxlIHdpdGggcmVjZW50IEdU SysgdmVyc2lvbnMKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNTY5OQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBi L1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCmluZGV4IDUwOTAxZmYuLjg3MGMwM2IgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFr ZS9PcHRpb25zR1RLLmNtYWtlCkBAIC05MSw3ICs5MSw3IEBAIGlmIChERVZFTE9QRVJfTU9ERSkK IGVsc2UgKCkKICAgICBzZXQoRU5BQkxFX1RPT0xTIE9GRikKICAgICBXRUJLSVRfT1BUSU9OX0RF RkFVTFRfUE9SVF9WQUxVRShFTkFCTEVfQVBJX1RFU1RTIE9GRikKLSAgICBzZXQoVkVSU0lPTl9T Q1JJUFQgIi1XbCwtLXZlcnNpb24tc2NyaXB0LCR7Q01BS0VfU09VUkNFX0RJUn0vU291cmNlL2F1 dG90b29scy9zeW1ib2xzLmZpbHRlciIpCisgICAgc2V0KFZFUlNJT05fU0NSSVBUICItV2wsLS12 ZXJzaW9uLXNjcmlwdCwke0NNQUtFX01PRFVMRV9QQVRIfS9ndGtzeW1ib2xzLmZpbHRlciIpCiBl bmRpZiAoKQogCiAjIEZJWE1FOiBXZSB3YW50IHRvIGV4cG9zZSBmZXdlciBvcHRpb25zIHRvIGRv d25zdHJlYW0sIGJ1dCBmb3Igbm93IGV2ZXJ5dGhpbmcgaXMgcHVibGljLgpkaWZmIC0tZ2l0IGEv U291cmNlL2NtYWtlL2d0a3N5bWJvbHMuZmlsdGVyIGIvU291cmNlL2NtYWtlL2d0a3N5bWJvbHMu ZmlsdGVyCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjBjNDE4M2EKLS0tIC9k ZXYvbnVsbAorKysgYi9Tb3VyY2UvY21ha2UvZ3Rrc3ltYm9scy5maWx0ZXIKQEAgLTAsMCArMSwx MiBAQAoreworZ2xvYmFsOgorICB3ZWJraXRfKjsKKyAgV2ViUHJvY2Vzc01haW5Vbml4OworICBO ZXR3b3JrUHJvY2Vzc01haW5Vbml4OworICBQbHVnaW5Qcm9jZXNzTWFpblVuaXg7CisgIF9aTjZX ZWJLaXQyMldlYkd0a0V4dGVuc2lvbk1hbmFnZXIxMGluaXRpYWxpemVFUEsxNE9wYXF1ZVdLQnVu ZGxlUEt2OworICBfWk42V2ViS2l0MjJXZWJHdGtFeHRlbnNpb25NYW5hZ2VyNnNoYXJlZEV2Owor bG9jYWw6CisgIHdlYmtpdF9tZWRpYV9wbGF5ZXJfZGVidWc7CisgICo7Cit9OwpkaWZmIC0tZ2l0 IGEvVG9vbHMvZ3RrL3N5bWJvbHMuZmlsdGVyIGIvVG9vbHMvZ3RrL3N5bWJvbHMuZmlsdGVyCmRl bGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRleCA4MWE5NzI1Li4wMDAwMDAwCi0tLSBhL1Rvb2xz L2d0ay9zeW1ib2xzLmZpbHRlcgorKysgL2Rldi9udWxsCkBAIC0xLDExICswLDAgQEAKLXsKLWds b2JhbDoKLSAgd2Via2l0Xyo7Ci0gIFdlYlByb2Nlc3NNYWluR3RrOwotICBOZXR3b3JrUHJvY2Vz c01haW47Ci0gIF9aTjZXZWJLaXQyMldlYkd0a0V4dGVuc2lvbk1hbmFnZXIxMGluaXRpYWxpemVF UEsxNE9wYXF1ZVdLQnVuZGxlUEt2OwotICBfWk42V2ViS2l0MjJXZWJHdGtFeHRlbnNpb25NYW5h Z2VyNnNoYXJlZEV2OwotbG9jYWw6Ci0gIHdlYmtpdF9tZWRpYV9wbGF5ZXJfZGVidWc7Ci0gICo7 Ci19Owo= 236341 2014-08-10 00:15:55 -0700 2014-08-10 00:15:55 -0700 Patch for landing wk2-version-script.diff text/plain 3638 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA5OGJjNmY1Li5jNDVhYjBj IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAK IDIwMTQtMDgtMTAgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgog CisgICAgICAgIFtHVEtdIFJFR1JFU1NJT04ocjE2NjIzOSk6IFRoZSBsZCB2ZXJzaW9uIHNjcmlw dCBpcyBub3QgYmVpbmcgdXNlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM1Njk0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTWFydGluIFJvYmluc29u LgorCisgICAgICAgIE1vdmUgdGhlIHN5bWJvbHMgZmlsdGVyIGZpbGUgZnJvbSBUb29scy9ndGsg dG8gU291cmNlL2NtYWtlIGFuZCByZW5hbWUKKyAgICAgICAgaXQgYXMgZ3Rrc3ltYm9scy5maWx0 ZXIuIEFsc28gdXBkYXRlZCBpdCwgc2luY2Ugc29tZSBvZiB0aGUgc3ltYm9scworICAgICAgICBl eHBvcnRlZCB3ZXJlIHJlbmFtZWQuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0dU Sy5jbWFrZToKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvZ3Rrc3ltYm9scy5maWx0ZXI6IFJlbmFt ZWQgZnJvbSBUb29scy9ndGsvc3ltYm9scy5maWx0ZXIuCisKKzIwMTQtMDgtMTAgIENhcmxvcyBH YXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCiAgICAgICAgIFtHVEtdIENoaWxk IHByb2Nlc3NlcyBzaG91bGQgYmUgaW5zdGFsbGVkIGluIGEgdmVyc2lvbmVkIGRpcmVjdG9yeQog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NzU0CiAK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYktp dDIvQ01ha2VMaXN0cy50eHQKaW5kZXggYTI2ZWY3MC4uNzZjYTFmOCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYktpdDIvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYktpdDIvQ01ha2VMaXN0 cy50eHQKQEAgLTcwNCw2ICs3MDQsMTAgQEAgdGFyZ2V0X2xpbmtfbGlicmFyaWVzKFdlYktpdDIg JHtXZWJLaXQyX0xJQlJBUklFU30pCiBzZXRfdGFyZ2V0X3Byb3BlcnRpZXMoV2ViS2l0MiBQUk9Q RVJUSUVTIEZPTERFUiAiV2ViS2l0IikKIHNldF90YXJnZXRfcHJvcGVydGllcyhXZWJLaXQyIFBS T1BFUlRJRVMgTElOS19JTlRFUkZBQ0VfTElCUkFSSUVTICIiKQogCitpZiAoV2ViS2l0Ml9WRVJT SU9OX1NDUklQVCkKKyAgICBBRERfVEFSR0VUX1BST1BFUlRJRVMoV2ViS2l0MiBMSU5LX0ZMQUdT ICIke1dlYktpdDJfVkVSU0lPTl9TQ1JJUFR9IikKK2VuZGlmICgpCisKIGlmIChXZWJLaXQyX09V VFBVVF9OQU1FKQogICAgIHNldF90YXJnZXRfcHJvcGVydGllcyhXZWJLaXQyIFBST1BFUlRJRVMg T1VUUFVUX05BTUUgJHtXZWJLaXQyX09VVFBVVF9OQU1FfSkKIGVuZGlmICgpCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5k ZXggNTJjMjc4OC4uOWI3MTNjNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTA4 LTEwICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXSBSRUdSRVNTSU9OKHIxNjYyMzkpOiBUaGUgbGQgdmVyc2lvbiBzY3JpcHQgaXMgbm90 IGJlaW5nIHVzZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNTY5NAorCisgICAgICAgIFJldmlld2VkIGJ5IE1hcnRpbiBSb2JpbnNvbi4KKworICAg ICAgICAqIENNYWtlTGlzdHMudHh0OiBBZGQgVkVSU0lPTl9TQ1JJUFQgdG8gV2ViS2l0MiBsaW5r IGZsYWdzIGlmIHByZXNlbnQuCisKIDIwMTQtMDgtMDkgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hv cnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVTU0lPTiAocjE3MjMwMSk6IENvbWJpbmVk IHBob25lIG51bWJlciBoaWdobGlnaHQgZG9lc24ndCBhcHBlYXIgaWYgcmljaCBjb250ZW50IGlz IHNlbGVjdGVkIGFuZCB3ZSBoYXZlIG5vIHJpY2ggY29udGVudCBzZXJ2aWNlcwpkaWZmIC0tZ2l0 IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dU Sy5jbWFrZQppbmRleCBlN2RiZGM3Li4yNzUzOGE2IDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2Uv T3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQpAQCAt OTEsNyArOTEsNyBAQCBpZiAoREVWRUxPUEVSX01PREUpCiBlbHNlICgpCiAgICAgc2V0KEVOQUJM RV9UT09MUyBPRkYpCiAgICAgV0VCS0lUX09QVElPTl9ERUZBVUxUX1BPUlRfVkFMVUUoRU5BQkxF X0FQSV9URVNUUyBPRkYpCi0gICAgc2V0KFZFUlNJT05fU0NSSVBUICItV2wsLS12ZXJzaW9uLXNj cmlwdCwke0NNQUtFX1NPVVJDRV9ESVJ9L1NvdXJjZS9hdXRvdG9vbHMvc3ltYm9scy5maWx0ZXIi KQorICAgIHNldChXZWJLaXQyX1ZFUlNJT05fU0NSSVBUICItV2wsLS12ZXJzaW9uLXNjcmlwdCwk e0NNQUtFX01PRFVMRV9QQVRIfS9ndGtzeW1ib2xzLmZpbHRlciIpCiBlbmRpZiAoKQogCiAjIEZJ WE1FOiBXZSB3YW50IHRvIGV4cG9zZSBmZXdlciBvcHRpb25zIHRvIGRvd25zdHJlYW0sIGJ1dCBm b3Igbm93IGV2ZXJ5dGhpbmcgaXMgcHVibGljLgpkaWZmIC0tZ2l0IGEvU291cmNlL2NtYWtlL2d0 a3N5bWJvbHMuZmlsdGVyIGIvU291cmNlL2NtYWtlL2d0a3N5bWJvbHMuZmlsdGVyCm5ldyBmaWxl IG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAuLjBjNDE4M2EKLS0tIC9kZXYvbnVsbAorKysgYi9T b3VyY2UvY21ha2UvZ3Rrc3ltYm9scy5maWx0ZXIKQEAgLTAsMCArMSwxMiBAQAoreworZ2xvYmFs OgorICB3ZWJraXRfKjsKKyAgV2ViUHJvY2Vzc01haW5Vbml4OworICBOZXR3b3JrUHJvY2Vzc01h aW5Vbml4OworICBQbHVnaW5Qcm9jZXNzTWFpblVuaXg7CisgIF9aTjZXZWJLaXQyMldlYkd0a0V4 dGVuc2lvbk1hbmFnZXIxMGluaXRpYWxpemVFUEsxNE9wYXF1ZVdLQnVuZGxlUEt2OworICBfWk42 V2ViS2l0MjJXZWJHdGtFeHRlbnNpb25NYW5hZ2VyNnNoYXJlZEV2OworbG9jYWw6CisgIHdlYmtp dF9tZWRpYV9wbGF5ZXJfZGVidWc7CisgICo7Cit9OwpkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL3N5 bWJvbHMuZmlsdGVyIGIvVG9vbHMvZ3RrL3N5bWJvbHMuZmlsdGVyCmRlbGV0ZWQgZmlsZSBtb2Rl IDEwMDY0NAppbmRleCA4MWE5NzI1Li4wMDAwMDAwCi0tLSBhL1Rvb2xzL2d0ay9zeW1ib2xzLmZp bHRlcgorKysgL2Rldi9udWxsCkBAIC0xLDExICswLDAgQEAKLXsKLWdsb2JhbDoKLSAgd2Via2l0 Xyo7Ci0gIFdlYlByb2Nlc3NNYWluR3RrOwotICBOZXR3b3JrUHJvY2Vzc01haW47Ci0gIF9aTjZX ZWJLaXQyMldlYkd0a0V4dGVuc2lvbk1hbmFnZXIxMGluaXRpYWxpemVFUEsxNE9wYXF1ZVdLQnVu ZGxlUEt2OwotICBfWk42V2ViS2l0MjJXZWJHdGtFeHRlbnNpb25NYW5hZ2VyNnNoYXJlZEV2Owot bG9jYWw6Ci0gIHdlYmtpdF9tZWRpYV9wbGF5ZXJfZGVidWc7Ci0gICo7Ci19Owo=