135691 2014-08-07 00:07:28 -0700 [EFL] Implement download directory selector on Minibrowser 2017-03-11 10:47:12 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Other Linux RESOLVED WONTFIX P2 Normal --- 1 atyourend webkit-unassigned lucas.de.marchi mcatanzaro shiva.jm oldest_to_newest 1027432 0 atyourend 2014-08-07 00:07:28 -0700 EFL Minibrowser doesn't implement download directory selector. To select destination download directory by user, Implement download directory selector on Minibrowser using existent fileselector API. 1027440 1 236177 atyourend 2014-08-07 00:49:24 -0700 Created attachment 236177 patch patch 1027446 2 atyourend 2014-08-07 01:15:06 -0700 The destination download path can be selected by user. And we can download a file whether suggested file name is exist or not. This is my first step to contribute on open source. I'll implement more this bug later. 1028156 3 shiva.jm 2014-08-11 03:01:18 -0700 (In reply to comment #2) > The destination download path can be selected by user. > And we can download a file whether suggested file name is exist or not. > > This is my first step to contribute on open source. > I'll implement more this bug later. hi i have submitted patch for similar issue https://bugs.webkit.org/show_bug.cgi?id=135791, how is your final patch going on? 1286641 4 mcatanzaro 2017-03-11 10:47:12 -0800 Closing this bug because the EFL port has been removed from trunk. If you feel this bug applies to a different upstream WebKit port and was closed in error, please either update the title and reopen the bug, or leave a comment to request this. 236177 2014-08-07 00:49:24 -0700 2014-08-07 00:49:45 -0700 patch patch-[20140807]-[atyourend@gmail.com]-[DownloadDirectorySelector].patch text/plain 3857 atyourend ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBjY2Zh ODkyLi4wMjM0NTRkIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMDgtMDcgIExlZSBXb25qdW4gIDxsZWUud29u anVuQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIEltcGxlbWVudCBkb3dubG9hZCBkaXJl Y3Rvcnkgc2VsZWN0b3Igb24gTWluaWJyb3dzZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTY5MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAg KG9uX2Rvd25sb2FkX3JlcXVlc3QpOgorICAgICAgICAoc2hvd19maWxlX2VudHJ5X2RpYWxvZyk6 CisKIDIwMTQtMDgtMDYgIERlYW4gSmFja3NvbiAgPGRpbm9AYXBwbGUuY29tPgogCiAgICAgICAg IEVOQUJMRV9DU1NfVFJBTlNGT1JNU19BTklNQVRJT05TX1VOUFJFRklYRUQgaXMgbm90IHVzZWQg YW55d2hlcmUuIFJlbW92ZSBpdC4KZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9t YWluLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IDEyZGVhYjcuLjJjMzg2 OTYxOCAxMDA2NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYworKysgYi9Ub29s cy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCkBAIC02NTMsMjYgKzY1MywzOCBAQCBvbl9lcnJvcih2 b2lkICp1c2VyX2RhdGEsIEV2YXNfT2JqZWN0ICpld2tfdmlldywgdm9pZCAqZXZlbnRfaW5mbykK IHN0YXRpYyB2b2lkCiBvbl9kb3dubG9hZF9yZXF1ZXN0KHZvaWQgKnVzZXJfZGF0YSwgRXZhc19P YmplY3QgKmV3a192aWV3LCB2b2lkICpldmVudF9pbmZvKQogeworICAgIEVpbmFfU3RyYnVmICpk ZXN0aW5hdGlvbl9wYXRoID0gZWluYV9zdHJidWZfbmV3KCk7CisgICAgQnJvd3Nlcl9XaW5kb3cg KndpbmRvdyA9IChCcm93c2VyX1dpbmRvdyAqKXVzZXJfZGF0YTsKICAgICBFd2tfRG93bmxvYWRf Sm9iICpkb3dubG9hZCA9IChFd2tfRG93bmxvYWRfSm9iICopZXZlbnRfaW5mbzsKKyAgICBjb25z dCBjaGFyICpzdWdnZXN0ZWRfbmFtZSA9IGV3a19kb3dubG9hZF9qb2Jfc3VnZ2VzdGVkX2ZpbGVu YW1lX2dldChkb3dubG9hZCk7CisgICAgY29uc3QgY2hhciAqaG9tZV9wYXRoID0gZ2V0ZW52KCJI T01FIik7CiAKLSAgICAvLyBGSVhNRTogVGhlIGRlc3RpbmF0aW9uIGZvbGRlciBzaG91bGQgYmUg c2VsZWN0ZWQgYnkgdGhlIHVzZXIgYnV0IHdlIHNldCBpdCB0byAnL3RtcCcgZm9yIG5vdy4KLSAg ICBFaW5hX1N0cmJ1ZiAqZGVzdGluYXRpb25fcGF0aCA9IGVpbmFfc3RyYnVmX25ldygpOworICAg IGlmICghaG9tZV9wYXRoKSB7CisgICAgICAgIGluZm8oIkVSUk9SOiBGYWlsIHRvIGxvYWQgaG9t ZSBwYXRoISIpOworICAgICAgICByZXR1cm47CisgICAgfQogCi0gICAgY29uc3QgY2hhciAqc3Vn Z2VzdGVkX25hbWUgPSBld2tfZG93bmxvYWRfam9iX3N1Z2dlc3RlZF9maWxlbmFtZV9nZXQoZG93 bmxvYWQpOwotICAgIGlmIChzdWdnZXN0ZWRfbmFtZSAmJiAqc3VnZ2VzdGVkX25hbWUpCi0gICAg ICAgIGVpbmFfc3RyYnVmX2FwcGVuZF9wcmludGYoZGVzdGluYXRpb25fcGF0aCwgIi90bXAvJXMi LCBzdWdnZXN0ZWRfbmFtZSk7Ci0gICAgZWxzZSB7Ci0gICAgICAgIC8vIEdlbmVyYXRlIGEgdW5p cXVlIGZpbGUgbmFtZSBzaW5jZSBubyBuYW1lIHdhcyBzdWdnZXN0ZWQuCi0gICAgICAgIGNoYXIg dW5pcXVlX3BhdGhbXSA9ICIvdG1wL2Rvd25sb2FkZWQtZmlsZS5YWFhYWFgiOwotICAgICAgICBp ZiAobWtzdGVtcCh1bmlxdWVfcGF0aCkgPT0gLTEpIHsKKyAgICBpZiAoIXN1Z2dlc3RlZF9uYW1l KSB7CisgICAgICAgIC8vIG1ha2UgYSB1bmlxdWUgZmlsZSBuYW1lIHdpdGggbWtzdGVtcAorICAg ICAgICBjaGFyIHVuaXF1ZV9maWxlX25hbWVbXSA9ICJkb3dubG9hZGVkLWZpbGUuWFhYWFhYIjsK KyAgICAgICAgaWYgKG1rc3RlbXAodW5pcXVlX2ZpbGVfbmFtZSkgPT0gLTEpIHsKICAgICAgICAg ICAgIGluZm8oIkVSUk9SOiBDb3VsZCBub3QgZ2VuZXJhdGUgYSB1bmlxdWUgZmlsZSBuYW1lLiIp OwogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICB9Ci0gICAgICAgIGVpbmFfc3RyYnVmX2Fw cGVuZChkZXN0aW5hdGlvbl9wYXRoLCB1bmlxdWVfcGF0aCk7CisgICAgICAgIHN1Z2dlc3RlZF9u YW1lID0gdW5pcXVlX2ZpbGVfbmFtZTsKICAgICB9CiAKLSAgICBld2tfZG93bmxvYWRfam9iX2Rl c3RpbmF0aW9uX3NldChkb3dubG9hZCwgZWluYV9zdHJidWZfc3RyaW5nX2dldChkZXN0aW5hdGlv bl9wYXRoKSk7Ci0gICAgaW5mbygiRG93bmxvYWRpbmc6ICVzIiwgZWluYV9zdHJidWZfc3RyaW5n X2dldChkZXN0aW5hdGlvbl9wYXRoKSk7CisgICAgZWluYV9zdHJidWZfYXBwZW5kX3ByaW50Zihk ZXN0aW5hdGlvbl9wYXRoLCAiJXMvRG93bmxvYWRzLyVzIiwgaG9tZV9wYXRoLCBzdWdnZXN0ZWRf bmFtZSk7CisKKyAgICBjb25zdCBjaGFyICphY3R1YWxfc2F2ZV9wYXRoID0gKGNvbnN0IGNoYXIg KilzaG93X2ZpbGVfZW50cnlfZGlhbG9nKHdpbmRvdywgIkRPV05MT0FEIiwgZWluYV9zdHJidWZf c3RyaW5nX2dldChkZXN0aW5hdGlvbl9wYXRoKSk7CisgICAgaWYgKCFhY3R1YWxfc2F2ZV9wYXRo KSB7CisgICAgICAgIGluZm8oIkVSUk9SOiBDb3VsZCBub3QgZ2VuZXJhdGUgYSBhY3R1YWxfc2F2 ZV9wYXRoIik7CisgICAgICAgIHJldHVybjsKKyAgICB9CisKKyAgICAvLyBGSVhNRTogSWYgdGhl cmUgaXMgYSBzYW1lIG5hbWUgZmlsZSBpbiB0aGUgZGlyZWN0b3J5LCBkb3dubG9hZCBmYWlsZWQu CisgICAgZXdrX2Rvd25sb2FkX2pvYl9kZXN0aW5hdGlvbl9zZXQoZG93bmxvYWQsIGFjdHVhbF9z YXZlX3BhdGgpOworICAgIGluZm8oIkRvd25sb2FkaW5nOiAlcyIsIGFjdHVhbF9zYXZlX3BhdGgp OwogICAgIGVpbmFfc3RyYnVmX2ZyZWUoZGVzdGluYXRpb25fcGF0aCk7CiB9CiAKQEAgLTEwODAs NiArMTA5MiwxMCBAQCBvbl9va19jbGlja2VkKHZvaWQgKnVzZXJfZGF0YSwgRXZhc19PYmplY3Qg Km9iaiwgdm9pZCAqZXZlbnRfaW5mbykKIHN0YXRpYyBFaW5hX1N0cmluZ3NoYXJlICoKIHNob3df ZmlsZV9lbnRyeV9kaWFsb2coQnJvd3Nlcl9XaW5kb3cgKndpbmRvdywgY29uc3QgY2hhciAqbGFi ZWxfdGFnLCBjb25zdCBjaGFyICpkZWZhdWx0X3RleHQpCiB7CisgICAgLy8gRklYTUUgOiBXaGVu IHRoZXJlIGlzIG5vIHN1Z2dlc3RlZCBmaWxlIG5hbWUoZXguZG93bmxvYWRlZC1maWxlLlJrZDBs aSksIGl0IGNyZWF0ZXMgdGVtcG9yYXJ5LW5hbWVkIGZpbGUgYmVmb3JlIHN0YXJ0aW5nIGRvd25s b2FkLgorICAgIC8vIEZJWE1FIDogV2hlbiB1c2VyIGNsaWNrcyAnY2FuY2xlJyBidXR0b24gb24g ZmlsZXNlbGVjdG9yIHdpbmRvdywgdGhlIHN1Z2dlc3RlZCBkb3dubG9hZCBwYXRoIGlzIGRlbGV0 ZWQuCisgICAgLy8gVE9ETyA6IEluIGZpbGVzZWxlY3RvciB3aW5kb3csIHRoZSBzcGFjZSBvZiBm aWxlIG5hbWUgc2hvdWxkIG5vdCBiZSBlbXB0eS4oSXQgc2hvdWxkIGJlIGZpbGxlZCB3aXRoIHN1 Z2dlc3RlZCBmaWxlIG5hbWUpCisKICAgICBFdmFzX09iamVjdCAqZmlsZV9wb3B1cCA9IGVsbV9w b3B1cF9hZGQod2luZG93LT5lbG1fd2luZG93KTsKICAgICBldmFzX29iamVjdF9zaXplX2hpbnRf d2VpZ2h0X3NldChmaWxlX3BvcHVwLCBFVkFTX0hJTlRfRVhQQU5ELCBFVkFTX0hJTlRfRVhQQU5E KTsKICAgICBldmFzX29iamVjdF9zaG93KGZpbGVfcG9wdXApOwo=