135669 2014-08-06 13:59:07 -0700 Document-relative overlays disappear after doing page-cache navigations 2014-08-06 14:53:26 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton commit-queue esprehn+autocc glenn kondapallykalyan simon.fraser oldest_to_newest 1027289 0 thorton 2014-08-06 13:59:07 -0700 <rdar://problem/17929171> 1027291 1 236132 thorton 2014-08-06 14:08:40 -0700 Created attachment 236132 patch 1027301 2 236132 simon.fraser 2014-08-06 14:24:13 -0700 Comment on attachment 236132 patch View in context: https://bugs.webkit.org/attachment.cgi?id=236132&action=review > Source/WebCore/rendering/RenderLayerCompositor.cpp:3439 > + Frame& frame = m_renderView.frameView().frame(); > + Page* page = frame.page(); > + if (!page) > + return; > + > + if (GraphicsLayer* overlayLayer = page->chrome().client().documentOverlayLayerForFrame(frame)) > + m_rootContentLayer->addChild(overlayLayer); Just call appendOverlayLayers()? 1027308 3 thorton 2014-08-06 14:53:26 -0700 http://trac.webkit.org/changeset/172179 As discussed, that's more work than it's worth. 236132 2014-08-06 14:08:40 -0700 2014-08-06 14:24:13 -0700 patch rlc-docoverlay.diff text/plain 2629 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA2ZGRkNjdlLi42MTcxMTgyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjQg QEAKKzIwMTQtMDgtMDYgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CisK KyAgICAgICAgRG9jdW1lbnQtcmVsYXRpdmUgb3ZlcmxheXMgZGlzYXBwZWFyIGFmdGVyIGRvaW5n IHBhZ2UtY2FjaGUgbmF2aWdhdGlvbnMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzNTY2OQorICAgICAgICA8cmRhcjovL3Byb2JsZW0vMTc5MjkxNzE+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiByZW5k ZXJpbmcvUmVuZGVyTGF5ZXJDb21wb3NpdG9yLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRl ckxheWVyQ29tcG9zaXRvcjo6cm9vdExheWVyQXR0YWNobWVudENoYW5nZWQpOgorICAgICAgICBX aGVuIG5hdmlnYXRpbmcgZnJvbSBvbmUgcGFnZSB0byBhbm90aGVyLCB0aGUgZG9jdW1lbnQtcmVs YXRpdmUgb3ZlcmxheQorICAgICAgICBsYXllciBpcyBtb3ZlZCBmcm9tIHRoZSBsYXllciB0cmVl IG9mIHRoZSBSZW5kZXJMYXllckNvbXBvc2l0b3Igb2YgdGhlCisgICAgICAgIGZpcnN0IFJlbmRl clZpZXcgdG8gdGhlIGxheWVyIHRyZWUgb2YgdGhlIFJlbmRlckxheWVyQ29tcG9zaXRvciBvZiB0 aGUKKyAgICAgICAgbmV3IFJlbmRlclZpZXcsIHVwb24gbGF5ZXIgdHJlZSBjb25zdHJ1Y3Rpb24u CisgICAgICAgIFdoZW4gZ29pbmcgImJhY2siIHZpYSBhIHBhZ2UgY2FjaGUgbmF2aWdhdGlvbiwg d2UgZG9uJ3QgcmVidWlsZCB0aGUKKyAgICAgICAgbGF5ZXIgdHJlZSwgYW5kIGp1c3QgYXNzdW1l IHRoYXQgaXQgaXMgaW4gYSB2YWxpZCBzdGF0ZS4KKyAgICAgICAgSG93ZXZlciwgdGhlIGRvY3Vt ZW50LXJlbGF0aXZlIG92ZXJsYXkgbGF5ZXIgd2FzICptb3ZlZCosIGFuZCBhcyBzdWNoLAorICAg ICAgICBuZWVkcyB0byBiZSBtb3ZlZCBiYWNrLiBUbyBkbyB0aGlzLCByZWF0dGFjaCB0aGUgZG9j dW1lbnQtcmVsYXRpdmUKKyAgICAgICAgb3ZlcmxheSBsYXllciB3aGVuZXZlciB0aGUgcm9vdCBs YXllciBhdHRhY2htZW50IG9mIGEgUmVuZGVyTGF5ZXJDb21wb3NpdG9yCisgICAgICAgIGNoYW5n ZXMsIHdoaWNoIHdpbGwgaGFwcGVuIGluIHRoZSByaWdodCBvcmRlciB3aGVuIGdvaW5nIGJhY2sg dG8gYSBjYWNoZWQgcGFnZS4KKwogMjAxNC0wOC0wNiAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1 ZXVlQHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjE3MjE1 NS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJMYXllckNvbXBv c2l0b3IuY3BwIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRv ci5jcHAKaW5kZXggMWEyOTc3My4uNmFlYmExZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cmVuZGVyaW5nL1JlbmRlckxheWVyQ29tcG9zaXRvci5jcHAKQEAgLTM0MjMsNiArMzQyMywyMCBA QCB2b2lkIFJlbmRlckxheWVyQ29tcG9zaXRvcjo6cm9vdExheWVyQXR0YWNobWVudENoYW5nZWQo KQogICAgIFJlbmRlckxheWVyKiBsYXllciA9IG1fcmVuZGVyVmlldy5sYXllcigpOwogICAgIGlm IChSZW5kZXJMYXllckJhY2tpbmcqIGJhY2tpbmcgPSBsYXllciA/IGxheWVyLT5iYWNraW5nKCkg OiAwKQogICAgICAgICBiYWNraW5nLT51cGRhdGVEcmF3c0NvbnRlbnQoKTsKKworICAgIC8vIFRo ZSBkb2N1bWVudC1yZWxhdGl2ZSBwYWdlIG92ZXJsYXkgbGF5ZXIgKHdoaWNoIGlzIHBpbm5lZCB0 byB0aGUgbWFpbiBmcmFtZSdzIGxheWVyIHRyZWUpCisgICAgLy8gaXMgbW92ZWQgYmV0d2VlbiBk aWZmZXJlbnQgUmVuZGVyTGF5ZXJDb21wb3NpdG9ycycgbGF5ZXIgdHJlZXMsIGFuZCBuZWVkcyB0 byBiZQorICAgIC8vIHJlYXR0YWNoZWQgd2hlbmV2ZXIgd2Ugc3dhcCBpbiBhIG5ldyBSZW5kZXJM YXllckNvbXBvc2l0b3IuCisgICAgaWYgKG1fcm9vdExheWVyQXR0YWNobWVudCA9PSBSb290TGF5 ZXJVbmF0dGFjaGVkKQorICAgICAgICByZXR1cm47CisKKyAgICBGcmFtZSYgZnJhbWUgPSBtX3Jl bmRlclZpZXcuZnJhbWVWaWV3KCkuZnJhbWUoKTsKKyAgICBQYWdlKiBwYWdlID0gZnJhbWUucGFn ZSgpOworICAgIGlmICghcGFnZSkKKyAgICAgICAgcmV0dXJuOworCisgICAgaWYgKEdyYXBoaWNz TGF5ZXIqIG92ZXJsYXlMYXllciA9IHBhZ2UtPmNocm9tZSgpLmNsaWVudCgpLmRvY3VtZW50T3Zl cmxheUxheWVyRm9yRnJhbWUoZnJhbWUpKQorICAgICAgICBtX3Jvb3RDb250ZW50TGF5ZXItPmFk ZENoaWxkKG92ZXJsYXlMYXllcik7CiB9CiAKIC8vIElGcmFtZXMgYXJlIHNwZWNpYWwsIGJlY2F1 c2Ugd2UgaG9vayBjb21wb3NpdGluZyBsYXllcnMgdG9nZXRoZXIgYWNyb3NzIGlmcmFtZSBib3Vu ZGFyaWVzCg==