135658 2014-08-06 10:41:35 -0700 REGRESSION(r172094): tests fail because Inspector test harness does not include UIString 2014-08-06 11:32:54 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg burg graouts joepeck timothy webkit-bug-importer oldest_to_newest 1027199 0 burg 2014-08-06 10:41:35 -0700 The timeline manager spins up during tests and makes a UIString for the first TimelineRecording's display name. But, localized strings are not currently included by Test.html. 1027201 1 webkit-bug-importer 2014-08-06 10:41:48 -0700 <rdar://problem/17933138> 1027222 2 236117 burg 2014-08-06 11:01:28 -0700 Created attachment 236117 Patch 1027225 3 236117 joepeck 2014-08-06 11:10:44 -0700 Comment on attachment 236117 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236117&action=review r=me > Source/WebInspectorUI/UserInterface/Base/Test.js:68 > +WebInspector.UIString = function(string) { > + // Don't localize strings when running tests. > + return string; > +} Style: Brace on new line Nit: Comment doesn't seem necessary, this is straightforward. 1027240 4 burg 2014-08-06 11:32:54 -0700 Committed r172162: <http://trac.webkit.org/changeset/172162> 236117 2014-08-06 11:01:28 -0700 2014-08-06 11:10:43 -0700 Patch bug-135658-20140806110123.patch text/plain 1538 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA2 ZTYyMWE4NjExMjU0YTY4Mjc5ZGQ1MzFjNzQ1Y2NjMTEwNjkyNTRlLi40NTBkNWMyZGE3OWFiYmE4 YjU2Y2MxNzRmMDgxNTg1YzgzODc1MTgzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNSBAQAogMjAxNC0wOC0wNiAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rv bi5lZHU+CiAKKyAgICAgICAgUkVHUkVTU0lPTihyMTcyMDk0KTogdGVzdHMgZmFpbCBiZWNhdXNl IEluc3BlY3RvciB0ZXN0IGhhcm5lc3MgZG9lcyBub3QgaW5jbHVkZSBVSVN0cmluZworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NjU4CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNl L0Jhc2UvVGVzdC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5VSVN0cmluZyk6IEFkZGVkLiBU aGlzIGlzIHRoZSBpZGVudGl0eSBmdW5jdGlvbiBkdXJpbmcgdGVzdGluZy4KKworMjAxNC0wOC0w NiAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CisKICAgICAgICAgV2Vi IEluc3BlY3RvcjogcHJvdG9jb2wgY29tbWFuZCBpbnZvY2F0aW9ucyBzaG91bGQgcmV0dXJuIGEg cHJvbWlzZSBpZiBubyBjYWxsYmFjayBpcyBzdXBwbGllZAogICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTMwNzAyCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVGVzdC5qcyBiL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvVGVzdC5qcwppbmRleCA5NzE2ZWRmMTUyMjBlMDBi YTBlMjA3OWU4NThmMWJkOTAzMmU0Y2M3Li4wZTdjZjU1ZTZmODAxYzdkNDcwOTc5NWIzOWQ1OTIx ZDUyYTA4ZDI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9CYXNlL1Rlc3QuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv QmFzZS9UZXN0LmpzCkBAIC02Miw2ICs2MiwxMSBAQCBXZWJJbnNwZWN0b3IuY29udGVudExvYWRl ZCA9IGZ1bmN0aW9uKCkgewogICAgIEluc3BlY3RvckZyb250ZW5kQVBJLmxvYWRDb21wbGV0ZWQo KTsKIH0KIAorV2ViSW5zcGVjdG9yLlVJU3RyaW5nID0gZnVuY3Rpb24oc3RyaW5nKSB7CisgICAg Ly8gRG9uJ3QgbG9jYWxpemUgc3RyaW5ncyB3aGVuIHJ1bm5pbmcgdGVzdHMuCisgICAgcmV0dXJu IHN0cmluZzsKK30KKwogLy8gQWRkIHN0dWJzIHRoYXQgYXJlIGNhbGxlZCBieSB0aGUgZnJvbnRl bmQgQVBJLgogV2ViSW5zcGVjdG9yLnVwZGF0ZURvY2tlZFN0YXRlID0gZnVuY3Rpb24oKQogewo=