135651 2014-08-06 08:59:47 -0700 [iOS] QuickLook returns an invalid MIME type for some documents 2017-01-26 03:06:51 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=166855 https://bugs.webkit.org/show_bug.cgi?id=167453 InRadar P2 Normal --- 1 aestes aestes ddkilzer oldest_to_newest 1027175 0 aestes 2014-08-06 08:59:47 -0700 [iOS] QuickLook returns an invalid MIME type for some documents 1027176 1 aestes 2014-08-06 09:00:55 -0700 <rdar://problem/17922339> 1027179 2 236106 aestes 2014-08-06 09:10:25 -0700 Created attachment 236106 Patch 1027183 3 236106 ddkilzer 2014-08-06 09:46:13 -0700 Comment on attachment 236106 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review r=me > Source/WebCore/platform/network/ios/QuickLook.mm:351 > + NSURLResponse *previewResponse = _quickLookHandle->nsResponse(); Should we use a RetainPtr<> here, or are we certain this object was retained and autoreleased before being returned? 1027189 4 aestes 2014-08-06 10:22:03 -0700 (In reply to comment #3) > (From update of attachment 236106 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236106&action=review > > r=me Thanks! > > > Source/WebCore/platform/network/ios/QuickLook.mm:351 > > + NSURLResponse *previewResponse = _quickLookHandle->nsResponse(); > > Should we use a RetainPtr<> here, or are we certain this object was retained and autoreleased before being returned? QuickLookHandle is already storing the NSURLResponse returned by nsResponse() in a RetainPtr<>. 1027190 5 aestes 2014-08-06 10:23:26 -0700 Committed r172151: <http://trac.webkit.org/changeset/172151> 1027202 6 aestes 2014-08-06 10:44:46 -0700 Reopening to attach new patch. 1027203 7 236111 aestes 2014-08-06 10:44:47 -0700 Created attachment 236111 Patch 1027208 8 236111 ddkilzer 2014-08-06 10:45:52 -0700 Comment on attachment 236111 Patch r=me 1027232 9 aestes 2014-08-06 11:18:56 -0700 Committed r172159: <http://trac.webkit.org/changeset/172159> 236106 2014-08-06 09:10:25 -0700 2014-08-06 10:44:43 -0700 Patch bug-135651-20140806091013.patch text/plain 4837 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZmFlMDJiZjhmZGZmYTYy M2EwZTQ1NmQ4OTE2YjQyOGRjZjExZWE4My4uOGM2YjU2NmJiOGNkMWEyZWJkN2M3NDhhYmIxMzli M2UzODUwZDFlYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1IEBACisyMDE0LTA4LTA2ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBRdWlja0xvb2sgcmV0 dXJucyBhbiBpbnZhbGlkIE1JTUUgdHlwZSBmb3Igc29tZSBkb2N1bWVudHMKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTY1MQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHNvbWUgY2FzZXMgUXVpY2tM b29rIGluZGljYXRlcyBhIGZhaWx1cmUgYnkgcmV0dXJuaW5nIGEgbmlsIE1JTUUgdHlwZSBpbiAt W1FMUHJldmlld0NvbnZlcnRlciBwcmV2aWV3UmVzcG9uc2VdCisgICAgICAgIHJhdGhlciB0aGFu IGNhbGxpbmcgY29ubmVjdGlvbjpkaWRGYWlsV2l0aEVycm9yOi4gQ2FsbGluZyBSZXNvdXJjZUxv YWRlcjo6ZGlkUmVjZWl2ZVJlc3BvbnNlKCkgd2l0aCBhIHJlc3BvbnNlCisgICAgICAgIGNvbnRh aW5pbmcgYSBuaWwgTUlNRSB0eXBlIGxlYWRzIHRvIGEgY3Jhc2guCisKKyAgICAgICAgU3RvcCBs b2FkaW5nIHRoZSByZXNvdXJjZSBhbmQgZGlzcGxheSBhbiBlcnJvciBwYWdlIGlmIFF1aWNrTG9v ayBjYW5ub3QgcHJvdmlkZSBhIE1JTUUgdHlwZSBmb3IgdGhlIGNvbnZlcnRlZCByZXNwb25zZS4K KworICAgICAgICBObyBuZXcgdGVzdHMuIFF1aWNrTG9vayBpcyBub3QgdGVzdGFibGUgZnJvbSBX ZWJLaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2lvcy9RdWlja0xvb2subW06Cisg ICAgICAgICgtW1dlYlJlc291cmNlTG9hZGVyUXVpY2tMb29rRGVsZWdhdGUgX3NlbmREaWRSZWNl aXZlUmVzcG9uc2VJZk5lY2Vzc2FyeV0pOiBDYWxsZWQgUmVzb3VyY2VMb2FkZXI6OmRpZEZhaWwo KSBpZgorICAgICAgICBNSU1FIHR5cGUgd2FzIG5pbC4gQ2FsbGVkIFJlc291cmNlTG9hZGVyOjpk aWRSZWNlaXZlUmVzcG9uc2UoKSBvdGhlcndpc2UuCisgICAgICAgICgtW1dlYlJlc291cmNlTG9h ZGVyUXVpY2tMb29rRGVsZWdhdGUgY29ubmVjdGlvbjpkaWRSZWNlaXZlRGF0YUFycmF5Ol0pOiBD YWxsZWQgLV9zZW5kRGlkUmVjZWl2ZVJlc3BvbnNlSWZOZWNlc3NhcnkuCisgICAgICAgICgtW1dl YlJlc291cmNlTG9hZGVyUXVpY2tMb29rRGVsZWdhdGUgY29ubmVjdGlvbjpkaWRSZWNlaXZlRGF0 YTpsZW5ndGhSZWNlaXZlZDpdKTogRGl0dG8uCisgICAgICAgICgtW1dlYlJlc291cmNlTG9hZGVy UXVpY2tMb29rRGVsZWdhdGUgY29ubmVjdGlvbjpkaWRGYWlsV2l0aEVycm9yOl0pOiBEaXR0by4K KwogMjAxNC0wOC0wNCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAg W2lPU10gVGhlIHJhdyBieXRlcyBvZiBhbiBpV29yayBkb2N1bWVudCdzIFBERiBwcmV2aWV3IGFy ZSBkaXNwbGF5ZWQgcmF0aGVyIHRoYW4gdGhlIFBERiBpdHNlbGYKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvaW9zL1F1aWNrTG9vay5tbSBiL1NvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL25ldHdvcmsvaW9zL1F1aWNrTG9vay5tbQppbmRleCBkMjY3YWVhODgxMmEw YzZlOGI5NDg1ZGJjNjFhN2Q4ZTIwYjdkZDVmLi5iZjg1ZWRlNzRmZjJlYjljYTgxN2I1MzhlNjRm MzAyMDhkMTYzN2Q0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2lvcy9RdWlja0xvb2subW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9p b3MvUXVpY2tMb29rLm1tCkBAIC0zMjQsNiArMzI0LDcgQEAgQGVuZAogQGludGVyZmFjZSBXZWJS ZXNvdXJjZUxvYWRlclF1aWNrTG9va0RlbGVnYXRlIDogTlNPYmplY3QgPE5TVVJMQ29ubmVjdGlv bkRlbGVnYXRlPiB7CiAgICAgUmVmUHRyPFJlc291cmNlTG9hZGVyPiBfcmVzb3VyY2VMb2FkZXI7 CiAgICAgQk9PTCBfaGFzU2VudERpZFJlY2VpdmVSZXNwb25zZTsKKyAgICBCT09MIF9oYXNGYWls ZWQ7CiB9CiBAcHJvcGVydHkgKG5vbmF0b21pYykgUXVpY2tMb29rSGFuZGxlKiBxdWlja0xvb2tI YW5kbGU7CiBAZW5kCkBAIC0zNDAsNiArMzQxLDI0IEBAIC0gKGlkKWluaXRXaXRoUmVzb3VyY2VM b2FkZXI6KFBhc3NSZWZQdHI8UmVzb3VyY2VMb2FkZXI+KXJlc291cmNlTG9hZGVyCiAgICAgcmV0 dXJuIHNlbGY7CiB9CiAKKy0gKHZvaWQpX3NlbmREaWRSZWNlaXZlUmVzcG9uc2VJZk5lY2Vzc2Fy eQoreworICAgIGlmIChfaGFzU2VudERpZFJlY2VpdmVSZXNwb25zZSB8fCBfaGFzRmFpbGVkIHx8 ICFfcXVpY2tMb29rSGFuZGxlKQorICAgICAgICByZXR1cm47CisKKyAgICAvLyBRdWlja0xvb2sg bWlnaHQgZmFpbCB0byBjb252ZXJ0IGEgZG9jdW1lbnQgd2l0aG91dCBjYWxsaW5nIGNvbm5lY3Rp b246ZGlkRmFpbFdpdGhFcnJvcjogKHNlZSA8cmRhcjovL3Byb2JsZW0vMTc5Mjc5NzI+KS4KKyAg ICAvLyBBIG5pbCBNSU1FIHR5cGUgaXMgYW4gaW5kaWNhdGlvbiBvZiBzdWNoIGEgZmFpbHVyZSwg c28gc3RvcCBsb2FkaW5nIHRoZSByZXNvdXJjZSBhbmQgaWdub3JlIHN1YnNlcXVlbnQgZGVsZWdh dGUgbWVzc2FnZXMuCisgICAgTlNVUkxSZXNwb25zZSAqcHJldmlld1Jlc3BvbnNlID0gX3F1aWNr TG9va0hhbmRsZS0+bnNSZXNwb25zZSgpOworICAgIGlmICghW3ByZXZpZXdSZXNwb25zZSBNSU1F VHlwZV0pIHsKKyAgICAgICAgX2hhc0ZhaWxlZCA9IFlFUzsKKyAgICAgICAgX3Jlc291cmNlTG9h ZGVyLT5kaWRGYWlsKF9yZXNvdXJjZUxvYWRlci0+Y2Fubm90U2hvd1VSTEVycm9yKCkpOworICAg ICAgICByZXR1cm47CisgICAgfQorCisgICAgX2hhc1NlbnREaWRSZWNlaXZlUmVzcG9uc2UgPSBZ RVM7CisgICAgX3Jlc291cmNlTG9hZGVyLT5kaWRSZWNlaXZlUmVzcG9uc2UocHJldmlld1Jlc3Bv bnNlKTsKK30KKwogI2lmIFVTRShORVRXT1JLX0NGREFUQV9BUlJBWV9DQUxMQkFDSykKIC0gKHZv aWQpY29ubmVjdGlvbjooTlNVUkxDb25uZWN0aW9uICopY29ubmVjdGlvbiBkaWRSZWNlaXZlRGF0 YUFycmF5OihOU0FycmF5ICopZGF0YUFycmF5CiB7CkBAIC0zNDcsMTAgKzM2Niw5IEBAIC0gKHZv aWQpY29ubmVjdGlvbjooTlNVUkxDb25uZWN0aW9uICopY29ubmVjdGlvbiBkaWRSZWNlaXZlRGF0 YUFycmF5OihOU0FycmF5ICopCiAgICAgaWYgKCFfcmVzb3VyY2VMb2FkZXIpCiAgICAgICAgIHJl dHVybjsKIAotICAgIGlmICghX2hhc1NlbnREaWRSZWNlaXZlUmVzcG9uc2UgJiYgX3F1aWNrTG9v a0hhbmRsZSkgewotICAgICAgICBfaGFzU2VudERpZFJlY2VpdmVSZXNwb25zZSA9IFlFUzsKLSAg ICAgICAgX3Jlc291cmNlTG9hZGVyLT5kaWRSZWNlaXZlUmVzcG9uc2UoX3F1aWNrTG9va0hhbmRs ZS0+bnNSZXNwb25zZSgpKTsKLSAgICB9CisgICAgW3NlbGYgX3NlbmREaWRSZWNlaXZlUmVzcG9u c2VJZk5lY2Vzc2FyeV07CisgICAgaWYgKF9oYXNGYWlsZWQpCisgICAgICAgIHJldHVybjsKIAog ICAgIF9yZXNvdXJjZUxvYWRlci0+ZGlkUmVjZWl2ZURhdGFBcnJheShyZWludGVycHJldF9jYXN0 PENGQXJyYXlSZWY+KGRhdGFBcnJheSkpOwogfQpAQCAtMzYyLDEwICszODAsOSBAQCAtICh2b2lk KWNvbm5lY3Rpb246KE5TVVJMQ29ubmVjdGlvbiAqKWNvbm5lY3Rpb24gZGlkUmVjZWl2ZURhdGE6 KE5TRGF0YSAqKWRhdGEgbAogICAgIGlmICghX3Jlc291cmNlTG9hZGVyKQogICAgICAgICByZXR1 cm47CiAKLSAgICBpZiAoIV9oYXNTZW50RGlkUmVjZWl2ZVJlc3BvbnNlICYmIF9xdWlja0xvb2tI YW5kbGUpIHsKLSAgICAgICAgX2hhc1NlbnREaWRSZWNlaXZlUmVzcG9uc2UgPSBZRVM7Ci0gICAg ICAgIF9yZXNvdXJjZUxvYWRlci0+ZGlkUmVjZWl2ZVJlc3BvbnNlKF9xdWlja0xvb2tIYW5kbGUt Pm5zUmVzcG9uc2UoKSk7Ci0gICAgfQorICAgIFtzZWxmIF9zZW5kRGlkUmVjZWl2ZVJlc3BvbnNl SWZOZWNlc3NhcnldOworICAgIGlmIChfaGFzRmFpbGVkKQorICAgICAgICByZXR1cm47CiAKICAg ICAvLyBRdWlja0xvb2sgY29kZSBzZW5kcyB1cyBhIG5pbCBkYXRhIGF0IHRpbWVzLiBUaGUgY2hl Y2sgYmVsb3cgaXMgdGhlIHNhbWUgYXMgdGhlIG9uZSBpbgogICAgIC8vIFJlc291cmNlSGFuZGxl TWFjLmNwcCBhZGRlZCBmb3IgYSBkaWZmZXJlbnQgYnVnLgpAQCAtMzg4LDEwICs0MDUsOSBAQCAt ICh2b2lkKWNvbm5lY3Rpb246KE5TVVJMQ29ubmVjdGlvbiAqKWNvbm5lY3Rpb24gZGlkRmFpbFdp dGhFcnJvcjooTlNFcnJvciAqKWVycgogewogICAgIFVOVVNFRF9QQVJBTShjb25uZWN0aW9uKTsK IAotICAgIGlmICghX2hhc1NlbnREaWRSZWNlaXZlUmVzcG9uc2UgJiYgX3F1aWNrTG9va0hhbmRs ZSkgewotICAgICAgICBfaGFzU2VudERpZFJlY2VpdmVSZXNwb25zZSA9IFlFUzsKLSAgICAgICAg X3Jlc291cmNlTG9hZGVyLT5kaWRSZWNlaXZlUmVzcG9uc2UoX3F1aWNrTG9va0hhbmRsZS0+bnNS ZXNwb25zZSgpKTsKLSAgICB9CisgICAgW3NlbGYgX3NlbmREaWRSZWNlaXZlUmVzcG9uc2VJZk5l Y2Vzc2FyeV07CisgICAgaWYgKF9oYXNGYWlsZWQpCisgICAgICAgIHJldHVybjsKIAogICAgIF9y ZXNvdXJjZUxvYWRlci0+ZGlkRmFpbChSZXNvdXJjZUVycm9yKGVycm9yKSk7CiB9Cg== 236111 2014-08-06 10:44:47 -0700 2014-08-06 10:45:52 -0700 Patch bug-135651-20140806104435.patch text/plain 1773 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ5NjViYzVlOTJjZTMx ZDJjODU5ZmEwNTQ2NjI2Y2FmNDIwNmEzYy4uNDU1MzIzZDI1YTdmMTM1ZjEwOGY3Y2NlNzBmZTg0 M2MzYzY3M2M5ZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMyw2ICszLDE5IEBACiAgICAgICAgIFtpT1NdIFF1 aWNrTG9vayByZXR1cm5zIGFuIGludmFsaWQgTUlNRSB0eXBlIGZvciBzb21lIGRvY3VtZW50cwog ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NjUxCiAK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgcjE3MjE1MSBl bnN1cmVkIHRoYXQgd2UgaWdub3JlIFF1aWNrTG9vayBkZWxlZ2F0ZSBtZXNzYWdlcyBhZnRlciBh biBlcnJvciwgYnV0IG5lZ2xlY3RlZCB0byBkbyBzbyBmb3IKKyAgICAgICAgY29ubmVjdGlvbkRp ZEZpbmlzaExvYWRpbmc6LiBEbyBub3QgY2FsbCBSZXNvdXJjZUxvYWRlcjo6ZGlkRmluaXNoTG9h ZGluZygpIGlmIGFuIGVycm9yIGhhcyBvY2N1cnJlZC4KKworICAgICAgICAqIHBsYXRmb3JtL25l dHdvcmsvaW9zL1F1aWNrTG9vay5tbToKKyAgICAgICAgKC1bV2ViUmVzb3VyY2VMb2FkZXJRdWlj a0xvb2tEZWxlZ2F0ZSBjb25uZWN0aW9uRGlkRmluaXNoTG9hZGluZzpdKToKKworMjAxNC0wOC0w NiAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gUXVpY2tM b29rIHJldHVybnMgYW4gaW52YWxpZCBNSU1FIHR5cGUgZm9yIHNvbWUgZG9jdW1lbnRzCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU2NTEKKwogICAg ICAgICBSZXZpZXdlZCBieSBEYXZpZCBLaWx6ZXIuCiAKICAgICAgICAgSW4gc29tZSBjYXNlcyBR dWlja0xvb2sgaW5kaWNhdGVzIGEgZmFpbHVyZSBieSByZXR1cm5pbmcgYSBuaWwgTUlNRSB0eXBl IGluIC1bUUxQcmV2aWV3Q29udmVydGVyIHByZXZpZXdSZXNwb25zZV0KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvaW9zL1F1aWNrTG9vay5tbSBiL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvaW9zL1F1aWNrTG9vay5tbQppbmRleCBiZjg1ZWRlNzRm ZjJlYjljYTgxN2I1MzhlNjRmMzAyMDhkMTYzN2Q0Li44Zjg0OWUzODJmNjU4NzRhZDc4ZDg2OGVj ZmRkODY2YzdmNWU5MGVmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3 b3JrL2lvcy9RdWlja0xvb2subW0KKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9pb3MvUXVpY2tMb29rLm1tCkBAIC0zOTQsNyArMzk0LDcgQEAgLSAodm9pZCljb25uZWN0aW9u OihOU1VSTENvbm5lY3Rpb24gKiljb25uZWN0aW9uIGRpZFJlY2VpdmVEYXRhOihOU0RhdGEgKilk YXRhIGwKIC0gKHZvaWQpY29ubmVjdGlvbkRpZEZpbmlzaExvYWRpbmc6KE5TVVJMQ29ubmVjdGlv biAqKWNvbm5lY3Rpb24KIHsKICAgICBVTlVTRURfUEFSQU0oY29ubmVjdGlvbik7Ci0gICAgaWYg KCFfcmVzb3VyY2VMb2FkZXIpCisgICAgaWYgKCFfcmVzb3VyY2VMb2FkZXIgfHwgX2hhc0ZhaWxl ZCkKICAgICAgICAgcmV0dXJuOwogCiAgICAgQVNTRVJUKF9oYXNTZW50RGlkUmVjZWl2ZVJlc3Bv bnNlKTsK