135646 2014-08-06 04:07:25 -0700 [GTK] Rename translation domain to WebKit2GTK-4.0 2014-08-06 06:36:45 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto webkit-unassigned bunhere commit-queue gyuyoung.kim rakuco sergio oldest_to_newest 1027125 0 berto 2014-08-06 04:07:25 -0700 This needs to match the new binary version set in http://trac.webkit.org/changeset/171846 1027126 1 236090 berto 2014-08-06 04:09:40 -0700 Created attachment 236090 Patch 1027127 2 236090 cgarcia 2014-08-06 04:12:49 -0700 Comment on attachment 236090 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236090&action=review > Source/WebCore/platform/gtk/po/CMakeLists.txt:8 > -set(domain WebKit2GTK-3.0) > +set(domain WebKit2GTK-4.0) Could we use ${WEBKITGTK_API_VERSION} instead of hardcoding the version? 1027130 3 236091 berto 2014-08-06 04:30:06 -0700 Created attachment 236091 Patch > Could we use ${WEBKITGTK_API_VERSION} instead of hardcoding the version? You're right, here's the updated patch, I just tested it. 1027133 4 236091 cgarcia 2014-08-06 05:00:55 -0700 Comment on attachment 236091 Patch Perfect, thanks! 1027141 5 236091 commit-queue 2014-08-06 06:36:41 -0700 Comment on attachment 236091 Patch Clearing flags on attachment: 236091 Committed r172142: <http://trac.webkit.org/changeset/172142> 1027142 6 commit-queue 2014-08-06 06:36:45 -0700 All reviewed patches have been landed. Closing bug. 236090 2014-08-06 04:09:40 -0700 2014-08-06 04:30:06 -0700 Patch 135646.diff text/plain 1224 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DTWFrZUxpc3RzLnR4 dCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DTWFrZUxpc3RzLnR4dAppbmRleCAx NjRmNGY1Li5mODIwZTA0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv cG8vQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3BvL0NN YWtlTGlzdHMudHh0CkBAIC01LDcgKzUsNyBAQCBpbmNsdWRlKEZpbmRHZXR0ZXh0KQogIyBTb3Vy Y2UgZGlyZWN0b3J5LiBQZXJoYXBzIHdlIHdhbnQgdGhpcywgYnV0IGZvciBub3cgZGlzYWJsZSBp dCB0byBtYWludGFpbiBjb21wYXRpYmlsaXR5Lgogc2V0KEdFVFRFWFRfTVNHTUVSR0VfRVhFQ1VU QUJMRSA6KQogCi1zZXQoZG9tYWluIFdlYktpdDJHVEstMy4wKQorc2V0KGRvbWFpbiBXZWJLaXQy R1RLLTQuMCkKIHNldChidWlsZF9kaXJlY3RvcnkgJHtDTUFLRV9CSU5BUllfRElSfS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvcG8pCiBzZXQocG90X2ZpbGUgJHtidWlsZF9kaXJlY3Rvcnl9 LyR7ZG9tYWlufS5wb3QpCiBzZXQocG90ZmlsZXNfZmlsZSAke2J1aWxkX2RpcmVjdG9yeX0vUE9U RklMRVMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvcG8vQ2hhbmdl TG9nIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3BvL0NoYW5nZUxvZwppbmRleCAxZmFj MzY5Li5hMDM2OGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvcG8v Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMiBAQAorMjAxNC0wOC0wNiAgQWxiZXJ0byBHYXJjaWEgIDxiZXJ0b0BpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIFJlbmFtZSB0cmFuc2xhdGlvbiBkb21haW4gdG8gV2Vi S2l0MkdUSy00LjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzNTY0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTQtMDUtMjAgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFJlbmFtZSB0cmFuc2xhdGlv biBkb21haW4gYXMgV2ViS2l0MkdUSy0zLjAK 236091 2014-08-06 04:30:06 -0700 2014-08-06 06:36:41 -0700 Patch 135646.diff text/plain 1245 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DTWFrZUxpc3RzLnR4 dCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DTWFrZUxpc3RzLnR4dAppbmRleCAx NjRmNGY1Li5iNTAwNWMyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv cG8vQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3BvL0NN YWtlTGlzdHMudHh0CkBAIC01LDcgKzUsNyBAQCBpbmNsdWRlKEZpbmRHZXR0ZXh0KQogIyBTb3Vy Y2UgZGlyZWN0b3J5LiBQZXJoYXBzIHdlIHdhbnQgdGhpcywgYnV0IGZvciBub3cgZGlzYWJsZSBp dCB0byBtYWludGFpbiBjb21wYXRpYmlsaXR5Lgogc2V0KEdFVFRFWFRfTVNHTUVSR0VfRVhFQ1VU QUJMRSA6KQogCi1zZXQoZG9tYWluIFdlYktpdDJHVEstMy4wKQorc2V0KGRvbWFpbiBXZWJLaXQy R1RLLSR7V0VCS0lUR1RLX0FQSV9WRVJTSU9OfSkKIHNldChidWlsZF9kaXJlY3RvcnkgJHtDTUFL RV9CSU5BUllfRElSfS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvcG8pCiBzZXQocG90X2Zp bGUgJHtidWlsZF9kaXJlY3Rvcnl9LyR7ZG9tYWlufS5wb3QpCiBzZXQocG90ZmlsZXNfZmlsZSAk e2J1aWxkX2RpcmVjdG9yeX0vUE9URklMRVMpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ndGsvcG8vQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3Bv L0NoYW5nZUxvZwppbmRleCAxZmFjMzY5Li5hMDM2OGYyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9ndGsvcG8vQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2d0ay9wby9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNC0wOC0wNiAgQWxiZXJ0 byBHYXJjaWEgIDxiZXJ0b0BpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIFJlbmFtZSB0cmFu c2xhdGlvbiBkb21haW4gdG8gV2ViS2l0MkdUSy00LjAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTY0NgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisKIDIwMTQtMDUtMjAg IENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtH VEtdIFJlbmFtZSB0cmFuc2xhdGlvbiBkb21haW4gYXMgV2ViS2l0MkdUSy0zLjAK