135633 2014-08-05 19:21:06 -0700 setCustomSwipeViews inside didChangeBackForwardList client callback is ignored 2014-08-07 16:30:05 -0700 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton sam simon.fraser webkit-bug-importer oldest_to_newest 1027050 0 thorton 2014-08-05 19:21:06 -0700 WebKit clears the set of custom swipe views at the end of WebPageProxy::didChangeBackForwardList, *after* calling into the client. This means that if the client wants to setCustomSwipeViews in didChangeBackForwardList, it won't be respected. Since there's only one client of this SPI, let's just stop clearing the list of custom swipe views in WebKit and leave that totally up to the client. 1027051 1 webkit-bug-importer 2014-08-05 19:21:15 -0700 <rdar://problem/17926507> 1027053 2 236072 thorton 2014-08-05 19:23:33 -0700 Created attachment 236072 patch 1027685 3 thorton 2014-08-07 16:30:05 -0700 http://trac.webkit.org/changeset/172307 236072 2014-08-05 19:23:33 -0700 2014-08-05 19:57:02 -0700 patch clearcustom.diff text/plain 5365 thorton ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBmMjM4MjU2Li5lMzBmNzk1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjcg QEAKKzIwMTQtMDgtMDUgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29t PgorCisgICAgICAgIHNldEN1c3RvbVN3aXBlVmlld3MgaW5zaWRlIGRpZENoYW5nZUJhY2tGb3J3 YXJkTGlzdCBjbGllbnQgY2FsbGJhY2sgaXMgaWdub3JlZAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NjMzCisgICAgICAgIDxyZGFyOi8vcHJvYmxl bS8xNzkyNjUwNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFVJUHJvY2Vzcy9QYWdlQ2xpZW50Lmg6CisgICAgICAgICogVUlQcm9jZXNzL1dlYlBh Z2VQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VQcm94eTo6ZGlkQ2hhbmdlQmFj a0ZvcndhcmRMaXN0KToKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9T Lmg6CisgICAgICAgICogVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbToKKyAgICAg ICAgKFdlYktpdDo6UGFnZUNsaWVudEltcGw6OmNsZWFyQ3VzdG9tU3dpcGVWaWV3cyk6IERlbGV0 ZWQuCisgICAgICAgICogVUlQcm9jZXNzL21hYy9QYWdlQ2xpZW50SW1wbC5oOgorICAgICAgICAq IFVJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW06CisgICAgICAgIChXZWJLaXQ6OlBhZ2VD bGllbnRJbXBsOjpjbGVhckN1c3RvbVN3aXBlVmlld3MpOiBEZWxldGVkLgorICAgICAgICBXZWJL aXQgY2xlYXJzIHRoZSBzZXQgb2YgY3VzdG9tIHN3aXBlIHZpZXdzIGF0IHRoZSBlbmQgb2YgV2Vi UGFnZVByb3h5OjpkaWRDaGFuZ2VCYWNrRm9yd2FyZExpc3QsCisgICAgICAgICphZnRlciogY2Fs bGluZyBpbnRvIHRoZSBjbGllbnQuIFRoaXMgbWVhbnMgdGhhdCBpZiB0aGUgY2xpZW50IHdhbnRz IHRvIHNldEN1c3RvbVN3aXBlVmlld3MgaW4KKyAgICAgICAgZGlkQ2hhbmdlQmFja0ZvcndhcmRM aXN0LCBpdCB3b24ndCBiZSByZXNwZWN0ZWQuCisKKyAgICAgICAgU2luY2UgdGhlcmUncyBvbmx5 IG9uZSBjbGllbnQgb2YgdGhpcyBTUEksIGxldCdzIGp1c3Qgc3RvcCBjbGVhcmluZyB0aGUgbGlz dCBvZiBjdXN0b20gc3dpcGUKKyAgICAgICAgdmlld3MgaW4gV2ViS2l0IGFuZCBsZWF2ZSB0aGF0 IHRvdGFsbHkgdXAgdG8gdGhlIGNsaWVudC4KKwogMjAxNC0wOC0wNCAgQW5keSBFc3RlcyAgPGFl c3Rlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gVGhlIHJhdyBieXRlcyBvZiBhbiBpV29y ayBkb2N1bWVudCdzIFBERiBwcmV2aWV3IGFyZSBkaXNwbGF5ZWQgcmF0aGVyIHRoYW4gdGhlIFBE RiBpdHNlbGYKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50 LmggYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNsaWVudC5oCmluZGV4IGE2N2FkZGMu LmY4YThkMDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9QYWdlQ2xpZW50 LmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1BhZ2VDbGllbnQuaApAQCAtMTgyLDcg KzE4Miw2IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIExheWVyT3JWaWV3ICphY2NlbGVyYXRlZENv bXBvc2l0aW5nUm9vdExheWVyKCkgY29uc3QgPSAwOwogICAgIHZpcnR1YWwgUGFzc1JlZlB0cjxW aWV3U25hcHNob3Q+IHRha2VWaWV3U25hcHNob3QoKSA9IDA7CiAgICAgdmlydHVhbCB2b2lkIHdo ZWVsRXZlbnRXYXNOb3RIYW5kbGVkQnlXZWJDb3JlKGNvbnN0IE5hdGl2ZVdlYldoZWVsRXZlbnQm KSA9IDA7Ci0gICAgdmlydHVhbCB2b2lkIGNsZWFyQ3VzdG9tU3dpcGVWaWV3cygpID0gMDsKICNl bmRpZgogCiAjaWYgVVNFKEFQUEtJVCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9XZWJQYWdlUHJveHkuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQ cm94eS5jcHAKaW5kZXggODlhNjBmYy4uNWMxNDUzNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9j ZXNzL1dlYlBhZ2VQcm94eS5jcHAKQEAgLTk2MiwxMCArOTYyLDYgQEAgdm9pZCBXZWJQYWdlUHJv eHk6OmRpZENoYW5nZUJhY2tGb3J3YXJkTGlzdChXZWJCYWNrRm9yd2FyZExpc3RJdGVtKiBhZGRl ZCwgVmVjdG8KIAogICAgIG1fcGFnZUxvYWRTdGF0ZS5zZXRDYW5Hb0JhY2sodHJhbnNhY3Rpb24s IG1fYmFja0ZvcndhcmRMaXN0LT5iYWNrSXRlbSgpKTsKICAgICBtX3BhZ2VMb2FkU3RhdGUuc2V0 Q2FuR29Gb3J3YXJkKHRyYW5zYWN0aW9uLCBtX2JhY2tGb3J3YXJkTGlzdC0+Zm9yd2FyZEl0ZW0o KSk7Ci0KLSNpZiBQTEFURk9STShNQUMpCi0gICAgbV9wYWdlQ2xpZW50LmNsZWFyQ3VzdG9tU3dp cGVWaWV3cygpOwotI2VuZGlmCiB9CiAKIHZvaWQgV2ViUGFnZVByb3h5Ojp3aWxsR29Ub0JhY2tG b3J3YXJkTGlzdEl0ZW0odWludDY0X3QgaXRlbUlELCBJUEM6Ok1lc3NhZ2VEZWNvZGVyJiBkZWNv ZGVyKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50 SW1wbElPUy5oIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElP Uy5oCmluZGV4IGQwNDdjOWEuLjM4Y2YwYTkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MuaAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1BhZ2VDbGllbnRJbXBsSU9TLmgKQEAgLTEwNyw3ICsxMDcsNiBAQCBwcml2YXRl OgogCiAgICAgdmlydHVhbCBQYXNzUmVmUHRyPFZpZXdTbmFwc2hvdD4gdGFrZVZpZXdTbmFwc2hv dCgpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCB3aGVlbEV2ZW50V2FzTm90SGFuZGxlZEJ5 V2ViQ29yZShjb25zdCBOYXRpdmVXZWJXaGVlbEV2ZW50Jikgb3ZlcnJpZGU7Ci0gICAgdmlydHVh bCB2b2lkIGNsZWFyQ3VzdG9tU3dpcGVWaWV3cygpIG92ZXJyaWRlOwogCiAgICAgdmlydHVhbCB2 b2lkIGNvbW1pdFBvdGVudGlhbFRhcEZhaWxlZCgpIG92ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9p ZCBkaWRHZXRUYXBIaWdobGlnaHRHZW9tZXRyaWVzKHVpbnQ2NF90IHJlcXVlc3RJRCwgY29uc3Qg V2ViQ29yZTo6Q29sb3ImLCBjb25zdCBWZWN0b3I8V2ViQ29yZTo6RmxvYXRRdWFkPiYgaGlnaGxp Z2h0ZWRRdWFkcywgY29uc3QgV2ViQ29yZTo6SW50U2l6ZSYgdG9wTGVmdFJhZGl1cywgY29uc3Qg V2ViQ29yZTo6SW50U2l6ZSYgdG9wUmlnaHRSYWRpdXMsIGNvbnN0IFdlYkNvcmU6OkludFNpemUm IGJvdHRvbUxlZnRSYWRpdXMsIGNvbnN0IFdlYkNvcmU6OkludFNpemUmIGJvdHRvbVJpZ2h0UmFk aXVzKSBvdmVycmlkZTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv UGFnZUNsaWVudEltcGxJT1MubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1BhZ2VD bGllbnRJbXBsSU9TLm1tCmluZGV4IGM2ZTkyZjIuLmI4OWQwNDIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvUGFnZUNsaWVudEltcGxJT1MubW0KKysrIGIvU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL2lvcy9QYWdlQ2xpZW50SW1wbElPUy5tbQpAQCAtNDc2LDExICs0 NzYsNiBAQCB2b2lkIFBhZ2VDbGllbnRJbXBsOjp3aGVlbEV2ZW50V2FzTm90SGFuZGxlZEJ5V2Vi Q29yZShjb25zdCBOYXRpdmVXZWJXaGVlbEV2ZW50JgogICAgIG5vdEltcGxlbWVudGVkKCk7CiB9 CiAKLXZvaWQgUGFnZUNsaWVudEltcGw6OmNsZWFyQ3VzdG9tU3dpcGVWaWV3cygpCi17Ci0gICAg bm90SW1wbGVtZW50ZWQoKTsKLX0KLQogdm9pZCBQYWdlQ2xpZW50SW1wbDo6Y29tbWl0UG90ZW50 aWFsVGFwRmFpbGVkKCkKIHsKICAgICBbbV9jb250ZW50VmlldyBfY29tbWl0UG90ZW50aWFsVGFw RmFpbGVkXTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNs aWVudEltcGwuaCBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwu aAppbmRleCBjZDc2NDhhLi4zNGY4ZDMzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLmgKKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9QYWdlQ2xpZW50SW1wbC5oCkBAIC0xMjYsNyArMTI2LDYgQEAgcHJpdmF0ZToKIAogICAg IHZpcnR1YWwgUGFzc1JlZlB0cjxWaWV3U25hcHNob3Q+IHRha2VWaWV3U25hcHNob3QoKSBvdmVy cmlkZTsKICAgICB2aXJ0dWFsIHZvaWQgd2hlZWxFdmVudFdhc05vdEhhbmRsZWRCeVdlYkNvcmUo Y29uc3QgTmF0aXZlV2ViV2hlZWxFdmVudCYpIG92ZXJyaWRlOwotICAgIHZpcnR1YWwgdm9pZCBj bGVhckN1c3RvbVN3aXBlVmlld3MoKSBvdmVycmlkZTsKIAogICAgIHZpcnR1YWwgdm9pZCBhY2Nl c3NpYmlsaXR5V2ViUHJvY2Vzc1Rva2VuUmVjZWl2ZWQoY29uc3QgSVBDOjpEYXRhUmVmZXJlbmNl Jik7CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVu dEltcGwubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1t CmluZGV4IGZkZjI2ZDEuLmVmYmViMDUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJv Y2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW0KKysrIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L21hYy9QYWdlQ2xpZW50SW1wbC5tbQpAQCAtNjEyLDExICs2MTIsNiBAQCBib29sIFBhZ2VDbGll bnRJbXBsOjpleGVjdXRlU2F2ZWRDb21tYW5kQnlTZWxlY3Rvcihjb25zdCBTdHJpbmcmIHNlbGVj dG9yU3RyaW5nKQogICAgIHJldHVybiBbbV93a1ZpZXcgX2V4ZWN1dGVTYXZlZENvbW1hbmRCeVNl bGVjdG9yOk5TU2VsZWN0b3JGcm9tU3RyaW5nKHNlbGVjdG9yU3RyaW5nKV07CiB9CiAKLXZvaWQg UGFnZUNsaWVudEltcGw6OmNsZWFyQ3VzdG9tU3dpcGVWaWV3cygpCi17Ci0gICAgcmV0dXJuIFtt X3drVmlldyBfc2V0Q3VzdG9tU3dpcGVWaWV3czpAW11dOwotfQotCiAjaWYgVVNFKERJQ1RBVElP Tl9BTFRFUk5BVElWRVMpCiB1aW50NjRfdCBQYWdlQ2xpZW50SW1wbDo6YWRkRGljdGF0aW9uQWx0 ZXJuYXRpdmVzKGNvbnN0IFJldGFpblB0cjxOU1RleHRBbHRlcm5hdGl2ZXM+JiBhbHRlcm5hdGl2 ZXMpCiB7Cg==