135632 2014-08-05 18:49:54 -0700 Move caching of undefined property lookup to GetByIDList. 2014-08-11 10:25:27 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Normal --- 1 kling kling kling mhahnenberg oldest_to_newest 1027039 0 kling 2014-08-05 18:49:54 -0700 Move caching of undefined property lookup to GetByIDList. 1027040 1 236069 kling 2014-08-05 18:50:47 -0700 Created attachment 236069 Patch 1027045 2 mhahnenberg 2014-08-05 19:06:12 -0700 Man, this code is getting so gnarly. 1027052 3 236069 mhahnenberg 2014-08-05 19:21:57 -0700 Comment on attachment 236069 Patch r=me. We should refactor all this stuff at some point. 1028216 4 kling 2014-08-11 10:25:27 -0700 The original thingy was rolled out, removing the need for this follow-up. 236069 2014-08-05 18:50:47 -0700 2014-08-05 19:21:57 -0700 Patch bug-135632.diff text/plain 5164 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IDIzZTQ1Y2MuLmFkYjA2NGEgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE0LTA4LTA1ICBBbmRyZWFzIEtsaW5n ICA8YWtsaW5nQGFwcGxlLmNvbT4KKworICAgICAgICBNb3ZlIGNhY2hpbmcgb2YgdW5kZWZpbmVk IHByb3BlcnR5IGxvb2t1cCB0byBHZXRCeUlETGlzdC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0 Lm9yZy9iLzEzNTYzMj4KKworICAgICAgICBTaGFyZSBjb2RlIHdpdGggdHJ5R2V0QnlJRExpc3Qo KSBieSBtb3ZpbmcgdGhlIGNhY2hpbmcgb2YgdW5kZWZpbmVkCisgICAgICAgIHByb3BlcnRpZXMg dGhlcmUuCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBqaXQvUmVwYXRjaC5jcHA6CisgICAgICAgIChKU0M6OnRyeUNhY2hlR2V0QnlJRCk6CisgICAg ICAgIChKU0M6OnRyeUJ1aWxkR2V0QnlJRExpc3QpOgorCiAyMDE0LTA4LTA1ICBQcnplbXlzbGF3 IEt1Y3p5bnNraSAgPHAua3Vjenluc2tpQHNhbXN1bmcuY29tPgogCiAgICAgICAgIEZpeCByZXNv dXJjZSBsZWFrIG9mIHVuY2xvc2VkIGZpbGUgZGVzY3JpcHRvci4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRjaC5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv aml0L1JlcGF0Y2guY3BwCmluZGV4IDc3MTE5MzguLjAwNjNmMTkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9qaXQvUmVwYXRjaC5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL2ppdC9SZXBhdGNoLmNwcApAQCAtNzUxLDM1ICs3NTEsNiBAQCBzdGF0aWMgSW5saW5lQ2Fj aGVBY3Rpb24gdHJ5Q2FjaGVHZXRCeUlEKEV4ZWNTdGF0ZSogZXhlYywgSlNWYWx1ZSBiYXNlVmFs dWUsIGNvbgogICAgIGlmIChhY3Rpb24gIT0gQXR0ZW1wdFRvQ2FjaGUpCiAgICAgICAgIHJldHVy biBhY3Rpb247CiAKLSAgICBpZiAoc2xvdC5pc1Vuc2V0KCkpIHsKLSAgICAgICAgLy8gUHJvcGVy dHkgbG9va3VwIG1pc3MgLSBsZXQncyB0cnkgdG8gY2FjaGUgdGhhdC4KLSAgICAgICAgc2l6ZV90 IGNvdW50ID0gbm9ybWFsaXplUHJvdG90eXBlQ2hhaW4oZXhlYywgYmFzZUNlbGwpOwotICAgICAg ICBpZiAoY291bnQgPT0gSW52YWxpZFByb3RvdHlwZUNoYWluKQotICAgICAgICAgICAgcmV0dXJu IEdpdmVVcE9uQ2FjaGU7Ci0gICAgICAgIFN0cnVjdHVyZUNoYWluKiBwcm90b3R5cGVDaGFpbiA9 IHN0cnVjdHVyZS0+cHJvdG90eXBlQ2hhaW4oZXhlYyk7Ci0gICAgICAgIFBvbHltb3JwaGljR2V0 QnlJZExpc3QqIGxpc3QgPSBQb2x5bW9ycGhpY0dldEJ5SWRMaXN0Ojpmcm9tKHN0dWJJbmZvKTsK LSAgICAgICAgaWYgKGxpc3QtPmlzRnVsbCgpKSB7Ci0gICAgICAgICAgICAvLyBXZSBuZWVkIHRo aXMgZXh0cmEgY2hlY2sgYmVjYXVzZSBvZiByZWN1cnNpb24uCi0gICAgICAgICAgICByZXR1cm4g R2l2ZVVwT25DYWNoZTsKLSAgICAgICAgfQotCi0gICAgICAgIFJlZlB0cjxKSVRTdHViUm91dGlu ZT4gc3R1YlJvdXRpbmU7Ci0gICAgICAgIGdlbmVyYXRlQnlJZFN0dWIoCi0gICAgICAgICAgICBl eGVjLCBHZXRVbmRlZmluZWQsIHByb3BlcnR5TmFtZSwgRnVuY3Rpb25QdHIoKSwgc3R1YkluZm8s IHByb3RvdHlwZUNoYWluLCBjb3VudCwgaW52YWxpZE9mZnNldCwKLSAgICAgICAgICAgIHN0cnVj dHVyZSwgZmFsc2UsIG51bGxwdHIsCi0gICAgICAgICAgICBzdHViSW5mby5jYWxsUmV0dXJuTG9j YXRpb24ubGFiZWxBdE9mZnNldChzdHViSW5mby5wYXRjaC5kZWx0YUNhbGxUb0RvbmUpLAotICAg ICAgICAgICAgQ29kZUxvY2F0aW9uTGFiZWwobGlzdC0+Y3VycmVudFNsb3dQYXRoVGFyZ2V0KHN0 dWJJbmZvKSksIHN0dWJSb3V0aW5lKTsKLQotICAgICAgICBsaXN0LT5hZGRBY2Nlc3MoR2V0QnlJ ZEFjY2VzcygKLSAgICAgICAgICAgICp2bSwgY29kZUJsb2NrLT5vd25lckV4ZWN1dGFibGUoKSwK LSAgICAgICAgICAgIEdldEJ5SWRBY2Nlc3M6OlNpbXBsZUlubGluZSwKLSAgICAgICAgICAgIHN0 dWJSb3V0aW5lLCBzdHJ1Y3R1cmUsIHByb3RvdHlwZUNoYWluLCBjb3VudCkpOwotCi0gICAgICAg IHBhdGNoSnVtcFRvR2V0QnlJZFN0dWIoY29kZUJsb2NrLCBzdHViSW5mbywgc3R1YlJvdXRpbmUu Z2V0KCkpOwotCi0gICAgICAgIHJldHVybiBsaXN0LT5pc0Z1bGwoKSA/IEdpdmVVcE9uQ2FjaGUg OiBSZXRyeUNhY2hlTGF0ZXI7Ci0gICAgfQotCiAgICAgLy8gT3B0aW1pemUgc2VsZiBhY2Nlc3Mu CiAgICAgaWYgKHNsb3Quc2xvdEJhc2UoKSA9PSBiYXNlVmFsdWUKICAgICAgICAgJiYgc2xvdC5p c0NhY2hlYWJsZVZhbHVlKCkKQEAgLTgyMCw3ICs3OTEsNyBAQCB2b2lkIHBhdGNoSnVtcFRvR2V0 QnlJZFN0dWIoQ29kZUJsb2NrKiBjb2RlQmxvY2ssIFN0cnVjdHVyZVN0dWJJbmZvJiBzdHViSW5m bywgSgogc3RhdGljIElubGluZUNhY2hlQWN0aW9uIHRyeUJ1aWxkR2V0QnlJRExpc3QoRXhlY1N0 YXRlKiBleGVjLCBKU1ZhbHVlIGJhc2VWYWx1ZSwgY29uc3QgSWRlbnRpZmllciYgaWRlbnQsIGNv bnN0IFByb3BlcnR5U2xvdCYgc2xvdCwgU3RydWN0dXJlU3R1YkluZm8mIHN0dWJJbmZvKQogewog ICAgIGlmICghYmFzZVZhbHVlLmlzQ2VsbCgpCi0gICAgICAgIHx8ICFzbG90LmlzQ2FjaGVhYmxl KCkpCisgICAgICAgIHx8ICghc2xvdC5pc0NhY2hlYWJsZSgpICYmICFzbG90LmlzVW5zZXQoKSkp CiAgICAgICAgIHJldHVybiBHaXZlVXBPbkNhY2hlOwogCiAgICAgSlNDZWxsKiBiYXNlQ2VsbCA9 IGJhc2VWYWx1ZS5hc0NlbGwoKTsKQEAgLTgzMSw2ICs4MDIsOSBAQCBzdGF0aWMgSW5saW5lQ2Fj aGVBY3Rpb24gdHJ5QnVpbGRHZXRCeUlETGlzdChFeGVjU3RhdGUqIGV4ZWMsIEpTVmFsdWUgYmFz ZVZhbHVlLAogICAgICAgICBsb2FkVGFyZ2V0RnJvbVByb3h5ID0gdHJ1ZTsKICAgICB9CiAKKyAg ICBpZiAoc2xvdC5pc1Vuc2V0KCkgJiYgbG9hZFRhcmdldEZyb21Qcm94eSkKKyAgICAgICAgcmV0 dXJuIEdpdmVVcE9uQ2FjaGU7CisKICAgICBWTSogdm0gPSAmZXhlYy0+dm0oKTsKICAgICBDb2Rl QmxvY2sqIGNvZGVCbG9jayA9IGV4ZWMtPmNvZGVCbG9jaygpOwogCkBAIC04NDUsMjAgKzgxOSwy MyBAQCBzdGF0aWMgSW5saW5lQ2FjaGVBY3Rpb24gdHJ5QnVpbGRHZXRCeUlETGlzdChFeGVjU3Rh dGUqIGV4ZWMsIEpTVmFsdWUgYmFzZVZhbHVlLAogICAgICAgICAvLyBXZSBjYW5ub3QgZG8gYXMg bXVjaCBpbmxpbmUgY2FjaGluZyBpZiB0aGUgcmVnaXN0ZXJzIHdlcmUgbm90IGZsdXNoZWQgcHJp b3IgdG8gdGhpcyBHZXRCeUlkLiBJbiBwYXJ0aWN1bGFyLAogICAgICAgICAvLyBub24tVmFsdWUg Y2FjaGVkIHByb3BlcnRpZXMgcmVxdWlyZSBwbGFudGluZyBjYWxscywgd2hpY2ggcmVxdWlyZXMg cmVnaXN0ZXJzIHRvIGhhdmUgYmVlbiBmbHVzaGVkLiBUaHVzLAogICAgICAgICAvLyBpZiByZWdp c3RlcnMgd2VyZSBub3QgZmx1c2hlZCwgZG9uJ3QgZG8gbm9uLVZhbHVlIGNhY2hpbmcuCi0gICAg ICAgIGlmICghc2xvdC5pc0NhY2hlYWJsZVZhbHVlKCkpCisgICAgICAgIGlmICghc2xvdC5pc0Nh Y2hlYWJsZVZhbHVlKCkgJiYgIXNsb3QuaXNVbnNldCgpKQogICAgICAgICAgICAgcmV0dXJuIEdp dmVVcE9uQ2FjaGU7CiAgICAgfQotICAgIAotICAgIFByb3BlcnR5T2Zmc2V0IG9mZnNldCA9IHNs b3QuY2FjaGVkT2Zmc2V0KCk7CisKKyAgICBQcm9wZXJ0eU9mZnNldCBvZmZzZXQgPSBzbG90Lmlz VW5zZXQoKSA/IGludmFsaWRPZmZzZXQgOiBzbG90LmNhY2hlZE9mZnNldCgpOwogICAgIFN0cnVj dHVyZUNoYWluKiBwcm90b3R5cGVDaGFpbiA9IDA7CiAgICAgc2l6ZV90IGNvdW50ID0gMDsKICAg ICAKLSAgICBpZiAoc2xvdC5zbG90QmFzZSgpICE9IGJhc2VWYWx1ZSkgeworICAgIGlmIChzbG90 LmlzVW5zZXQoKSB8fCBzbG90LnNsb3RCYXNlKCkgIT0gYmFzZVZhbHVlKSB7CiAgICAgICAgIGlm ICh0eXBlSW5mby5wcm9oaWJpdHNQcm9wZXJ0eUNhY2hpbmcoKSB8fCBzdHJ1Y3R1cmUtPmlzRGlj dGlvbmFyeSgpKQogICAgICAgICAgICAgcmV0dXJuIEdpdmVVcE9uQ2FjaGU7Ci0gICAgICAgIAot ICAgICAgICBjb3VudCA9IG5vcm1hbGl6ZVByb3RvdHlwZUNoYWluRm9yQ2hhaW5BY2Nlc3MoCi0g ICAgICAgICAgICBleGVjLCBiYXNlVmFsdWUsIHNsb3Quc2xvdEJhc2UoKSwgaWRlbnQsIG9mZnNl dCk7CisKKyAgICAgICAgaWYgKHNsb3QuaXNVbnNldCgpKQorICAgICAgICAgICAgY291bnQgPSBu b3JtYWxpemVQcm90b3R5cGVDaGFpbihleGVjLCBiYXNlQ2VsbCk7CisgICAgICAgIGVsc2UKKyAg ICAgICAgICAgIGNvdW50ID0gbm9ybWFsaXplUHJvdG90eXBlQ2hhaW5Gb3JDaGFpbkFjY2VzcygK KyAgICAgICAgICAgICAgICBleGVjLCBiYXNlVmFsdWUsIHNsb3Quc2xvdEJhc2UoKSwgaWRlbnQs IG9mZnNldCk7CiAgICAgICAgIGlmIChjb3VudCA9PSBJbnZhbGlkUHJvdG90eXBlQ2hhaW4pCiAg ICAgICAgICAgICByZXR1cm4gR2l2ZVVwT25DYWNoZTsKICAgICAgICAgcHJvdG90eXBlQ2hhaW4g PSBzdHJ1Y3R1cmUtPnByb3RvdHlwZUNoYWluKGV4ZWMpOwpAQCAtODgwLDYgKzg1Nyw4IEBAIHN0 YXRpYyBJbmxpbmVDYWNoZUFjdGlvbiB0cnlCdWlsZEdldEJ5SURMaXN0KEV4ZWNTdGF0ZSogZXhl YywgSlNWYWx1ZSBiYXNlVmFsdWUsCiAgICAgR2V0QnlJZEFjY2Vzczo6QWNjZXNzVHlwZSBhY2Nl c3NUeXBlOwogICAgIGlmIChzbG90LmlzQ2FjaGVhYmxlVmFsdWUoKSkKICAgICAgICAgYWNjZXNz VHlwZSA9IHNsb3Qud2F0Y2hwb2ludFNldCgpID8gR2V0QnlJZEFjY2Vzczo6V2F0Y2hlZFN0dWIg OiBHZXRCeUlkQWNjZXNzOjpTaW1wbGVTdHViOworICAgIGVsc2UgaWYgKHNsb3QuaXNVbnNldCgp KQorICAgICAgICBhY2Nlc3NUeXBlID0gR2V0QnlJZEFjY2Vzczo6U2ltcGxlSW5saW5lOwogICAg IGVsc2UgaWYgKHNsb3QuaXNDYWNoZWFibGVHZXR0ZXIoKSkKICAgICAgICAgYWNjZXNzVHlwZSA9 IEdldEJ5SWRBY2Nlc3M6OkdldHRlcjsKICAgICBlbHNlCg==