135623 2014-08-05 14:44:06 -0700 Remove an unused argument from BuildbotQueue.update() 2014-08-05 16:01:19 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ap ap commit-queue timothy oldest_to_newest 1026948 0 ap 2014-08-05 14:44:06 -0700 The argument is never used by callers. 1026949 1 236048 ap 2014-08-05 14:49:19 -0700 Created attachment 236048 proposed patch 1026981 2 236048 commit-queue 2014-08-05 16:01:15 -0700 Comment on attachment 236048 proposed patch Clearing flags on attachment: 236048 Committed r172097: <http://trac.webkit.org/changeset/172097> 1026982 3 commit-queue 2014-08-05 16:01:19 -0700 All reviewed patches have been landed. Closing bug. 236048 2014-08-05 14:49:19 -0700 2014-08-05 16:01:15 -0700 proposed patch UnusedArgument.txt text/plain 2707 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3MjA4NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTA4LTA1ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJlbW92ZSBhbiB1bnVzZWQgYXJndW1lbnQgZnJvbSBCdWlsZGJvdFF1ZXVl LnVwZGF0ZSgpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzU2MjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBbHNvIHJlbWFuZWQgYSBjb25zdGFudCB0byBiZXR0ZXIgbWF0Y2ggd2hhdCBpdCBtZWFucy4K KworICAgICAgICAqIEJ1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL3B1 YmxpY19odG1sL2Rhc2hib2FyZC9TY3JpcHRzL0J1aWxkYm90UXVldWUuanM6CisKIDIwMTQtMDgt MDUgIFZpdmVrIEdhbGF0YWdlICA8dml2ZWsudmdAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW2d0 a10gSW5jbHVkZSBsbHZtLWRldihlbCkgcGFja2FnZSB0byBzYXRpc2Z5IG1lc2EgYnVpbGQgY29u ZmlndXJhdGlvbgpJbmRleDogVG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9y Zy1jb25maWcvcHVibGljX2h0bWwvZGFzaGJvYXJkL1NjcmlwdHMvQnVpbGRib3RRdWV1ZS5qcwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlLmpzCShyZXZp c2lvbiAxNzIwMzMpCisrKyBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3Jn LWNvbmZpZy9wdWJsaWNfaHRtbC9kYXNoYm9hcmQvU2NyaXB0cy9CdWlsZGJvdFF1ZXVlLmpzCSh3 b3JraW5nIGNvcHkpCkBAIC00OSw3ICs0OSw3IEBAIEJ1aWxkYm90UXVldWUgPSBmdW5jdGlvbihi dWlsZGJvdCwgaWQsIGkKIAogQmFzZU9iamVjdC5hZGRDb25zdHJ1Y3RvckZ1bmN0aW9ucyhCdWls ZGJvdFF1ZXVlKTsKIAotQnVpbGRib3RRdWV1ZS5NYXhpbXVtUXVldWVzVG9Mb2FkID0gMTA7CitC dWlsZGJvdFF1ZXVlLlJlY2VudEl0ZXJhdGlvbnNUb0xvYWQgPSAxMDsKIAogQnVpbGRib3RRdWV1 ZS5FdmVudCA9IHsKICAgICBJdGVyYXRpb25zQWRkZWQ6ICJpdGVyYXRpb25zLWFkZGVkIiwKQEAg LTExOCw3ICsxMTgsNyBAQCBCdWlsZGJvdFF1ZXVlLnByb3RvdHlwZSA9IHsKICAgICAgICAgcmV0 dXJuIG51bGw7CiAgICAgfSwKIAotICAgIHVwZGF0ZTogZnVuY3Rpb24oaXRlcmF0aW9uc1RvTG9h ZCkKKyAgICB1cGRhdGU6IGZ1bmN0aW9uKCkKICAgICB7CiAgICAgICAgIGlmICh0aGlzLmJ1aWxk Ym90Lm5lZWRzQXV0aGVudGljYXRpb24gJiYgdGhpcy5idWlsZGJvdC5hdXRoZW50aWNhdGlvblN0 YXR1cyA9PT0gQnVpbGRib3QuQXV0aGVudGljYXRpb25TdGF0dXMuSW52YWxpZENyZWRlbnRpYWxz KQogICAgICAgICAgICAgcmV0dXJuOwpAQCAtMTMyLDE1ICsxMzIsMTEgQEAgQnVpbGRib3RRdWV1 ZS5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICBpZiAoZGF0YS5jdXJyZW50QnVpbGRzIGluc3Rh bmNlb2YgQXJyYXkpCiAgICAgICAgICAgICAgICAgZGF0YS5jdXJyZW50QnVpbGRzLmZvckVhY2go ZnVuY3Rpb24oaWQpIHsgY3VycmVudEJ1aWxkc1tpZF0gPSB0cnVlOyB9KTsKIAotICAgICAgICAg ICAgaWYgKCFpdGVyYXRpb25zVG9Mb2FkKQotICAgICAgICAgICAgICAgIGl0ZXJhdGlvbnNUb0xv YWQgPSBkYXRhLmNhY2hlZEJ1aWxkcy5sZW5ndGg7Ci0KLSAgICAgICAgICAgIHZhciBzdG9wID0g TWF0aC5tYXgoMCwgZGF0YS5jYWNoZWRCdWlsZHMubGVuZ3RoIC0gaXRlcmF0aW9uc1RvTG9hZCk7 Ci0gICAgICAgICAgICB2YXIgbG9hZGluZ1N0b3AgPSBNYXRoLm1heCgwLCBkYXRhLmNhY2hlZEJ1 aWxkcy5sZW5ndGggLSBCdWlsZGJvdFF1ZXVlLk1heGltdW1RdWV1ZXNUb0xvYWQpOworICAgICAg ICAgICAgdmFyIGxvYWRpbmdTdG9wID0gTWF0aC5tYXgoMCwgZGF0YS5jYWNoZWRCdWlsZHMubGVu Z3RoIC0gQnVpbGRib3RRdWV1ZS5SZWNlbnRJdGVyYXRpb25zVG9Mb2FkKTsKIAogICAgICAgICAg ICAgdmFyIG5ld0l0ZXJhdGlvbnMgPSBbXTsKIAotICAgICAgICAgICAgZm9yICh2YXIgaSA9IGRh dGEuY2FjaGVkQnVpbGRzLmxlbmd0aCAtIDE7IGkgPj0gc3RvcDsgLS1pKSB7CisgICAgICAgICAg ICBmb3IgKHZhciBpID0gZGF0YS5jYWNoZWRCdWlsZHMubGVuZ3RoIC0gMTsgaSA+PSAwOyAtLWkp IHsKICAgICAgICAgICAgICAgICB2YXIgaXRlcmF0aW9uID0gdGhpcy5fa25vd25JdGVyYXRpb25z W2RhdGEuY2FjaGVkQnVpbGRzW2ldXTsKICAgICAgICAgICAgICAgICBpZiAoIWl0ZXJhdGlvbikg ewogICAgICAgICAgICAgICAgICAgICBpdGVyYXRpb24gPSBuZXcgQnVpbGRib3RJdGVyYXRpb24o dGhpcywgcGFyc2VJbnQoZGF0YS5jYWNoZWRCdWlsZHNbaV0sIDEwKSwgIShkYXRhLmNhY2hlZEJ1 aWxkc1tpXSBpbiBjdXJyZW50QnVpbGRzKSk7Cg==