135616 2014-08-05 12:02:45 -0700 SVGRenderingContext::createImageBuffer is not retina (2x) compatible (affects <mask>) 2017-01-05 18:22:32 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID https://bugs.webkit.org/show_bug.cgi?id=166750 InRadar P2 Normal --- 151737 1 timothy webkit-unassigned dino sabouhallawa simon.fraser thaddee.tyl webkit-bug-importer zimmermann oldest_to_newest 1026911 0 timothy 2014-08-05 12:02:45 -0700 SVGRenderingContext::createImageBuffer always makes a 1x buffer. This makes <mask> and maybe other things always use 1x on 2x devices. We really need to audit all places that call ImageBuffer::create with a hardcoded 1! (This was going to affect Web Inspector but I was able to use <clipPath> instead.) 1084406 1 webkit-bug-importer 2015-04-10 16:45:32 -0700 <rdar://problem/20506912> 1259917 2 297130 thaddee.tyl 2016-12-14 14:53:03 -0800 Created attachment 297130 Test case: the two circles should look identical. I would like to point out that this is not just an issue for Retina screens; it also affects zoomed in pages (either manually or through CSS). 1264305 3 sabouhallawa 2017-01-05 18:05:49 -0800 I do not think we currently have a problem in SVGRenderingContext::createImageBuffer() when calling ImageBuffer::create(). Yes, we are still sending resolutionScale = 1 to ImageBuffer::create() but this is correct. We send absoluteTransform = zooming_factor * device_scaling to SVGRenderingContext::createImageBuffer() which uses it to scale the ImageBuffer bitmap and to transform its context accordingly. So the caller (RenderSVGResourceMasker::applyResource() in this case) can still draw using logical units on the ImageBuffer. Regarding the new test case, I think it is unrelated to this bug. It is related to displaying an <img> element whose src is an SVG data uri. In this case, we do not respect the zooming_factor because the SVG root element belongs to an SVGDocument which does not inherit the deviceScaleFactor of the containing HTMLDocument. I am going to close this bug and open a new one for the data uri case. 1264317 4 sabouhallawa 2017-01-05 18:22:32 -0800 See https://bugs.webkit.org/show_bug.cgi?id=166750 297130 2016-12-14 14:53:03 -0800 2017-01-05 16:58:01 -0800 Test case: the two circles should look identical. file_135616.html text/html 664 thaddee.tyl PCFkb2N0eXBlIGh0bWw+DQo8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+DQo8dGl0bGU+U2FmYXJpIGJ1 ZzogU1ZHIG1hc2sgYXBwZWFycyBibHVycnkgd2hlbiB6b29tZWQgb3Igb24gUmV0aW5hIGRpc3Bs YXlzPC90aXRsZT4NCjxzdHlsZT5ib2R5e3pvb206NH08L3N0eWxlPg0KPHA+VGhlIHR3byBjaXJj bGVzIHNob3VsZCBsb29rIGlkZW50aWNhbC48L3A+DQo8aW1nIHNyYz0iZGF0YTppbWFnZS9zdmcr eG1sLDxzdmcgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnJyB3aWR0aD0nMTAwJyBo ZWlnaHQ9JzEwMCc+PG1hc2sgaWQ9J2EnPjxjaXJjbGUgY3g9JzUwJyBjeT0nNTAnIHI9JzUwJyBm aWxsPScjZmZmJy8+PC9tYXNrPjxnIG1hc2s9J3VybCgjYSknPjxyZWN0IHg9JzAnIHk9JzAnIHdp ZHRoPScxMDAnIGhlaWdodD0nMTAwJy8+PC9nPjwvc3ZnPiIgYWx0PSJCbHVycnkgYmxhY2sgY2ly Y2xlIj4NCjxzdmcgeG1sbnM9J2h0dHA6Ly93d3cudzMub3JnLzIwMDAvc3ZnJyB3aWR0aD0nMTAw JyBoZWlnaHQ9JzEwMCc+PG1hc2sgaWQ9J2EnPjxjaXJjbGUgY3g9JzUwJyBjeT0nNTAnIHI9JzUw JyBmaWxsPScjZmZmJy8+PC9tYXNrPjxnIG1hc2s9J3VybCgjYSknPjxyZWN0IHg9JzAnIHk9JzAn IHdpZHRoPScxMDAnIGhlaWdodD0nMTAwJy8+PC9nPjwvc3ZnPg==