135608 2014-08-05 09:48:44 -0700 Web Inspector: ReplayManager should unpause and suppress breakpoints before capturing/replaying 2014-08-06 23:15:09 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 135249 1 burg burg graouts joepeck timothy webkit-bug-importer oldest_to_newest 1026865 0 burg 2014-08-05 09:48:44 -0700 Patch to follow. 1026866 1 webkit-bug-importer 2014-08-05 09:48:56 -0700 <rdar://problem/17917514> 1027252 2 236123 burg 2014-08-06 12:08:23 -0700 Created attachment 236123 Patch 1027265 3 236123 timothy 2014-08-06 13:02:24 -0700 Comment on attachment 236123 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=236123&action=review > Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:682 > + WebInspector.debuggerManager.resume(); > + WebInspector.debuggerManager.addSingleFireEventListener(WebInspector.DebuggerManager.Event.Resumed, resolve); WebInspector.debuggerManager.resume() should return a Promise! 1027425 4 burg 2014-08-06 23:13:57 -0700 (In reply to comment #3) > (From update of attachment 236123 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=236123&action=review > > > Source/WebInspectorUI/UserInterface/Controllers/ReplayManager.js:682 > > + WebInspector.debuggerManager.resume(); > > + WebInspector.debuggerManager.addSingleFireEventListener(WebInspector.DebuggerManager.Event.Resumed, resolve); > > WebInspector.debuggerManager.resume() should return a Promise! Filed: https://bugs.webkit.org/show_bug.cgi?id=135690 1027426 5 burg 2014-08-06 23:15:09 -0700 Committed r172203: <http://trac.webkit.org/changeset/172203> 236123 2014-08-06 12:08:23 -0700 2014-08-06 13:02:24 -0700 Patch bug-135608-20140806120818.patch text/plain 6062 burg U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMTYyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCA5 ZjQwMjFjMDM4NDFiNGNkYTUxNDU2ZTk5NjFkOWUyMWI5Njg4OTQyLi5kZGI0OTE0ZDY5MDc3OGU0 N2JmZmYxMTBjMTY2ZWVlNzU5NmJiODE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwyOSBAQAogMjAxNC0wOC0wNiAgQnJpYW4gSi4gQnVyZyAgPGJ1cmdAY3Mud2FzaGluZ3Rv bi5lZHU+CiAKKyAgICAgICAgV2ViIEluc3BlY3RvcjogUmVwbGF5TWFuYWdlciBzaG91bGQgdW5w YXVzZSBhbmQgc3VwcHJlc3MgYnJlYWtwb2ludHMgYmVmb3JlIGNhcHR1cmluZy9yZXBsYXlpbmcK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTYwOAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0IGlzIGph cnJpbmcgd2hlbiB0aGUgZGVidWdnZXIgcGF1c2VzIGR1cmluZyBjYXB0dXJpbmcgb3IgcmVwbGF5 aW5nLiBGb3Igbm93LCB3ZSBzaG91bGQgc3VwcHJlc3MKKyAgICAgICAgYWxsIGJyZWFrcG9pbnRz IGR1cmluZyBjYXB0dXJpbmcgb3IgcmVwbGF5aW5nLCBhbmQgcmVzdG9yZSBicmVha3BvaW50IGVu YWJsZWQgc3RhdGUgd2hlbgorICAgICAgICBjYXB0dXJpbmcgZmluaXNoZXMsIHdoZW4gcmVwbGF5 aW5nIGZpbmlzaGVzLCBvciBkdXJpbmcgdGVtcG9yYXJ5IHJlcGxheSBwYXVzZXMuCisKKyAgICAg ICAgSW4gdGhlIGZ1dHVyZSwgdGhlIGRlYnVnZ2VyIHdpbGwgYmUgc2VsZWN0aXZlbHkgZW5hYmxl ZCBkdXJpbmcgcGxheWJhY2sgdG8gc2VlayB0byBzcGVjaWZpYworICAgICAgICBicmVha3BvaW50 IGhpdHMuIFRoaXMgaXMgdHJhY2tlZCBpbiBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1NjYzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9Db250cm9sbGVycy9S ZXBsYXlNYW5hZ2VyLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIucHJv dG90eXBlLnN0YXJ0Q2FwdHVyaW5nLnJlc3VsdCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVw bGF5TWFuYWdlci5wcm90b3R5cGUucmVwbGF5VG9Qb3NpdGlvbi5yZXN1bHQpOgorICAgICAgICAo V2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIucHJvdG90eXBlLnJlcGxheVRvQ29tcGxldGlvbi5y ZXN1bHQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIucHJvdG90eXBlLmNh cHR1cmVTdG9wcGVkKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5SZXBsYXlNYW5hZ2VyLnByb3Rv dHlwZS5wbGF5YmFja1BhdXNlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdl ci5wcm90b3R5cGUucGxheWJhY2tGaW5pc2hlZCk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUmVw bGF5TWFuYWdlci5wcm90b3R5cGUuX2NoYW5nZVNlZ21lbnRTdGF0ZSk6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuUmVwbGF5TWFuYWdlci5wcm90b3R5cGUuX3N1cHByZXNzQnJlYWtwb2ludHNBbmRS ZXN1bWVJZk5lZWRlZCk6CisKKzIwMTQtMDgtMDYgIEJyaWFuIEouIEJ1cmcgIDxidXJnQGNzLndh c2hpbmd0b24uZWR1PgorCiAgICAgICAgIFJFR1JFU1NJT04ocjE3MjA5NCk6IHRlc3RzIGZhaWwg YmVjYXVzZSBJbnNwZWN0b3IgdGVzdCBoYXJuZXNzIGRvZXMgbm90IGluY2x1ZGUgVUlTdHJpbmcK ICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTY1OAog CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Db250cm9s bGVycy9SZXBsYXlNYW5hZ2VyLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvQ29udHJvbGxlcnMvUmVwbGF5TWFuYWdlci5qcwppbmRleCAyMmJjN2E2MDI4Y2I4YTc4NDIx NDExMjM4NzhiNjVkOWE5YTdmYTcxLi5hMWMwMjk5ZGZiYzdmODUxNTVkNTU3Y2U4MjAyOTg4OTg2 ODFlYjk0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9D b250cm9sbGVycy9SZXBsYXlNYW5hZ2VyLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL0NvbnRyb2xsZXJzL1JlcGxheU1hbmFnZXIuanMKQEAgLTI0OCw2ICsyNDgs OCBAQCBXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdlci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAg ICB9KTsKICAgICAgICAgfQogCisgICAgICAgIHJlc3VsdCA9IHJlc3VsdC50aGVuKHRoaXMuX3N1 cHByZXNzQnJlYWtwb2ludHNBbmRSZXN1bWVJZk5lZWRlZCgpKTsKKwogICAgICAgICByZXN1bHQg PSByZXN1bHQudGhlbihmdW5jdGlvbigpIHsKICAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2Vy dChtYW5hZ2VyLnNlc3Npb25TdGF0ZSA9PT0gV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIuU2Vz c2lvblN0YXRlLkluYWN0aXZlKTsKICAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2VydChtYW5h Z2VyLnNlZ21lbnRTdGF0ZSA9PT0gV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIuU2VnbWVudFN0 YXRlLlVubG9hZGVkKTsKQEAgLTM0Myw2ICszNDUsOCBAQCBXZWJJbnNwZWN0b3IuUmVwbGF5TWFu YWdlci5wcm90b3R5cGUgPSB7CiAgICAgICAgICAgICB9KTsKICAgICAgICAgfQogCisgICAgICAg IHJlc3VsdCA9IHJlc3VsdC50aGVuKHRoaXMuX3N1cHByZXNzQnJlYWtwb2ludHNBbmRSZXN1bWVJ Zk5lZWRlZCgpKTsKKwogICAgICAgICByZXN1bHQgPSByZXN1bHQudGhlbihmdW5jdGlvbigpIHsK ICAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2VydChtYW5hZ2VyLnNlc3Npb25TdGF0ZSAhPT0g V2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIuU2Vzc2lvblN0YXRlLkNhcHR1cmluZyk7CiAgICAg ICAgICAgICAgICAgY29uc29sZS5hc3NlcnQobWFuYWdlci5zZWdtZW50U3RhdGUgIT09IFdlYklu c3BlY3Rvci5SZXBsYXlNYW5hZ2VyLlNlZ21lbnRTdGF0ZS5BcHBlbmRpbmcpOwpAQCAtMzcyLDYg KzM3Niw4IEBAIFdlYkluc3BlY3Rvci5SZXBsYXlNYW5hZ2VyLnByb3RvdHlwZSA9IHsKICAgICAg ICAgICAgIH0pOwogICAgICAgICB9CiAKKyAgICAgICAgcmVzdWx0ID0gcmVzdWx0LnRoZW4odGhp cy5fc3VwcHJlc3NCcmVha3BvaW50c0FuZFJlc3VtZUlmTmVlZGVkKCkpOworCiAgICAgICAgIHJl c3VsdCA9IHJlc3VsdC50aGVuKGZ1bmN0aW9uKCkgewogICAgICAgICAgICAgICAgIGNvbnNvbGUu YXNzZXJ0KG1hbmFnZXIuc2Vzc2lvblN0YXRlICE9PSBXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdl ci5TZXNzaW9uU3RhdGUuQ2FwdHVyaW5nKTsKICAgICAgICAgICAgICAgICBjb25zb2xlLmFzc2Vy dChtYW5hZ2VyLnNlZ21lbnRTdGF0ZSA9PT0gV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIuU2Vn bWVudFN0YXRlLkxvYWRlZCB8fCBtYW5hZ2VyLnNlZ21lbnRTdGF0ZSA9PT0gV2ViSW5zcGVjdG9y LlJlcGxheU1hbmFnZXIuU2VnbWVudFN0YXRlLlVubG9hZGVkKTsKQEAgLTQwOSw2ICs0MTUsMTEg QEAgV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIucHJvdG90eXBlID0gewogICAgICAgICB0aGlz Ll9jaGFuZ2VTZXNzaW9uU3RhdGUoV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIuU2Vzc2lvblN0 YXRlLkluYWN0aXZlKTsKICAgICAgICAgdGhpcy5fY2hhbmdlU2VnbWVudFN0YXRlKFdlYkluc3Bl Y3Rvci5SZXBsYXlNYW5hZ2VyLlNlZ21lbnRTdGF0ZS5VbmxvYWRlZCk7CiAKKyAgICAgICAgaWYg KHRoaXMuX2JyZWFrcG9pbnRzV2VyZVN1cHByZXNzZWQpIHsKKyAgICAgICAgICAgIGRlbGV0ZSB0 aGlzLl9icmVha3BvaW50c1dlcmVTdXBwcmVzc2VkOworICAgICAgICAgICAgV2ViSW5zcGVjdG9y LmRlYnVnZ2VyTWFuYWdlci5icmVha3BvaW50c0VuYWJsZWQgPSB0cnVlOworICAgICAgICB9CisK ICAgICAgICAgdGhpcy5kaXNwYXRjaEV2ZW50VG9MaXN0ZW5lcnMoV2ViSW5zcGVjdG9yLlJlcGxh eU1hbmFnZXIuRXZlbnQuQ2FwdHVyZVN0b3BwZWQpOwogICAgIH0sCiAKQEAgLTQ0Niw2ICs0NTcs MTEgQEAgV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIucHJvdG90eXBlID0gewogICAgICAgICBj b25zb2xlLmFzc2VydCh0aGlzLnNlc3Npb25TdGF0ZSA9PT0gV2ViSW5zcGVjdG9yLlJlcGxheU1h bmFnZXIuU2Vzc2lvblN0YXRlLlJlcGxheWluZyk7CiAgICAgICAgIHRoaXMuX2NoYW5nZVNlZ21l bnRTdGF0ZShXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdlci5TZWdtZW50U3RhdGUuTG9hZGVkKTsK IAorICAgICAgICBpZiAodGhpcy5fYnJlYWtwb2ludHNXZXJlU3VwcHJlc3NlZCkgeworICAgICAg ICAgICAgZGVsZXRlIHRoaXMuX2JyZWFrcG9pbnRzV2VyZVN1cHByZXNzZWQ7CisgICAgICAgICAg ICBXZWJJbnNwZWN0b3IuZGVidWdnZXJNYW5hZ2VyLmJyZWFrcG9pbnRzRW5hYmxlZCA9IHRydWU7 CisgICAgICAgIH0KKwogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJ bnNwZWN0b3IuUmVwbGF5TWFuYWdlci5FdmVudC5QbGF5YmFja1BhdXNlZCk7CiAgICAgfSwKIApA QCAtNDU3LDYgKzQ3MywxMSBAQCBXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdlci5wcm90b3R5cGUg PSB7CiAgICAgICAgIHRoaXMuX2NoYW5nZVNlc3Npb25TdGF0ZShXZWJJbnNwZWN0b3IuUmVwbGF5 TWFuYWdlci5TZXNzaW9uU3RhdGUuSW5hY3RpdmUpOwogICAgICAgICBjb25zb2xlLmFzc2VydCh0 aGlzLnNlZ21lbnRTdGF0ZSA9PT0gV2ViSW5zcGVjdG9yLlJlcGxheU1hbmFnZXIuU2VnbWVudFN0 YXRlLlVubG9hZGVkKTsKIAorICAgICAgICBpZiAodGhpcy5fYnJlYWtwb2ludHNXZXJlU3VwcHJl c3NlZCkgeworICAgICAgICAgICAgZGVsZXRlIHRoaXMuX2JyZWFrcG9pbnRzV2VyZVN1cHByZXNz ZWQ7CisgICAgICAgICAgICBXZWJJbnNwZWN0b3IuZGVidWdnZXJNYW5hZ2VyLmJyZWFrcG9pbnRz RW5hYmxlZCA9IHRydWU7CisgICAgICAgIH0KKwogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRU b0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuUmVwbGF5TWFuYWdlci5FdmVudC5QbGF5YmFja0Zpbmlz aGVkKTsKICAgICB9LAogCkBAIC02NDUsNiArNjY2LDIxIEBAIFdlYkluc3BlY3Rvci5SZXBsYXlN YW5hZ2VyLnByb3RvdHlwZSA9IHsKICAgICAgICAgY29uc29sZS5hc3NlcnQoaXNBbGxvd2VkLCAi SW52YWxpZCBzZWdtZW50IHN0YXRlIGNoYW5nZTogIiwgdGhpcy5fc2VnbWVudFN0YXRlLCAiIHRv ICIsIG5ld1N0YXRlKTsKICAgICAgICAgaWYgKGlzQWxsb3dlZCkKICAgICAgICAgICAgIHRoaXMu X3NlZ21lbnRTdGF0ZSA9IG5ld1N0YXRlOworICAgIH0sCisKKyAgICBfc3VwcHJlc3NCcmVha3Bv aW50c0FuZFJlc3VtZUlmTmVlZGVkOiBmdW5jdGlvbigpCisgICAgeworICAgICAgICB2YXIgbWFu YWdlciA9IHRoaXM7CisKKyAgICAgICAgcmV0dXJuIG5ldyBQcm9taXNlKGZ1bmN0aW9uKHJlc29s dmUsIHJlamVjdCkgeworICAgICAgICAgICAgbWFuYWdlci5fYnJlYWtwb2ludHNXZXJlU3VwcHJl c3NlZCA9IFdlYkluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIuYnJlYWtwb2ludHNFbmFibGVkOwor ICAgICAgICAgICAgV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFuYWdlci5icmVha3BvaW50c0VuYWJs ZWQgPSBmYWxzZTsKKyAgICAgICAgICAgIGlmICghV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFuYWdl ci5wYXVzZWQpCisgICAgICAgICAgICAgICAgcmV0dXJuIHJlc29sdmUoKTsKKworICAgICAgICAg ICAgV2ViSW5zcGVjdG9yLmRlYnVnZ2VyTWFuYWdlci5yZXN1bWUoKTsKKyAgICAgICAgICAgIFdl Ykluc3BlY3Rvci5kZWJ1Z2dlck1hbmFnZXIuYWRkU2luZ2xlRmlyZUV2ZW50TGlzdGVuZXIoV2Vi SW5zcGVjdG9yLkRlYnVnZ2VyTWFuYWdlci5FdmVudC5SZXN1bWVkLCByZXNvbHZlKTsKKyAgICAg ICAgfSk7CiAgICAgfQogfTsKIAo=