135607 2014-08-05 09:34:31 -0700 [GStreamer][1.4] Caps negotiation failure in playback pipeline 2014-08-08 00:49:41 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand webkit-unassigned agomez calvaris cdumez commit-queue eric.carlson glenn jer.noble philipj pnormand sergio vjaquez oldest_to_newest 1026855 0 pnormand 2014-08-05 09:34:31 -0700 ** (WebKitWebProcess:14901): WARNING **: Error: 11, Filter caps do not completely specify the output format. Debug output: gstcapsfilter.c(356): gst_capsfilter_prepare_buf (): /GstPipeline:play/WebKitWebAudioSrc:webkitwebaudiosrc0/GstCapsFilter:capsfilter0: Output caps are unfixed: EMPTY The webkitwebaudiosrc bin uses interleave with this chain upfront for each mono channel: queue ! capsfilter ! audioconvert ! i.sink but audioconvert only handles interleaved buffers so the capsfilter has to use interleaved layout as well. Right now it's using non-interleaved and it somehow works fine when webkitgtk is built against 1.2.x but not in 1.4.0. So let's fix this once for all, using interleaved works fine in 1.2.x and 1.4.x. 1026858 1 236031 pnormand 2014-08-05 09:41:47 -0700 Created attachment 236031 Patch 1026862 2 commit-queue 2014-08-05 09:44:02 -0700 Attachment 236031 did not pass style-queue: ERROR: Source/WebCore/platform/audio/gstreamer/WebKitWebAudioSourceGStreamer.cpp:95: Use 0 instead of NULL. [readability/null] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1027110 3 236085 pnormand 2014-08-06 02:58:27 -0700 Created attachment 236085 rebased patch, also using nullptr instead of NULL sentinel 1027812 4 pnormand 2014-08-08 00:49:41 -0700 Committed r172338: <http://trac.webkit.org/changeset/172338> 236031 2014-08-05 09:41:47 -0700 2014-08-06 02:58:27 -0700 Patch Patch.patch text/plain 2221 pnormand RnJvbSA5NzM1ZTI5MzBjY2QyZWE5NjA3YWU1YzgxNTVjMWMxYjA3NTA1YWE0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDUgQXVnIDIwMTQgMTg6NDA6MTIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBQ YXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9hdWRpby9nc3RyZWFtZXIvV2Vi S2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwICAgfCAgMiArLQogMiBmaWxlcyBjaGFuZ2Vk LCAxOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDM0M2VmN2Eu LjI2ZDZiOGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMCBAQAorMjAxNC0wOC0wNSAgUGhpbGlw cGUgTm9ybWFuZCAgPHBub3JtYW5kQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dTdHJlYW1lcl1b MS40XSBDYXBzIG5lZ290aWF0aW9uIGZhaWx1cmUgaW4gcGxheWJhY2sgcGlwZWxpbmUKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTYwNworCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuc3VyZSB0aGUgY2Fw c2ZpbHRlcnMgdXNlZCBpbiBmcm9udCBvZiBpbnRlcmxlYXZlIG5lZ290aWF0ZSB0aGVpcgorICAg ICAgICBjYXBzIGNvcnJlY3RseSB3aXRoIGF1ZGlvY29udmVydCB3aGljaCByZXF1aXJlcyBhdWRp byBidWZmZXJzIHdpdGgKKyAgICAgICAgaW50ZXJsZWF2ZWQgbGF5b3V0LgorCisgICAgICAgIE5v IG5ldyB0ZXN0cywgZXhpc3Rpbmcgd2ViYXVkaW8gdGVzdHMgd2lsbCBjb3ZlciB0aGlzIGNoYW5n ZSBvbmNlCisgICAgICAgIHdlIGJ1bXAgb3VyIEpIQnVpbGQgbW9kdWxlc2V0IHRvIEdTdHJlYW1l ciAxLjQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVk aW9Tb3VyY2VHU3RyZWFtZXIuY3BwOgorICAgICAgICAoZ2V0R1N0cmVhbWVyTW9ub0F1ZGlvQ2Fw cyk6CisKIDIwMTQtMDgtMDUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4K IAogICAgICAgICBBWDogU2VsZWN0IHRleHQgYWN0aXZpdHkgc2hvdWxkIHJldHVybiByZXBsYWNl ZCB0ZXh0IGluc3RlYWQgb2YgcHJldmlvdXNseSBzZWxlY3RlZCB0ZXh0CmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3Vy Y2VHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVy L1dlYktpdFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcAppbmRleCBmZjY3MmYzLi5lZGUzY2Zi IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2Vi S2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL2F1ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKQEAg LTkyLDcgKzkyLDcgQEAgc3RhdGljIEdzdENhcHMqIGdldEdTdHJlYW1lck1vbm9BdWRpb0NhcHMo ZmxvYXQgc2FtcGxlUmF0ZSkKICAgICByZXR1cm4gZ3N0X2NhcHNfbmV3X3NpbXBsZSgiYXVkaW8v eC1yYXciLCAicmF0ZSIsIEdfVFlQRV9JTlQsIHN0YXRpY19jYXN0PGludD4oc2FtcGxlUmF0ZSks CiAgICAgICAgICJjaGFubmVscyIsIEdfVFlQRV9JTlQsIDEsCiAgICAgICAgICJmb3JtYXQiLCBH X1RZUEVfU1RSSU5HLCBnc3RfYXVkaW9fZm9ybWF0X3RvX3N0cmluZyhHU1RfQVVESU9fRk9STUFU X0YzMiksCi0gICAgICAgICJsYXlvdXQiLCBHX1RZUEVfU1RSSU5HLCAibm9uLWludGVybGVhdmVk IiwgTlVMTCk7CisgICAgICAgICJsYXlvdXQiLCBHX1RZUEVfU1RSSU5HLCAiaW50ZXJsZWF2ZWQi LCBOVUxMKTsKIH0KIAogc3RhdGljIEdzdEF1ZGlvQ2hhbm5lbFBvc2l0aW9uIHdlYktpdFdlYkF1 ZGlvR1N0cmVhbWVyQ2hhbm5lbFBvc2l0aW9uKGludCBjaGFubmVsSW5kZXgpCi0tIAoyLjAuMQ== 236085 2014-08-06 02:58:27 -0700 2014-08-08 00:37:32 -0700 rebased patch, also using nullptr instead of NULL sentinel Patch.patch text/plain 2222 pnormand RnJvbSA2MTkyY2U3OWQxOTYxYmM4ZTQyM2M4OTY5OWQ4NWVmMDRhYzM2Y2ZkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQaGlsaXBwZSBOb3JtYW5kIDxwbm9ybWFuZEBpZ2FsaWEuY29t PgpEYXRlOiBUdWUsIDUgQXVnIDIwMTQgMTg6NDA6MTIgKzAyMDAKU3ViamVjdDogW1BBVENIXSBQ YXRjaAoKLS0tCiBTb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHwgMTcgKysrKysrKysrKysrKysrKysKIC4uLi9hdWRpby9nc3RyZWFtZXIvV2Vi S2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwICAgfCAgMiArLQogMiBmaWxlcyBjaGFuZ2Vk LCAxOCBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9uKC0pCgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDgwODNjMDgu LjZiMTU3NDJlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMTQtMDgtMDUgIFBoaWxp cHBlIE5vcm1hbmQgIDxwbm9ybWFuZEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHU3RyZWFtZXJd WzEuNF0gQ2FwcyBuZWdvdGlhdGlvbiBmYWlsdXJlIGluIHBsYXliYWNrIHBpcGVsaW5lCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU2MDcKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbnN1cmUgdGhlIGNh cHNmaWx0ZXJzIHVzZWQgaW4gZnJvbnQgb2YgaW50ZXJsZWF2ZSBuZWdvdGlhdGUgdGhlaXIKKyAg ICAgICAgY2FwcyBjb3JyZWN0bHkgd2l0aCBhdWRpb2NvbnZlcnQgd2hpY2ggcmVxdWlyZXMgYXVk aW8gYnVmZmVycyB3aXRoCisgICAgICAgIGludGVybGVhdmVkIGxheW91dC4KKworICAgICAgICBO byBuZXcgdGVzdHMsIGV4aXN0aW5nIHdlYmF1ZGlvIHRlc3RzIHdpbGwgY292ZXIgdGhpcyBjaGFu Z2Ugb25jZQorICAgICAgICB3ZSBidW1wIG91ciBKSEJ1aWxkIG1vZHVsZXNldCB0byBHU3RyZWFt ZXIgMS40LgorCisgICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1 ZGlvU291cmNlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKGdldEdTdHJlYW1lck1vbm9BdWRpb0Nh cHMpOgorCiAyMDE0LTA4LTA1ICBKYW1lcyBDcmFpZyAgPGpjcmFpZ0BhcHBsZS5jb20+CiAKICAg ICAgICAgV2ViIEluc3BlY3RvcjogQVhJOiBBZGQgbGFiZWwgc3RyaW5nIG9uY2UgQWNjZXNzaWJp bGl0eU9iamVjdDo6Y29tcHV0ZWRMYWJlbCgpIGlzIGF2YWlsYWJsZQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNl R1N0cmVhbWVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1ZGlvL2dzdHJlYW1lci9X ZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKaW5kZXggZmY2NzJmMy4uNDhkZGVlNSAx MDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktp dFdlYkF1ZGlvU291cmNlR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCkBAIC05 Miw3ICs5Miw3IEBAIHN0YXRpYyBHc3RDYXBzKiBnZXRHU3RyZWFtZXJNb25vQXVkaW9DYXBzKGZs b2F0IHNhbXBsZVJhdGUpCiAgICAgcmV0dXJuIGdzdF9jYXBzX25ld19zaW1wbGUoImF1ZGlvL3gt cmF3IiwgInJhdGUiLCBHX1RZUEVfSU5ULCBzdGF0aWNfY2FzdDxpbnQ+KHNhbXBsZVJhdGUpLAog ICAgICAgICAiY2hhbm5lbHMiLCBHX1RZUEVfSU5ULCAxLAogICAgICAgICAiZm9ybWF0IiwgR19U WVBFX1NUUklORywgZ3N0X2F1ZGlvX2Zvcm1hdF90b19zdHJpbmcoR1NUX0FVRElPX0ZPUk1BVF9G MzIpLAotICAgICAgICAibGF5b3V0IiwgR19UWVBFX1NUUklORywgIm5vbi1pbnRlcmxlYXZlZCIs IE5VTEwpOworICAgICAgICAibGF5b3V0IiwgR19UWVBFX1NUUklORywgImludGVybGVhdmVkIiwg bnVsbHB0cik7CiB9CiAKIHN0YXRpYyBHc3RBdWRpb0NoYW5uZWxQb3NpdGlvbiB3ZWJLaXRXZWJB dWRpb0dTdHJlYW1lckNoYW5uZWxQb3NpdGlvbihpbnQgY2hhbm5lbEluZGV4KQotLSAKMi4wLjE=