135585 2014-08-04 17:34:19 -0700 [GTK] [CSS Shapes] Layout test fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html fails 2014-08-05 18:30:48 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez bjonesbe bjonesbe cgarcia commit-queue dino jfernandez mrobinson pnormand rego oldest_to_newest 1026739 0 clopez 2014-08-04 17:34:19 -0700 The layout test fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html added on r172010 <http://trac.webkit.org/changeset/172010> fails on GTK: fast/shapes/shape-outside-floats/shape-outside-image-shape-margin.html [ ImageOnlyFailure ] Failure: http://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r172010%20%281886%29/fast/shapes/shape-outside-floats/shape-outside-image-shape-margin-diffs.html 1026751 1 clopez 2014-08-04 18:24:15 -0700 I have added this test to the list of expected failures for GTK on https://trac.webkit.org/r172017. Please remove it from the list if you fix the issue. Thanks 1026935 2 236045 bjonesbe 2014-08-05 13:44:34 -0700 Created attachment 236045 Patch This should fix the issue, but I have not been able to test it on a GTK build yet, if someone can do that, it would be great, otherwise I'll update when I have a working Linux GTK build. 1026967 3 236045 bjonesbe 2014-08-05 15:35:52 -0700 Comment on attachment 236045 Patch This does fix it in my GTK build. 1026996 4 clopez 2014-08-05 16:34:38 -0700 (In reply to comment #3) > (From update of attachment 236045 [details]) > This does fix it in my GTK build. Yes. I confirm that this patch fixes the issue on the GTK build. I'm not a reviewer, but hopefully one will look into it soon :) Thanks 1027012 5 236045 zoltan 2014-08-05 17:48:53 -0700 Comment on attachment 236045 Patch (In reply to comment #4) > (In reply to comment #3) > > (From update of attachment 236045 [details] [details]) > > This does fix it in my GTK build. > > Yes. I confirm that this patch fixes the issue on the GTK build. > > I'm not a reviewer, but hopefully one will look into it soon :) > > Thanks Thanks for checking! 1027027 6 236045 commit-queue 2014-08-05 18:30:44 -0700 Comment on attachment 236045 Patch Clearing flags on attachment: 236045 Committed r172116: <http://trac.webkit.org/changeset/172116> 1027028 7 commit-queue 2014-08-05 18:30:48 -0700 All reviewed patches have been landed. Closing bug. 236045 2014-08-05 13:44:34 -0700 2014-08-05 18:30:43 -0700 Patch bug-135585-20140805134423.patch text/plain 4883 bjonesbe U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMDM1CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggZDAyMWUxMGI3NjZlODY2OGMyZTM2 OWY4ZjM1ZmVmMGYxMGRiMjk5NS4uZGFlMjQ3OWIyZWJlZDJlMmQ1MzY5ZGY3ODMyMTE1YjczYzJi NzAzZSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA4LTA1ICBCZW0gSm9uZXMtQmV5ICA8 YmpvbmVzYmVAYWRvYmUuY29tPgorCisgICAgICAgIFtHVEtdIFtDU1MgU2hhcGVzXSBMYXlvdXQg dGVzdCBmYXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWltYWdl LXNoYXBlLW1hcmdpbi5odG1sIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xMzU1ODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgcG9zaXRpb25pbmcgd2FzIGRlcGVuZGVudCBvbiB0aGUgZm9u dCBtZXRyaWNzIG9mIHRoZSA8cD4gdGFnLAorICAgICAgICB3aGljaCBkaWZmZXJzIGJldHdlZW4g cGxhdGZvcm1zLiBUaGlzIGZpeGVzIHRoYXQsIHdoaWNoIHNob3VsZCBtYWtlCisgICAgICAgIHRo ZSB0ZXN0IHBhc3Mgb24gYWxsIHBsYXRmb3Jtcy4KKworICAgICAgICAqIGZhc3Qvc2hhcGVzL3No YXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUtaW1hZ2Utc2hhcGUtbWFyZ2luLWV4cGVj dGVkLmh0bWw6CisgICAgICAgICogZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hh cGUtb3V0c2lkZS1pbWFnZS1zaGFwZS1tYXJnaW4uaHRtbDoKKyAgICAgICAgKiBwbGF0Zm9ybS9n dGsvVGVzdEV4cGVjdGF0aW9uczogCisKIDIwMTQtMDgtMDUgIFJlbmF0YSBIb2RvdmFuICA8cmhv ZG92YW4udS1zemVnZWRAcGFydG5lci5zYW1zdW5nLmNvbT4KIAogICAgICAgICBGaXhpbmcgY2Fs YygpIHBhcmFtZXRlciBwYXJzaW5nIGluIGN1YmljLWJlemllciBmdW5jdGlvbnMKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91 dHNpZGUtaW1hZ2Utc2hhcGUtbWFyZ2luLWV4cGVjdGVkLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0 L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWltYWdlLXNoYXBlLW1h cmdpbi1leHBlY3RlZC5odG1sCmluZGV4IGQzZDE1NjI0YzA4M2E1ZTEzODhhOGVlNjcwMjBkOWMx YzUyM2M4MjIuLjJlYzk2Y2RkZjVkYjExZGZkZDhlYTE4YTIxNjEyZGViNWQ0YWIzMjIgMTAwNjQ0 Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBl LW91dHNpZGUtaW1hZ2Utc2hhcGUtbWFyZ2luLWV4cGVjdGVkLmh0bWwKKysrIGIvTGF5b3V0VGVz dHMvZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1pbWFnZS1z aGFwZS1tYXJnaW4tZXhwZWN0ZWQuaHRtbApAQCAtNCw5ICs0LDE0IEBACiAgICAgPHRpdGxlPkNT UyBSZWZlcmVuY2UgRmlsZTwvdGl0bGU+CiAgICAgPGxpbmsgcmVsPSJhdXRob3IiIHRpdGxlPSJS ZWJlY2NhIEhhdWNrIiBocmVmPSJyaGF1Y2tAYWRvYmUuY29tIi8+CiAgICAgPHN0eWxlIHR5cGU9 InRleHQvY3NzIj4KKyAgICAgICAgI291dGVyIHsKKyAgICAgICAgICAgIHBvc2l0aW9uOiByZWxh dGl2ZTsKKyAgICAgICAgICAgIHdpZHRoOiAxMDBweDsKKyAgICAgICAgICAgIGhlaWdodDogMjUw cHg7CisgICAgICAgIH0KICAgICAgICAgI2NvbnRhaW5lciB7CiAgICAgICAgICAgICBwb3NpdGlv bjogYWJzb2x1dGU7Ci0gICAgICAgICAgICB0b3A6IDE3MHB4OworICAgICAgICAgICAgdG9wOiAx MjBweDsKICAgICAgICAgfQogICAgICAgICAjc2hhcGUtcmVmLWRpdiB7CiAgICAgICAgICAgICB3 aWR0aDogNTBweDsKQEAgLTI0LDkgKzI5LDExIEBACiAgICAgPHA+CiAgICAgICAgIFRoZSB0ZXN0 IHBhc3NlcyBpZiB0aGUgZ3JlZW4gcmVjdGFuZ2xlIGlzIGJlbG93IHRoZSBsaW5lLiBUaGVyZSBz aG91bGQgYmUgbm8gcmVkLgogICAgIDwvcD4KLSAgICA8ZGl2IGlkPSJjb250YWluZXIiPgotICAg ICAgICA8ZGl2IGlkPSJsaW5lIj48ZGl2PgotICAgICAgICA8ZGl2IGlkPSJzaGFwZS1yZWYtZGl2 Ij48L2Rpdj4KKyAgICA8ZGl2IGlkPSJvdXRlciI+CisgICAgICAgIDxkaXYgaWQ9ImNvbnRhaW5l ciI+CisgICAgICAgICAgICA8ZGl2IGlkPSJsaW5lIj48ZGl2PgorICAgICAgICAgICAgPGRpdiBp ZD0ic2hhcGUtcmVmLWRpdiI+PC9kaXY+CisgICAgICAgIDwvZGl2PgogICAgIDwvZGl2PgogPC9i b2R5PgogPC9odG1sPgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUt b3V0c2lkZS1mbG9hdHMvc2hhcGUtb3V0c2lkZS1pbWFnZS1zaGFwZS1tYXJnaW4uaHRtbCBiL0xh eW91dFRlc3RzL2Zhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBlLW91dHNpZGUt aW1hZ2Utc2hhcGUtbWFyZ2luLmh0bWwKaW5kZXggMWVlNzBlYWQ3ZDIzM2E0OTczYjhkNzU1MGE5 NGM4NDM3NWNjZGI0Yi4uMDllMDc3N2MzYTc4YTNlYTU5MzE5Mjg2N2EyODMzMDdiMjhjN2YzOSAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9zaGFwZXMvc2hhcGUtb3V0c2lkZS1mbG9hdHMv c2hhcGUtb3V0c2lkZS1pbWFnZS1zaGFwZS1tYXJnaW4uaHRtbAorKysgYi9MYXlvdXRUZXN0cy9m YXN0L3NoYXBlcy9zaGFwZS1vdXRzaWRlLWZsb2F0cy9zaGFwZS1vdXRzaWRlLWltYWdlLXNoYXBl LW1hcmdpbi5odG1sCkBAIC0xMiw2ICsxMiwxMSBAQAogICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgc2hhcGUtbWFyZ2luIGV4dGVuZGluZyBiZXlvbmQgdGhlIG1hcmdpbi1yaWdodCwg Y2F1c2luZyB0aGUKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIHRleHQgdG8gYmUg cHVzaGVkIGJlbG93IHRoZSBkZWZpbmVkIHNoYXBlLiIvPgogICAgIDxzdHlsZSB0eXBlPSJ0ZXh0 L2NzcyI+CisgICAgICAgICNvdXRlciB7CisgICAgICAgICAgICBwb3NpdGlvbjogcmVsYXRpdmU7 CisgICAgICAgICAgICB3aWR0aDogMTAwcHg7CisgICAgICAgICAgICBoZWlnaHQ6IDI1MHB4Owor ICAgICAgICB9CiAgICAgICAgIC5jb250YWluZXIgewogICAgICAgICAgICAgICBwb3NpdGlvbjog cmVsYXRpdmU7CiAgICAgICAgICAgICAgIGZvbnQtZmFtaWx5OiBBaGVtOwpAQCAtMzMsNyArMzgs NyBAQAogICAgICAgICB9CiAgICAgICAgICNyZWYgewogICAgICAgICAgICAgcG9zaXRpb246IGFi c29sdXRlOwotICAgICAgICAgICAgdG9wOiAxNzBweDsKKyAgICAgICAgICAgIHRvcDogMTIwcHg7 CiAgICAgICAgIH0KICAgICAgICAgI2xpbmUgewogICAgICAgICAgICAgd2lkdGg6IDEwMHB4OwpA QCAtNTIsMTQgKzU3LDE1IEBACiAgICAgPHA+CiAgICAgICAgIFRoZSB0ZXN0IHBhc3NlcyBpZiB0 aGUgZ3JlZW4gcmVjdGFuZ2xlIGlzIGJlbG93IHRoZSBsaW5lLiBUaGVyZSBzaG91bGQgYmUgbm8g cmVkLgogICAgIDwvcD4KLSAgICA8ZGl2IGlkPSJyZWYiPgotICAgICAgICA8ZGl2IGlkPSJsaW5l Ij48L2Rpdj4KLSAgICAgICAgPGRpdiBpZD0iZmFpbHVyZSI+PC9kaXY+Ci0gICAgPC9kaXY+Ci0g ICAgPGRpdiBpZD0idGVzdCIgY2xhc3M9ImNvbnRhaW5lciI+Ci0gICAgICAgIDxkaXYgaWQ9InNo YXBlLWRpdiI+PC9kaXY+Ci0gICAgICAgIHggeAorICAgIDxkaXYgaWQ9Im91dGVyIj4KKyAgICAg ICAgPGRpdiBpZD0icmVmIj4KKyAgICAgICAgICAgIDxkaXYgaWQ9ImxpbmUiPjwvZGl2PgorICAg ICAgICAgICAgPGRpdiBpZD0iZmFpbHVyZSI+PC9kaXY+CisgICAgICAgIDwvZGl2PgorICAgICAg ICA8ZGl2IGlkPSJ0ZXN0IiBjbGFzcz0iY29udGFpbmVyIj4KKyAgICAgICAgICAgIDxkaXYgaWQ9 InNoYXBlLWRpdiI+PC9kaXY+CisgICAgICAgICAgICB4IHgKKyAgICAgICAgPC9kaXY+CiAgICAg PC9kaXY+Ci0KIDwvYm9keT4KIDwvaHRtbD4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RF eHBlY3RhdGlvbnMKaW5kZXggMGZkNWU2ZWY4MGUyMzRlZjAyNmEyZjM2N2ZjN2IzMDVlYzhiMWQ4 Ni4uMzViMmY3MWNmMmVkZjIxYTgwOTFiNWMzODFjMmEwNDY5ZjQzMDhjZCAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysrIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTQzMSw4ICs0MzEsNiBAQCB3ZWJr aXQub3JnL2IvMTMxMzQ3IHN2Zy90ZXh0L2hpZHBpLXRleHQtc2VsZWN0aW9uLXJlY3QtcG9zaXRp b24uaHRtbCBbIEltYWdlT25seQogCiB3ZWJraXQub3JnL2IvMTMzODA2IHN2Zy9tYXNraW5nL21h c2stdHJhbnNmb3JtZWQtdGV4dC1taXNzaW5nLnN2ZyBbIEltYWdlT25seUZhaWx1cmUgXQogCi13 ZWJraXQub3JnL2IvMTM1NTg1IGZhc3Qvc2hhcGVzL3NoYXBlLW91dHNpZGUtZmxvYXRzL3NoYXBl LW91dHNpZGUtaW1hZ2Utc2hhcGUtbWFyZ2luLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KLQog Iy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8KICMgRW5kIG9mIEV4cGVjdGVkIGZhaWx1 cmVzCiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwo=