135572 2014-08-04 13:17:12 -0700 [MSE] Further fixes for "fast forward" playback after seeking in YouTube behavior. 2015-01-26 08:50:04 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified REOPENED InRadar P2 Normal --- 1 jer.noble jer.noble calvaris commit-queue eric.carlson glenn jonlee ltilve philipj sergio webkit-bug-importer oldest_to_newest 1026676 0 jer.noble 2014-08-04 13:17:12 -0700 [MSE] Further fixes for "fast forward" playback after seeking in YouTube behavior. 1026677 1 235984 jer.noble 2014-08-04 13:30:25 -0700 Created attachment 235984 Patch 1026678 2 235984 eric.carlson 2014-08-04 13:36:42 -0700 Comment on attachment 235984 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235984&action=review > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1211 > + if (presentationTimestamp > MediaTime::createWithDouble(m_source->currentTime())) { Should this be >= instead of > ? 1026679 3 jer.noble 2014-08-04 13:39:11 -0700 (In reply to comment #2) > (From update of attachment 235984 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=235984&action=review > > > Source/WebCore/Modules/mediasource/SourceBuffer.cpp:1211 > > + if (presentationTimestamp > MediaTime::createWithDouble(m_source->currentTime())) { > > Should this be >= instead of > ? Good point. In fact, this should probably be >, but checking against frameEndTimestamp. I.e., if the frame spans the currentTime (where the start time is <= but the end time is >), we should add the sample to the decode queue. 1026685 4 jer.noble 2014-08-04 13:55:21 -0700 Committed r172000: <http://trac.webkit.org/changeset/172000> 1026697 5 jer.noble 2014-08-04 14:59:51 -0700 Rolled out in r172007 <http://trac.webkit.org/r172007>. Re-opening. 1026712 6 jonlee 2014-08-04 15:59:33 -0700 <rdar://problem/17856763> 235984 2014-08-04 13:30:25 -0700 2015-01-26 08:50:04 -0800 Patch bug-135572-20140804133013.patch text/plain 3002 jer.noble U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTk1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzliODI4YjYyZDQwYzRk ZTc5NjBiMmMwYjMyYzhmMjVmZWJhYmViZS4uNTFjNzdmNDA2NTg2NGZlODE0ZjJiMjMwNzBhNThj OGU4ODBhOWYxNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI0IEBACiAyMDE0LTA4LTA0ICBKZXIg Tm9ibGUgIDxqZXIubm9ibGVAYXBwbGUuY29tPgogCisgICAgICAgIFtNU0VdIEZ1cnRoZXIgZml4 ZXMgZm9yICJmYXN0IGZvcndhcmQiIHBsYXliYWNrIGFmdGVyIHNlZWtpbmcgaW4gWW91VHViZSBi ZWhhdmlvci4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTEzNTU3MgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFR3byByZWxhdGVkIGZpeGVzOgorCisgICAgICAgIEluIHJlZW5xdWV1ZU1lZGlhRm9yVGltZSgp LCB1cGRhdGUgVHJhY2tCdWZmZXIubGFzdEVucXVldWVkUHJlc2VudGF0aW9uVGltZSB3aGVuIHdl IGZsdXNoIHNhbXBsZXMsIHNvIHRoYXQKKyAgICAgICAgdGhlIG5leHQgdGltZSBzYW1wbGVzIGFy ZSByZS1lbnF1ZXVlZCwgdGhlIHN0YXJ0aW5nIHBvaW50IGZvciByZS1lbnF1ZXVlaW5nIGlzIGNv cnJlY3QuCisKKyAgICAgICAgSW4gc291cmNlQnVmZmVyUHJpdmF0ZURpZFJlY2VpdmVTYW1wbGUo KSwgZG8gbm90IGFkZCBzYW1wbGVzIHRvIHRoZSBkZWNvZGUgcXVldWUgaWYgdGhleSBhcmUgYmVm b3JlIHRoZQorICAgICAgICBjdXJyZW50IG1lZGlhIHRpbWUuCisKKyAgICAgICAgKiBNb2R1bGVz L21lZGlhc291cmNlL1NvdXJjZUJ1ZmZlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTb3VyY2VC dWZmZXI6OnNvdXJjZUJ1ZmZlclByaXZhdGVEaWRSZWNlaXZlU2FtcGxlKToKKyAgICAgICAgKFdl YkNvcmU6OlNvdXJjZUJ1ZmZlcjo6cmVlbnF1ZXVlTWVkaWFGb3JUaW1lKToKKworMjAxNC0wOC0w NCAgSmVyIE5vYmxlICA8amVyLm5vYmxlQGFwcGxlLmNvbT4KKwogICAgICAgICBbTVNFXSBSZS1l bnF1ZWluZyBkdWUgdG8gb3ZlcmxhcHBpbmcgYXBwZW5kZWQgc2FtcGxlcyBjYW4gY2F1c2Ugc3R1 dHRlcmluZyBwbGF5YmFjawogICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM1NDI0CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVk aWFzb3VyY2UvU291cmNlQnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL01vZHVsZXMvbWVkaWFz b3VyY2UvU291cmNlQnVmZmVyLmNwcAppbmRleCA0NzhjYWJmNGM4YTBjNjQwYzkxNDZjNzIzOGVk Nzk2ZWQ3ZTkxNjM1Li5iODJmZDRmZjVhYjI0ZjdhZTRhNmEyNmU4OTBjY2I0OWJmZjA2ZWIyIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc291cmNlL1NvdXJjZUJ1ZmZl ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXNvdXJjZS9Tb3VyY2VCdWZm ZXIuY3BwCkBAIC0xMjA4LDggKzEyMDgsMTAgQEAgdm9pZCBTb3VyY2VCdWZmZXI6OnNvdXJjZUJ1 ZmZlclByaXZhdGVEaWRSZWNlaXZlU2FtcGxlKFNvdXJjZUJ1ZmZlclByaXZhdGUqLCBQYXMKICAg ICAgICAgLy8gQWRkIHRoZSBjb2RlZCBmcmFtZSB3aXRoIHRoZSBwcmVzZW50YXRpb24gdGltZXN0 YW1wLCBkZWNvZGUgdGltZXN0YW1wLCBhbmQgZnJhbWUgZHVyYXRpb24gdG8gdGhlIHRyYWNrIGJ1 ZmZlci4KICAgICAgICAgdHJhY2tCdWZmZXIuc2FtcGxlcy5hZGRTYW1wbGUoc2FtcGxlKTsKIAot ICAgICAgICBEZWNvZGVPcmRlclNhbXBsZU1hcDo6S2V5VHlwZSBkZWNvZGVLZXkoZGVjb2RlVGlt ZXN0YW1wLCBwcmVzZW50YXRpb25UaW1lc3RhbXApOwotICAgICAgICB0cmFja0J1ZmZlci5kZWNv ZGVRdWV1ZS5pbnNlcnQoRGVjb2RlT3JkZXJTYW1wbGVNYXA6Ok1hcFR5cGU6OnZhbHVlX3R5cGUo ZGVjb2RlS2V5LCBzYW1wbGUpKTsKKyAgICAgICAgaWYgKHByZXNlbnRhdGlvblRpbWVzdGFtcCA+ IE1lZGlhVGltZTo6Y3JlYXRlV2l0aERvdWJsZShtX3NvdXJjZS0+Y3VycmVudFRpbWUoKSkpIHsK KyAgICAgICAgICAgIERlY29kZU9yZGVyU2FtcGxlTWFwOjpLZXlUeXBlIGRlY29kZUtleShkZWNv ZGVUaW1lc3RhbXAsIHByZXNlbnRhdGlvblRpbWVzdGFtcCk7CisgICAgICAgICAgICB0cmFja0J1 ZmZlci5kZWNvZGVRdWV1ZS5pbnNlcnQoRGVjb2RlT3JkZXJTYW1wbGVNYXA6Ok1hcFR5cGU6OnZh bHVlX3R5cGUoZGVjb2RlS2V5LCBzYW1wbGUpKTsKKyAgICAgICAgfQogCiAgICAgICAgIC8vIDEu MTggU2V0IGxhc3QgZGVjb2RlIHRpbWVzdGFtcCBmb3IgdHJhY2sgYnVmZmVyIHRvIGRlY29kZSB0 aW1lc3RhbXAuCiAgICAgICAgIHRyYWNrQnVmZmVyLmxhc3REZWNvZGVUaW1lc3RhbXAgPSBkZWNv ZGVUaW1lc3RhbXA7CkBAIC0xNDQ5LDYgKzE0NTEsOCBAQCB2b2lkIFNvdXJjZUJ1ZmZlcjo6cmVl bnF1ZXVlTWVkaWFGb3JUaW1lKFRyYWNrQnVmZmVyJiB0cmFja0J1ZmZlciwgQXRvbWljU3RyaW5n CiAgICAgICAgIG5vbkRpc3BsYXlpbmdTYW1wbGVzLmFwcGVuZChpdGVyLT5zZWNvbmQpOwogCiAg ICAgbV9wcml2YXRlLT5mbHVzaEFuZEVucXVldWVOb25EaXNwbGF5aW5nU2FtcGxlcyhub25EaXNw bGF5aW5nU2FtcGxlcywgdHJhY2tJRCk7CisgICAgaWYgKCFub25EaXNwbGF5aW5nU2FtcGxlcy5p c0VtcHR5KCkpCisgICAgICAgIHRyYWNrQnVmZmVyLmxhc3RFbnF1ZXVlZFByZXNlbnRhdGlvblRp bWUgPSBub25EaXNwbGF5aW5nU2FtcGxlcy5sYXN0KCktPnByZXNlbnRhdGlvblRpbWUoKTsKIAog ICAgIC8vIEZpbGwgdGhlIGRlY29kZSBxdWV1ZSB3aXRoIHRoZSByZW1haW5pbmcgc2FtcGxlcy4K ICAgICB0cmFja0J1ZmZlci5kZWNvZGVRdWV1ZS5jbGVhcigpOwo=