135571 2014-08-04 13:08:06 -0700 [GTK] run-launcher --gtk is broken 2014-08-04 19:52:15 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mcatanzaro webkit-unassigned cgarcia commit-queue dbates oldest_to_newest 1026672 0 mcatanzaro 2014-08-04 13:08:06 -0700 When I run layout tests, if any test fails I except MiniBrowser to be launched with test results, but instead I get this error: ScriptError raised: Failed to run "['Tools/Scripts/run-launcher', '--release', '--gtk', u'file:///home/mcatanzaro/WebKit/WebKitBuild/Release/layout-test-results/results.html']" exit_code: 2 cwd: /home/mcatanzaro/WebKit Traceback (most recent call last): File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 80, in main run_details = run(port, options, args, stderr) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/layout_tests/run_webkit_tests.py", line 406, in run run_details = manager.run(args) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/layout_tests/controllers/manager.py", line 243, in run self._port.show_results_html_file(results_path) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/port/gtk.py", line 198, in show_results_html_file self._run_script("run-launcher", run_launcher_args) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/port/base.py", line 1292, in _run_script output = self._executive.run_command(run_script_command, cwd=self.webkit_base(), decode_output=decode_output, env=env) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 452, in run_command (error_handler or self.default_error_handler)(script_error) File "/home/mcatanzaro/WebKit/Tools/Scripts/webkitpy/common/system/executive.py", line 370, in default_error_handler raise error ScriptError: Failed to run "['Tools/Scripts/run-launcher', '--release', '--gtk', u'file:///home/mcatanzaro/WebKit/WebKitBuild/Release/layout-test-results/results.html']" exit_code: 2 cwd: /home/mcatanzaro/WebKit Looks like it's looking for webkit2gtk-3.0 instead of webkit2gtk-4.0 1026673 1 235982 mcatanzaro 2014-08-04 13:12:53 -0700 Created attachment 235982 Patch 1026772 2 235982 commit-queue 2014-08-04 19:52:12 -0700 Comment on attachment 235982 Patch Clearing flags on attachment: 235982 Committed r172022: <http://trac.webkit.org/changeset/172022> 1026773 3 commit-queue 2014-08-04 19:52:15 -0700 All reviewed patches have been landed. Closing bug. 235982 2014-08-04 13:12:53 -0700 2014-08-04 19:52:12 -0700 Patch bug-135571-20140804151240.patch text/plain 1706 mcatanzaro U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTk3CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNTdmNjZjNzQ5NjJhZjRjMWFhYWJhNTlhOGM1MzY0Mjll MzlhMmY5Mi4uMTUxNmQyNGQxMDBiYWYwZDVlM2Q4OTcyNTIxZDRiZjEyZTA2OWJkNCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDE0LTA4LTA0ICBNaWNoYWVsIENhdGFuemFybyAgPG1jYXRhbnphcm9AaWdhbGlhLmNv bT4KKworICAgICAgICBbR1RLXSBydW4tbGF1bmNoZXIgLS1ndGsgaXMgYnJva2VuCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzU1NzEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0 ZGlycy5wbToKKyAgICAgICAgKGJ1aWx0RHlsaWJQYXRoRm9yTmFtZSk6IFNlYXJjaCBmb3IgbGli d2Via2l0Mmd0ay00LjAKKwogMjAxNC0wOC0wMyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gRG8gbm90IGluY2x1ZGUgSmF2YVNjcmlw dENvcmUgc3RyZXNzIHRlc3RzIGluIHJlbGVhc2UgdGFyYmFsbHMKZGlmZiAtLWdpdCBhL1Rvb2xz L1NjcmlwdHMvd2Via2l0ZGlycy5wbSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQppbmRl eCAxMmRkNjkzZWJjOWFjNGI5ZTg2ZjAzOGJjZmYzZGU0NWQ4MTAyYjYxLi5hODkyNWQxYWI0MDJk NWNjMjJiZjQwYzZlNGY4YTgwNmI5MGVmOTk3IDEwMDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdGRpcnMucG0KKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCkBAIC04MjYsMTYg KzgyNiw3IEBAIHN1YiBidWlsdER5bGliUGF0aEZvck5hbWUKICAgICBkZXRlcm1pbmVDb25maWd1 cmF0aW9uUHJvZHVjdERpcigpOwogCiAgICAgaWYgKGlzR3RrKCkpIHsKLSAgICAgICAgIyBXZWJL aXRHVEsrIGZvciBHVEsyLCBXZWJLaXRHVEsrIGZvciBHVEszLCBhbmQgV2ViS2l0MiByZXNwZWN0 aXZlbHkuCi0gICAgICAgIG15IEBsaWJyYXJpZXMgPSAoImxpYndlYmtpdGd0ay0xLjAiLCAibGli d2Via2l0Z3RrLTMuMCIsICJsaWJ3ZWJraXQyZ3RrLTMuMCIpOwotICAgICAgICBteSAkZXh0ZW5z aW9uID0gaXNEYXJ3aW4oKSA/ICIuZHlsaWIiIDogIi5zbyI7Ci0gICAgICAgIG15ICRidWlsdExp YnJhcnlQYXRoID0gIiRjb25maWd1cmF0aW9uUHJvZHVjdERpci9saWIvIjsKLQotICAgICAgICBm b3JlYWNoICRsaWJyYXJ5TmFtZSAoQGxpYnJhcmllcykgewotICAgICAgICAgICAgbXkgJGxpYnJh cnlQYXRoID0gIiRidWlsdExpYnJhcnlQYXRoIiAuICRsaWJyYXJ5TmFtZSAuICRleHRlbnNpb247 Ci0gICAgICAgICAgICByZXR1cm4gJGxpYnJhcnlQYXRoIGlmIC1lICRsaWJyYXJ5UGF0aDsKLSAg ICAgICAgfQotICAgICAgICByZXR1cm4gIk5vdEZvdW5kIjsKKyAgICAgICAgcmV0dXJuICIkY29u ZmlndXJhdGlvblByb2R1Y3REaXIvbGliL2xpYndlYmtpdDJndGstNC4wIiAuIGlzRGFyd2luKCkg PyAiLmR5bGliIiA6ICIuc28iOwogICAgIH0KICAgICBpZiAoaXNFZmwoKSkgewogICAgICAgICBy ZXR1cm4gIiRjb25maWd1cmF0aW9uUHJvZHVjdERpci9saWIvbGliZXdlYmtpdDIuc28iOwo=