135554 2014-08-03 22:15:40 -0700 Enable didReceiveDataArray callback on Mac 2014-08-12 16:46:08 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 135727 1 psolanki psolanki benjamin cmarcelo commit-queue psolanki oldest_to_newest 1026590 0 psolanki 2014-08-03 22:15:40 -0700 iOS uses didReceiveDataArray callback while Mac uses didReceiveData. It would be nice to make the two platforms consistent. didReceiveDataArray callback is better since it reduces a copying phase in CFNetwork. <rdar://problem/9170731> 1026591 1 235960 psolanki 2014-08-03 22:19:50 -0700 Created attachment 235960 Patch for bots 1027650 2 psolanki 2014-08-07 15:10:12 -0700 Uncovered bug 135727 when looking at the memory impact of this change. 1027740 3 236255 psolanki 2014-08-07 19:57:32 -0700 Created attachment 236255 Patch 1027948 4 236255 kling 2014-08-08 14:30:28 -0700 Comment on attachment 236255 Patch r=me 1028268 5 psolanki 2014-08-11 12:21:35 -0700 Thanks for the review. I'll check this in after bug 135727. 1028668 6 psolanki 2014-08-12 16:46:08 -0700 Committed r172508: <http://trac.webkit.org/changeset/172508> 235960 2014-08-03 22:19:50 -0700 2014-08-07 19:57:29 -0700 Patch for bots bug-135554-20140803221937.patch text/plain 1369 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxNzE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI4YmQ0MWY2NWYyZGRiZjFhYTRlOTIx ZjViZjYzNWIwMThhYmJhOWMuLjZlMTJkM2MwZGUyZDljNzc1NzE1ODcxOTJlNzhkYjAyYjE3ZWE2 ZjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMDgtMDMgIFByYXRpayBTb2xhbmtpICA8cHNv bGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBkaWRSZWNlaXZlRGF0YUFycmF5IGNh bGxiYWNrIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM1NTU0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxNC0wNy0yOCAgQnJpYW4gSi4gQnVyZyAgPGJ1 cmdAY3Mud2FzaGluZ3Rvbi5lZHU+CiAKICAgICAgICAgU2hvdWxkIG5vdCBleHBvcnQgc3ltYm9s cyBmb3IgYmFzZTY0RW5jb2RlIGlubGluZSBhZGFwdGVyIG1ldGhvZHMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5oCmluZGV4 IDkyNjg4MWM2MGM2NDM3ZDFlODc2NjQ5YThmMDdmM2U5ZmRjMTU5ZjUuLjhlMmRkZGUyYmNkOGFj MWMzOWZjNjNmNzQ0ZWExYWVlNGMxOGFlYjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1Bs YXRmb3JtLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtNDY1LDEyICs0NjUs MTAgQEAKIAogI2RlZmluZSBXVEZfVVNFX0NGIDEKICNkZWZpbmUgV1RGX1VTRV9GT1VOREFUSU9O IDEKKyNkZWZpbmUgV1RGX1VTRV9ORVRXT1JLX0NGREFUQV9BUlJBWV9DQUxMQkFDSyAxCiAjZGVm aW5lIEVOQUJMRV9VU0VSX01FU1NBR0VfSEFORExFUlMgMQotCi0jZW5kaWYKLQotI2lmIFBMQVRG T1JNKENPQ09BKQogI2RlZmluZSBIQVZFX09VVF9PRl9QUk9DRVNTX0xBWUVSX0hPU1RJTkcgMQor CiAjZW5kaWYKIAogI2lmIFBMQVRGT1JNKE1BQykKQEAgLTUwMSw3ICs0OTksNiBAQAogI2RlZmlu ZSBET05UX0ZJTkFMSVpFX09OX01BSU5fVEhSRUFEIDEKICNkZWZpbmUgSEFWRV9SRUFETElORSAx CiAjZGVmaW5lIFdURl9VU0VfQ0ZORVRXT1JLIDEKLSNkZWZpbmUgV1RGX1VTRV9ORVRXT1JLX0NG REFUQV9BUlJBWV9DQUxMQkFDSyAxCiAjZGVmaW5lIFdURl9VU0VfVUlLSVRfRURJVElORyAxCiAj ZGVmaW5lIFdURl9VU0VfV0VCX1RIUkVBRCAxCiAjZGVmaW5lIFdURl9VU0VfUVVJQ0tfTE9PSyAx Cg== 236255 2014-08-07 19:57:32 -0700 2014-08-08 14:30:27 -0700 Patch bug-135554-20140807195720.patch text/plain 1503 psolanki U3VidmVyc2lvbiBSZXZpc2lvbjogMTcyMzI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI3ZGFjNjQ2YTUwNjc3N2E3YjZkMGU3 ODMzNjdhMzg5MWNhZWUzOTQuLjRkNzFiYTVjNzFiOWU2ZTQxOWQzODEwZjUzNjIyZjNmNjhlOTk1 MGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMDgtMDcgIFByYXRpayBTb2xhbmtpICA8cHNv bGFua2lAYXBwbGUuY29tPgorCisgICAgICAgIEVuYWJsZSBkaWRSZWNlaXZlRGF0YUFycmF5IGNh bGxiYWNrIG9uIE1hYworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM1NTU0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS85MTcwNzMxPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEVuYWJsZSBXVEZfVVNFX05F VFdPUktfQ0ZEQVRBX0FSUkFZX0NBTExCQUNLIGZvciBhbGwgQ29jb2EgcGxhdGZvcm1zIHNvIHRo YXQgd2UgdXNlIHRoZSBzYW1lCisgICAgICAgIGNvZGUgcGF0aCBmb3IgTWFjIGFuZCBpT1MuCisK KyAgICAgICAgKiB3dGYvUGxhdGZvcm0uaDoKKwogMjAxNC0wOC0wNyAgQmVuamFtaW4gUG91bGFp biAgPGJwb3VsYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBHZXQgcmlkIG9mIFNDUklQVEVEX1NQ RUVDSApkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9XVEYv d3RmL1BsYXRmb3JtLmgKaW5kZXggNDFjZTRiZWQ1OTBmMTFjOTA3MjMwOTFiMDk5Yjc3NDgxNTcy MTQ0ZC4uNDcxNTQ4MTkwOThlNGUyNTU4YmUwN2FmNzVkZDYxYmE5NmQ4OTFmYyAxMDA2NDQKLS0t IGEvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9y bS5oCkBAIC00NjUsMTIgKzQ2NSwxMCBAQAogCiAjZGVmaW5lIFdURl9VU0VfQ0YgMQogI2RlZmlu ZSBXVEZfVVNFX0ZPVU5EQVRJT04gMQorI2RlZmluZSBXVEZfVVNFX05FVFdPUktfQ0ZEQVRBX0FS UkFZX0NBTExCQUNLIDEKICNkZWZpbmUgRU5BQkxFX1VTRVJfTUVTU0FHRV9IQU5ETEVSUyAxCi0K LSNlbmRpZgotCi0jaWYgUExBVEZPUk0oQ09DT0EpCiAjZGVmaW5lIEhBVkVfT1VUX09GX1BST0NF U1NfTEFZRVJfSE9TVElORyAxCisKICNlbmRpZgogCiAjaWYgUExBVEZPUk0oTUFDKQpAQCAtNTAx LDcgKzQ5OSw2IEBACiAjZGVmaW5lIERPTlRfRklOQUxJWkVfT05fTUFJTl9USFJFQUQgMQogI2Rl ZmluZSBIQVZFX1JFQURMSU5FIDEKICNkZWZpbmUgV1RGX1VTRV9DRk5FVFdPUksgMQotI2RlZmlu ZSBXVEZfVVNFX05FVFdPUktfQ0ZEQVRBX0FSUkFZX0NBTExCQUNLIDEKICNkZWZpbmUgV1RGX1VT RV9VSUtJVF9FRElUSU5HIDEKICNkZWZpbmUgV1RGX1VTRV9XRUJfVEhSRUFEIDEKICNkZWZpbmUg V1RGX1VTRV9RVUlDS19MT09LIDEK