135553 2014-08-03 18:41:57 -0700 [EFL] Move DATA_INSTALL_DIR to ewebkit2-0 2014-08-03 19:12:52 -0700 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ryuan.choi ryuan.choi bunhere commit-queue gyuyoung.kim lucas.de.marchi rakuco sergio oldest_to_newest 1026558 0 ryuan.choi 2014-08-03 18:41:57 -0700 ewebkit used ewebkit-0 for DATA_INSTALL_DIR but libewebkit2.so and includes are installed in ewebkit2-0 Since WebKit1/Efl is dropped, we don't need to have two directory name. 1026560 1 235955 ryuan.choi 2014-08-03 18:44:00 -0700 Created attachment 235955 Patch 1026561 2 235955 gyuyoung.kim 2014-08-03 18:45:21 -0700 Comment on attachment 235955 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=235955&action=review > Source/cmake/OptionsEfl.cmake:41 > set(WebKit_OUTPUT_NAME ewebkit) Should we continue to keep this variable ? 1026566 3 235956 ryuan.choi 2014-08-03 18:51:37 -0700 Created attachment 235956 Patch 1026567 4 235956 gyuyoung.kim 2014-08-03 18:53:38 -0700 Comment on attachment 235956 Patch LGTM. But, WebKit_OUTPUT_NAME is being used by GTK port as well. Those look redundant too. 1026568 5 ryuan.choi 2014-08-03 19:03:04 -0700 (In reply to comment #4) > (From update of attachment 235956 [details]) > LGTM. But, WebKit_OUTPUT_NAME is being used by GTK port as well. Those look redundant too. GTK port used it for DATA_BUILD_DIR but it looks also not used. I will make the different bug for GTK port maintainers to confirm it. 1026572 6 235956 ryuan.choi 2014-08-03 19:12:37 -0700 Comment on attachment 235956 Patch Clearing flags on attachment: 235956 Committed r171985: <http://trac.webkit.org/changeset/171985> 1026573 7 ryuan.choi 2014-08-03 19:12:52 -0700 All reviewed patches have been landed. Closing bug. 235955 2014-08-03 18:44:00 -0700 2014-08-03 18:51:29 -0700 Patch bug-135553-20140804104346.patch text/plain 1388 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGNjOTgw YTE4MDhkNmQyZGMwNGI4ZmRlZTkwNjNmY2FhNmM5YjU2NDEuLmZhMTM3NzkyYzE0NWQ5NTI2MzEy Y2ZkMDEwMmI4ODg0YmQ5MWNmNWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC00MSw3ICs0MSw3 IEBAIHNldChXZWJDb3JlX09VVFBVVF9OQU1FIHdlYmNvcmVfZWZsKQogc2V0KFdlYktpdF9PVVRQ VVRfTkFNRSBld2Via2l0KQogc2V0KFdlYktpdDJfT1VUUFVUX05BTUUgZXdlYmtpdDIpCiAKLXNl dChEQVRBX0lOU1RBTExfRElSICJzaGFyZS8ke1dlYktpdF9PVVRQVVRfTkFNRX0tJHtQUk9KRUNU X1ZFUlNJT05fTUFKT1J9IiBDQUNIRSBQQVRIICJJbnN0YWxsYXRpb24gcGF0aCBmb3IgdGhlbWUg ZGF0YSIpCitzZXQoREFUQV9JTlNUQUxMX0RJUiAic2hhcmUvJHtXZWJLaXQyX09VVFBVVF9OQU1F fS0ke1BST0pFQ1RfVkVSU0lPTl9NQUpPUn0iIENBQ0hFIFBBVEggIkluc3RhbGxhdGlvbiBwYXRo IGZvciB0aGVtZSBkYXRhIikKIHNldChUSEVNRV9CSU5BUllfRElSICR7Q01BS0VfQklOQVJZX0RJ Un0vV2ViQ29yZS9wbGF0Zm9ybS9lZmwvRGVmYXVsdFRoZW1lKQogZmlsZShNQUtFX0RJUkVDVE9S WSAke1RIRU1FX0JJTkFSWV9ESVJ9KQogCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cgYi9DaGFuZ2VM b2cKaW5kZXggMDgzODA2YzUxZGFiYzYyNTdhZTQzM2JmNWYxNzM5Zjk0YjViN2Q3Yi4uODE1OWVi ZTk5OWYyMmY4ZTBlZDYxMjczYTI3MzJlNWYxYWJmZDUyMSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9n CisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE0LTA4LTAzICBSeXVhbiBDaG9p ICA8cnl1YW4uY2hvaUBzYW1zdW5nLmNvbT4KKworICAgICAgICBbRUZMXSBNb3ZlIERBVEFfSU5T VEFMTF9ESVIgdG8gZXdlYmtpdDItMAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MTM1NTUzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgU2luY2UgV2ViS2l0MS9FZmwgaXMgZHJvcHBlZCwgd2UgZG9uJ3QgbmVl ZCB0byB1c2UgZXdlYmtpdC0xIGFuZCBld2Via2l0Mi0xLgorCisgICAgICAgICogU291cmNlL2Nt YWtlL09wdGlvbnNFZmwuY21ha2U6CisKIDIwMTQtMDgtMDEgIEJlYXIgVHJhdmlzICA8YmV0cmF2 aXNAYWRvYmUuY29tPgogCiAgICAgICAgIFtGZWF0dXJlIFF1ZXJpZXNdIEVuYWJsZSBGZWF0dXJl IFF1ZXJpZXMgb24gRUZML0dUSwo= 235956 2014-08-03 18:51:37 -0700 2014-08-03 19:12:36 -0700 Patch bug-135553-20140804105124.patch text/plain 1593 ryuan.choi U3VidmVyc2lvbiBSZXZpc2lvbjogMTcxOTg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0VmbC5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCmluZGV4IGNjOTgw YTE4MDhkNmQyZGMwNGI4ZmRlZTkwNjNmY2FhNmM5YjU2NDEuLmMxN2U3NTIyMjU4N2Q2N2NkYWEx OWZkZTMwMTc4MjVlMjkzYzcxMjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZs LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlCkBAIC0zOCwxMCArMzgs OSBAQCBzZXQoV1RGX0xJQlJBUllfVFlQRSBTVEFUSUMpCiBzZXQoV1RGX09VVFBVVF9OQU1FIHd0 Zl9lZmwpCiBzZXQoSmF2YVNjcmlwdENvcmVfT1VUUFVUX05BTUUgamF2YXNjcmlwdGNvcmVfZWZs KQogc2V0KFdlYkNvcmVfT1VUUFVUX05BTUUgd2ViY29yZV9lZmwpCi1zZXQoV2ViS2l0X09VVFBV VF9OQU1FIGV3ZWJraXQpCiBzZXQoV2ViS2l0Ml9PVVRQVVRfTkFNRSBld2Via2l0MikKIAotc2V0 KERBVEFfSU5TVEFMTF9ESVIgInNoYXJlLyR7V2ViS2l0X09VVFBVVF9OQU1FfS0ke1BST0pFQ1Rf VkVSU0lPTl9NQUpPUn0iIENBQ0hFIFBBVEggIkluc3RhbGxhdGlvbiBwYXRoIGZvciB0aGVtZSBk YXRhIikKK3NldChEQVRBX0lOU1RBTExfRElSICJzaGFyZS8ke1dlYktpdDJfT1VUUFVUX05BTUV9 LSR7UFJPSkVDVF9WRVJTSU9OX01BSk9SfSIgQ0FDSEUgUEFUSCAiSW5zdGFsbGF0aW9uIHBhdGgg Zm9yIHRoZW1lIGRhdGEiKQogc2V0KFRIRU1FX0JJTkFSWV9ESVIgJHtDTUFLRV9CSU5BUllfRElS fS9XZWJDb3JlL3BsYXRmb3JtL2VmbC9EZWZhdWx0VGhlbWUpCiBmaWxlKE1BS0VfRElSRUNUT1JZ ICR7VEhFTUVfQklOQVJZX0RJUn0pCiAKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxv ZwppbmRleCAwODM4MDZjNTFkYWJjNjI1N2FlNDMzYmY1ZjE3MzlmOTRiNWI3ZDdiLi5jOWI0MTg5 MjdlMWU3NzUzYzc5NTdjZDczZTVlZTM3NjliNjdjYTE2IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cK KysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMDgtMDMgIFJ5dWFuIENob2kg IDxyeXVhbi5jaG9pQHNhbXN1bmcuY29tPgorCisgICAgICAgIFtFRkxdIE1vdmUgREFUQV9JTlNU QUxMX0RJUiB0byBld2Via2l0Mi0wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0xMzU1NTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTaW5jZSBXZWJLaXQxL0VmbCBpcyBkcm9wcGVkLCB3ZSBkb24ndCBuZWVk IHRvIHVzZSBld2Via2l0LTEgYW5kIGV3ZWJraXQyLTEuCisgICAgICAgIEFuZCByZW1vdmVkIFdl YktpdF9PVVRQVVRfTkFNRSB2YXJpYWJsZSB3aGljaCBpcyBub3QgdXNlZCBhbnltb3JlIG9uIHRo ZSBFRkwgcG9ydC4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlOgor CiAyMDE0LTA4LTAxICBCZWFyIFRyYXZpcyAgPGJldHJhdmlzQGFkb2JlLmNvbT4KIAogICAgICAg ICBbRmVhdHVyZSBRdWVyaWVzXSBFbmFibGUgRmVhdHVyZSBRdWVyaWVzIG9uIEVGTC9HVEsK