135546 2014-08-02 23:09:38 -0700 AX: SelectText functionality always selects text after current selection even if closer selection is behind it 2014-08-04 10:43:03 -0700 1 1 1 Unclassified WebKit Accessibility 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 cfleizach cfleizach aboxhall apinheiro commit-queue dmazzoni jcraig jdiggs mario samuel_white webkit-bug-importer oldest_to_newest 1026505 0 cfleizach 2014-08-02 23:09:38 -0700 WebKit doesn't always select closest words when handling Dictation's "Select <phrase> command. <rdar://problem/17398315> 1026586 1 235957 cfleizach 2014-08-03 20:54:57 -0700 Created attachment 235957 patch 1026656 2 235957 commit-queue 2014-08-04 10:43:01 -0700 Comment on attachment 235957 patch Clearing flags on attachment: 235957 Committed r171997: <http://trac.webkit.org/changeset/171997> 1026657 3 commit-queue 2014-08-04 10:43:03 -0700 All reviewed patches have been landed. Closing bug. 235957 2014-08-03 20:54:57 -0700 2014-08-04 10:43:00 -0700 patch patch text/plain 6976 cfleizach SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTk4NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE0LTA4LTAzICBDaHJpcyBG bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFNlbGVjdFRleHQg ZnVuY3Rpb25hbGl0eSBhbHdheXMgc2VsZWN0cyB0ZXh0IGFmdGVyIGN1cnJlbnQgc2VsZWN0aW9u IGV2ZW4gaWYgY2xvc2VyIHNlbGVjdGlvbiBpcyBiZWhpbmQgaXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTU0NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExvZ2ljIHdhcyBpbmNvcnJlY3QgZm9yIGNv bXBhcmluZyByYW5nZXMgZm91bmQgYmVmb3JlIHRoZSBjdXJyZW50IHNlbGVjdGlvbi4KKyAgICAg ICAgQVNTRVJUIHdhcyBpbmNvcnJlY3QgZm9yIGFsbG93ZWQgcmFuZ2VzLiBXZSBuZWVkIHRvIGFs bG93IHJhbmdlcyB0aGF0IGFyZSByaWdodCBhdCB0aGUgYm91bmRhcmllcyBvZiBvdXIgZm91bmQg cmFuZ2VzLgorCisgICAgICAgIEV4dGVuZGVkIGV4aXN0aW5nIHRlc3Q6IHBsYXRmb3JtL21hYy9h Y2Nlc3NpYmlsaXR5L3NlbGVjdC10ZXh0Lmh0bWwKKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eU9iamVjdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpyYW5nZUNsb3Nlc3RU b1JhbmdlKToKKwogMjAxNC0wOC0wMyAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgog CiAgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8xNzc4MjUyOT4gUkVHUkVTU0lPTjogT1MgbWFya2V0 aW5nIHZlcnNpb24gaW4gaU9TIFNpbXVsYXRvciB1c2VyLWFnZW50IHN0cmluZyBpcyB0aGUgaG9z dCBPU+KAmXMKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0 eU9iamVjdC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B Y2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkocmV2aXNpb24gMTcxOTczKQorKysgU291cmNlL1dlYkNv cmUvYWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcAkod29ya2luZyBjb3B5KQpA QCAtNTMxLDggKzUzMSw4IEBACiBzdGF0aWMgUGFzc1JlZlB0cjxSYW5nZT4gcmFuZ2VDbG9zZXN0 VG9SYW5nZShSYW5nZSogcmVmZXJlbmNlUmFuZ2UsIFBhc3NSZWZQdHI8UmFuZ2U+IGFmdGVyUmFu Z2UsIFBhc3NSZWZQdHI8UmFuZ2U+IGJlZm9yZVJhbmdlKQogewogICAgIEFTU0VSVChyZWZlcmVu Y2VSYW5nZSk7Ci0gICAgQVNTRVJUKCFhZnRlclJhbmdlIHx8IGFmdGVyUmFuZ2UtPnN0YXJ0UG9z aXRpb24oKSA+IHJlZmVyZW5jZVJhbmdlLT5zdGFydFBvc2l0aW9uKCkpOwotICAgIEFTU0VSVCgh YmVmb3JlUmFuZ2UgfHwgYmVmb3JlUmFuZ2UtPmVuZFBvc2l0aW9uKCkgPCByZWZlcmVuY2VSYW5n ZS0+ZW5kUG9zaXRpb24oKSk7CisgICAgQVNTRVJUKCFhZnRlclJhbmdlIHx8IGFmdGVyUmFuZ2Ut PnN0YXJ0UG9zaXRpb24oKSA+PSByZWZlcmVuY2VSYW5nZS0+ZW5kUG9zaXRpb24oKSk7CisgICAg QVNTRVJUKCFiZWZvcmVSYW5nZSB8fCBiZWZvcmVSYW5nZS0+ZW5kUG9zaXRpb24oKSA8PSByZWZl cmVuY2VSYW5nZS0+c3RhcnRQb3NpdGlvbigpKTsKICAgICAKICAgICBpZiAoIXJlZmVyZW5jZVJh bmdlIHx8ICghYWZ0ZXJSYW5nZSAmJiAhYmVmb3JlUmFuZ2UpKQogICAgICAgICByZXR1cm4gbnVs bHB0cjsKQEAgLTU0MSw4ICs1NDEsOCBAQAogICAgIGlmICghYWZ0ZXJSYW5nZSAmJiBiZWZvcmVS YW5nZSkKICAgICAgICAgcmV0dXJuIGJlZm9yZVJhbmdlOwogICAgIAotICAgIHVuc2lnbmVkIHBv c2l0aW9uc1RvQWZ0ZXJSYW5nZSA9IFBvc2l0aW9uOjpwb3NpdGlvbkNvdW50QmV0d2VlblBvc2l0 aW9ucyhhZnRlclJhbmdlLT5zdGFydFBvc2l0aW9uKCksIHJlZmVyZW5jZVJhbmdlLT5zdGFydFBv c2l0aW9uKCkpOwotICAgIHVuc2lnbmVkIHBvc2l0aW9uc1RvQmVmb3JlUmFuZ2UgPSBQb3NpdGlv bjo6cG9zaXRpb25Db3VudEJldHdlZW5Qb3NpdGlvbnMoYWZ0ZXJSYW5nZS0+ZW5kUG9zaXRpb24o KSwgcmVmZXJlbmNlUmFuZ2UtPmVuZFBvc2l0aW9uKCkpOworICAgIHVuc2lnbmVkIHBvc2l0aW9u c1RvQWZ0ZXJSYW5nZSA9IFBvc2l0aW9uOjpwb3NpdGlvbkNvdW50QmV0d2VlblBvc2l0aW9ucyhh ZnRlclJhbmdlLT5zdGFydFBvc2l0aW9uKCksIHJlZmVyZW5jZVJhbmdlLT5lbmRQb3NpdGlvbigp KTsKKyAgICB1bnNpZ25lZCBwb3NpdGlvbnNUb0JlZm9yZVJhbmdlID0gUG9zaXRpb246OnBvc2l0 aW9uQ291bnRCZXR3ZWVuUG9zaXRpb25zKGJlZm9yZVJhbmdlLT5lbmRQb3NpdGlvbigpLCByZWZl cmVuY2VSYW5nZS0+c3RhcnRQb3NpdGlvbigpKTsKICAgICAKICAgICByZXR1cm4gcG9zaXRpb25z VG9BZnRlclJhbmdlIDwgcG9zaXRpb25zVG9CZWZvcmVSYW5nZSA/IGFmdGVyUmFuZ2UgOiBiZWZv cmVSYW5nZTsKIH0KSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBM YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTk4NSkKKysrIExheW91dFRlc3RzL0No YW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTA4LTAzICBDaHJp cyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IFNlbGVjdFRl eHQgZnVuY3Rpb25hbGl0eSBhbHdheXMgc2VsZWN0cyB0ZXh0IGFmdGVyIGN1cnJlbnQgc2VsZWN0 aW9uIGV2ZW4gaWYgY2xvc2VyIHNlbGVjdGlvbiBpcyBiZWhpbmQgaXQKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTU0NgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWFjL2FjY2Vzc2li aWxpdHkvc2VsZWN0LXRleHQtZXhwZWN0ZWQudHh0OgorICAgICAgICAqIHBsYXRmb3JtL21hYy9h Y2Nlc3NpYmlsaXR5L3NlbGVjdC10ZXh0Lmh0bWw6CisKIDIwMTQtMDgtMDEgIENhcmxvcyBBbGJl cnRvIExvcGV6IFBlcmV6ICA8Y2xvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS10gVW5y ZXZpZXdlZCBHVEsgZ2FyZGVuaW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2Fj Y2Vzc2liaWxpdHkvc2VsZWN0LXRleHQtZXhwZWN0ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91 dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlbGVjdC10ZXh0LWV4cGVjdGVkLnR4 dAkocmV2aXNpb24gMTcxOTczKQorKysgTGF5b3V0VGVzdHMvcGxhdGZvcm0vbWFjL2FjY2Vzc2li aWxpdHkvc2VsZWN0LXRleHQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkpCkBAIC0xLDUgKzEs NyBAQAogVGhlwqBzbG93wqBCUk9XTsKgY2F0wqBqdW1wcyBvdmVyIHRoZSBsYXp5IGRvZy4KIAor VEVYVDI6IFRoZSBxdWljayBicm93biBmb3gganVtcHMgb3ZlciB0aGUgbGF6eSBkb2cuIFRoZSBx dWljayBicm93biBmb3gganVtcHMgb3ZlciB0aGUgbGF6eSBkb2cuCisKIFRoaXMgdGVzdHMgdGhl IGFiaWxpdHkgdG8gc2VsZWN0IGFuZCByZXBsYWNlIHRleHQgd2l0aCByZXNwZWN0IHRvIHNlbGVj dGlvbi4KIAogT24gc3VjY2VzcywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNz YWdlcywgZm9sbG93ZWQgYnkgIlRFU1QgQ09NUExFVEUiLgpAQCAtMjcsNiArMjksMTIgQEAKIFBB U1Mgc2VsZWN0aW9uIGlzICdicm93bicKIFBBU1MgcmVzdWx0IGlzICdicm93bicKIFBBU1Mgc2Vs ZWN0aW9uIGlzICdCUk9XTicKK1BBU1MgcmVzdWx0IGlzICdxdWljaycKK1BBU1Mgd2luZG93U2Vs ZWN0aW9uLmdldFJhbmdlQXQoMCkuc3RhcnRPZmZzZXQgaXMgMTEKK1BBU1Mgd2luZG93U2VsZWN0 aW9uLmdldFJhbmdlQXQoMCkuZW5kT2Zmc2V0IGlzIDE2CitQQVNTIHJlc3VsdCBpcyAncXVpY2sn CitQQVNTIHdpbmRvd1NlbGVjdGlvbi5nZXRSYW5nZUF0KDApLnN0YXJ0T2Zmc2V0IGlzIDU2CitQ QVNTIHdpbmRvd1NlbGVjdGlvbi5nZXRSYW5nZUF0KDApLmVuZE9mZnNldCBpcyA2MQogUEFTUyBz dWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQogCiBURVNUIENPTVBMRVRFCkluZGV4OiBMYXlvdXRU ZXN0cy9wbGF0Zm9ybS9tYWMvYWNjZXNzaWJpbGl0eS9zZWxlY3QtdGV4dC5odG1sCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nlc3NpYmlsaXR5L3NlbGVjdC10ZXh0 Lmh0bWwJKHJldmlzaW9uIDE3MTk3MykKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9hY2Nl c3NpYmlsaXR5L3NlbGVjdC10ZXh0Lmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTYsOCArNiwxMCBA QAogPC9oZWFkPgogPGJvZHk+CiAKLTxwIGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSIgaWQ9InRleHQi PlRoZSBxdWljayBicm93biBmb3ggPHNwYW4gaWQ9InRhcmdldCI+anVtcHM8L3NwYW4+IG92ZXIg dGhlIGxhenkgZG9nLjwvcD4KKzxwIGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSIgaWQ9InRleHQiPlRo ZSBxdWljayBicm93biBmb3ggPHNwYW4gaWQ9InRhcmdldCI+anVtcHM8L3NwYW4+IG92ZXIgdGhl IGxhenkgZG9nLiA8L3A+CiAKKzxwIGNvbnRlbnRlZGl0YWJsZT0idHJ1ZSIgaWQ9InRleHQyIj5U RVhUMjogVGhlIHF1aWNrIGJyb3duIGZveCBqdW1wcyBvdmVyIHRoZSBsYXp5IGRvZy4gVGhlIHF1 aWNrIGJyb3duIGZveCBqdW1wcyBvdmVyIHRoZSBsYXp5IGRvZy48L3A+CisKIDxwIGlkPSJkZXNj cmlwdGlvbiI+PC9wPgogPGRpdiBpZD0iY29uc29sZSI+PC9kaXY+CiAKQEAgLTExMCw2ICsxMTIs MzcgQEAKICAgICAgICAgc2VsZWN0aW9uID0gc2VsZWN0ZWRUZXh0KCk7CiAgICAgICAgIHNob3Vs ZEJlKCJzZWxlY3Rpb24iLCAiJ0JST1dOJyIpOwogCisgICAgICAgIC8vIFtodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM1NTQ2XSAKKyAgICAgICAgLy8gQSBtYXRjaGlu ZyByYW5nZSBiZWZvcmUgdGhlIHNlbGVjdGlvbiBzaG91bGQgYmUgc2VsZWN0ZWQgd2hlbiBzZWFy Y2hpbmcgZm9yIGNsb3Nlc3QgbWF0Y2guCisgICAgICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJ0ZXh0MiIpLmZvY3VzKCk7CisgICAgICAgIHZhciB3aW5kb3dTZWxlY3Rpb24gPSB3aW5kb3cu Z2V0U2VsZWN0aW9uKCk7CisgICAgICAgIHdpbmRvd1NlbGVjdGlvbi5yZW1vdmVBbGxSYW5nZXMo KTsKKworICAgICAgICAvLyBGaXJzdCBmaW5kIHRoZSByYW5nZSBiZWZvcmUgdGhlIGN1cnJlbnQg c2VsZWN0aW9uLgorICAgICAgICB2YXIgcmFuZ2UgPSBkb2N1bWVudC5jcmVhdGVSYW5nZSgpOwor ICAgICAgICByYW5nZS5zZXRTdGFydChkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGV4dDIiKS5m aXJzdENoaWxkLCAyMCk7CisgICAgICAgIHJhbmdlLnNldEVuZChkb2N1bWVudC5nZXRFbGVtZW50 QnlJZCgidGV4dDIiKS5maXJzdENoaWxkLCAyMCk7CisgICAgICAgIHdpbmRvd1NlbGVjdGlvbi5h ZGRSYW5nZShyYW5nZSk7CisgICAgICAKKyAgICAgICAgdmFyIHRleHQyID0gYWNjZXNzaWJpbGl0 eUNvbnRyb2xsZXIuYWNjZXNzaWJsZUVsZW1lbnRCeUlkKCJ0ZXh0MiIpOworICAgICAgICByZXN1 bHQgPSB0ZXh0Mi5zZWxlY3RUZXh0V2l0aENyaXRlcmlhKCJBWFNlbGVjdFRleHRBbWJpZ3VpdHlS ZXNvbHV0aW9uQ2xvc2VzdFRvU2VsZWN0aW9uIiwgInF1aWNrIik7CisgICAgICAgIHNob3VsZEJl KCJyZXN1bHQiLCAiJ3F1aWNrJyIpOworICAgICAgICBzZWxlY3Rpb24gPSB3aW5kb3cuZ2V0U2Vs ZWN0aW9uKCk7CisgICAgICAgIHNob3VsZEJlKCJ3aW5kb3dTZWxlY3Rpb24uZ2V0UmFuZ2VBdCgw KS5zdGFydE9mZnNldCIsICIxMSIpOworICAgICAgICBzaG91bGRCZSgid2luZG93U2VsZWN0aW9u LmdldFJhbmdlQXQoMCkuZW5kT2Zmc2V0IiwgIjE2Iik7CisKKyAgICAgICAgLy8gTW92ZSB0aGUg Y3Vyc29yIGNsb3NlciB0byB0aGUgc2Vjb25kIGluc3RhbmNlIGluIGZyb250IG9mIHRoZSBzZWxl Y3Rpb24uCisgICAgICAgIHJhbmdlID0gZG9jdW1lbnQuY3JlYXRlUmFuZ2UoKTsKKyAgICAgICAg cmFuZ2Uuc2V0U3RhcnQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRleHQyIikuZmlyc3RDaGls ZCwgNDgpOworICAgICAgICByYW5nZS5zZXRFbmQoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInRl eHQyIikuZmlyc3RDaGlsZCwgNDgpOworICAgICAgICB3aW5kb3dTZWxlY3Rpb24ucmVtb3ZlQWxs UmFuZ2VzKCk7CisgICAgICAgIHdpbmRvd1NlbGVjdGlvbi5hZGRSYW5nZShyYW5nZSk7CisKKyAg ICAgICAgcmVzdWx0ID0gdGV4dDIuc2VsZWN0VGV4dFdpdGhDcml0ZXJpYSgiQVhTZWxlY3RUZXh0 QW1iaWd1aXR5UmVzb2x1dGlvbkNsb3Nlc3RUb1NlbGVjdGlvbiIsICJxdWljayIpOworICAgICAg ICBzaG91bGRCZSgicmVzdWx0IiwgIidxdWljayciKTsKKyAgICAgICAgc2hvdWxkQmUoIndpbmRv d1NlbGVjdGlvbi5nZXRSYW5nZUF0KDApLnN0YXJ0T2Zmc2V0IiwgIjU2Iik7CisgICAgICAgIHNo b3VsZEJlKCJ3aW5kb3dTZWxlY3Rpb24uZ2V0UmFuZ2VBdCgwKS5lbmRPZmZzZXQiLCAiNjEiKTsK KwogICAgIH0KIDwvc2NyaXB0PgogCg==