135541 2014-08-02 07:28:51 -0700 [WinCairo] Compile error in OpenTypeMathData.cpp. 2014-08-04 09:40:34 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned achristensen bfulgham commit-queue ossy oldest_to_newest 1026459 0 peavo 2014-08-02 07:28:51 -0700 The SharedBuffer class needs to be defined. Also, the OpenTypeMathData constructor should also be implemented when OPENTYPE_MATH is not enabled. 1026460 1 235935 peavo 2014-08-02 07:32:47 -0700 Created attachment 235935 Patch 1026472 2 235935 bfulgham 2014-08-02 10:44:04 -0700 Comment on attachment 235935 Patch Thank you! R=me. 1026479 3 peavo 2014-08-02 11:37:34 -0700 (In reply to comment #2) > (From update of attachment 235935 [details]) > Thank you! R=me. Thanks :) 1026610 4 ossy 2014-08-04 01:23:01 -0700 Just out of curiosity, are you planning to fix the WinCairo buildbot which is broken long time ago - at least a month ago. 1026612 5 235935 commit-queue 2014-08-04 01:48:12 -0700 Comment on attachment 235935 Patch Clearing flags on attachment: 235935 Committed r171989: <http://trac.webkit.org/changeset/171989> 1026613 6 commit-queue 2014-08-04 01:48:15 -0700 All reviewed patches have been landed. Closing bug. 1026640 7 peavo 2014-08-04 09:28:27 -0700 (In reply to comment #4) > Just out of curiosity, are you planning to fix the WinCairo > buildbot which is broken long time ago - at least a month ago. Haven't got access to the bot :) I believe it's just a minor issue though, I can see the following error in the build output: rm: cannot remove `/cygdrive/c/Projects/BuildSlave/win-cairo-release/build/Source/WebInspectorUI/WebInspectorUI.vcxproj': Directory not empty 1026642 8 achristensen 2014-08-04 09:40:34 -0700 (In reply to comment #4) > Just out of curiosity, are you planning to fix the WinCairo > buildbot which is broken long time ago - at least a month ago. That is a known problem, and the maintainers said they will fix it. It seems to be a low priority, though. I might set up one I have more control over in about a month. WinCairo is not dead. 235935 2014-08-02 07:32:47 -0700 2014-08-04 01:48:12 -0700 Patch bug-135541-20140802163224.patch text/plain 1505 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3MTk2NSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTA4LTAyICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvciBpbiBPcGVuVHlwZU1hdGhEYXRhLmNwcC4KKyAgICAgICAgaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzNTU0MQorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBTaGFyZWRCdWZmZXIgY2xhc3MgbmVlZHMg dG8gYmUgZGVmaW5lZC4KKyAgICAgICAgQWxzbywgdGhlIE9wZW5UeXBlTWF0aERhdGEgY29uc3Ry dWN0b3Igc2hvdWxkIGJlIGltcGxlbWVudGVkIHdoZW4gT1BFTlRZUEVfTUFUSCBpcyBub3QgZW5h YmxlZC4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlTWF0 aERhdGEuY3BwOgorCiAyMDE0LTA4LTAxICBDb21taXQgUXVldWUgIDxjb21taXQtcXVldWVAd2Vi a2l0Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByMTcxOTU3LgpJbmRl eDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mvb3BlbnR5cGUvT3BlblR5cGVNYXRo RGF0YS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3Mv b3BlbnR5cGUvT3BlblR5cGVNYXRoRGF0YS5jcHAJKHJldmlzaW9uIDE3MTk2NSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL29wZW50eXBlL09wZW5UeXBlTWF0aERhdGEuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw2ICszMCw3IEBACiAjaWYgRU5BQkxFKE9QRU5UWVBFX01B VEgpCiAjaW5jbHVkZSAiT3BlblR5cGVUeXBlcy5oIgogI2VuZGlmCisjaW5jbHVkZSAiU2hhcmVk QnVmZmVyLmgiCiAjaW5jbHVkZSAiU2ltcGxlRm9udERhdGEuaCIKIAogdXNpbmcgbmFtZXNwYWNl IHN0ZDsKQEAgLTI1OSwxMSArMjYwLDExIEBAIE9wZW5UeXBlTWF0aERhdGE6Ok9wZW5UeXBlTWF0 aERhdGEoY29uc3QKICNlbmRpZgogfQogCi0jaWYgRU5BQkxFKE9QRU5UWVBFX01BVEgpCiBPcGVu VHlwZU1hdGhEYXRhOjp+T3BlblR5cGVNYXRoRGF0YSgpCiB7CiB9CiAKKyNpZiBFTkFCTEUoT1BF TlRZUEVfTUFUSCkKIGZsb2F0IE9wZW5UeXBlTWF0aERhdGE6OmdldE1hdGhDb25zdGFudChjb25z dCBTaW1wbGVGb250RGF0YSogZm9udCwgTWF0aENvbnN0YW50IGNvbnN0YW50KSBjb25zdAogewog ICAgIGludDMyX3QgdmFsdWUgPSAwOwo=